[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGd230848a85a9: [lldb] Print an error message when we're reading libobjc.A.dylib from memory (authored by JDevlieghere). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

JDevlieghere planned changes to this revision. JDevlieghere added a comment. In D117601#3253663 , @labath wrote: > I don't think that `atomic` is what you want here. In the case of a > race, the "loser" will immediately continue to use python as if it wa

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

JDevlieghere updated this revision to Diff 401267. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Do private initialization exactly once in ScriptInterpreterPython::Initialize CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:3154-3176 -#if LLDB_USE_PYTHON_SET_INTERRUPT -namespace { -/// Saves the current signal handler for the specified signal and restores -/// it at the end of th

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

JDevlieghere added a comment. Do you actually care about the timers or is this really about getting these methods instrumented with signposts on our platform? If it's the latter, I think it would make more sense to put that call in the `LLDB_RECORD_*` macros (which I'm planning to rename immine

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5c0ea68180: [lldb] Initialize Python exactly once (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D117601?vs=401267&id=401300#toc Repositor

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

JDevlieghere commandeered this revision. JDevlieghere edited reviewers, added: aprantl; removed: JDevlieghere. JDevlieghere added a comment. I can do this after the rename. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/ https://reviews.llvm.org/D117632 __

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Remove the last remaining references to the reproducers fro

[Lldb-commits] [PATCH] D117632: Instrument SB API with signposts

JDevlieghere updated this revision to Diff 401369. JDevlieghere retitled this revision from "Instrument SBAPI with scoped timers" to "Instrument SB API with signposts". JDevlieghere edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/ https://rev

[Lldb-commits] [PATCH] D117632: [lldb] Instrument SB API with signposts

JDevlieghere added a comment. Yup, at this point I might as well inline it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/ https://reviews.llvm.org/D117632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere added a comment. In D117712#3255978 , @labath wrote: > It seems the set of macros could be reduced. If you don't need to generate > "unique identifiers" for each method, then you can stop worrying about const > methods, constructors, etc. I

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112825/new/ https://reviews.llvm.org/D112825 ___

[Lldb-commits] [PATCH] D117490: [lldb] Log prototype

JDevlieghere added a comment. Very cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere updated this revision to Diff 401503. JDevlieghere added a comment. Simplify macros CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117712/new/ https://reviews.llvm.org/D117712 Files: lldb/include/lldb/Utility/Instrumentation.h lldb/include/lldb/Utility/ReproducerInstrum

[Lldb-commits] [PATCH] D117748: [lldb] Revive lldb-instr

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. I revived `lldb-instr` to update the macros for D117712 . I think the new macros are simple enough that

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere updated this revision to Diff 401505. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117712/new/ https://reviews.llvm.org/D117712 Files: lldb/include/lldb/Utility/Instrumentation.h lldb/include/lldb/Utility/ReproducerInstrumentation.

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere added a comment. Thanks, I'll address those things before landing the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117712/new/ https://reviews.llvm.org/D117712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D117837: [lldb] Fix timer logging inverted quiet condition

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117837/new/ https://reviews.llvm.org/D117837 ___

[Lldb-commits] [PATCH] D117748: [lldb] Revive lldb-instr

This revision was automatically updated to reflect the committed changes. Closed by commit rGf811cb82a6cd: [lldb] Revive lldb-instr (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D117748?vs=401504&id=401831#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

This revision was automatically updated to reflect the committed changes. Closed by commit rG1755f5b1d7b7: [lldb] Decouple instrumentation from the reproducers (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D117712?vs=401505&id=401832

[Lldb-commits] [PATCH] D117632: [lldb] Instrument SB API with signposts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG156b997251db: [lldb] Instrument SB API with signposts (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:57 + /// }; + using MaskType = uint32_t; + Didn't this all start with Greg wanting to make this a `uint64_t`? Comment at: lldb/include/lldb/Utility/Logging.h:19-5

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath. JDevlieghere requested review of this revision. Add statistics about the memory usage of the string pool. I'm particularly interested in the memory used by the allocator, i.e. the number of bytes actually used by

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/ConstString.h:409 /// in memory. static size_t StaticMemorySize(); I purposely didn't use this function for the reasons explained in the summary. It seems like a few classes im

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere added inline comments. Comment at: lldb/source/Target/Statistics.cpp:228 {"modules", std::move(json_modules)}, + {"strings", string_stats.ToJSON()}, {"totalSymbolTableParseTime", symtab_parse_time}, clayborg wrote: > "constStrings"

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere updated this revision to Diff 402093. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Put string statistics under memory: "memory": { "strings": { "bytesAllocated": 2056916, "bytesTotal": 3145728, "bytesUnallocated": 1088812 }

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere added a comment. In D117914#3262467 , @kastiglione wrote: > I find "Unallocated" ambiguous. To the Allocator, maybe it's not, but to VM > it is. What about Total/Used/Unused? Note that the docs for `BytesAllocated` > say it can be used to

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere updated this revision to Diff 402104. JDevlieghere added a comment. "memory": { "strings": { "bytesTotal": 3145728, "bytesUnused": 1088812, "bytesUsed": 2056916 } }, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117914/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

JDevlieghere added a comment. Why are we disabling a lldb test because of a bug in GDB? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117928/new/ https://reviews.llvm.org/D117928 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere added a comment. @clayborg Does the latest scheme look good to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117914/new/ https://reviews.llvm.org/D117914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I'm happy with this. LGTM assuming Greg feels the same way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://review

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere added a comment. In D117914#3267657 , @clayborg wrote: > Yep! Looks good. > > As a follow up patch it would be great to ask the SymbolFile classes to break > down some memory usage. I know in the SymbolFileDWARF we have each DWARFUnit > tha

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd8122b27f8f: [lldb] Add ConstString memory usage statistics (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D118091: [lldb] Remove ConstString::StaticMemorySize

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, kastiglione. JDevlieghere requested review of this revision. Remove `ConstString::StaticMemorySize` as it is unused. It is referenced in a bunch of doc comments but I don't really understand why. My best guess it

[Lldb-commits] [PATCH] D117382: [NFC] Cleanup log channel stuff to all be consistent and use 64 bit log channel mask.

JDevlieghere added a comment. Nice improvement! Comment at: lldb/include/lldb/Utility/LLDBLog.h:1 +//===-- Logging.h ---*- C++ -*-===// +// LLDBLog.h Comment at: lldb/include/lldb/Utility/LLDBLog.h

[Lldb-commits] [PATCH] D118091: [lldb] Remove ConstString::StaticMemorySize

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd0822f2730: [lldb] Remove ConstString::StaticMemorySize (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D118251: [lldb/DWARF] Make manual dwarf index deterministic

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118251/new/ https://reviews.llvm.org/D118251 ___

[Lldb-commits] [PATCH] D118261: [lldb/API] Add ability to check if module is reading from memory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118261/new/ https://reviews.llvm.org/D118261 ___

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. From my own notes: - I wrote down that I neede "MSVC C++ x64/x86 build tool". Not sure if that's really required? - As someone who's used to working on the command line, it

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/ https://reviews.llvm.org/D118425 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:323-344 +{'name': 'rax', 'bitsize': 64, 'offset': 0, 'encoding': 'uint', 'format': 'hex', 'set': 0, 'gcc': 0, 'dwarf': 0}, +{'name':

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the test comment. Comment at: lldb/examples/python/scripted_process/scripted_process.py:338 + +ARM64_GPR = [ {'name': 'x0', 'bitsize': 64, 'offset':

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:1323 +// CommandObjectThreadSiginfo + I know you're just being consistent with the rest of this file, but we've been slowly phasing out these kind of comments. CHAN

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, labath. JDevlieghere requested review of this revision. Libraries which rely heavily on templates (e.g. boost) can generate extremely long symbol names, with mangled names in the 10 000 of characters. These symb

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, labath. Herald added a subscriber: arphaman. JDevlieghere requested review of this revision. The symbol table needs to demangle all symbols when building its index. However, the index doesn't need the demangeld s

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere added a comment. In D118814#3291174 , @kastiglione wrote: >> the amount of memory we save here is well worth the small performance hit > > any numbers to share? We have one scenario where this bring memory usage after attach down from 7gb

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere added a comment. In D118812#3291937 , @clayborg wrote: > Can we put a limit on the length of the kinds of names we are willing to > demangle in the first place? How long are some of these names _prior_ to > demangling? It would be great if

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere added a comment. In D118812#3291482 , @dblaikie wrote: > In D118812#3291303 , @jingham wrote: > >> In D118812#3291109 , @dblaikie >> wrote: >> >>> Any chance

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere added a comment. In D118812#3291969 , @clayborg wrote: > Yikes sorry, I read line Symtab.cpp:311 as if it was demangling the name > first and then checking _its_ length... > > The settings leads one to believe that we don't ever demangle nam

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere updated this revision to Diff 405657. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. The symbol table index is the only caller to `DemangleWithRichManglingInfo`, so I removed the optional argument. Based on Pavel's observations in D118812

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere abandoned this revision. JDevlieghere added a comment. Thanks Pavel. I should've dug a little deeper in the rich mangling context. After giving it a second look I think you're absolutely right and we can drop this patch in favor of D118814 . CHANG

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere updated this revision to Diff 405698. JDevlieghere added a comment. **Before** Memory usage: 280MB Benchmark 1: ./bin/lldb -n Slack -o quit Time (mean ± σ): 4.829 s ± 0.518 s[User: 4.012 s, System: 0.208 s] Range (min … max):4.624 s … 6.294 s10 runs **Af

[Lldb-commits] [PATCH] D118953: [lldb] Improve RichManglingContext ergonomics (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: clayborg. JDevlieghere requested review of this revision. Have the different `::Parse.*` methods return the demangled string directly instead of having to go through `::GetBufferRef`. https://reviews.llvm.org/D118953 Files: l

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Symbol/Symtab.cpp:388-389 // Only register functions that have a base name. rmc.ParseFunctionBaseName(); llvm::StringRef base_name = rmc.GetBufferRef(); if (base

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D118814#3297075 , @jingham wrote: > In D118814#3296008 , @labath wrote: > >> This seems fine, though it's not clear to me what is the

[Lldb-commits] [PATCH] D118953: [lldb] Improve RichManglingContext ergonomics (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa52788b7a6d: [lldb] Improve RichManglingContext ergonomics (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D118953?vs=405823&id=406031#

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rGaed965d55d46: [lldb] Don't construct the demangled strings while indexing the symbol table (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:237-239 + // Find types in a specific scope. + // \param scope + // Must be either the scope prefix (with leading ::) or empty Comment at: lldb/includ

[Lldb-commits] [PATCH] D118972: Increase preallocated buffer for scanning the process objc classes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the nits about the comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2011 - const uint32_t num_

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

JDevlieghere added a comment. Returning a StringRef from GetName makes sense, but in the constructor, if you're eventually going to store it, why not pass and `std::string` in and `std::move` it into place? Other than that this LGTM, but I'll refrain from accepting so it continues to show up in

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

JDevlieghere added a comment. We have (shell) tests that import the crashlog command. Can you add a check line to make sure the message gets printed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119155/new/ https://reviews.llvm.org/D119155 _

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

JDevlieghere added a comment. In D119155#3301826 , @kastiglione wrote: >> We have (shell) tests that import the crashlog command. Can you add a check >> line to make sure the message gets printed? > > The message isn't printed for a Python `import`, onl

[Lldb-commits] [PATCH] D119170: [lldb] Skip ScriptInterpreter/Lua/watchpoint_callback.test on Apple Silicon

JDevlieghere created this revision. JDevlieghere requested review of this revision. The watchpoint isn't hit the first time, resulting is us only printing "val =2". XFAIL the test until the underlying watchpoint issue gets fixed. https://reviews.llvm.org/D119170 Files: lldb/test/Shell/Script

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

JDevlieghere added a comment. I recently modified this function to support parsing the rosetta registers. To do that I call `parse_thread_registers` recursively, and I think we should do the same here and add an optional argument for the prefix. So the result would look something like: def p

[Lldb-commits] [PATCH] D119170: [lldb] Skip ScriptInterpreter/Lua/watchpoint_callback.test on Apple Silicon

JDevlieghere abandoned this revision. JDevlieghere added a comment. In D119170#3302067 , @labath wrote: > If I had to guess, I'd say this is because "b main" stops at a point after > the variable has already been initialized. If true, it should be fairly

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119155/new/ https://reviews.llvm.org/D119155 ___

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

JDevlieghere added a comment. API and code change make sense, but I think we should be able to simplify the test. Comment at: lldb/test/API/commands/thread/backtrace/TestThreadBacktraceRepeat.py:18-28 +# Test occasionally times out on the Linux build bot +@skipIfLinux

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

JDevlieghere added a comment. I believe it's generally considered bad practice to install signal handlers in a library. This is why the initialization currently happens in the driver. If you look at other tools in LLVM you'll notice they do the same thing. Can we address this issue by (1) makin

[Lldb-commits] [PATCH] D119179: [lldb] Call __lldb_init_module from __init__

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119179/new/ https://reviews.llvm.org/D119179

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We should add this to `LLDB_SYSTEM_LIBS` in `lldb/source/Host/CMakeLists.txt` and include `${LLDB_SYSTEM_LIBS}` for `lldbPluginProcessGDBRemote`. Repository: rG LLVM G

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere added a comment. Basically it should mirror what we have for LZMA: if (LLDB_ENABLE_LZMA) list(APPEND EXTRA_LIBS ${LIBLZMA_LIBRARIES}) endif() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere added a comment. In D119186#3302765 , @mceier wrote: > In D119186#3302612 , @JDevlieghere > wrote: > >> We should add this to `LLDB_SYSTEM_LIBS` like we do in >> `lldb/source/Host/CMakeLists.txt` an

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 __

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119168/new/ https://reviews.llvm.org/D119168 ___

[Lldb-commits] [PATCH] D119297: "thread until": make sure the current function is valid before asking it questions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119297/new/ https://reviews.llvm.org/D119297 _

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Jim. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119046/new/ https://reviews.llvm.org/D119046 __

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I don't feel super strongly, I was just curious. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119146/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D119131: [lldb] List platform plugin *instances* in "platform list"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:243 +OS << " "; +llvm::ListSeparator LS; +for (const PlatformSP &platform

[Lldb-commits] [PATCH] D118513: [lldb/test] Split Scripted Process test in multiple tests (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118513/new/ https://reviews.llvm.org/D118513 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D119386: [lldb/Plugins] Clean-up ScriptedProcess python script (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/examples/python/scripted_process/scripted_process.py:264 /// not be examined. +eStateCrashed, //

[Lldb-commits] [PATCH] D119499: [lldb/API] Add a way to check if the CommandInterpreter is interactive

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119499/new/ https://reviews.llvm.org/D119499 ___

[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:466 +if 'signal' in json_exception: +exception_signal += "({})".format(json_exception['signal']) + Should this be surrounded by spaces? Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1142-1146 +if options.interactive and ci and ci.IsInteractive(): +load_crashlog_in_scripted_process(debugger, crash_log_file) +else: crash_log

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess

JDevlieghere added a comment. In D119501#3314991 , @clayborg wrote: > I used this back when I worked at Apple to load thousands of crash logs and > get information about the versions of a library that were all involved in the > crash. From the Apple cra

[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/examples/python/crashlog.py:471 exception_extra = "" -return "{} ({}){}".format(exception_type, exception_signal,

[Lldb-commits] [PATCH] D119389: [lldb/crashlog] Add CrashLogScriptedProcess and resurrect_crashlog method

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1098 +class ResurrectCrashProcess: +def __init__(self, debugger, internal_dict): Do we need this at all if we integrate it in the existing crashlog command?

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess to replace interactive mode

JDevlieghere added a comment. Test? Comment at: lldb/examples/python/crashlog.py:990 +res = lldb.SBCommandReturnObject() +ci.HandleCommand('script from lldb.macosx import crashlog_scripted_process', res) +if not res.Succeeded(): Do we need to have

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:990 +res = lldb.SBCommandReturnObject() +ci.HandleCommand('script from lldb.macosx import crashlog_scripted_process', res) +if not res.Succeeded(): mib wrote: > JDevlieg

[Lldb-commits] [PATCH] D119602: Add additional method for ObjectFileMachO to find the first loadable segment in a Mach-O binary

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119602/new/ https://reviews.llvm.org/D119602 ___

[Lldb-commits] [PATCH] D119737: [lldb] Add llvm_unreachable in RichManglingContext

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119737/new/ https://reviews.llvm.org/D119737 ___

[Lldb-commits] [PATCH] D119755: [crashlog] Change heuristic to stripping the meta data from crashlogs

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. JDevlieghere requested review of this revision. Instead of pro-actively trying to determine if the first line in a crashlog contains meta data, change the heuristic to trying to parse the whole file first. If that fails, str

[Lldb-commits] [PATCH] D119756: [lldb] Stop forwarding LLDB_DEFAULT_PYTHON_VERSION in crashlog

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. JDevlieghere requested review of this revision. Title says it all https://reviews.llvm.org/D119756 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D119756: [lldb] Stop forwarding LLDB_DEFAULT_PYTHON_VERSION in crashlog

This revision was automatically updated to reflect the committed changes. Closed by commit rGd52866e1a82d: [lldb] Stop forwarding LLDB_DEFAULT_PYTHON_VERSION in crashlog (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D119755: [crashlog] Change heuristic to stripping the meta data from crashlogs

This revision was automatically updated to reflect the committed changes. Closed by commit rG343662a02878: [crashlog] Change heuristic to stripping the meta data from crashlogs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

JDevlieghere added a comment. This is in line with the existing ways of sourcing init files in LLDB and has all the things we discussed in the RFC. I left few nits but this all looks good to me. I'll hold off on accepting so it continues to show up in the other reviewer's queue.

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

JDevlieghere created this revision. JDevlieghere added reviewers: labath, kastiglione, mib. JDevlieghere requested review of this revision. I was looking at `Stream::PutRawBytes` and thought I spotted a bug because both looks are using `i < src_len` as the loop condition despite them iterating "i

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Stream.cpp:360 ByteDelta delta(*this); + if (src_byte_order == eByteOrderInvalid) Intentional newline for consistency with `Stream::PutRawBytes` above. CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

JDevlieghere updated this revision to Diff 409135. JDevlieghere added a comment. - Add unit test for edge case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119857/new/ https://reviews.llvm.org/D119857 Files: lldb/source/Utility/Stream.cpp lldb/unittests/Utility/StreamTest.cpp In

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG920146316da1: [lldb] Don't rely on wrapping in PutRawBytes/PutBytesAsRawHex8 (authored by JDevlieghere). Herald added a project: LLDB. Repository:

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119501/new/ https://reviews.llvm.org/D119501 ___ lldb-commits mailing list

<    4   5   6   7   8   9   10   11   12   13   >