JDevlieghere added a comment. In D119186#3302765 <https://reviews.llvm.org/D119186#3302765>, @mceier wrote:
> In D119186#3302612 <https://reviews.llvm.org/D119186#3302612>, @JDevlieghere > wrote: > >> We should add this to `LLDB_SYSTEM_LIBS` like we do in >> `lldb/source/Host/CMakeLists.txt` and include `${LLDB_SYSTEM_LIBS}` for >> `lldbPluginProcessGDBRemote`. > > So should I add: > > if(LLVM_ENABLE_ZLIB) > list(APPEND LLDB_SYSTEM_LIBS ZLIB::ZLIB) > endif() > > to `lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt` or do you have > different CMakeLists.txt file in mind ? Yup that's fine. I think at some point we'll want to centralize all these dependencies somewhere higher up and have it shared by the different targets, but that's definitely for a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
