JDevlieghere added a comment. Returning a StringRef from GetName makes sense, but in the constructor, if you're eventually going to store it, why not pass and `std::string` in and `std::move` it into place? Other than that this LGTM, but I'll refrain from accepting so it continues to show up in other's review queue.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119146/new/ https://reviews.llvm.org/D119146 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
