[Lldb-commits] [PATCH] D134927: Make the sanitizer Notify callbacks asynchronous

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp:302-309 bool internal = true; bool hardware = false; Breakpoint *breakpoint = process_sp->GetTarge

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, DavidSpickett, jingham, mib. Herald added a project: All. JDevlieghere requested review of this revision. Around this time last year, I said on the mailing list [1] that I wanted to to transform the reproducers in

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 464395. JDevlieghere added a comment. Fix baseline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Target/Statistics.h lldb/include/ll

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 464396. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Target/Statistics.h lldb/include/lldb/Utility/Diagnostics.h lldb/include/lldb/

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere added a comment. In D134991#3830682 , @DavidSpickett wrote: > I like the direction, thanks for working on this. > > To no one's surprise, I was thinking about testing :) > > - Errors related to the filesystem e.g. can't open a path, is too c

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

JDevlieghere added a comment. I'm not sure I understand how the test is exercising the application specific backtrace. I don't see any of the frames or the crash reason in there. What am I missing? Comment at: lldb/examples/python/crashlog.py:581-597 +def parse_asi_ba

[Lldb-commits] [PATCH] D135310: [lldb/crashlog] Add support for 32bit frame addresses

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135310/new/ https://reviews.llvm.org/D135310 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D135482: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images

JDevlieghere added a comment. Can we add a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135482/new/ https://reviews.llvm.org/D135482 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:231 llvm::StringRef function, const char *format, - Args &&... args) { + Args &&...args) { F

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 466526. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebug

[Lldb-commits] [PATCH] D135577: Summary:

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/README.md:39 +It is important to note that the directory `~/.vscode/extensions` works for users logged in loca

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

JDevlieghere added a comment. The change looks good but this needs unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135547/new/ https://reviews.llvm.org/D135547 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D135577: Summary:

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-vscode/README.md:39 +It is important to note that the directory `~/.vscode/extensions` works for users logged in locally to the machine. If you are remoting into the box using Visual Studio Code's Remote plugins

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 466549. JDevlieghere added a comment. Changed my mind (again). I made the Callback a std::function so we can use lambas. I used function pointers originally so we could easily compare and remove callbacks, but there's too many places where this overcomp

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, jingham, mib, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Add an "always on" log channel. The channel is meant to be used sparsely and deliberately for logging high-

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, clayborg, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Add a "diagnostics dump" command to, as the name implies, dump the diagnostics to disk. The goal of this command

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, clayborg, mib. Herald added a project: All. JDevlieghere requested review of this revision. This patch copies over log files to the diagnostic directory. It's a bit of a straw man proposal as it has some shor

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D135631#3849295 , @DavidSpickett wrote: > So either way, if someone was running with no logs enabled we would have to > ask them to enable them then re-run and get a new set

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added a comment. In D135621#3849043 , @labath wrote: > I'm not sure if this will do what you wanted it to do. Despite the title, > this patch is not adding a new log *channel* -- it is adding a new log > *category* to the "lldb" channel. Ou

[Lldb-commits] [PATCH] D135607: Summary:

JDevlieghere added a comment. In D135607#3848334 , @HenriqueBucher wrote: > To be frank, I think this formatting is silly and wrong now that I am looking > at it. > Looking at the rendered markdown at Github >

[Lldb-commits] [PATCH] D135577: Summary:

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 ___

[Lldb-commits] [PATCH] D135577: Summary:

JDevlieghere added a comment. Henrique, do you have commit access? Whoever ends up committing this, please make sure the commit has a reasonable commit description and not "Summary:". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ http

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Statistics.cpp:305 +std::error_code ec; +raw_fd_ostream stats_stream(stat_file.GetPath(), ec, sys::fs::OF_None); +if (ec) clayborg wrote:

[Lldb-commits] [PATCH] D135983: [lldb] Fix a -Wdeprecated-declarations warning

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135983/new/ https://reviews.llvm.org/D135983 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

JDevlieghere added a comment. Hey, this patch still breaks TestArray.py. Could you please take another look? https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/47748/testReport/lldb-api/commands_frame_diagnose_array/TestArray_py/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 469399. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Split off the statistics CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebugger.

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere updated this revision to Diff 469677. JDevlieghere added a comment. - Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135621/new/ https://reviews.llvm.org/D135621 Files: lldb/include/lldb/Utility/Diagnostics.h lldb/include/lldb/Utility/Log.h

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added a comment. In D135621#3850248 , @clayborg wrote: > I am also questioning if the these even belong in the LLDB logging stuff? > Seems like it would be just as easy to create a diagnostic message by calling > Diagnostics::Report(...). D

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Diagnostics.cpp:23 +static constexpr Log::Category g_categories[] = { +{{"lldb"}, {"diagnostics log for lldb"}, DiagnosticsLog::LLDB}, +}; kastiglione wrote: > To me, it's not ideal that ther

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere abandoned this revision. JDevlieghere added a comment. Seems like the consensus is that we prefer a dedicated API rather than using the existing logging infrastructure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135621/new/ https://reviews.llvm.org/D135621

[Lldb-commits] [PATCH] D136620: Change how debugserver clears auth bits from pc/fp/sp/lr with thread_get_state on Darwin

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/DNB.cpp:1830-1837 + static bool g_tried_addressing_bits_syscall = false; + if (g_tried_addressing_bits_syscall == false) { +size_t len = sizeof(uint32_t); +if (::sysctlbyname("machdep.virtual_

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere updated this revision to Diff 470283. JDevlieghere marked 8 inline comments as done. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135622/new/ https://reviews.llvm.org/D135622 Files: lldb/include/lldb/Utility/Dia

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectDiagnostics.cpp:84 +if (!directory) { + result.AppendError(llvm::toString(directory.takeError())); + result.SetStatus(eReturnStatusFailed); clayborg wrote: > Do we wan

[Lldb-commits] [PATCH] D136648: [lldb] Emit diagnostic events in the diagnostic dump

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. Emit diagnostic events (errors and warnings) in the diagnostic dump. This patch also adds an "information" diagnostic event

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere updated this revision to Diff 470503. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Update wording CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135622/new/ https://reviews.llvm.org/D135622 Files: lldb/include/lldb/Utility/Diagnostics.h l

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Diagnostics.cpp:70 - Error error = Create(FileSpec(diagnostics_dir.str())); + Error error = Create(*diagnostics_dir); if (error) { DavidSpickett wrote: > JDevlieghere wrote: > > DavidSpick

[Lldb-commits] [PATCH] D136620: Change how debugserver clears auth bits from pc/fp/sp/lr with thread_get_state on Darwin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136620/new/ https://reviews.llvm.org/D136620 ___

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 470975. JDevlieghere added a comment. Remove spurious `lldb` subdir CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Utility/Diagnostics.

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with @rupprecht's comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136798/new/ https://reviews.llvm.org/D136798 __

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

JDevlieghere added a comment. Thanks Will, let me apply this locally and see if that addresses the issue for which I reverted the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/D132734 _

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice use of std::optional. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136719/new/ https://reviews.llvm.org/D136719 ___

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:725 +MachProcess::GetPlatformString(unsigned char platform) { + std::optional platform_string; switch (platform) { This is unused Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D136900: Don't test dyld_process_create_for_current_task symbol before calling it in HostInfoMacOSX.mm

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Two less levels of indentation 🥳 LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136900/new/ https://reviews.llvm.org/D136900 _

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG84ea6b6f78df: [lldb] Add diagnostics (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d01300aacf6: [lldb] Add a "diagnostics dump" command (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D136648: [lldb] Emit diagnostic events in the diagnostic dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aed0ce20fc6: [lldb] Emit diagnostic events in the diagnostic dump (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Should this be controllable with a setting? I'm not sure I (always) want my editor to pop up when I save a transcript. Comment at: lldb/source/Interpreter/Comman

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137137/new/ https://reviews.llvm.org/D137137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D135616: [lldb/Utility] Fix StructuredData::ParseJSONValue for null items

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135616/new/ https://reviews.llvm.org/D135616 ___

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

JDevlieghere added a comment. The change looks good but I'd like to see a few more unit tests to cover edge cases (empty array, dict, etc), Comment at: lldb/unittests/Utility/StructuredDataTest.cpp:40-43 + const std::string expected = + " Array :\n3.14\n1.23

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere updated this revision to Diff 472812. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135631/new/ https://reviews.llvm.org/D135631 Files: lldb/source/Core/Debugger.cpp lldb/test/Shell/Dia

[Lldb-commits] [PATCH] D137301: PlatformDarwinKernel::GetSupportedArchitectures should report all supported architectures

JDevlieghere added a comment. LGTM Comment at: lldb/source/Target/Target.cpp:1550-1556 + LLDB_LOGF( + log, + "Target::SetArchitecture changing architecture to %s (%s) from %s (%s)", + arch_spec.GetArchitectureName(), + arch_spec.GetTriple().getTriple().c_st

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT with the missing periods fixed. Comment at: lldb/source/Utility/StructuredData.cpp:208 + +// Reset original indentation level +s.SetIndentLevel(inden

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few nits but overall this LGTM. Comment at: lldb/examples/python/crashlog.py:601-605 +for idx, backtrace in enumerate(json_app_specific_bts): +

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

JDevlieghere added a comment. I like the new approach, it's much easier to follow. I also like the wrapper class to abstract over the common operations. It just seems like there are some remnants of the canonical wp approach that we no longer need. Comment at: lldb/include/ll

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D137807: When scanning mach-o corefile, don't run all DynamicLoader plugins letting one of them Create when searching for binaries

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp:334 + // un-set it later. + if (m_dyld_up.get()) m_dyld_plugin_name = GetDynamic

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo a few small nits Comment at: lldb/include/lldb/Symbol/CompilerType.h:60 +} +operator bool() const { return (bool)m_typesystem_sp; } +bool

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory

JDevlieghere added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135631/new/ https://reviews.llvm.org/D135631 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:410 + LLDB_LOG(log, "xcrun returned exit code %d", status); + return ""; +

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere created this revision. JDevlieghere added reviewers: avl, friss, aprantl. Herald added a subscriber: hiraditya. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. D125469

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere updated this revision to Diff 475985. JDevlieghere added a comment. Remove unrelated changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 Files: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h llvm/lib/DWARFLinker/DW

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere updated this revision to Diff 475988. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address @friss' feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 Files: llvm/include/llvm/DWARFLinker/DW

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere updated this revision to Diff 476158. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address @avl's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 Files: llvm/include/llvm/DWARFLinker/DWAR

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:13 #include "lldb/Host/macosx/HostInfoMacOSX.h" +#include "lldb/Core/Debugger.h" #include "lldb/Utility/Args.h" aprantl wrote: > labath wrote: > > We shouldn't have

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere added a comment. In D138176#3937163 , @avl wrote: > That might be an error if referenced DIE is not cloned. @friss and I were starting to wonder the same thing. I was out last week because of Thanksgiving but I'll dig into this a bit more t

[Lldb-commits] [PATCH] D138430: [lldb/test] Use SBPlatform info for lldbplatformutil.getPlatform()

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138430/new/ https://reviews.llvm.org/D138430 ___

[Lldb-commits] [PATCH] D138879: [lldb] Make SWIG an autodetected depenency

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, mib, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch makes SWIG itself an autodetected dependency. This allows us to look for SWIG once in a centralized place and makes it

[Lldb-commits] [PATCH] D138879: [lldb] Make SWIG an autodetected depenency

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3c978e850d3: [lldb] Make SWIG an auto-detected dependency (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:10 +#include "lldb/Host/macosx/HostInfoMacOSX.h" +#include "Utility/UuidCompatibility.h" #inclu

[Lldb-commits] [PATCH] D139054: Delay calling ObjC class list read utility functions very early in process startup

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2519-2520 + case SharedCacheWarningReason::eExpressionUnableToRun: +Debugger::ReportWarning("Objective-C class names could not be read " +

[Lldb-commits] [PATCH] D139061: [lldb] Fix the `dwarf` log descriptions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp:15 {{"comp"}, - {"log insertions of object files into DWARF debug maps"}, +

[Lldb-commits] [PATCH] D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139058/new/ https://reviews.llvm.org/D139058 ___

[Lldb-commits] [PATCH] D138878: [lldb] Remove timer from Module::GetNumCompileUnits

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138878/new/ https://reviews.llvm.org/D138878 ___

[Lldb-commits] [PATCH] D139247: [lldb/Utility] Make ScriptedProcessInfo more generic

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Utility/ScriptedMetadata.h:12-14 +#include "lldb/Host/Host.h" +#include "lldb/Host/ProcessLaunchInfo.h" +#include "lld

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 _

[Lldb-commits] [PATCH] D139361: [lldb-tests] Force system's libcxx on tests failing with debug symbols

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139361/new/ https://reviews.llvm.org/D139361 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptedMetadata.h:36 + + std::string GetClassName() const { return m_class_name; } + StructuredData::DictionarySP GetArgsSP() const { return m_args_sp; } Why return a copy? Can this

[Lldb-commits] [PATCH] D103020: [lldb] Add missing mutex guards to TargetList::CreateTarget

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103020/new/ https://reviews.llvm.org/D103020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103107/new/ https://reviews.llvm.org/D103107 ___ lldb-comm

[Lldb-commits] [PATCH] D103217: Make ignore counts work as "after stop" modifiers so they play nicely with conditions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/include/lldb/Breakpoint/BreakpointLocation.h:300-305 + /// BreakpointLocation::IgnoreCountShouldStop can only be called once + /// per st

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, labath, mib, jingham. Herald added a subscriber: pengfei. JDevlieghere requested review of this revision. When executing a `script` command in `HandleCommand(s)` we currently print its output twice: once directly to the

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. Are there other places where we check this, either in `lldbutil` or maybe more generally a pattern in the tests that could be extracted into a helper? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D103442: [lldb][NFC] Remove a redundant call to weak_ptr::expired

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103442/new/ https://reviews.llvm.org/D103442 __

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandReturnObject.h:169 + /// as a temporary. + bool m_hermetic; }; aprantl wrote: > bool m_hermetic = false; This is the second time

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere updated this revision to Diff 349033. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Use in-class initializers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103349/new/ https://reviews.llvm.org/D103349 Files: lldb/include/lldb/Interpreter/Co

[Lldb-commits] [PATCH] D103483: [lldb] Convert the default constructor’s member initializers into default member initializers

JDevlieghere added a comment. FWIW this is more of an RFC and as always there's some manual fixing up to be done and formatting to be fixed. I wanted to put this up for review before sinking time in that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103483/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D103504: Improve performance when parsing symbol tables in mach-o files.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103504/new/ https://reviews.llvm.org/D103504 ___

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere updated this revision to Diff 349651. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Don't try to be cute: `s/Hermetic/SuppressImmediateOutput/` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103349/new/ https://reviews.llvm.org/D103349 Files:

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

JDevlieghere added a comment. I think we should just remove the functionality form the timer class again. I only added it there because of the macro. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103575/new/ https://reviews.llvm.org/D103575

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

JDevlieghere added inline comments. Comment at: lldb/bindings/interface/SBTrace.i:32-51 + /// deprecated void StopTrace(SBError &error, lldb::tid_t thread_id); + /// deprecated void GetTraceConfig(SBTraceOptions &options, SBError

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a216fb15a18: [lldb] Don't print script output twice in HandleCommand (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to com

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

JDevlieghere added a comment. In D103575#2804151 , @aprantl wrote: > I'm not sure I fully understand the suggestion: > >> I think we should just remove the functionality form the timer class again. >> I only added it there because of the macro. > > ... a

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:103-105 CommandInterpreterRunOptions() + = default; Interesting, I would've expected clang-format to get this. CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104047/new/ https://reviews.llvm.org/D104047 __

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Expression/ExpressionParser.h:45 + virtual ~ExpressionParser() = default; + ; teemperor wrote: > Please drop that when you land it. Dropped. Comment at: lldb/include/lldb/Tar

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103575/new/ https://reviews.llvm.org/D103575 ___ lldb-commits

[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103391/new/ https://reviews.llvm.org/D103391

<    18   19   20   21   22   23   24   25   26   27   >