JDevlieghere added inline comments.
================
Comment at: lldb/source/Utility/Diagnostics.cpp:23
+static constexpr Log::Category g_categories[] = {
+ {{"lldb"}, {"diagnostics log for lldb"}, DiagnosticsLog::LLDB},
+};
----------------
kastiglione wrote:
> To me, it's not ideal that there's an "lldb" channel, and this channel has an
> "lldb" category.
>
> Do you have other categories in mind for later updates, that should be moved
> into this patch? For example, will there eventually be "warning" and "error"
> categories? If so, maybe start with those instead of "lldb".
Yes, for the errors I was going to add an error category. Maybe we can call
this one general or something?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135621/new/
https://reviews.llvm.org/D135621
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
