JDevlieghere added a comment. The change looks good but I'd like to see a few more unit tests to cover edge cases (empty array, dict, etc),
================ Comment at: lldb/unittests/Utility/StructuredDataTest.cpp:40-43 + const std::string expected = + " Array :\n 3.140000\n 1.234000 \n Dictionary :\n FalseBool " + ": False \n Integer : 1\n Null : NULL\n String : value\n TrueBool : " + "True"; ---------------- Maybe use a string literal to make it clear what the formatted text looks like? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135547/new/ https://reviews.llvm.org/D135547 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
