[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

JDevlieghere added a comment. In D131539#3711835 , @labath wrote: > In D131539#3711518 , @JDevlieghere > wrote: > >> In D131539#3711488 , @kastiglione >> wrote: >> >>> t

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

JDevlieghere added a comment. @labath Ping in case it got pushed down your review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131407/new/ https://reviews.llvm.org/D131407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D131542: [lldb/crashlog] Add `-V|--version` option

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131542/new/ https://reviews.llvm.org/D131542

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/DataFileCache.h:82 private: + /// Gets the default LLDB index cache policy, which is s It's a little weird that `GetLLDBIndexCachePolicy` would be private, if only from a documentation p

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Core/DataFileCache.cpp:23-46 +llvm::CachePruningPolicy DataFileCache::GetLLDBIndexCachePolicy() { + static llvm::CachePruningPolicy

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:6344 segment_vmaddr seg_vmaddr; +// this is the uncommon case where strncpy is exactly +// the right one, doesn't need to be nul terminated.

[Lldb-commits] [PATCH] D131613: [LLDB][NFC] Clean up dead code

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131613/new/ https://reviews.llvm.org/D131613 __

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere commandeered this revision. JDevlieghere added a reviewer: friss. JDevlieghere added a comment. Herald added a reviewer: shafik. Herald added a project: All. Commandeering this from Fred CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D5138

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere updated this revision to Diff 451714. JDevlieghere added a comment. - Rebase - Address Jim's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D51387 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/lldb/S

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere added a comment. In D51387#1387074 , @clayborg wrote: > Do we have any callers that call GetNumTemplateArguments with false? If not, > remove the argument? Yup, there's a bunch of uses in `Language/CPlusPlus/LibCxx*.cpp` CHANGES SINCE LAST

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { clayborg wrote: > fixathon wrote: > >

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jasonmolenda. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Starting with Xcode 14, ld64 is using authenticated fixups for x86_64 as well as a

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. With this patch applied the test suite should be clean on an Intel mac running macOS Ventura beta + Xcode 14 beta. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 ___ l

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM assuming this compiles on non-apple hosts Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542 + case EXC_BAD_ACCESS: +ret

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere updated this revision to Diff 452045. JDevlieghere added a comment. Check the darwin OS version as a proxy for the deployment target CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 Files: lldb/test/API/commands/target/basic/Test

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. In D131741#3717974 , @jasonmolenda wrote: > We already skip these tests for arm64 & arm64e because of the chained fixups > and arm64e fixups before that -- and now we're going to skip them on x86_64 > if the deployment tar

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. In D131741#3717992 , @JDevlieghere wrote: > In D131741#3717974 , @jasonmolenda > wrote: > >> We already skip these tests for arm64 & arm64e because of the chained fixups >> and arm

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere updated this revision to Diff 452077. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 Files: lldb/test/API/commands/target/basic/TestTargetCommand.py lldb/test/API/lang/c/global_variables/TestGlobalVariables.py lldb/test/API/l

[Lldb-commits] [PATCH] D131761: [LLDB] Remove __future__ imports from tests

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131761/new/ https://reviews.llvm.org/D131761 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D131772: [LLDB] Remove __future__ imports from examples

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131772/new/ https://reviews.llvm.org/D131772 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D131741: [lldb] Skip target variable tests on Darwin because of chained fixups

This revision was automatically updated to reflect the committed changes. Closed by commit rGabe9599f04f0: [lldb] Skip target variable tests on Darwin because of chained fixups (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. As mentioned in D113155 the difference in CPU type between `qHostInfo` and `qProcessInfo` is intentional. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

JDevlieghere added inline comments. Comment at: lldb/CMakeLists.txt:128 +set(LLDB_INCLUDE_UNITTESTS ON) +if (NOT TARGET llvm_gtest) + set(LLDB_INCLUDE_UNITTESTS OFF) mgorny wrote: > If LLDB is built through `LLVM_ENABLE_PROJECTS`, then LLDB's CMakeLists are > i

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with D118814

JDevlieghere added a comment. I applied your patch and ran the test and for me it's passing: lldb version 16.0.0git (g...@github.com:llvm/llvm-project.git revision 0c90d5f7e967aee8ab6e5e971e25921e631a40ac) clang revision 0c90d5f7e967aee8ab6e5e971e25921e631a40ac llvm revision 0c90d5f7e9

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131901/new/ https://reviews.llvm.org/D131901 ___

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp:227 static StructuredData::Array *ConvertToStructuredArray( ValueObjectSP return_value_sp, const std::string &items_name, fixat

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

JDevlieghere accepted this revision. JDevlieghere added a comment. In D131664#3715513 , @DavidSpickett wrote: > @JDevlieghere Unless this is still used in your downstream? Thanks for checking. It's not used downstream, so this LGTM. Repository: rG L

[Lldb-commits] [PATCH] D131850: [LLDB][NFC] Reliability Fixes for FormatEntity

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131850/new/ https://reviews.llvm.org/D131850 ___

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

This revision was automatically updated to reflect the committed changes. Closed by commit rG350755d94d6b: [llvm] Include utils/unittest before projects and runtimes (authored by JDevlieghere). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoi

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 452786. JDevlieghere added a comment. Rebase on top of D131303 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files: lldb/include/lldb/Core/Debugger.h lldb/incl

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with D118814

JDevlieghere added a comment. Great. Thanks for closing the loop on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131821/new/ https://reviews.llvm.org/D131821 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

JDevlieghere added a comment. In D131900#3724366 , @fixathon wrote: > I am going to clean up the code in the entire file where **raw pointers** > should be **shared_ptr** (because they get cast to shared_ptr anyways). Also > planning to convert the **na

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d36a82d0a3d: [lldb] Flush the global thread pool in Debugger::Terminate (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

This revision was automatically updated to reflect the committed changes. Closed by commit rG11f45f36dcf5: [lldb] Fetching symbols in the background with dsymForUUID (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131328?vs=452786&id=

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo inline comment. Comment at: lldb/include/lldb/Utility/SharedCluster.h:52 ClusterManager() : m_objects() {} - - llvm::SmallVector m_objects; + llvm::SmallPtrSet m_objects; std::mutex m_mutex;

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread = queue1.GetThreadAtIndex(0) Any reason this should be a separate func

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere marked 8 inline comments as done. JDevlieghere added a comment. Thanks for the review Michael. I've addressed all your comments in the version I landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D51387 __

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb706f56133a7: [lldb] Automatically unwrap parameter packs in template argument accessors (authored by JDevlieghere). Hera

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/SharedCluster.h:52 ClusterManager() : m_objects() {} - - llvm::SmallVector m_objects; + llvm::SmallPtrSet m_objects; std::mutex m_mutex; labath wrote: > JDevlieghere wrote: > > I as

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:65-69 +// Indeed this is a leak, but it's intentional. "future" obj destructor +// will block on waiting for the worker thread to join. And the worker +// thread might be stuck in b

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:14-26 +:: + $ cmake \ +-G Ninja \ +-DCMAKE_BUILD_TYPE='Release' \ +-DLLVM_USE_SANITIZER='Address' \ +-DLLVM_USE_SANITIZE_COVERAGE=On \ +-DLLVM_BUILD_RUNTIME=

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:28-33 +To build a fuzzer, run the desired ninja command for the fuzzer(s) you want to build: + +:: + $ ninja lldb-target-fuzzer + $ ninja lldb-commandinterpreter-fuzzer + $ ninja lldb-expressio

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_l

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + aprantl wrote: > JDevlieghere wrote: > > Please don't rely on environme

[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

JDevlieghere created this revision. JDevlieghere added reviewers: fdeazeve, aprantl, labath. Herald added a project: All. JDevlieghere requested review of this revision. D129166 was an attempt to ensure that by default we use the libc++ from the build dir instea

[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc0b5ebf7fc8: [lldb] Support specifying a custom libcxx for the API tests (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/RegularExpression.h:92 + std::regex m_regex; + std::optional m_regex_error; }; There's an ongoing discussion on the forums [1] to replace `llvm::Optional` with `std::optional`. Until th

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets (WIP)

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. https://reviews.llvm.org/D132433 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/Ob

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

JDevlieghere updated this revision to Diff 455428. JDevlieghere retitled this revision from "[lldb] Teach LLDB about filesets (WIP)" to "[lldb] Teach LLDB about filesets". JDevlieghere added a comment. - Rebase - Support reading Filesets from memory CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

This revision was automatically updated to reflect the committed changes. Closed by commit rG242c574dc03e: [lldb] Synchronize output through the IOHandler (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D121500?vs=414775&id=415474#toc

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

JDevlieghere added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:1309 stack.back().GetScalar() = DerefSizeExtractDataHelper( -addr_bytes, sizeof(addr_bytes), objfile->GetByteOrder(), size); +addr_bytes, size,

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415643. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Herald added a subscriber: mgorny. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Fil

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415644. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/source/Core/DebuggerEv

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415695. JDevlieghere added a comment. Print diagnostics directly to the debugger's error stream if nobody is listening for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415697. JDevlieghere added a comment. Migrate a few more call sites to `Debugger::Report{Error,Warning}` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h ll

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415699. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/source/Core/DebuggerEv

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fc38b2b7bf9: [lldb] Report debugger diagnostics as events (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: http

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib. Herald added a project: All. JDevlieghere requested review of this revision. Expose diagnostic events through the SB API. Unlike the progress events, I chose to use a SBStructuredData so that we can add fields in the f

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

JDevlieghere updated this revision to Diff 415894. JDevlieghere added a comment. Use the minidump warning to check for an actual event. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121818/new/ https://reviews.llvm.org/D121818 Files: lldb/bindings/interface/SBDebugger.i lldb/includ

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

JDevlieghere updated this revision to Diff 415895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121818/new/ https://reviews.llvm.org/D121818 Files: lldb/bindings/interface/SBDebugger.i lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/API/SBD

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

JDevlieghere added a comment. Can we cover this case in the existing test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121826/new/ https://reviews.llvm.org/D121826 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

JDevlieghere added a comment. In D121631#3386244 , @labath wrote: > In D121631#3384124 , @yinghuitan > wrote: > >>> unify with `target.preload-symbols` feature >> >> I do not have strong opinion on this. One conc

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121844/new/ https://reviews.llvm.org/D121844 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

This revision was automatically updated to reflect the committed changes. Closed by commit rGff9e596b1006: [lldb] Expose diagnostic events through the SB API (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D121818?vs=415895&id=415996#t

[Lldb-commits] [PATCH] D121831: Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. We do the same thing for parsing the classes from the Objective-C runtime so this makes sense to me. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121831/new/ https

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. I think we've reached a point where the test binary has become complex enough that we should check it in instead of hoping that the offsets will match, but that's something t

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

JDevlieghere closed this revision. JDevlieghere added a comment. Landed as 242c574dc03e CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121537/new/ https://reviews.llvm.org/D121537

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121912/new/ https://reviews.llvm.org/D121912

[Lldb-commits] [PATCH] D121900: [lldb] Add more documentation on test variants

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121900/new/ https://reviews.llvm.org/D121900 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Can we include this in the `docs` folder instead? Having READMEs spread throughout the sources isn't going to be particularly discoverable. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf93d861349f9: [lldb] Fix ^C handling in IOHandlerProcessSTDIO (authored by labath, committed by JDevlieghere). Changed prior to commit: https://re

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Please reflow the document to match the 80 column limit observed in the other docs. LGTM with that addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1624 +# == +# Utility class to setup a progress event listener +# == We

[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1624 +# == +# Utility class to setup a progress event listener +# == mi

[Lldb-commits] [PATCH] D122025: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput

JDevlieghere created this revision. JDevlieghere added reviewers: labath, lemo, jingham, mib. Herald added a project: All. JDevlieghere requested review of this revision. The assertion checks that the command output doesn't contain any null bytes. I'm not sure if the intention was to make sure the

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/eventlistener.py:19 +eBroadcastBitStopListenerThread = (1 << 0) +fetched_events = [] + Just `events` maybe? Comment at: lldb/packages/Python/lldbsuite/t

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice, thanks for bearing with me. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121977/new/ https://reviews.llvm.org/D121977 ___

[Lldb-commits] [PATCH] D122177: [lldb] Fix log & progress report for in-memory binaries

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Fix the log and progress report message for in-memory binaries. If there's no object file, use the name from the Module. With this

[Lldb-commits] [PATCH] D122177: [lldb] Fix log & progress report for in-memory binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG3323321f4ef0: [lldb] Fix log & progress report for in-memory binaries (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D122177?vs=417077&id=417

[Lldb-commits] [PATCH] D122025: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput

JDevlieghere updated this revision to Diff 417483. JDevlieghere added a comment. Use `StringRef::split` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122025/new/ https://reviews.llvm.org/D122025 Files: lldb/source/Interpreter/CommandInterpreter.cpp Index: lldb/source/Interpreter/Co

[Lldb-commits] [PATCH] D122283: [lldb] Add a Stream variant that escapes null bytes

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath. Herald added a project: All. JDevlieghere requested review of this revision. In D122025 Jim suggested that we should sanitize the input to the command return object to retain the

[Lldb-commits] [PATCH] D122349: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

JDevlieghere created this revision. JDevlieghere added reviewers: friss, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. The current code increment the indirect symbol offset with the LINKEDIT slide every time `ObjectFileMachO::ParseSymtab` is called. Th

[Lldb-commits] [PATCH] D122347: Expose GetAddressingBits() in the Process API

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122347/new/ https://reviews.llvm.org/D122347 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D122349: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

JDevlieghere added a comment. PS: I don't think we should ever parse the symbol table more than onceafter D114288 , but this patch is still the right thing to do imho. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122349/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D122025: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0f1f3b95cd5: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D122349: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0dc2fae6025: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D122422: [lldb/crashlog] Parse more thread fields and pass it to crashlog scripted process

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122422/new/ https://reviews.llvm.org/D122422 __

[Lldb-commits] [PATCH] D122429: [lldb/Plugin] Sort the ScriptedProcess' thread list before creating threads

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:320 + + std::vector sorted_keys(keys->GetSize()); + auto sort_keys = [&sorted_keys](StructuredData::Object *item) -> bool { Won't this overflow when you ret

[Lldb-commits] [PATCH] D122461: [lldb] Add a fuzzer for target create

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds a fuzzer that interprets inputs as object files and makes lldb create targets from them. It is v

[Lldb-commits] [PATCH] D122461: [lldb] Add a fuzzer for target create

JDevlieghere updated this revision to Diff 418133. JDevlieghere added a comment. Fix ASCII art CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122461/new/ https://reviews.llvm.org/D122461 Files: lldb/tools/CMakeLists.txt lldb/tools/lldb-fuzzer/CMakeLists.txt lldb/tools/lldb-fuzzer/

[Lldb-commits] [PATCH] D122461: [lldb] Add a fuzzer for target create

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-fuzzer-target.cpp:24 +extern "C" int LLVMFuzzerTestOneInput(uint8_t *data, size_t size) { + auto file = TempFile::Create(data, size); + if (!file)

[Lldb-commits] [PATCH] D122429: [lldb/Plugin] Sort the ScriptedProcess' thread list before creating threads

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:320 + + std::vector sorted_keys(keys->GetSize()); + auto sort_keys = [&sorted_keys](StructuredData::Object *item) -> bool { mib wrote: > JDevlieghere wrote:

[Lldb-commits] [PATCH] D122426: [lldb/Utility] Make `StructuredData::Dictionary::GetKeys` return an `Array`

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122426/new/ https://reviews.llvm.org/D122426 __

[Lldb-commits] [PATCH] D122429: [lldb/Plugin] Sort the ScriptedProcess' thread list before creating threads

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:321-342 + auto sort_keys = [&sorted_threads, +&thread_info_sp](StructuredData::Object *item) -> bool { +if (!item) + return false; + +llvm::S

[Lldb-commits] [PATCH] D122429: [lldb/Plugin] Sort the ScriptedProcess' thread list before creating threads

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:321-342 + auto sort_keys = [&sorted_threads, +&thread_info_sp](Stru

[Lldb-commits] [PATCH] D122461: [lldb] Add a fuzzer for target create

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG61efe14e21b2: [lldb] Add a fuzzer for target creation (authored by JDevlieghere). Herald added projects: LLDB, LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham, clayborg, jasonmolenda. Herald added subscribers: mgrang, mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Currently we error out if multiple platforms can supports the architectu

<    8   9   10   11   12   13   14   15   16   17   >