JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo inline comment.
================ Comment at: lldb/include/lldb/Utility/SharedCluster.h:52 ClusterManager() : m_objects() {} - - llvm::SmallVector<T *, 16> m_objects; + llvm::SmallPtrSet<T *, 16> m_objects; std::mutex m_mutex; ---------------- I assume pointers cannot be modified once they're in the set. Can this be `const T *`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131996/new/ https://reviews.llvm.org/D131996 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits