JDevlieghere added inline comments.
================ Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:65-69 + // Indeed this is a leak, but it's intentional. "future" obj destructor + // will block on waiting for the worker thread to join. And the worker + // thread might be stuck in blocking I/O. Intentionally leaking the obj + // as a hack to avoid blocking main thread, and adding annotation to + // supress static code inspection warnings ---------------- ================ Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:89-95 + // Indeed this is a leak, but it's intentional. "future" obj destructor will + // block on waiting for the worker thread to join. And the worker thread + // might be stuck in blocking I/O. Intentionally leaking the obj as a hack + // to avoid blocking main thread, and adding annotation to supress static + // code inspection warnings" + + // coverity[leaked_storage] ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131998/new/ https://reviews.llvm.org/D131998 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
