[Lldb-commits] [lldb] r302327 - Be a little more permissive in DynamicLoaderMacOS::CanLoadImage

Author: jingham Date: Fri May 5 20:15:47 2017 New Revision: 302327 URL: http://llvm.org/viewvc/llvm-project?rev=302327&view=rev Log: Be a little more permissive in DynamicLoaderMacOS::CanLoadImage If we can't find the "is dyld locked" symbol, assume it is safe to load the image unless we only ha

Re: [Lldb-commits] [PATCH] D33283: RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false

Yes, though the original code handled the unsuccessful completion cases slightly differently. I'm not sure how significant that is without pondering it further and I'm in the middle of something else right now. Jim > On May 17, 2017, at 1:31 PM, Pavel Labath via Phabricator > wrote: > > lab

[Lldb-commits] [lldb] r303643 - We shouldn't put actual tests in directories that contain

Author: jingham Date: Tue May 23 11:11:21 2017 New Revision: 303643 URL: http://llvm.org/viewvc/llvm-project?rev=303643&view=rev Log: We shouldn't put actual tests in directories that contain other test directories. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/num_

[Lldb-commits] [lldb] r303832 - Fix the warning when you pass -c to step/next/si/ni.

Author: jingham Date: Wed May 24 21:24:18 2017 New Revision: 303832 URL: http://llvm.org/viewvc/llvm-project?rev=303832&view=rev Log: Fix the warning when you pass -c to step/next/si/ni. During some cleanup the test for whether the thread plan accepted an iteration count was reversed, so we give

Re: [Lldb-commits] Documentation LLDB-MI

The virtue of the MI interface is that it allows you to write a tool that supports gdb as well as lldb. But the MI is a not an API per se, it's just a structured text interface. You send text commands to the MI server, and receive text results which you then parse to extract the results. If

Re: [Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

SBThread::Resume instructs lldb to set the resume state on a thread to "eStateRunning", meaning that means the next time you continue the process, that thread will get a chance to run. It has no effect on the StopReason for the thread (it doesn't even start it running except maybe in the not we

Re: [Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

Before we get past "it's hard" to "just to do it", it would help me to be clear first on what you are actually trying to achieve with this proposal. It's not clear to me what problem are people trying to solve here? If it is writing tests for the decomposable parts of lldb - like the tests Jas

Re: [Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

ypothetical DSL that allowed every test to be an inline test but > still test equally complicated scenarios in half the code. Then suppose it > also ran on a more robust multiprocessing infrastructure than dotest.py. > That's all we're really talking about Thanks for the clarific

Re: [Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

> devising. I can't at all see wanting to learn that if the only use it would > be to me is for writing tests. > > > After all, they're simpler than the other style of test. Now, suppose there > > were some hypothetical DSL that allowed every test to be an inli

[Lldb-commits] [lldb] r304379 - Forgot to mention rewriting CommandObject::DoExecute

Author: jingham Date: Wed May 31 20:05:30 2017 New Revision: 304379 URL: http://llvm.org/viewvc/llvm-project?rev=304379&view=rev Log: Forgot to mention rewriting CommandObject::DoExecute using the SB API's not the lldb_private API's. Modified: lldb/trunk/www/projects.html Modified: lldb/tru

Re: [Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

This is WWDC week. We’ll try to find time to take a look at this, but silence may mean preoccupation more than anything else… Jim > On Jun 6, 2017, at 6:53 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > I'd like to commit this this week. If you have any objections

[Lldb-commits] [lldb] r306445 - Fix up the Xcode project:

Author: jingham Date: Tue Jun 27 11:48:32 2017 New Revision: 306445 URL: http://llvm.org/viewvc/llvm-project?rev=306445&view=rev Log: Fix up the Xcode project: 1) Renaming the InstrumentationRuntime directory & file names 2) Bunch of stuff moved from Core to Utility 3) Deleted a bunch of files re

[Lldb-commits] [lldb] r306725 - Timer.{h, cpp} moved, find them again in the project file.

Author: jingham Date: Thu Jun 29 11:54:40 2017 New Revision: 306725 URL: http://llvm.org/viewvc/llvm-project?rev=306725&view=rev Log: Timer.{h,cpp} moved, find them again in the project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxp

[Lldb-commits] [lldb] r307234 - Add a lldbutils routine that gathers up the boiler-plate

Author: jingham Date: Wed Jul 5 19:18:16 2017 New Revision: 307234 URL: http://llvm.org/viewvc/llvm-project?rev=307234&view=rev Log: Add a lldbutils routine that gathers up the boiler-plate to make a target, set a source regex breakpoint, run to the breakpoint and find the thread that hit the br

[Lldb-commits] [lldb] r307287 - Working through testcases, converting to run_to_source_breakpoint.

Author: jingham Date: Thu Jul 6 11:06:25 2017 New Revision: 307287 URL: http://llvm.org/viewvc/llvm-project?rev=307287&view=rev Log: Working through testcases, converting to run_to_source_breakpoint. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/issue_11588/Test1158

[Lldb-commits] [lldb] r307870 - The llvm.org bugzilla moved.

Author: jingham Date: Wed Jul 12 17:36:21 2017 New Revision: 307870 URL: http://llvm.org/viewvc/llvm-project?rev=307870&view=rev Log: The llvm.org bugzilla moved. Modified: lldb/trunk/www/sidebar.incl Modified: lldb/trunk/www/sidebar.incl URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/

[Lldb-commits] [lldb] r307942 - Fix a deadlock in the Python interpreter vrs. SIGINT.

Author: jingham Date: Thu Jul 13 12:45:54 2017 New Revision: 307942 URL: http://llvm.org/viewvc/llvm-project?rev=307942&view=rev Log: Fix a deadlock in the Python interpreter vrs. SIGINT. The interpreter gets invoked in the sigint handler to cancel long-running Python operations. That requires t

[Lldb-commits] [lldb] r307943 - Convert a few more tests to use run_to_source_breakpoint.

Author: jingham Date: Thu Jul 13 12:46:21 2017 New Revision: 307943 URL: http://llvm.org/viewvc/llvm-project?rev=307943&view=rev Log: Convert a few more tests to use run_to_source_breakpoint. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/unwind_expression/TestUnwindE

[Lldb-commits] [lldb] r307944 - Enable parsing C++ names generated by lambda functions.

Author: jingham Date: Thu Jul 13 12:48:43 2017 New Revision: 307944 URL: http://llvm.org/viewvc/llvm-project?rev=307944&view=rev Log: Enable parsing C++ names generated by lambda functions. https://reviews.llvm.org/D34911 from Weng Xuetian. Modified: lldb/trunk/source/Plugins/Language/CPlusP

Re: [Lldb-commits] [PATCH] D34911: Enable parsing C++ names generated by lambda functions.

Done (r307944). Thanks for the patch! Jim > On Jul 13, 2017, at 8:20 AM, Xuetian Weng via Phabricator via lldb-commits > wrote: > > wengxt added a comment. > > I don't have commit access. May any one help me to commit? > > > https://reviews.llvm.org/D34911 > > > > _

[Lldb-commits] [lldb] r308549 - Add help text for "expression" telling how to enter multi-line mode.

Author: jingham Date: Wed Jul 19 16:25:42 2017 New Revision: 308549 URL: http://llvm.org/viewvc/llvm-project?rev=308549&view=rev Log: Add help text for "expression" telling how to enter multi-line mode. This seemed natural to us, but wasn't documented anywhere and was not clear to everybody. M

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

Not at present, but you presumably know more about this than I do. Part of the point of Greg's extracting the DWARF parser from lldb and making it into it's own library in llvm was precisely so that somebody could then write a simple wrapper tool that would poke it with not necessarily complete

[Lldb-commits] [lldb] r309238 - Fix the formatting for help on option value types.

Author: jingham Date: Wed Jul 26 17:18:18 2017 New Revision: 309238 URL: http://llvm.org/viewvc/llvm-project?rev=309238&view=rev Log: Fix the formatting for help on option value types. Patch by Jessica Han https://reviews.llvm.org/D35525 Modified: lldb/trunk/packages/Python/lldbsuite/test/

[Lldb-commits] [lldb] r309709 - Remember to make API headers Public in the LLDB target.

Author: jingham Date: Tue Aug 1 10:19:59 2017 New Revision: 309709 URL: http://llvm.org/viewvc/llvm-project?rev=309709&view=rev Log: Remember to make API headers Public in the LLDB target. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxpro

[Lldb-commits] [lldb] r309772 - Fix a mis-feature with propagation of breakpoint options -> location options.

Author: jingham Date: Tue Aug 1 17:16:10 2017 New Revision: 309772 URL: http://llvm.org/viewvc/llvm-project?rev=309772&view=rev Log: Fix a mis-feature with propagation of breakpoint options -> location options. When an option was set at on a location, I was just copying the whole option set to

[Lldb-commits] [lldb] r309969 - Add an auto-continue flag to breakpoints & locations.

Author: jingham Date: Thu Aug 3 11:13:24 2017 New Revision: 309969 URL: http://llvm.org/viewvc/llvm-project?rev=309969&view=rev Log: Add an auto-continue flag to breakpoints & locations. You can get a breakpoint to auto-continue by adding "continue" as a command, but that has the disadvantage th

[Lldb-commits] [lldb] r309977 - Cut and paste error from r23162.

Author: jingham Date: Thu Aug 3 12:38:38 2017 New Revision: 309977 URL: http://llvm.org/viewvc/llvm-project?rev=309977&view=rev Log: Cut and paste error from r23162. Modified: lldb/trunk/source/API/SBBreakpoint.cpp lldb/trunk/source/API/SBBreakpointLocation.cpp Modified: lldb/trunk/sour

Re: [Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

> On Aug 8, 2017, at 12:02 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D35223#834050, @emaste wrote: > >> With this patch I observed three new failures on FreeBSD and three new >> unexpected passes on FreeBSD. An exam

[Lldb-commits] [lldb] r311590 - Log whether we found a step out plan or not.

Author: jingham Date: Wed Aug 23 12:40:21 2017 New Revision: 311590 URL: http://llvm.org/viewvc/llvm-project?rev=311590&view=rev Log: Log whether we found a step out plan or not. Modified: lldb/trunk/source/Target/ThreadPlanStepInRange.cpp Modified: lldb/trunk/source/Target/ThreadPlanStepInR

[Lldb-commits] [lldb] r311679 - Fixed a typo in the example (getName -> GetName)

Author: jingham Date: Thu Aug 24 11:01:50 2017 New Revision: 311679 URL: http://llvm.org/viewvc/llvm-project?rev=311679&view=rev Log: Fixed a typo in the example (getName -> GetName) but while I was at it I converted the example to use properties, since that's much nicer looking. Modified: ll

[Lldb-commits] [lldb] r311786 - Add the DWARF DWP files to the Xcode project.

Author: jingham Date: Fri Aug 25 10:48:01 2017 New Revision: 311786 URL: http://llvm.org/viewvc/llvm-project?rev=311786&view=rev Log: Add the DWARF DWP files to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: ht

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Yes, the fact that llvm & clang and the MCJIT abort willy nilly has caused much pain to lldb. We don’t control that behavior and so are resigned to some continued suffering along those lines - though it seems like Lang is going to do a much cleaner job of handling problems in the new ORC JIT wh

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 8, 2017, at 11:45 PM, Zachary Turner wrote: > > > On Fri, Sep 8, 2017 at 8:19 PM Jason Molenda > wrote: > Also keep in mind that debug sessions have a tendency to be long lived. I > may be working through a problem for half an hour -- or this may be the on

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 9, 2017, at 11:36 AM, Zachary Turner wrote: > > > > On Sat, Sep 9, 2017 at 11:18 AM Jim Ingham > wrote: >> On Sep 8, 2017, at 11:45 PM, Zachary Turner > > wrote: >> > >> On Fri, Sep 8, 2017 at 8:19 PM Jason Molenda >

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

I think we are talking at cross purposes. Seems to me you are saying “If we can assert that the answers to questions I ask must always copacetic, then we can express that in software, and that will make things so much easier". I’m saying "my experience of the data debuggers have to deal with i

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 9, 2017, at 7:38 PM, Zachary Turner wrote: > > Sure, but reading a core file involves handling user input. Obviously that > has to be sanitized and you can't crash on user input. I don't think there's > ever been any disagreement about that. On the other hand, if you just type an > e

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

willing to give it a try. You are right that this code is tricky, but it would be worth the effort to fix it right, if for no other reason than to get some other eyes on it. I'm happy to answer any questions as you go along. This code has ping-ponged back and forth between Greg and me, so w

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

d narrow case. IMO the > > "right" fix is #1, but it seems a more radical change. #2 seems tempting in > > terms of code changes, but I find it less compelling overall since > > rollbacks are generally fragile if the code is not designed with that in > >

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 11, 2017, at 4:05 PM, Leonard Mosescu via lldb-commits > wrote: > > > Process already has "Error Process::WillResume()" for this very reason. Just > have the Windows mini dump core file plug-in override it. The code in > Process::Resume already checks this: > Status Process::Private

Re: [Lldb-commits] [lldb-dev] PTYPE replacement in LLDB

The original plan was to add a "type eval" to go alongside "type lookup". "type eval" would take an expression, evaluate it, and then print the resulting type. gdb's type takes either a type name or an expression, but there's no way to disambiguate if you have a type that has the same name as

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 12, 2017, at 11:19 AM, Zachary Turner via lldb-commits > wrote: > > > > On Tue, Sep 12, 2017 at 11:07 AM Greg Clayton wrote: > >> On Sep 12, 2017, at 10:10 AM, Zachary Turner wrote: >> >> >> >> On Tue, Sep 12, 2017 at 10:03 AM Greg Clayton wrote: >>> On Sep 12, 2017, at 9:53 A

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Huh, yeah I don't see any of these bugs as making your point. These are all fixes so I don't see how they argue that we're willfully ignoring anything. To the extent that they deal with asserts they fixes for lldb not remembering that it has to tread carefully to avoid triggering other asserts

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Can you elaborate on this comment. I must be being dense but it didn't parse for me. Jim > On Sep 12, 2017, at 1:21 PM, Zachary Turner wrote: > > Incidentally, if you add --stat to the command line there, you'll see that > only 1 of those CLs has any test coverage at all. I pressed Enter a

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Got that part, didn't get the last PP. Jim > On Sep 12, 2017, at 1:36 PM, Zachary Turner wrote: > > > > On Tue, Sep 12, 2017 at 1:30 PM Jim Ingham wrote: > Can you elaborate on this comment. I must be being dense but it didn't parse > for me. > > Jim > > git log --stat shows you the file

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Yeah, seems like there's too much heat right now of this to be a useful avenue. Jim > On Sep 12, 2017, at 1:35 PM, Zachary Turner wrote: > > 4ad5334bfcff803f3765e444785b8f9d3a73c683: Don't pass a null StringRef. > simple. > f7b079263a751fdf3adea8e549803aaf92d465f8: Maybe fix it instead, as th

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

I agree with Jason here, but I guess that's no surprise. Jim > On Sep 12, 2017, at 2:57 PM, Jason Molenda via lldb-commits > wrote: > > Or another way, I don't object to asserts because we hit them so often today. > I object to asserts in a shipping debugger fundamentally - it's not an err

[Lldb-commits] [lldb] r313216 - Forgot to svn add the test cases for breakpoint auto-continue flag.

Author: jingham Date: Wed Sep 13 16:43:26 2017 New Revision: 313216 URL: http://llvm.org/viewvc/llvm-project?rev=313216&view=rev Log: Forgot to svn add the test cases for breakpoint auto-continue flag. Adding that now. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoi

[Lldb-commits] [lldb] r313221 - Commands are -d to break modify, not -C.

Author: jingham Date: Wed Sep 13 17:27:36 2017 New Revision: 313221 URL: http://llvm.org/viewvc/llvm-project?rev=313221&view=rev Log: Commands are -d to break modify, not -C. The auto-continue test was using the new (better) name for providing commands (-C) but I haven't checked in that change ye

[Lldb-commits] [lldb] r313293 - Add new files to the cmake lists.

Author: jingham Date: Thu Sep 14 13:31:02 2017 New Revision: 313293 URL: http://llvm.org/viewvc/llvm-project?rev=313293&view=rev Log: Add new files to the cmake lists. Modified: lldb/trunk/source/API/CMakeLists.txt lldb/trunk/source/Breakpoint/CMakeLists.txt Modified: lldb/trunk/source/A

[Lldb-commits] [lldb] r313296 - Remove BreakpointName.h from all targets so it doesn't

Author: jingham Date: Thu Sep 14 13:52:35 2017 New Revision: 313296 URL: http://llvm.org/viewvc/llvm-project?rev=313296&view=rev Log: Remove BreakpointName.h from all targets so it doesn't get included in headermaps or put in a CopyFiles phase. Modified: lldb/trunk/lldb.xcodeproj/project.pbx

[Lldb-commits] [lldb] r313305 - Mention breakpoint names in the tutorial.

Author: jingham Date: Thu Sep 14 15:20:31 2017 New Revision: 313305 URL: http://llvm.org/viewvc/llvm-project?rev=313305&view=rev Log: Mention breakpoint names in the tutorial. Modified: lldb/trunk/www/tutorial.html Modified: lldb/trunk/www/tutorial.html URL: http://llvm.org/viewvc/llvm-proj

[Lldb-commits] [lldb] r313327 - Wire up the breakpoint name help string.

Author: jingham Date: Thu Sep 14 17:52:35 2017 New Revision: 313327 URL: http://llvm.org/viewvc/llvm-project?rev=313327&view=rev Log: Wire up the breakpoint name help string. Modified: lldb/trunk/include/lldb/API/SBBreakpointName.h lldb/trunk/packages/Python/lldbsuite/test/functionalitie

[Lldb-commits] [lldb] r313371 - Remove a couple of warnings pointed out by Ted Woodward.

Author: jingham Date: Fri Sep 15 10:54:37 2017 New Revision: 313371 URL: http://llvm.org/viewvc/llvm-project?rev=313371&view=rev Log: Remove a couple of warnings pointed out by Ted Woodward. Modified: lldb/trunk/source/API/SBBreakpointName.cpp Modified: lldb/trunk/source/API/SBBreakpointName

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

Python based commands will need to be able to call WasInterrupted if they are going to do their jobs. So it would make sense to add an SBCommandInterpreter::WasInterrupted API and make sure that works. And you can already send the interrupt with DispatchInputInterrupt. So it should be pretty

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

I'd really prefer to do this as/along with an SB API test since we also need commands made through the SB API to be interruptible, and we should test that that also works. So this kills two birds with one stone. In general, when developing any high-level features in lldb one of the questions y

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

I disagree. The things we care about are (a) that this works in C++ implemented commands and (b) that it works in Python commands. This doesn't seem to test either of those things. Also, I find writing tests for new functionality to be a great way to inform you about what you need to add to t

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

We agreed to forwards compatibility because people write big scripts that use the SB API, implement GUI's on top of them (more than just Xcode) etc. So we try not to jerk those folks around. That adds a little more responsibility on our part to think carefully about what we add, but the notion

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

> On Sep 19, 2017, at 11:30 AM, Zachary Turner wrote: > > > > On Tue, Sep 19, 2017 at 11:27 AM Jim Ingham wrote: > We agreed to forwards compatibility because people write big scripts that use > the SB API, implement GUI's on top of them (more than just Xcode) etc. So we > try not to jerk

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

IIRC Enrico put in something where we would tell Python to interrupt at points where Python checks for interruptibility, but that is pretty herky-jerky. It would be much better to have the commands control this. Jim > On Sep 19, 2017, at 11:34 AM, Jim Ingham wrote: > > >> On Sep 19, 2017, a

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

Xcode does, I don't know about other UI's. Jim > On Sep 19, 2017, at 11:35 AM, Leonard Mosescu wrote: > > I agree Jim. I'd like like to build thing incrementally - checking in the > current change as is does not preclude adding the SB APIs while it does > provide the foundation. > > I think

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

I must be missing something. DisaptchInputInterrupt knows how to interrupt a running process, and because of Enrico's Python interruption stuff it will interrupt script execution at some point but it wasn't very reliable last time I tried it. But the whole point of this patch is that in gen

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

That seems fine to me. Jim > On Sep 19, 2017, at 11:39 AM, Leonard Mosescu wrote: > > So, how about I look into exposing WasInterrupted() through SB APIs in a > follow up change? > > On Tue, Sep 19, 2017 at 11:36 AM, Jim Ingham wrote: > Xcode does, I don't know about other UI's. > > Jim >

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

> On Sep 19, 2017, at 11:25 AM, Leonard Mosescu wrote: > > These are all great suggestions, thanks everyone! > > > We should have a test. The test would need to use pexpect or something > > similar. If anyone has any pointer on how to make a test for this, please > > chime in. I was thinking

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

Here's a short description of the coding rules and the general idea of how to add API's: http://lldb.llvm.org/SB-api-coding-rules.html If you come across something you wished would have been in this document while you are implementing this, please add it. It's sometimes hard to see some cruci

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

One of the fundamental goals of lldb is that it be an extensible debugger. The extension mechanism for command line lldb all runs through the SB API through either Python or C++ (though most folks choose to use Python). We know first hand that many people take advantage this mechanism to add c

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

Directly WRT testing. I’m not against ALSO adding gtests when you add some functionality. But when your change is actually adding behaviors to lldb, one of the things you need to ask yourself is if this is functionality that extension developers for lldb will benefit from. If it is, then addi

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

I write lots of tests. I don’t really think that the SB API’s are really a barrier to writing tests. The lldbinline tests are trivial to write and can even be made just as a transcription of an lldb command line session, so the barrier to entry is trivial. That is surely the easiest way to wr

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

> On Sep 20, 2017, at 11:25 AM, Zachary Turner wrote: > > > > On Wed, Sep 20, 2017 at 11:14 AM Jim Ingham > wrote: > > The amount of test coverage lldb has at present has much more to do with the > very aggressive schedules lldb has been driven by since its incepti

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

> On Sep 20, 2017, at 4:16 PM, Leonard Mosescu wrote: > > I don't quite understand the comment about signals adding indeterminacy. No > signal delivery is required to test this part. The lldb driver has a sigint > handler that calls SBDebugger::DispatchInputInterrupt. But since you aren't >

[Lldb-commits] [lldb] r314371 - Revert patch r313904, as it breaks "command source" and in

Author: jingham Date: Wed Sep 27 18:39:07 2017 New Revision: 314371 URL: http://llvm.org/viewvc/llvm-project?rev=314371&view=rev Log: Revert patch r313904, as it breaks "command source" and in particular causes lldb to die on startup if you have a ~/.lldbinit file. I filed: https://bugs.llvm.or

[Lldb-commits] [lldb] r314958 - Another silly little thing you can do with Python commands.

Author: jingham Date: Wed Oct 4 17:49:49 2017 New Revision: 314958 URL: http://llvm.org/viewvc/llvm-project?rev=314958&view=rev Log: Another silly little thing you can do with Python commands. Sometimes you want to step along and print a local each time as you go. You can do that with stop hooks

[Lldb-commits] [lldb] r314959 - Work around a bug in the C++ expression parser.

Author: jingham Date: Wed Oct 4 18:00:29 2017 New Revision: 314959 URL: http://llvm.org/viewvc/llvm-project?rev=314959&view=rev Log: Work around a bug in the C++ expression parser. When the expression parser does name resolution for local variables in C++ closures it doesn't give the local name

[Lldb-commits] [lldb] r315549 - The save_crashlog command was still looking at lldb.target and

Author: jingham Date: Wed Oct 11 19:21:41 2017 New Revision: 315549 URL: http://llvm.org/viewvc/llvm-project?rev=315549&view=rev Log: The save_crashlog command was still looking at lldb.target and lldb.process. That hasn't worked for a long time. Convert it to the form that takes an SBExecutionC

Re: [Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

This thread behavior over fork is the same on Mach, BTW. Apple extended posix_spawnp to take a “Stop at first instruction” attribute, basically just running PT_TRACEME for us. That has ended up being very handy because we get all the nice cleanup behavior that pthread_spawn does, but still get

Re: [Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

See my other message. In a ptrace based system the inferior has to call PT_TRACEME to signal it should be stopped at the first instruction. So you do need to run that code. As I said, Apple added an extension to posix_spawnp to do this for us. Jim > On Oct 16, 2017, at 2:17 PM, Zachary Tu

Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

> On Oct 26, 2017, at 9:34 AM, Zachary Turner > wrote: > > Note that $ is a valid character in a MSVC-mangled symbol name. So, I don't > think it will work for that reason alone. FWIW, I also don't like the {,,} > syntax very much, but if you read on there's a sim

[Lldb-commits] [lldb] r316954 - Remove a stray space.

Author: jingham Date: Mon Oct 30 13:44:45 2017 New Revision: 316954 URL: http://llvm.org/viewvc/llvm-project?rev=316954&view=rev Log: Remove a stray space. Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp Modified: lldb/trunk/source/Plugins/Lan

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

> On Oct 30, 2017, at 5:35 PM, Zachary Turner wrote: > > > On Mon, Oct 30, 2017 at 5:32 PM Jim Ingham via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > jingham added a comment. > > In https://reviews.llvm.org/D39436#911304 > , @hintonda wro

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

> On Oct 31, 2017, at 9:05 AM, Zachary Turner wrote: > > This is a case where I think a new API *would* be warranted. But it would > not be an API specifically for the -m option. It would instead be an API > that introduces an `SBBreakpointOptions` class, and then add a method called > `Br

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

Not directly, though you can get the ID from the breakpoint you've made, and then do: debugger.HandleCommand("breakpoint modify -m 0 %d"%(ID)) Jim > On Oct 31, 2017, at 8:32 AM, Don Hinton wrote: > > Btw, is there a way to pass the '-m' option via the SB API? I'd like to > exclude matches

[Lldb-commits] [lldb] r317043 - Modernize the example cmdtemplate.py.

Author: jingham Date: Tue Oct 31 15:38:24 2017 New Revision: 317043 URL: http://llvm.org/viewvc/llvm-project?rev=317043&view=rev Log: Modernize the example cmdtemplate.py. This version relies on a newer and more convenient way to use a class to implement a command. It has been in place since ear

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

> On Nov 1, 2017, at 9:54 AM, Greg Clayton via Phabricator > wrote: > > clayborg added a comment. > > In https://reviews.llvm.org/D39436#912828, @zturner wrote: > >> In https://reviews.llvm.org/D39436#912810, @clayborg wrote: >> >>> I was unhappy when we went over two pointers for a FileSpe

[Lldb-commits] [lldb] r351585 - Add BreakpadRecords to the Xcode project.

Author: jingham Date: Fri Jan 18 12:20:40 2019 New Revision: 351585 URL: http://llvm.org/viewvc/llvm-project?rev=351585&view=rev Log: Add BreakpadRecords to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http:/

[Lldb-commits] [lldb] r352114 - Add unittests to the Xcode gtest target.

Author: jingham Date: Thu Jan 24 14:03:36 2019 New Revision: 352114 URL: http://llvm.org/viewvc/llvm-project?rev=352114&view=rev Log: Add unittests to the Xcode gtest target. A handful of test files had been added to lldb, but not to the appropriate target in the Xcode project. So they weren't b

[Lldb-commits] [lldb] r352122 - Add UUID::SetFromOptionalStringRef, use it in DynamicLoaderDarwin

Author: jingham Date: Thu Jan 24 14:43:44 2019 New Revision: 352122 URL: http://llvm.org/viewvc/llvm-project?rev=352122&view=rev Log: Add UUID::SetFromOptionalStringRef, use it in DynamicLoaderDarwin We use UUID::fromOptionalData to read UUID's from the Mach-O files, so UUID's of all 0's are inva

[Lldb-commits] [lldb] r352894 - Fix the xcode build for r352845.

Author: jingham Date: Fri Feb 1 10:26:08 2019 New Revision: 352894 URL: http://llvm.org/viewvc/llvm-project?rev=352894&view=rev Log: Fix the xcode build for r352845. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj ___ lldb-commits mailing list

[Lldb-commits] [lldb] r353243 - Fix PathMappingList::FindFile to handle relative incoming FileSpecs.

Author: jingham Date: Tue Feb 5 15:48:10 2019 New Revision: 353243 URL: http://llvm.org/viewvc/llvm-project?rev=353243&view=rev Log: Fix PathMappingList::FindFile to handle relative incoming FileSpecs. An equivalent change was made to RemapPaths, but it needed to be made here as well. Also add

Re: [Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

I don't have the ability to debug this and the test output isn't very helpful. There's very little chance what this is testing was working on Windows before this patch, as the relative case was unhandled... So I don't think this patch makes things worse. If somebody who has a windows machine

[Lldb-commits] [lldb] r353251 - Add the source directory for https://reviews.llvm.org/D57552.

Author: jingham Date: Tue Feb 5 16:52:04 2019 New Revision: 353251 URL: http://llvm.org/viewvc/llvm-project?rev=353251&view=rev Log: Add the source directory for https://reviews.llvm.org/D57552. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/source-map/Trivial/ lldb/t

Re: [Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

Oh, wait. I forgot to svn add the directory in which I was hiding the source file. I did that in r353251. Let's see if that works any better! Jim > On Feb 5, 2019, at 4:42 PM, Jim Ingham wrote: > > I don't have the ability to debug this and the test output isn't very > helpful. There's

[Lldb-commits] [lldb] r353257 - Little more cleanup on https://reviews.llvm.org/D57552

Author: jingham Date: Tue Feb 5 17:27:45 2019 New Revision: 353257 URL: http://llvm.org/viewvc/llvm-project?rev=353257&view=rev Log: Little more cleanup on https://reviews.llvm.org/D57552 Thanks Jonas... One more early continue and using a range where we had an iterator. NFC Modified: lldb

[Lldb-commits] [lldb] r353487 - Removing some unimplemented methods from the SB headers

Author: jingham Date: Thu Feb 7 16:34:04 2019 New Revision: 353487 URL: http://llvm.org/viewvc/llvm-project?rev=353487&view=rev Log: Removing some unimplemented methods from the SB headers NFC Modified: lldb/trunk/include/lldb/API/SBCommandInterpreter.h lldb/trunk/include/lldb/API/SBExec

[Lldb-commits] [lldb] r354702 - When deserializing breakpoints some options may not be present.

Author: jingham Date: Fri Feb 22 15:54:11 2019 New Revision: 354702 URL: http://llvm.org/viewvc/llvm-project?rev=354702&view=rev Log: When deserializing breakpoints some options may not be present. The deserializer was not handling this case. For now we just accept the absent option, and set it t

[Lldb-commits] [lldb] r354706 - Make sure that stop-hooks run asynchronously.

Author: jingham Date: Fri Feb 22 16:13:25 2019 New Revision: 354706 URL: http://llvm.org/viewvc/llvm-project?rev=354706&view=rev Log: Make sure that stop-hooks run asynchronously. They aren't designed to nest recursively, so this will prevent that. Also add a --auto-continue flag, putting "contin

[Lldb-commits] [lldb] r354711 - Revert r354706 - lit touched my thigh

Author: jingham Date: Fri Feb 22 17:08:17 2019 New Revision: 354711 URL: http://llvm.org/viewvc/llvm-project?rev=354711&view=rev Log: Revert r354706 - lit touched my thigh Modified: lldb/trunk/include/lldb/Target/Process.h lldb/trunk/include/lldb/Target/Target.h lldb/trunk/lit/ExecCon

Re: [Lldb-commits] [lldb] r354711 - Revert r354706 - lit touched my thigh

i, Feb 22, 2019 at 5:07 PM Jim Ingham via lldb-commits > wrote: > Author: jingham > Date: Fri Feb 22 17:08:17 2019 > New Revision: 354711 > > URL: http://llvm.org/viewvc/llvm-project?rev=354711&view=rev > Log: > Revert r354706 - lit touched my thigh > > Modifie

[Lldb-commits] [lldb] r354914 - Mention predicting exception catch at throw site

Author: jingham Date: Tue Feb 26 11:18:09 2019 New Revision: 354914 URL: http://llvm.org/viewvc/llvm-project?rev=354914&view=rev Log: Mention predicting exception catch at throw site Modified: lldb/trunk/docs/status/projects.rst lldb/trunk/www/projects.html Modified: lldb/trunk/docs/stat

[Lldb-commits] [lldb] r355026 - Pass arguments correctly to the objc object checker on arm64

Author: jingham Date: Wed Feb 27 12:27:25 2019 New Revision: 355026 URL: http://llvm.org/viewvc/llvm-project?rev=355026&view=rev Log: Pass arguments correctly to the objc object checker on arm64 Traditionally objc had two entry points, objc_msgSend for scalar return methods, and objc_msgSend_stre

[Lldb-commits] [lldb] r355213 - Resubmit r354706 with a fix for process launch.

Author: jingham Date: Fri Mar 1 10:13:38 2019 New Revision: 355213 URL: http://llvm.org/viewvc/llvm-project?rev=355213&view=rev Log: Resubmit r354706 with a fix for process launch. When the debugger is run in sync mode, you need to be able to tell whether a hijacked resume is for some special pu

[Lldb-commits] [lldb] r355358 - Fix the Xcode project for UserIDResolver.

Author: jingham Date: Mon Mar 4 16:52:12 2019 New Revision: 355358 URL: http://llvm.org/viewvc/llvm-project?rev=355358&view=rev Log: Fix the Xcode project for UserIDResolver. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http:/

<    1   2   3   4   5   6   7   8   9   10   >