Yes, though the original code handled the unsuccessful completion cases slightly differently. I'm not sure how significant that is without pondering it further and I'm in the middle of something else right now.
Jim > On May 17, 2017, at 1:31 PM, Pavel Labath via Phabricator > <revi...@reviews.llvm.org> wrote: > > labath added a comment. > > I'm not sure I understand what you're saying. Did you mean to say that I > should add the "thread plan didn't successfully complete." (line 5281) block > to the "Halt" branch as well ? (possibly by including it into the factored > out function) > > > https://reviews.llvm.org/D33283 > > > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
