[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

jasonmolenda requested changes to this revision. jasonmolenda added a comment. This revision now requires changes to proceed. Looks good, a few small suggestions from reading the code afresh. I'm not sure how many open source contributors we may have running macOS 10.6 or earlier (or macOS 10.7

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

jasonmolenda added a comment. Hah, I misread what the 'buffer[first_letter] & 0x40' line was doing still. Maybe use isupper() here instead of the bitmask? https://reviews.llvm.org/D30918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. looks good to me. Comment at: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp:66 + int error = ::sysctlbyname(feature, &answer, &answer_size, NULL,

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jasonmolenda updated this revision to Diff 537942. jasonmolenda added a comment. Herald added a subscriber: wangpc. After reverting to avoid CI bot failures on macos intel, this is an updated patch that (1) corrects the binary image count size, (2) allows for a fallback if it can't find the noti

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jasonmolenda updated this revision to Diff 538253. jasonmolenda added a comment. Update the patch to address the failures we were hitting on the Intel macOS 10.15 CI bot. In addition to lldb_notifier_function, look for "gdb_notifier_function" which is what it was called back in macOS 10.15. Re

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I'm fine with this. It does increase the size of the UnwindPlan object, and there are a couple of them for every function that we see on a stack during a program execution, but I

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

jasonmolenda added a comment. (to say it more clearly: I'm fine if you'd like to reduce the places where ConstStrings are being used, but I don't think there's any good reason to remove this use of them. It will increase our memory footprint a bit.) Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

jasonmolenda added a comment. probably the real correct change is to have constant c-strings in as globals and have pointers to those. Then you're using the same space as a ConstString in each UnwindPlan (a pointer) but creation is cheaper. There's no dynamic aspect to the names when the Unwi

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

jasonmolenda added a comment. I guess simplest is we can have all the UnwindPlan creators have a `static g_unwindplan_name` and save a pointer to that. Each one is unique, don't need anything fancier than that. There's the risk that someone will create a new UnwindPlan and forget to make it a

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

jasonmolenda added a comment. Herald added subscribers: Michael137, JDevlieghere. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154907/new/ https://reviews.llvm.org/D154907 ___ lldb-commits maili

[Lldb-commits] [PATCH] D154992: Add a generic Process method to dump plugin history

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah excellent, thanks for adding this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154992/new/ https://reviews.llvm.org/D154992 __

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

jasonmolenda added a comment. I have no experience with the linux support so I'm not an ideal person to review, but when I was reading about watchpoints I saw the caveats about SSVE mode and false watchpoint hits so I read through the patch out of curiosity about SME/SSVE. You mention a couple

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. On Darwin, we first get a p

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

jasonmolenda added a comment. Ah, I understand, thanks for the explanation. What an unusual feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154926/new/ https://reviews.llvm.org/D154926 ___ lldb-c

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

jasonmolenda updated this revision to Diff 539719. jasonmolenda added a comment. Update to incorporate Jonas' suggestion - adding MachProcess::GetParentProcessID and MachProcess::ProcessIsBeingDebugged, as well as the DNB passthrough functions. I didn't pass back optionals for the cases were w

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

jasonmolenda updated this revision to Diff 539721. jasonmolenda added a comment. Update the patch; that last one included a separate set of changes I was working on with Alex yesterday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155037/new/ htt

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

jasonmolenda added a comment. LGTM. Good description of the problem being addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155100/new/ https://reviews.llvm.org/D155100 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb136f5b393c: Improve error messaging when debugserver fails to complete attaching (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

jasonmolenda added a comment. @splhack the shell tests are all asserting on Darwin systems (on my desktop and on the bots https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/ ): [ RUN ] LocateModuleCallbackTest.GetOrCre

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

jasonmolenda added a comment. Hm, let me try a clean build. `ninja check-lldb-unit` repo'ed the issue on my desktop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 _

[Lldb-commits] [PATCH] D155135: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. unit tests pass clean with this patch, thanks! Maybe your mac build wasn't cmake'd with `-DLLVM_ENABLE_ASSERTIONS=1` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D155221: [lldb] Support compressed CTF

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:151 + sizeof(ctf_header_t)); +zstr.ava

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

jasonmolenda added a comment. Just curious -- would it be better to have a single `vg` register shown to the user which is the vector length in non-streaming mode when the processor is in non-streaming mode, and the vector length in streaming mode when the processor is in streaming mode? I have

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

jasonmolenda added a comment. I ran the TargetTests under lldb to see (this test doesn't fail on my arm64 mac desktop ftr). ASSERT_EQ calls `template AssertionResult CmpHelperEQ()` and that calls `FileSpec::operator==` on my desktop. Jonas suggested that we get the binary data dump of the F

[Lldb-commits] [PATCH] D155332: [lldb][NFC] Factor out CommandObject code filtering results based on scope

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155332/new/ https://reviews.llvm.org/D155332 __

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

jasonmolenda added a comment. My first thought was, but what about all the other unit tests doing this, and git grepping around, I think there's one in Interpreter/TestOptionValue.cpp and one in Interpreter/TestOptionValueFileColonLine.cpp. I'd like to see what @JDevlieghere thinks, this patc

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

jasonmolenda added a comment. Like reading third-party/unittest/googletest/include/gtest/gtest-printers.h, I thought I could add a static PrintTo method? but index 6eb5b805d9d..93d98baa5be 100644 --- a/lldb/include/lldb/Utility/FileSpec.h +++ b/lldb/include/lldb/Utility/FileSpec.h @@ -1

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

jasonmolenda added a comment. FWIW when I was testing this locally, I was seeing paths like (lldb) p uuid_view (lldb_private::FileSpec) $0 = file: "AndroidModule.so" dir: "/var/folders/1b/976z5_5513l64wvrj15vkt80gn/T/lldb/49966/LocateModuleCallbackTest-GetOrCreateModuleWithCachedModuleAn

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

jasonmolenda accepted this revision. jasonmolenda added a comment. Great catch, thanks for digging in on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155333/new/ https://reviews.llvm.org/D155333 _

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

jasonmolenda added a comment. Isn't it better to print branches within a function as an offset, given that our disassembly format by default lists the offset of each instruction. So instead of looking for a 6-digit long hex address, you're looking for a decimal offset in the output? I'm not s

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

jasonmolenda added a comment. In D155269#4505021 , @DavidSpickett wrote: >> As you say above, we can show svg when in non-streaming mode but we can't >> show vg when in streaming mode. Should we only show a single vg for the >> currently-available regi

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

jasonmolenda added a comment. In D155269#4509130 , @DavidSpickett wrote: > > Ideally we would have as few routes to mode switch via the debugger as > possible. Writing to the streaming vector control register is the single > route I'd support given

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

jasonmolenda added a comment. In D155269#4509364 , @DavidSpickett wrote: > I think in https://reviews.llvm.org/D154926, > `lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_static_config/TestSVERegisters.py` > addresses this. If

[Lldb-commits] [PATCH] D155768: [lldb] [NFC] Remove some dead code from Watchpoint class, and a method that makes no sense

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Johnny Chen added t

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

jasonmolenda added a comment. PrintBranchImmAsAddress is used in the RISCV, aarch64, PPC, Mips, and X86 instruction printers - most of them in one or two spots. I tried a quick attempt at writing a program that would change output with the aarch64 instruction printer but didn't succeed at firs

[Lldb-commits] [PATCH] D155768: [lldb] [NFC] Remove some dead code from Watchpoint class, and a method that makes no sense

jasonmolenda added a comment. Thanks David, yeah I came to the same conclusion about that method. I made hacked up lldb that behaved like the MIPS case to confirm that the hit count is incremented before we decide it's a fake stop & decrement it again. Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D155768: [lldb] [NFC] Remove some dead code from Watchpoint class, and a method that makes no sense

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG259e3f2a4fef: Remove IncrementFalseAlarmsAndReviseHitCount, unused ivars (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda created this revision. jasonmolenda added reviewers: DavidSpickett, jingham, clayborg. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. Thanks for the feedback David. > You are missing a way to fix a high mem address, is that intentional? Or > would you get the high mem mask, change the setting, fix the address, as > needed by context. The FixAddress method will choose whether to use the high mem

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

jasonmolenda added a comment. I'm not super familiar with the MCInst class from llvm, and hadn't heard of MCInstrAnalysis. I was looking through the llvm targets - are these MCInstrAnalysis primitives going to be implemented for all targets we support today? I see them defined for e.g. MIPS a

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added inline comments. Comment at: lldb/include/lldb/API/SBProcess.h:415-416 + /// (unsigned long long) 0xfc00 + lldb::addr_t GetCodeAddressMask(); + lldb::addr_t GetDataAddressMask(); + clayborg wrote: > Will there only ever be two va

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. Also interesting to consider if there should be an "Any" define. e.g. enum AddressMaskType { eTypeCode = 0, eTypeData, eTypeHighmemCode, eTypeHighmemData, eTypeAny }; lldb::addr_t GetAddressMask(AddressMaskType mask_type); void SetAddress

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

jasonmolenda added a comment. In D156086#4530507 , @RamNalamothu wrote: > In D156086#4529791 , @jasonmolenda > wrote: > >> >> Does `isBranch` include other variants like `isUnconditionalBranch`? > > No. They

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looking at Ted's earlier riscv disassembly with this enabled, it is more readable, I'm surprised these instructions don't print this way by default like they are for other targets.

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. In D155905#4537036 , @clayborg wrote: > > I like it the above approach with more enums for the high and low code/data. > Not sure if eTypeAny makes sense in the GetAddressMask(eTypeAny) scenario, > but I can see the use

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. In D155905#4537892 , @DavidSpickett wrote: >> but I could imagine some harvard architecture target that behaved >> differently (surely this is why Linux has two address masks) > > I'm not privy to the exact reasoning, but a

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda updated this revision to Diff 544936. jasonmolenda added a comment. Update the patch to express the mask getter/setters in terms of a type enum, after discussions with Greg and David. I still need to write a test for this API but I'm liking where this is now. Repository: rG LLV

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added inline comments. Comment at: lldb/include/lldb/API/SBProcess.h:445 + lldb::addr_t FixDataAddress(lldb::addr_t addr); + lldb::addr_t FixAnyAddress(lldb::addr_t addr); + clayborg wrote: > What does this function do? Does it try to auto detect c

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added inline comments. Comment at: lldb/source/API/SBProcess.cpp:1260-1261 + return process_sp->GetHighmemDataAddressMask(); +case eMaskTypeAny: + return process_sp->GetDataAddressMask(); +} jasonmolenda wrote: > clayborg wrote: > >

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. Given the AddressMaskType enum, I wonder if instead of `FixCodeAddress`, `FixDataAddress`, and `FixAddress`, there should be one `SBProcess::FixAddress(lldb::AddressMaskType type, lldb::addr_t address)` and it would be used with `eMaskTypeCode`, `eMaskTypeData`, or

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

jasonmolenda added a comment. This is fine to me but maybe instead of `ifndef apple` we could do a `if __has_include()` and include the system header if it's avail. I must be misreading the patch but it seems like you're changing the filename to AppleUuidCompatbility.h but the two places it's

[Lldb-commits] [PATCH] D156817: _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156817/new/ https://reviews.llvm.org/D156817 __

[Lldb-commits] [PATCH] D156838: [lldb] Re-add compile-time checks for SPI in HosInfoMacOSX

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, I missed that I removed the check when we were trying to clean up old pre-macOS 10.12 ifdef's. LGTM thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. On Darwin systems, lldb w

[Lldb-commits] [PATCH] D157165: [lldb] [darwin kernel debug] When looking for a Darwin kernel symbol file, call GetSharedModules before DownloadObjectAndSymbolFile

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. ModuleList::GetSharedModule will call in to the DebugSymbols framew

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda created this revision. jasonmolenda added reviewers: bulbazord, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added subscribers: lldb-commits, wangpc. DynamicLoader::LoadBinaryWithUUIDAndAddress()

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

jasonmolenda created this revision. jasonmolenda added reviewers: bulbazord, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. We have some corefiles which are intended to debug a

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda added inline comments. Comment at: lldb/include/lldb/Target/DynamicLoader.h:267 /// + /// \param[in] allow_use_memory_image_last_resort + /// If no better binary image can be found, allow reading the binary JDevlieghere wrote: > Nit: seems l

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda updated this revision to Diff 547864. jasonmolenda added a comment. Incorporate Jonas' feedback about the naming of the new DynamicLoader method argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157167/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda added inline comments. Comment at: lldb/test/API/macosx/lc-note/multiple-binary-corefile/TestMultipleBinaryCorefile.py:38-39 ) +if self.TraceOn(): +self.runCmd("script print('Creating corefile with command %s')" % cmd) call(cmd

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda updated this revision to Diff 547866. jasonmolenda added a comment. Fix my `script print`'s to just `print`, I can't repo a buffering problem that I thought I had seen in the past. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157167/n

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

This revision was automatically updated to reflect the committed changes. Closed by commit rG57cbd26a68ab: Flag for LoadBinaryWithUUIDAndAddress, to create memory image or not (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D157167?vs=547866&id=547978#toc Reposito

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda updated this revision to Diff 548001. jasonmolenda added a comment. Change calls to Log::Printf to use LLDB_LOGF(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157160/new/ https://reviews.llvm.org/D157160 Files: lldb/source/Core/D

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda updated this revision to Diff 548009. jasonmolenda added a comment. fix typeo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157160/new/ https://reviews.llvm.org/D157160 Files: lldb/source/Core/DynamicLoader.cpp lldb/source/Plugins

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda added inline comments. Comment at: lldb/source/Core/DynamicLoader.cpp:241-243 +Stream &s = target.GetDebugger().GetOutputStream(); +s.Printf("Tried DBGShellCommands cmd, got error: %s\n", + error.AsCString()); JDevlieg

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda updated this revision to Diff 548015. jasonmolenda added a comment. Update patch to send these error messages to the ErrorStream not OutputStream. Also change LocateSymbolFileMacOSX.cpp so the full command that was used to find the binary is included in the error message, to make i

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

jasonmolenda updated this revision to Diff 548364. jasonmolenda added a comment. Rebase on current TOT sources, and add a comment to the ProcessMachCore::LoadBinariesViaMetadata prototype in the header documenting the meaning of the return value, I agree with Alex I should make this a little cl

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5f81100e447: When ProcessMachCore has metadata for a binary, don't scan (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157168/new

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG1290869ef2f7: Show error messages from DebugSymbols DBGShellCommand agent (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D157160?vs=548015&id=548409#toc Repository: rG

[Lldb-commits] [PATCH] D157165: [lldb] [darwin kernel debug] When looking for a Darwin kernel symbol file, call GetSharedModules before DownloadObjectAndSymbolFile

jasonmolenda updated this revision to Diff 548414. jasonmolenda added a comment. Rebase patch on current top of tree sources. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157165/new/ https://reviews.llvm.org/D157165 Files: lldb/source/Plugins/D

[Lldb-commits] [PATCH] D157165: [lldb] [darwin kernel debug] When looking for a Darwin kernel symbol file, call GetSharedModules before DownloadObjectAndSymbolFile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d8d31bbf55c: When loading kernel binary, use DownloadObjectAndSymbolFile last (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

jasonmolenda added a comment. I'm fine with this but on macOS I believe it's com.apple.security.get-task-allow v. "Entitlements on macOS" https://developer.apple.com/documentation/technotes/tn3125-inside-code-signing-provisioning-profiles CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

jasonmolenda added a comment. Maybe get-task-allow is allowed (lol) on macOS too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157640/new/ https://reviews.llvm.org/D157640 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

jasonmolenda added a comment. Maybe const char *ent_name = #if TARGET_OS_OSX "com.apple.security.get-task-allow"; #else "get-task-allow"; #endif debugserver is running on the target device so compile time checks are fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15764

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, bulbazord. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. This patch addresses two issues I found while looking

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

jasonmolenda added a comment. One more bit of explanation about the changes: There is an SBTarget::AddModule which takes individual parts of a module spec, and an SBTarget::AddModule which takes an SBModuleSpec. I was going to need to duplicate my code to force the expensive search & update t

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. To recap, o

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

jasonmolenda updated this revision to Diff 549214. jasonmolenda added a comment. update comments a tiny bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157667/new/ https://reviews.llvm.org/D157667 Files: lldb/docs/lldb-gdb-remote.txt lldb/i

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. The lldb side looks good to me, and I think you've addressed the llvm parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

jasonmolenda updated this revision to Diff 549504. jasonmolenda added a comment. Fix the problems Alex found on review, thanks Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157667/new/ https://reviews.llvm.org/D157667 Files: lldb/docs/lldb

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

jasonmolenda marked 2 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/test/API/python_api/target-arch-from-module/TestTargetArchFromModule.py:39 +dwarfdump_cmd_output = subprocess.check_output( +('/usr/bin/dwarfdump --uuid "%s"'

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

jasonmolenda updated this revision to Diff 549507. jasonmolenda added a comment. Incorporate Alex's suggestions, not sure about using llvm-dwarfdump yet tho. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157659/new/ https://reviews.llvm.org/D157659

[Lldb-commits] [PATCH] D157756: Support corefiles that put the uuid of their binary in a fixed address in low memory; load that binary

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. There are some Mach-O coref

[Lldb-commits] [PATCH] D157756: Support corefiles that put the uuid of their binary in a fixed address in low memory; load that binary

jasonmolenda updated this revision to Diff 549516. jasonmolenda added a comment. Fix size check when making sure there's enough data. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157756/new/ https://reviews.llvm.org/D157756 Files: lldb/source/P

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

This revision was automatically updated to reflect the committed changes. Closed by commit rGebf249066ac5: [lldb] SBTarget::AddModule do all searches by UUID, set Target arch (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

jasonmolenda updated this revision to Diff 550148. jasonmolenda added a comment. Incorporate Jonas' suggestion of a AddressableBits class that GDBRemoteCommunicationClient and ObjectFileMachO could use to store the zero/one/two addressable bits values back to a Process, and centralizing the log

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad618f4aea1: Update qHostInfo/LC_NOTE so multiple address bits can be specified (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D157756: Support corefiles that put the uuid of their binary in a fixed address in low memory; load that binary

This revision was automatically updated to reflect the committed changes. Closed by commit rGd70d5e9f6fa2: Get binary UUID from fixed location in special Mach-O corefiles (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15775

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. A small follow on patch to https://reviews.llvm.org/D157667 to

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:58-60 +bool AddressableBits::IsValid() { + return m_low_memory_addr_bits != 0 || m_high_memory_addr_bits != 0; +} JDevlieghere wrote: > Please implement `operator bool()` ins

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:62-64 +void AddressableBits::Clear() { + m_low_memory_addr_bits = m_high_memory_addr_bits = 0; +} jasonmolenda wrote: > JDevlieghere wrote: > > Where is this called? > Hm. W

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda updated this revision to Diff 550868. jasonmolenda added a comment. Update patch to change the `AddressableBits::IsValid` to `AddressableBits::HasValue` which is a clearer description. The `IsValid` methods are used across the lldb_private classes everywhere. I tried changing thi

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:62-64 +void AddressableBits::Clear() { + m_low_memory_addr_bits = m_high_memory_addr_bits = 0; +} JDevlieghere wrote: > jasonmolenda wrote: > > jasonmolenda wrote: > > > JDev

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda updated this revision to Diff 550917. jasonmolenda added a comment. Update patch to remove the HasValue/IsValue and Clear methods from AddressableBits. Change methods that may fill in an AddressableBits object with values to return an AddressableBits object unconditionally. Change

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. ah dangit, I meant to update the patch in https://reviews.llvm.org/D158041 and accidentally blew away the last patch I had for this one. let's see if I can extract it from here somehow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda updated this revision to Diff 550919. jasonmolenda added a comment. Update patch to remove the HasValue/IsValue and Clear methods from AddressableBits. Change methods that may fill in an AddressableBits object with values to return an AddressableBits object unconditionally. Change

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda updated this revision to Diff 550924. jasonmolenda added a comment. Updated back to my most recent version of this patch, thanks for the help all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155905/new/ https://reviews.llvm.org/D1559

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f4a0c762fe2: hi/low addr space bits can be sent in stop-rely packet (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158041/new/ h

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158205/new/ https://reviews.llvm.org/D158205

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:49 + if (TT.isOSBinFormatELF()) +return filename.starts_with("libobjc.so"); + if (TT.isOSWindows()) theraven wrote: > This is

<    1   2   3   4   5   6   7   8   9   10   >