jasonmolenda added inline comments.
================
Comment at: lldb/source/Utility/AddressableBits.cpp:58-60
+bool AddressableBits::IsValid() {
+ return m_low_memory_addr_bits != 0 || m_high_memory_addr_bits != 0;
+}
----------------
JDevlieghere wrote:
> Please implement `operator bool()` instead.
ok.
================
Comment at: lldb/source/Utility/AddressableBits.cpp:62-64
+void AddressableBits::Clear() {
+ m_low_memory_addr_bits = m_high_memory_addr_bits = 0;
+}
----------------
JDevlieghere wrote:
> Where is this called?
Hm. When I thought of this patch last night, I was sure I needed a Clear
method for some reason, but you're right I never ended up using it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158041/new/
https://reviews.llvm.org/D158041
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
