https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/104497
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101086
>From 2860a75fdc243f55d1e675068f9d120fb43cb21d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 26 Jul 2024 14:14:42 -0700
Subject: [PATCH 1/2] Remove 64b specific method and create Cache from both
memor
@@ -553,53 +547,49 @@ static bool
CreateRegionsCacheFromMemoryList(MinidumpParser &parser,
std::vector ®ions) {
Log *log = GetLog(LLDBLog::Modules);
+ // Cache the expected memory32 into an optional
+ // because double checking the expected
@@ -457,34 +456,24 @@ MinidumpParser::FindMemoryRange(lldb::addr_t addr) {
}
}
- // Some Minidumps have a Memory64ListStream that captures all the heap memory
- // (full-memory Minidumps). We can't exactly use the same loop as above,
- // because the Minidump uses sl
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101086
>From 2860a75fdc243f55d1e675068f9d120fb43cb21d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 26 Jul 2024 14:14:42 -0700
Subject: [PATCH 1/3] Remove 64b specific method and create Cache from both
memor
Jlalond wrote:
@labath appreciate the review, I've addressed the points. CC: @clayborg
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
@@ -174,6 +176,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/102708
>From b451c1630a9799180a3a976a4ecd86c8d4ec35da Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 Aug 2024 08:58:52 -0700
Subject: [PATCH 01/14] Initial attempt at new classes Summary statistics in
Summa
@@ -175,6 +177,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
@@ -175,6 +177,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
Jlalond wrote:
Great idea
https://github.com/llvm/llvm-project/pull/102708
_
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -449,6 +449,10 @@ class RangeDataVector {
~RangeDataVector() = default;
void Append(const Entry &entry) { m_entries.emplace_back(entry); }
+
+ void Append(const B&& b, const S&& s, const T&& t) {
Jlalond wrote:
Yeah, I can drop const but these are r
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -7,6 +7,9 @@
//===--===//
#include "lldb/API/SBSaveCoreOptions.h"
+#include "lldb/API/SBError.h"
+#include "lldb/API/SBFileSpec.h"
Jlalond wrote:
Good call, I'll try to trim all the unnee
@@ -6544,7 +6545,8 @@ static void AddRegion(const MemoryRegionInfo ®ion,
bool try_dirty_pages,
return;
if (try_dirty_pages && AddDirtyPages(region, ranges))
return;
- ranges.push_back(CreateCoreFileMemoryRange(region));
+
+ ranges.Append(region.GetRange().GetRangeB
@@ -101,6 +103,18 @@ bool SaveCoreOptions::ShouldThreadBeSaved(lldb::tid_t tid)
const {
return m_threads_to_save.count(tid) > 0;
}
+bool SaveCoreOptions::HasSpecifiedThreads() const {
+ return !m_threads_to_save.empty();
+}
+
+void SaveCoreOptions::AddMemoryRegionToSave(co
@@ -1222,6 +1222,7 @@ enum SaveCoreStyle {
eSaveCoreFull = 1,
eSaveCoreDirtyOnly = 2,
eSaveCoreStackOnly = 3,
+ eSaveCoreCustom = 4,
Jlalond wrote:
I think `CustomOnly` sounds a bit clunky, but it does convey only custom fields
will be saved and fits w
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/102708
>From b451c1630a9799180a3a976a4ecd86c8d4ec35da Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 Aug 2024 08:58:52 -0700
Subject: [PATCH 01/16] Initial attempt at new classes Summary statistics in
Summa
Jlalond wrote:
@Michael137 implemented your feedback, and I got gcf to work. I'm going to let
CI run and then merge. Thanks for your patience!
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/105442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@medismailben Ack
https://github.com/llvm/llvm-project/pull/105442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/106293
Reverts #105442. Due to `TestSkinnyCoreFailing` and root causing of the failure
will likely take longer than EOD.
>From b0caffa2d427ea94e90186e32125452ab4e1dd1e Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Dat
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/106293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/106473
This patch addresses a bug where `cs`/`gs` and other segmentation flags were
being identified as having a type of `32b` and `64b` for `rflags`. In that case
the register value was returning the fail value `0xF.
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/106473
>From 88a1a5d2b8698a5474bff0756012369401f7f433 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 28 Aug 2024 16:50:57 -0700
Subject: [PATCH 1/2] Have minidump read all registers as 64 and handle
truncatio
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/106473
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -62,6 +63,17 @@ def verify_core_file(
# Try to read just past the red zone and fail
process.ReadMemory(sp - red_zone - 1, 1, error)
self.assertTrue(error.Fail(), "No failure when reading past the
red zone")
+# Verify the regis
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/106473
>From 88a1a5d2b8698a5474bff0756012369401f7f433 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 28 Aug 2024 16:50:57 -0700
Subject: [PATCH 1/3] Have minidump read all registers as 64 and handle
truncatio
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/106473
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/106767
A follow up to #106473 Minidump wasn't collecting fs or gs_base. This patch
extends the x86_64 register context and gated reading it behind an lldb
specific flag. Additionally these registers are explicitly che
@@ -473,7 +473,8 @@ GetThreadContext_x86_64(RegisterContext *reg_ctx) {
lldb_private::minidump::MinidumpContext_x86_64_Flags::x86_64_Flag |
lldb_private::minidump::MinidumpContext_x86_64_Flags::Control |
lldb_private::minidump::MinidumpContext_x86_64_Flags::Se
@@ -67,6 +67,18 @@ def verify_core_file(
self.assertIn(thread_id, stacks_to_registers_map)
register_val_list = stacks_to_registers_map[thread_id]
frame_register_list = frame.GetRegisters()
+# explicitly verify we collected fs and
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/107159
Reapplies #106293, testing identified issue in the merging code. I used this
opportunity to strip CoreFileMemoryRanges to it's own file and then add unit
tests on it's behavior.
>From 63a343d2613d09a866180c8be
Jlalond wrote:
Need to verify this passes `SaveSkinnyCore`.
https://github.com/llvm/llvm-project/pull/107159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/107159
>From 63a343d2613d09a866180c8bebdf4568e20fd3b7 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 29 Aug 2024 10:09:19 -0700
Subject: [PATCH 1/3] =?UTF-8?q?Reapply=20"[LLDB][SBSaveCore]=20Add=20selec?=
=?U
Jlalond wrote:
Hey @bulbazord, this was reverted because it failed `TestSkinnyCorefile.py`
[Link](https://github.com/llvm/llvm-project/blob/main/lldb/test/API/macosx/skinny-corefile/TestSkinnyCorefile.py#L15),
I'm running into issues where it keeps coming up as unsupported. Is there a
way to t
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/106767
>From ceb20d62d9cef3090e34e8b9fc0bc620a7d9da3d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 30 Aug 2024 10:33:08 -0700
Subject: [PATCH 1/3] Extend the minidump x86_64 registers to include fs_base
and
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/106767
>From ceb20d62d9cef3090e34e8b9fc0bc620a7d9da3d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 30 Aug 2024 10:33:08 -0700
Subject: [PATCH 1/4] Extend the minidump x86_64 registers to include fs_base
and
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/106767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/107319
>From 70f94e152ba2a6826a3c4f8071b5e0ee2bb81d2d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 4 Sep 2024 14:06:04 -0700
Subject: [PATCH 1/7] Cherry-pick llvm only changes from minidump multiple
excepti
@@ -258,6 +258,14 @@ class TypeSummaryImpl {
virtual std::string GetDescription() = 0;
+ /// Get the name of the Type Summary Provider, either a C++ class, a summary
+ /// string, or a script function name.
+ virtual std::string GetName() = 0;
+
+ /// Get the name of th
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/107159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 5d7f2a6fb8dc06b838bf072aca1d8829eb61b316 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Sep 2024 13:09:27 -0700
Subject: [PATCH 1/3] MSquash merge lldb changes and drop llvm changes
---
.../Pro
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 5d7f2a6fb8dc06b838bf072aca1d8829eb61b316 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Sep 2024 13:09:27 -0700
Subject: [PATCH 1/4] MSquash merge lldb changes and drop llvm changes
---
.../Pro
Jlalond wrote:
> I'll look more closely later when I have time, but ObjectFileMachO::SaveCore
> called `Process::CalculateCoreFileSaveRanges` with an `options` of
> `eSaveCoreDirtyOnly` (so, `GetCoreFileSaveRangesDirtyOnly()`), it's returning
> gigantic memory regions to be saved to the corefi
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 5d7f2a6fb8dc06b838bf072aca1d8829eb61b316 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Sep 2024 13:09:27 -0700
Subject: [PATCH 1/5] MSquash merge lldb changes and drop llvm changes
---
.../Pro
@@ -387,10 +399,8 @@ bool ProcessMinidump::DoUpdateThreadList(ThreadList
&old_thread_list,
LocationDescriptor context_location = thread.Context;
// If the minidump contains an exception context, use it
-if (m_active_exception != nullptr &&
-m_active_except
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 5d7f2a6fb8dc06b838bf072aca1d8829eb61b316 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Sep 2024 13:09:27 -0700
Subject: [PATCH 1/5] MSquash merge lldb changes and drop llvm changes
---
.../Pro
Jlalond wrote:
@jasonmolenda I was just about to respond. In `AddDirtyPages` [I am in fact
passing End() as Size()]
(https://github.com/llvm/llvm-project/commit/bb343468ffa8c2190fcdd0f704d370c75d3b5edd#diff-96c5fb7a96b37c4401faaef482eaf8d4e1ecd38d49a1ff8eb96d361b0dfa24b9L6497).
I'm using this
@@ -0,0 +1,99 @@
+//===-- CoreFileMemoryRanges.cpp *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/107937
Recently in #107731 this change was revereted due to excess memory size in
`TestSkinnyCore`. This was due to a bug where a range's end was being passed as
size. Creating massive memory ranges.
Additionally, an
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/97470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/107937
>From 2bdc8c0bd8b92989420b798d90e47f27d8a06e66 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 9 Sep 2024 13:54:37 -0700
Subject: [PATCH 1/4] Reapply "[LLDB] Reappply SBSaveCore AddMemoryList"
(#107731)
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -450,6 +450,8 @@ class RangeDataVector {
void Append(const Entry &entry) { m_entries.emplace_back(entry); }
+ void Append(B &&b, S &&s, T &&t) { m_entries.emplace_back(Entry(b, s, t)); }
Jlalond wrote:
Nit to self, add code comments about Base Size And
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/107937
>From 2bdc8c0bd8b92989420b798d90e47f27d8a06e66 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 9 Sep 2024 13:54:37 -0700
Subject: [PATCH 1/5] Reapply "[LLDB] Reappply SBSaveCore AddMemoryList"
(#107731)
Jlalond wrote:
Investigating the windows issue
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108079
Follow up to #102708, the tests are failing for windows. There is a large
variance in these tests between summary strings and built in types. I'm
disabling these test for windows, and will add windows specific
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/108079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@Michael137 / @JDevlieghere are we okay disabling these tests for windows? Even
on Linux we encountered significant variance between built in types and summary
strings. We can either land this or I can make the tests Linux specific and add
mac and windows specific tests as a fol
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/108079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108248
@adrian-prantl from your recent changes I keep encountering issues iwth this
file in my build chain. Does this API usage look correct for your new redesign?
>From 0b449cc60c33ee8231c7a108511207298fab0403 Mon Se
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/108248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/108248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108248
>From c13cca79b5b90a858fe32b4ee490189c10fcd7c9 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 09:46:02 -0700
Subject: [PATCH] Remove CommandObjectTraceStartIntelPT.cpp call to Status()
cons
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/3] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108309
Added a progress tracker to Minidump file builders memory saving
>From 043d25d320b71ed0049387a89d46ed18145e5c55 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/4] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH] Add Progress bar to minidump memory emission
---
.../Minidump/
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH 1/2] Add Progress bar to minidump memory emission
---
.../Minid
Jlalond wrote:
> The variable name should be `progress_tracker` but really we should just call
> it `progress` for consistency with the rest of lldb.
Good to know, I know this class has a lot of pascal casing from before and I'm
always unsure to break the existing pattern and use snake or not
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH 1/3] Add Progress bar to minidump memory emission
---
.../Minid
@@ -645,6 +645,33 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
@@ -146,6 +146,8 @@ class LLDB_API SBValue {
lldb::SBValue CreateValueFromData(const char *name, lldb::SBData data,
lldb::SBType type);
+ lldb::SBValue CreateBoolValue(const char *name, bool value);
Jlalond wrote:
I woul
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH 1/3] Add Progress bar to minidump memory emission
---
.../Minid
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/4] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/5] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
return 0;
}
+struct SaveCoreRequest {
+ SaveCoreRequest(MinidumpFileBuilder &builder) : m_builder(builder) {}
+
+ ~SaveCoreRequest() {
+if (!m_success)
+ m_builder.DeleteFile();
---
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108448
Recently my coworker @jeffreytan81 pointed out that Minidumps don't show
breakpoints when collected. This was prior blocked because Minidumps could only
contain 1 exception, now that we support N signals/sectio
@@ -54,6 +54,13 @@ using namespace lldb;
using namespace lldb_private;
using namespace llvm::minidump;
+// Set of all the stop reasons minidumps will collect.
Jlalond wrote:
@labath Hey Pavel, is there a more elegant way to define a constant set? I want
to d
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/108248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108448
>From adcc5e8065d2a1b7edf877bd74de9cebd2f84cc9 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 12 Sep 2024 13:10:58 -0700
Subject: [PATCH 1/3] Create set for the stop reasons we collect, and add
breakpo
Jlalond wrote:
@jeffreytan81 I'll add a test to ensure we get an error message
https://github.com/llvm/llvm-project/pull/108259
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/6] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH 1/4] Add Progress bar to minidump memory emission
---
.../Minid
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/7] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/108259
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108602
Adds a test that ensures two minidumps produced from the same target are the
same bytes. Covers the three primary core flavors.
>From 60b48f98ffa70dbf633f1b9bf935479dbfce59d4 Mon Sep 17 00:00:00 2001
From: Jaco
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108602
>From 41bb7f8a13483e55f677d51e049e3d79d763088b Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 13 Sep 2024 09:29:46 -0700
Subject: [PATCH 1/2] Add multiplatform minidump determinism test
---
.../TestPr
Jlalond wrote:
Hey @kusmour. I actually looked into this on Thursday, see #108248. If we are
going to merge this I think we should just call `std::move` and not
`Status::FromError(std::move(err))` as the API takes an err r-value.
https://github.com/llvm/llvm-project/pull/108719
___
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/108719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/108309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/89110
std::string children are normally formatted as their summary [my_string_prop] =
"hello world". Sbvalues/ValueObjects created from data do not follow the same
summary formatter path and instead hit the value obje
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/89110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/89110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/89110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -254,13 +254,13 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
addr_of_string =
valobj.GetAddressOf(scalar_is_load_addr, &addr_type);
- if (addr_of_string != LLDB_INVALID_ADDRESS) {
+ if (addr_of_string != LLDB_INVALID_ADDRESS ||
+
Jlalond wrote:
@jimingham
What should we do if the child address type is File? I don't know how that
could ever happen, and should we support it? Because currently we didn't
support summarizing host or file.
https://github.com/llvm/llvm-project/pull/89110
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/89110
>From e0316188d22605c670079e37855d3d8b5c944cee Mon Sep 17 00:00:00 2001
From: Jacob John Lalonde
Date: Wed, 10 Apr 2024 14:33:40 -0700
Subject: [PATCH 1/2] Fix bug where an sbvalue containing a std::string create
201 - 300 of 642 matches
Mail list logo
