[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. The path defined in CMakeLists.txt doesn't match the path generated in our python script. This change fixes that. LLVM_LIBRARY_OUTPUT_INTDIR is defined as: ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INT

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220207. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt ==

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220206. hhb added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt ==

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220392. hhb added a comment. Use CMAKE_HOST_SYSTEM_NAME instead. Since the python script is run on host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scrip

[Lldb-commits] [PATCH] D67583: Fix swig python package path

This revision was automatically updated to reflect the committed changes. Closed by commit rL372047: Fix swig python package path (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67583?vs=

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb added a reviewer: JDevlieghere. This way it can be overwritten when cross compiling. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LL

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb added a comment. In D67641#1671881 , @JDevlieghere wrote: > Can we match what `FindPythonInterp ` and `FindPythonLibs` does? > > mark_as_advanced( > PYTHON_EXECUTABLE > PYTHON_DEBUG_LIBRARY > PYTHON_LIBRARY > PYTHON_INCLUDE_DIR > )

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220410. hhb added a comment. Add mark_as_advanced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220424. hhb added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220584. hhb added a comment. Turns out I still need to change previous lines to remove PARENT_SCOPE. Otherwise local value will still be used even if a different value is set in the cache. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220589. hhb added a comment. Add CACHE PATH again. I think this is the only way to go. With PARENT_SCOPE: Tthe local detected value is always used, even if a different value is set in cache. With no parameter: Always the value in cache is used. If a value is not

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220594. hhb added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfig

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL372194: Cache PYTHON_EXECUTABLE for windows (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1673356 , @ZeGentzy wrote: > Hello folks, > > These changes break running `ninja install` when building with `-D > LLVM_LIBDIR_SUFFIX=32`. > > [...] > -- Up-to-date: > /build/llvm-git-gentz/pkg/lib32-llvm-git-gentz/opt/

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1674430 , @hhb wrote: > In D67583#1673356 , @ZeGentzy wrote: > > > Hello folks, > > > > These changes break running `ninja install` when building with `-D > > LLVM_LIBDIR_SUFFIX=32`.

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. I don't have the right environment to try your command. But I didn't see anything obviously problematic. Can you try the following: cd /src/llvm-project/lldb/scripts/Python Then run the following python program: import sys sys.path.append('/src/llvm-project/lldb/scr

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. +deepak2427 since this behavior is introduced in https://github.com/llvm/llvm-project/commit/9b35cf52d2a88cda5167c9638696adce5b152720 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. Oh sorry my mistake. The current directory should be llvm-project/lldb/scripts. I.e. cd /src/llvm-project/lldb/scripts Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. I'm making a change in finishSwigPythonLLDB.py to write directly to targetDir. This way we don't have the problem to guess where the files are written. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1675697 , @ZeGentzy wrote: > In D67583#1675415 , @hhb wrote: > > > Oh sorry my mistake. The current directory should be > > llvm-project/lldb/scripts. I.e. > > > > cd /src/llvm-proj

[Lldb-commits] [PATCH] D67781: Revert "Fix swig python package path"

hhb created this revision. hhb added reviewers: JDevlieghere, ZeGentzy. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This reverts commit 5a115e81cdd40c758b10c382aeffc0c8de6930e2 . Repository:

[Lldb-commits] [PATCH] D67781: Revert "Fix swig python package path"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372364: Revert "Fix swig python package path" (authored by hhb, committed by ). Herald added a project: LLVM. Herald added

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1675889 , @ZeGentzy wrote: > In D67583#1675714 , @hhb wrote: > > > My theory now is that your python has a different implementation of > > get_python_lib(). After all we should not gu

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1676531 , @labath wrote: > I could be off mark here, but I do recall some people trying to get this code > to work in environments where python and lldb(llvm) are configured with > different libdirs (so LLVM_LIBDIR_SUFFIX i

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Before this change, the procedure of installing and loading python modules are as follow: 1. finishSwigPythonLLDB.py writes necessary files to ${CMAKE_BINARY_DIR

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb updated this revision to Diff 221123. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67866/new/ https://reviews.llvm.org/D67866 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Python/finishS

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

hhb created this revision. Herald added subscribers: lldb-commits, mstorsjo. Herald added a project: LLDB. This way it works better with MinGW. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67887 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372493: Use _WIN32 instead of _MSC_VER (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subs

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb updated this revision to Diff 221251. hhb added a comment. Fix symbol linker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67866/new/ https://reviews.llvm.org/D67866 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Pyt

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_BINARY_DIR} +OUT

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added a comment. And thanks for this and it is definitely an improvement! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67890/new/ https://reviews.llvm.org/D67890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > If we go this way, sho

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > mgorny wrote: > > > hh

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > mgorny wrote: > > > hh

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote: > mgorny wrote: > > hhb wrote: > > > mgorn

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

hhb accepted this revision. hhb added a comment. This revision is now accepted and ready to land. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67894/new/ https://reviews.llvm.org/D67894 ___ lldb-commits ma

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

hhb added inline comments. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative_path +if module_path is None: +from distutils.sysconfig import get_python_lib Just bail out in this situati

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

hhb added inline comments. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative_path +if module_path is None: +from distutils.sysconfig import get_python_lib hhb wrote: > Just bail out in

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

hhb accepted this revision. hhb added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ Maybe move these into the defined(_MSC_V

[Lldb-commits] [PATCH] D67942: Install python dll to bin

hhb created this revision. hhb added a reviewer: mstorsjo. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Not sure whether this is a feature or bug... Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67942 Files: lldb/CMakeLists.txt Index: lldb

[Lldb-commits] [PATCH] D67942: Install python dll to bin

hhb marked an inline comment as done. hhb added a comment. Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above. Comment at: lldb/CMakeLists.txt:233 COMMENT "Copying Python DLL to LL

[Lldb-commits] [PATCH] D67988: [lldb] clean up lldb/scripts a little bit

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No functional change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67988 Files: lldb/scripts/Python/finishSwigPythonLLDB.py lldb/scripts

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This replaces the hard coded path. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67993 Files: lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Elimiates lots of unused code. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb updated this revision to Diff 221664. hhb added a comment. Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68007/new/ https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python/prepare_binding_Python.py

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb updated this revision to Diff 221667. hhb added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68007/new/ https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python/prepare_binding_Python.py l

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

hhb added a comment. In D67993#1681901 , @mgorny wrote: > Yep, that's a change in the right direction. Have you (at least mentally) > verified that it produces the correct path in all cases? I wouldn't trust the > inputs being entirely correct. So far

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb added a comment. In D68007#1681908 , @mgorny wrote: > I'm kinda surprised we don't need site-packages path there after all. Yes that's surprising. Seems like it is better to move the install() call in your change to lldb/CMakeLists.txt. To be togeth

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rL372895: [lldb] Move swig call from python code to cmake (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb marked an inline comment as done. hhb added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) xiaobai wrote: > Doesn't this now include the `lldb-private` head

[Lldb-commits] [PATCH] D68040: [lldb] Excludes private headers from SWIG dependency.

hhb created this revision. hhb added a reviewer: xiaobai. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68040 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D68040: [lldb] Excludes private headers from SWIG dependency.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372905: [lldb] Excludes private headers from SWIG dependency. (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb closed this revision. hhb added a comment. I gave up on this. 😊 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D80253: [lldb] Cleans up system_libs

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Long long ago system_libs was appended to LLDB_SYSTEM_LIBS in cmake/LLDBDependencies.cmake. After that file was removed, system_libs is orphaned. Currently the only user is source/Utility. Mov

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb updated this revision to Diff 265080. hhb added a comment. hhb edited the summary of this revision. hhb updated this revision to Diff 265082. Remove endif() hhb added a comment. rebase

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

hhb updated this revision to Diff 265080. hhb added a comment. Remove endif() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.org/D80257 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Host/CMakeLists.txt

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

hhb updated this revision to Diff 265082. hhb added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.org/D80257 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Host/CMakeLists.txt lldb/so

[Lldb-commits] [PATCH] D80253: [lldb] Cleans up system_libs

This revision was automatically updated to reflect the committed changes. Closed by commit rG04daba967031: [lldb] Cleans up system_libs (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D80253?vs=265065&id=265327#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG780d7d77327c: [lldb] Allows customizing libxml2 for darwin (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.

<    1   2