I like the clang specific patch here better. Mainly because if you add a
function like this to TypeSystem.h:
virtual uint32_t
DeclContextCountDeclLevels (void *opaque_decl_ctx,
void *opaque_find_decl_ctx,
ConstString *find_na
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
My main concern here is efficient storage. See my inline comment regarding
DebugMacroEntryStorage and let me know what you think.
Comment at: include/lldb/Symbo
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
You want to check if each reg num is not LLDB_INVALID_REGNUM and return an
appropriate error.
http://reviews.llvm.org/D15457
___
l
clayborg added a comment.
"offset" here must be a file address, or a virtual address as the file's
sections know it. So if you take "offset" and look it up in the sections for
the COFF file, it should be a correct address. I don't know what
"m_coff_header_opt.image_base" is, but as along as ent
clayborg added a comment.
Let me clarify a few things. A "file address" is an address (lldb::addr_t) that
gets translated into a section + offset address (lldb_private::Address which
contains a lldb_private::Section + offset. Any addresses coming from ObjectFile
parsers must be made into lldb_p
clayborg added a comment.
Example code to resolve this would be:
Address entry_addr = objfile->GetEntryPointAddress();
lldb::addr_t entry_load_addr = entry_addr.GetLoadAddress(target);
if (entry_load_addr != LLDB_INVALID_ADDRESS)
{
// We were able to resolve the address as the
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will the unix / cmake experts make the decision here.
Repository:
rL LLVM
http://reviews.llvm.org/D19685
___
lldb-commits mailing list
lldb-c
Author: gclayton
Date: Fri Apr 29 15:48:39 2016
New Revision: 268098
URL: http://llvm.org/viewvc/llvm-project?rev=268098&view=rev
Log:
Make sure LLDB can deal with forward declarations to enums without crashing or
asserting.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/enum
Author: gclayton
Date: Fri Apr 29 16:00:38 2016
New Revision: 268101
URL: http://llvm.org/viewvc/llvm-project?rev=268101&view=rev
Log:
Fix TestGetVariables.py so it works correctly. We had duplicate static values
showing up as we would find static variables in the Block and also in the
compile u
Author: gclayton
Date: Fri Apr 29 16:26:46 2016
New Revision: 268110
URL: http://llvm.org/viewvc/llvm-project?rev=268110&view=rev
Log:
Watch out for compilers that generate bad bitfield info. If the bit size of a
bitfield member doesn't lie within the bit bounds of the type itself, just
leave it
clayborg accepted this revision.
clayborg added a comment.
Looks good
http://reviews.llvm.org/D19086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: gclayton
Date: Mon May 2 17:53:08 2016
New Revision: 268325
URL: http://llvm.org/viewvc/llvm-project?rev=268325&view=rev
Log:
debugserver should fflush its log stream in FileLogCallback, now it does.
Modified:
lldb/trunk/tools/debugserver/source/debugserver.cpp
Modified: lldb/tru
clayborg added a comment.
I would prefer a fix in the ADB client only if I had to pick. I don't think
anyone else will use this functionality and prefer to the keep the API as
simple as possible for Connection subclasses.
Repository:
rL LLVM
http://reviews.llvm.org/D19533
___
Author: gclayton
Date: Wed May 4 17:14:55 2016
New Revision: 268562
URL: http://llvm.org/viewvc/llvm-project?rev=268562&view=rev
Log:
Fixed a missing break and fixed spacing.
Modified:
lldb/trunk/source/Core/Scalar.cpp
Modified: lldb/trunk/source/Core/Scalar.cpp
URL:
http://llvm.org/viewv
Author: gclayton
Date: Wed May 4 17:26:42 2016
New Revision: 268563
URL: http://llvm.org/viewvc/llvm-project?rev=268563&view=rev
Log:
Don't let two threads call Debugger::Clear simultaneously.
We don't want a mutex in debugger as it will cause A/B locking issues with the
lldb_private::Target's
Author: gclayton
Date: Wed May 4 17:41:32 2016
New Revision: 268566
URL: http://llvm.org/viewvc/llvm-project?rev=268566&view=rev
Log:
Unblock the windows buildbot.
Modified:
lldb/trunk/include/lldb/Core/Debugger.h
Modified: lldb/trunk/include/lldb/Core/Debugger.h
URL:
http://llvm.org/view
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just get rid of the extra typedef as specified in inline comments and this is
good to go.
Comment at: include/lldb/Host/HostProcess.h:41
@@ -41,1 +40,3 @@
+publ
Author: gclayton
Date: Thu May 12 17:33:02 2016
New Revision: 269372
URL: http://llvm.org/viewvc/llvm-project?rev=269372&view=rev
Log:
Fix libstdc++ failure where is not able to be imported on Darwin
systems.
The adding of to test_common.h broke 12 tests on Darwin. We work
around this by not
Author: gclayton
Date: Thu May 12 17:36:47 2016
New Revision: 269373
URL: http://llvm.org/viewvc/llvm-project?rev=269373&view=rev
Log:
Don't crash when a process' task port goes bad.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachException.cpp
Modified: lldb/trunk/tools/debugser
Author: gclayton
Date: Thu May 12 17:58:52 2016
New Revision: 269377
URL: http://llvm.org/viewvc/llvm-project?rev=269377&view=rev
Log:
Fix some long standing issues that caused tests to be flaky.
The main issues were:
- Listeners recently were converted over to used by getting a shared pointer t
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
If you want remote debugging, you should actually implement the lldb-server
code and not do a native Process plug-in. What linux and macosx do is even when
debugging locally we r
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. We should work toward remove Mutex.cpp and Mutex.h completely and
also switch over to using std::condition_variable.
http://reviews.llvm.org/D20278
Author: gclayton
Date: Mon May 16 15:07:38 2016
New Revision: 269686
URL: http://llvm.org/viewvc/llvm-project?rev=269686&view=rev
Log:
Don't crash when OS plug-in returns None from any of the functions we might
call.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInte
Author: gclayton
Date: Mon May 16 16:14:44 2016
New Revision: 269707
URL: http://llvm.org/viewvc/llvm-project?rev=269707&view=rev
Log:
Make sure we notify that the section module was loaded when
SBTarget::SetSectionLoadAddress() is called. Also make sure that the section
module is unloaded when
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
http://reviews.llvm.org/D20303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We should think about converting everyone over to using
std::chrono::microseconds for any timeout parameters that are currently
"uint32_t timeout_usec". But we can do that in a future chan
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Expression/IRExecutionUnit.cpp:128
@@ -127,3 +127,3 @@
{
-if (function.m_name.AsCString() != m_name.AsCStri
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: gclayton
Date: Fri May 20 14:18:20 2016
New Revision: 270254
URL: http://llvm.org/viewvc/llvm-project?rev=270254&view=rev
Log:
Adopt mmap flags that allow mmap'ed memory to be less crash prone.
On Darwin if a mmap file is code signed and the code signature is invalid, it
used to crash. I
Author: gclayton
Date: Mon May 23 15:37:24 2016
New Revision: 270488
URL: http://llvm.org/viewvc/llvm-project?rev=270488&view=rev
Log:
We have many radars showing that stepping through C++ code can result in slow
steps.
One of the things slowing us down is that ItaniumABILanguageRuntime class
d
clayborg added a comment.
At some point we should probably make a host layer call like:
const char *const char *Host::GetIllegalFilenameCharacters();" so that each
host can determine the correct thing for the current host. Then FileSpec can be
updated to use this function handle this with a met
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Few minor changes, but looks great overall. Thanks for doing this.
Comment at: include/lldb/Target/MemoryRegionInfo.h:18-19
@@ -17,3 +17,4 @@
{
-class Memor
clayborg requested changes to this revision.
This revision now requires changes to proceed.
Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64
@@ +63,3 @@
+self.assertTrue(golden.IsValid(), "Encountered an error reading the
process's golden vari
clayborg added a comment.
I would just make a large buffer and use snprintf:
char buffer[4096];
char *p = buffer;
char *end = p + sizeof(buffer);
p += snprintf(p, end - p, "a_as_A->a() = '%s'\n", a_as_A->a());
p += snprintf(p, end - p, "a_as_A->b() = '%s'\n", a_as_A->b());
http://revi
Author: gclayton
Date: Wed May 25 19:08:39 2016
New Revision: 270803
URL: http://llvm.org/viewvc/llvm-project?rev=270803&view=rev
Log:
Make sure to try and take the process stop lock when calling:
uint32_t SBProcess::GetNumQueues();
SBQueue SBProcess::GetQueueAtIndex (size_t index);
Otherwise th
Author: gclayton
Date: Thu May 26 11:51:23 2016
New Revision: 270869
URL: http://llvm.org/viewvc/llvm-project?rev=270869&view=rev
Log:
Guard against the C++ destructor chain by not letting the debugger list clean
up after itself in the C++ destructor chain.
If users call "static void lldb::SBDe
Author: gclayton
Date: Thu May 26 14:24:02 2016
New Revision: 270891
URL: http://llvm.org/viewvc/llvm-project?rev=270891&view=rev
Log:
Make sure that we succeed in starting a definition before we complete it and
emit an error if we fail to start the definition.
ClangASTContext::StartTagDeclarati
Author: gclayton
Date: Thu May 26 17:33:25 2016
New Revision: 270932
URL: http://llvm.org/viewvc/llvm-project?rev=270932&view=rev
Log:
With -gmodules, we have been having a harder time always finding a type when we
need one.
We have seen cases where we have been unable to find an argument type
Author: gclayton
Date: Thu May 26 19:17:18 2016
New Revision: 270941
URL: http://llvm.org/viewvc/llvm-project?rev=270941&view=rev
Log:
Add a new "lldb" log channel named "demangle". If we have crashes that are
related to demangling, we now can enable this logging and we will be able to
reproduce
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This looks good as long as SBMemoryRegionInfo and SBMemoryRegionInfoList are
ready only and will never have any setter functions. If we plan to ever have
the SBMemoryRegionInfo o
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: include/lldb/Interpreter/Args.h:120
@@ -100,3 +119,3 @@
void
-Dump (Stream *s);
+Dump (Stream *s, const char *labe
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20760
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
In http://reviews.llvm.org/D20565#444223, @hhellyer wrote:
> In http://reviews.llvm.org/D20565#442373, @clayborg wrote:
>
> > This looks good as long as SBMemoryRegionInfo and SBMemoryRegionInfoList
> > are ready only and will never have any setter functions. If we plan
Author: gclayton
Date: Tue May 31 17:29:56 2016
New Revision: 271343
URL: http://llvm.org/viewvc/llvm-project?rev=271343&view=rev
Log:
Add more verification on consectutive bitfields otherwise clang will assert.
We need to verify that consecutive bitfields have higher offsets and don't
overlap.
clayborg added a comment.
"display-column-info"?
http://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
One last thing: we should default construct a MemoryRegionInfo in all
SBMemoryRegionInfo::SBMemoryRegionInfo() constructors so we don't have a make
sure to call a non-const ref()
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So a bit more cleanup. We should always have a valid object inside of a
SBMemoryRegionInfo or SBMemoryRegionInfoList so there is no need to ever check
the m_opaque_ap to see if i
Author: gclayton
Date: Thu Jun 2 12:19:39 2016
New Revision: 271543
URL: http://llvm.org/viewvc/llvm-project?rev=271543&view=rev
Log:
Fixed a problem where -gmodules debug info would be loaded by the DWO file
support accidentally and cause 1000s of files to be mapped into LLDB's address
space f
Author: gclayton
Date: Thu Jun 2 12:22:42 2016
New Revision: 271545
URL: http://llvm.org/viewvc/llvm-project?rev=271545&view=rev
Log:
LLDB needs to be able to handle DW_AT_GNU_dwo_name that are relative to the
DW_AT_comp_dir when using -gmodules with DWARF in .o files on darwin.
Modified:
Author: gclayton
Date: Fri Jun 3 12:59:26 2016
New Revision: 271696
URL: http://llvm.org/viewvc/llvm-project?rev=271696&view=rev
Log:
Add support in debug LLDB builds (if LLDB_CONFIGURATION_DEBUG is defined) where
we can set an environment variable named LLDB_DWARF_DONT_COMPLETE_TYPENAMES
that
Author: gclayton
Date: Fri Jun 3 14:45:05 2016
New Revision: 271716
URL: http://llvm.org/viewvc/llvm-project?rev=271716&view=rev
Log:
Fix a printf warning.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWAR
Author: gclayton
Date: Tue Jun 7 13:16:39 2016
New Revision: 272036
URL: http://llvm.org/viewvc/llvm-project?rev=272036&view=rev
Log:
LLDB is leaking memory in Editline.cpp on MacOSX.
When USE_SETUPTERM_WORKAROUND is enabled, we were calling setupterm() multiple
times and leaking memory on eac
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I am fine with this as long as all test suites on all systems pass.
http://reviews.llvm.org/D21088
___
lldb-commits mailing list
lldb-commits
Author: gclayton
Date: Tue Jun 7 17:56:40 2016
New Revision: 272069
URL: http://llvm.org/viewvc/llvm-project?rev=272069&view=rev
Log:
Fix a memory leak in InstructionLLVMC where it held onto a strong reference to
the DisassemblerLLVMC which in turn had a vector of InstructionSP causing the
stro
Author: gclayton
Date: Tue Jun 7 18:19:00 2016
New Revision: 272071
URL: http://llvm.org/viewvc/llvm-project?rev=272071&view=rev
Log:
Now that there are no cycles that cause leaks in the disassembler/instruction
classes, we can get rid of the FIXME lines that were working around this issue.
Author: gclayton
Date: Thu Jun 9 11:34:06 2016
New Revision: 272276
URL: http://llvm.org/viewvc/llvm-project?rev=272276&view=rev
Log:
Since our expression parser needs to locate areas of memory that are not in use
when you have a process that can't JIT code, like core file debugging, the core
f
Author: gclayton
Date: Thu Jun 9 12:52:02 2016
New Revision: 272281
URL: http://llvm.org/viewvc/llvm-project?rev=272281&view=rev
Log:
Some core files on MacOSX don't have permissions setup correctly on the
LC_SEGMENT load commands. Assume read + execute if the permissions are not set.
Modif
Author: gclayton
Date: Thu Jun 9 13:06:09 2016
New Revision: 272284
URL: http://llvm.org/viewvc/llvm-project?rev=272284&view=rev
Log:
Fix a no newline at end of file warning.
Modified:
lldb/trunk/unittests/ScriptInterpreter/Python/PythonExceptionStateTests.cpp
Modified:
lldb/trunk/unittest
Author: gclayton
Date: Thu Jun 9 17:26:49 2016
New Revision: 272322
URL: http://llvm.org/viewvc/llvm-project?rev=272322&view=rev
Log:
Fixed an issue in the ProcessMachCore where segments are not always contiguous
in mach-o core files. We have core files that have segments like:
Addres
Author: gclayton
Date: Thu Jun 9 18:56:12 2016
New Revision: 272348
URL: http://llvm.org/viewvc/llvm-project?rev=272348&view=rev
Log:
Fix "frame variable" to show all variables defined in functions and any
contained lexical blocks, even if they are static variables.
For code like:
int g_globa
Author: gclayton
Date: Fri Jun 10 15:09:33 2016
New Revision: 272423
URL: http://llvm.org/viewvc/llvm-project?rev=272423&view=rev
Log:
Fixed a few places that were building a regex from an identifier without
escaping the identifier text.
Modified:
lldb/trunk/examples/python/crashlog.py
Author: gclayton
Date: Fri Jun 10 15:56:09 2016
New Revision: 272434
URL: http://llvm.org/viewvc/llvm-project?rev=272434&view=rev
Log:
Fixed C++ template integer parameter types to work correctly when the integer
type is signed.
Prior to this we would display the typename for "TestObj<-1>" as
"
Author: gclayton
Date: Fri Jun 10 18:23:34 2016
New Revision: 272444
URL: http://llvm.org/viewvc/llvm-project?rev=272444&view=rev
Log:
On MacOSX, the threads can appear out of order at times depending on the order
in which the kernel returns thread IDs to debugserver. To avoid thread lists
chang
Author: gclayton
Date: Fri Jun 10 18:53:06 2016
New Revision: 272445
URL: http://llvm.org/viewvc/llvm-project?rev=272445&view=rev
Log:
Add missing #include for linux.
Modified:
lldb/trunk/source/Target/ThreadCollection.cpp
Modified: lldb/trunk/source/Target/ThreadCollection.cpp
URL:
http
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Does this patch handle being able to share an 8 byte watchpoint between two
watchpoints? Lets say you have an 8 byte array named "a" and watch to watch
a[0] and a[3] and a[7]. You should b
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This looks like it would work for normal operation. I am not sure it will work
when an extra private state thread is spun up. In certain circumstances we need
to create more priv
clayborg added a comment.
Ok, as long as Jim agrees, then I will give it the go ahead.
http://reviews.llvm.org/D21296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good if Jim is happy.
http://reviews.llvm.org/D21296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Seems like CheckIfWatchpointsExhausted() inside Target.cpp works for some
targets, but not all of them. Seems like this functionality should be pushed
down into RegisterContext to do this
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
Jason Molenda should be able to adequately review any patches. If he is OK,
then I am OK.
http://reviews.llvm.org/D21221
___
lldb-commits mailing
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sean Callanan needs to OK this as well.
http://reviews.llvm.org/D21328
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I am OK if Sean is OK with this.
http://reviews.llvm.org/D17856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
Author: gclayton
Date: Tue Jun 21 14:57:58 2016
New Revision: 273306
URL: http://llvm.org/viewvc/llvm-project?rev=273306&view=rev
Log:
Fix the "Release" build on MacOSX for debugserver. Extra bad include paths were
making things not build due to header file issues with stdio.h.
Modified:
ll
Author: gclayton
Date: Tue Jun 21 15:00:36 2016
New Revision: 273307
URL: http://llvm.org/viewvc/llvm-project?rev=273307&view=rev
Log:
Fix the use of lldb::eSymbolContextVariable.
In Address.cpp, we were asking for the lldb::eSymbolContextVariable to be
resolved, yet we weren't using the variabl
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So this is close. My idea was that the lldb-server would not just set a
key/value pair named "dynamic_size" to "1" in the "qRegisterInfo" or
"$qXfer:features:read:target.xml:0,1f
clayborg accepted this revision.
clayborg added a comment.
Make sure you keep a very close eye on all the buildbots with this one. I agree
this change is good, but I seem to remember there were problems when this was
done.
http://reviews.llvm.org/D21649
_
clayborg requested changes to this revision.
clayborg added a comment.
Sorry missed your comments about when a platform dies. Also be sure to know
that you might not have to connect to a platform for it to be useful. We have
ios-simulator platforms that don't require connecting.
http://reviews
Author: gclayton
Date: Thu Jun 23 14:54:32 2016
New Revision: 273604
URL: http://llvm.org/viewvc/llvm-project?rev=273604&view=rev
Log:
Added a new python example which installs a command called "shadow".
This shows how to grab individual blocks from stack frames and get only the
variables from
clayborg added a comment.
Platforms are funny because the "ios-simulator" platform doesn't need to be
connected for anything since it exists and runs things locally. The platform is
there to help us launch our processes so they run as simulator binaries, and
also to help locate files and other
clayborg added a comment.
Looks good.
http://reviews.llvm.org/D21648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: gclayton
Date: Fri Jun 24 18:40:35 2016
New Revision: 273749
URL: http://llvm.org/viewvc/llvm-project?rev=273749&view=rev
Log:
Add .i files for SBMemoryRegionInfo and SBMemoryRegionInfoList and also hook up
the new calls in SBProcess that give out SBMemoryRegionInfo and
SBMemoryRegionInf
Author: gclayton
Date: Fri Jun 24 18:48:00 2016
New Revision: 273750
URL: http://llvm.org/viewvc/llvm-project?rev=273750&view=rev
Log:
Made templates that have Enumeration values as arguments work correctly.
We were checking for integer types only before this. So I added the ability for
Compiler
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We shouldn't need to implement this on all process subclasses.
Process::GetMemoryRegions(...) could just call the
Process::GetMemoryRegionInfo() and fill the stuff in. We would n
clayborg added a comment.
This of course would rely on the fact that each Process subclass the overrides
GetMemoryRegionInfo() will follow the following rules:
1 - if no memory is mapped for a given address, set an extra "not_mapped"
variable in MemoryRegionInfo and provide the next address that
Author: gclayton
Date: Mon Jun 27 19:06:35 2016
New Revision: 273963
URL: http://llvm.org/viewvc/llvm-project?rev=273963&view=rev
Log:
Fixup the "shadow" example command to use the function that takes an execution
context now that the @lldb.command decorator does the right thing for the
command
clayborg added a comment.
In http://reviews.llvm.org/D21751#468738, @hhellyer wrote:
> Since there’s a list of memory regions already created in the Process
> implementations for the core fles I thought it made sense just to use that
> directly, at least when reading from a core file. It mean
Author: gclayton
Date: Tue Jun 28 12:14:18 2016
New Revision: 274037
URL: http://llvm.org/viewvc/llvm-project?rev=274037&view=rev
Log:
64-bit LEB values are not always correctly decoded due to a casting issue, now
they are.
Modified:
lldb/trunk/source/Core/DataExtractor.cpp
lldb/trun
clayborg added a comment.
There should be no need to add code on the lldb-server side. It would just send
the DWARF expression bytes over when qRegisterInfo or the target xml is sent to
the host. The host would store this expression and run it each time the
register info is asked for for a regi
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D21923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: gclayton
Date: Fri Jul 1 12:17:23 2016
New Revision: 274366
URL: http://llvm.org/viewvc/llvm-project?rev=274366&view=rev
Log:
Added support for thread local variables on all Apple OS variants.
We had support that assumed that thread local data for a variable could be
determined solely f
Author: gclayton
Date: Fri Jul 1 13:22:01 2016
New Revision: 274374
URL: http://llvm.org/viewvc/llvm-project?rev=274374&view=rev
Log:
Try to fix Ubuntu buildbots after I broke thread local variables with 274366.
Modified:
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSI
Author: gclayton
Date: Fri Jul 1 13:55:55 2016
New Revision: 274377
URL: http://llvm.org/viewvc/llvm-project?rev=274377&view=rev
Log:
Revert fix that didn't work. I will need to debug this on linux to figure
things out.
Modified:
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicL
Author: gclayton
Date: Fri Jul 1 16:25:20 2016
New Revision: 274388
URL: http://llvm.org/viewvc/llvm-project?rev=274388&view=rev
Log:
Thread local storage was already broken on Linux and the tests were passing
because there was a dectorator:
@unitte
Author: gclayton
Date: Fri Jul 1 17:33:13 2016
New Revision: 274393
URL: http://llvm.org/viewvc/llvm-project?rev=274393&view=rev
Log:
Fixed thread local storage test case to run normally with no expected fail for
Darwin, always skip on windows, and expected fail for all other OSs while
mentioni
Author: gclayton
Date: Tue Jul 5 13:19:43 2016
New Revision: 274568
URL: http://llvm.org/viewvc/llvm-project?rev=274568&view=rev
Log:
Fix "lldb.SBProcess.is_stopped" and "lldb.SBProcess.is_running" to do the right
thing.
https://llvm.org/bugs/show_bug.cgi?id=28428
Modified:
lldb/trunk/sc
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
It would be nice to export the is_mapped through the SBMemoryRegionInfo in the
public API for completeness.
http://reviews.llvm.org/D21751
___
Author: gclayton
Date: Tue Jul 5 18:01:20 2016
New Revision: 274585
URL: http://llvm.org/viewvc/llvm-project?rev=274585&view=rev
Log:
Warning about debugging optimized code was not happening without dSYMs. Now it
works for DWARF in .o files on Darwin.
I changed "m_is_optimized" in lldb_private:
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D21751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
401 - 500 of 3396 matches
Mail list logo
