clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We should think about converting everyone over to using
std::chrono::microseconds for any timeout parameters that are currently
"uint32_t timeout_usec". But we can do that in a future change.
================
Comment at: source/Core/Communication.cpp:163-165
@@ -169,3 +162,5 @@
EventSP event_sp;
- while (listener_sp->WaitForEvent (timeout_time.IsValid() ?
&timeout_time : nullptr, event_sp))
+ while (listener_sp->WaitForEvent((timeout_usec == UINT32_MAX) ?
std::chrono::microseconds(0)
+ :
std::chrono::microseconds(timeout_usec),
+ event_sp))
{
----------------
Should we convert the "timeout_usec" argument over to be a
std::chrono::microseconds type?
Repository:
rL LLVM
http://reviews.llvm.org/D20436
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
