clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed.
See inlined comments. ================ Comment at: source/Expression/IRExecutionUnit.cpp:128 @@ -127,3 +127,3 @@ { - if (function.m_name.AsCString() != m_name.AsCString()) + if (function.m_name.AsCString() == m_name.AsCString()) { ---------------- If "function.m_name" is a lldb_private::ConstString and so it "m_name", then please do this comparison as: ``` if (function.m_name == m_name) ``` Check with Sean to see if changing != to == is the correct thing. http://reviews.llvm.org/D20312 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits