[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

fdeazeve added a comment. In D154617#4478369 , @JDevlieghere wrote: > Is the reason this is necessary because the apple accelerator tables would > emit an entry for both the mangled and demangled name? Not quite. The name inside the accelerator table (

[Lldb-commits] [PATCH] D154549: [lldb][NFCI] Remove use of Stream * from TypeSystem

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154549/new/ https://reviews.llvm.org/D154549 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

fdeazeve added a comment. > Cool, might be worth mentioning that in the commit message. LGMT. Agreed! I'll update it prior to merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154617/new/ https://reviews.llvm.org/D154617 ___

[Lldb-commits] [PATCH] D154610: [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3bb6a59027: [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154610/

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

This revision was automatically updated to reflect the committed changes. Closed by commit rG032de3ee0d35: [lldb][DebugNamesDWARF] Also use mangled name when matching regex (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154617/

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc04b18ad7e4: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154513

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

fdeazeve added a comment. > There are some potential improvements we could make to this code Yup, there's a lot I want to change here, but I am taking it slowly in the interest of making each change easier to verify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D154730: [lldb] Consider TAG_imported_declaration in DebugNamesIndex

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In order to recognize namespace aliases as a namespace, the DW_TAG_imported_declarati

[Lldb-commits] [PATCH] D154730: [lldb] Consider TAG_imported_declaration in DebugNamesIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rGcec33fc87c0c: [lldb] Consider TAG_imported_declaration in DebugNamesIndex (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154730/new/

[Lldb-commits] [PATCH] D154757: [lldb][NFCI] TestEmulation should take a Stream ref

fdeazeve accepted this revision. fdeazeve added a comment. Thanks for finding those! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154757/new/ https://reviews.llvm.org/D154757 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D154843: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The ordering in which functions are presented to the expression evaluator in this test setting triggers a known bug in LLD

[Lldb-commits] [PATCH] D154843: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG6890ad3f41c5: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154843/new/

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. This code was introduced in 2fc93eabf7e132abd51d0ea0ad599beb3fa44334. In order to improve readability of ParseVaria

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

This revision was automatically updated to reflect the committed changes. Closed by commit rG85c2e420c87c: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155100/

[Lldb-commits] [PATCH] D153891: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve abandoned this revision. fdeazeve added a comment. Now that we have agreement on the discourse thread, I'll close this, polish it, and post again with tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153891/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D153886: [DRAFT][lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve abandoned this revision. fdeazeve added a comment. We're going with the other solution. See discourse thread linked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153886/new/ https://reviews.llvm.org/D153886 ___

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On a subsequent commit, I intend to update the expression and call the evaluate function more times. This refactors enable

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This rewrites DW_OP_addrx inside DWARFExpression as an DW_OP_addr so that we can update addresses that are originally loca

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve updated this revision to Diff 540001. fdeazeve added a comment. Minor comment improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D155198 Files: lldb/source/Expression/DWARFExpression.cpp ll

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

fdeazeve added a comment. See the patch stack for the commit that benefits from this refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155197/new/ https://reviews.llvm.org/D155197 ___ lldb-commits

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

fdeazeve added a comment. In D155178#4496936 , @IncludeGuardian wrote: > @MaskRay seems like `ninja` on its own after preparing `lldb` isn't enough to > build tests. I've now built llvm, clang, flang, bolt, lldb, + tests - I'm > hoping that this is it

[Lldb-commits] [PATCH] D155332: [lldb][NFC] Factor out CommandObject code filtering results based on scope

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We will need this code in a subsequent commit. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155332

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently frame var --regex sometimes searches globals, sometimes it doesn't. This happens because `StackFrame::GetVariabl

[Lldb-commits] [PATCH] D155332: [lldb][NFC] Factor out CommandObject code filtering results based on scope

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc97a3ee4f4: [lldb][NFC] Factor out CommandObject code filtering results based on scope (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

This revision was automatically updated to reflect the committed changes. Closed by commit rG00c60496775b: [lldb][NFC] Refactor test to enable subsequent reuse (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155197/new/ https:/

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve updated this revision to Diff 541986. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D155198 Files: lldb/source/Expression/DWARFExpression.cpp lldb/unittests/Expres

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve updated this revision to Diff 541987. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/ https://reviews.llvm.org/D155334 Files: lldb/include/lldb/Symbol/VariableList.h lldb/source/Commands/Com

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve updated this revision to Diff 542122. fdeazeve added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/ https://reviews.llvm.org/D155334 Files: lldb/include/lldb/Symbol/VariableList.h lldb/sou

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b19d13fde6e: [lldb] Make frame var --regex always search globals (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/ https://

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve added a comment. Hi @clayborg, just wanted to make sure this doesn't fall off your radar :) This fixes all outstanding DWARF 5 issues with Debug Maps, so it would be cool if we could get this in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

fdeazeve added a comment. In D158023#4590502 , @bulbazord wrote: > I think the categories you've set are the same ones I would have created. May > I suggest renaming `Extending LLDB` to `Scripting LLDB` or something similar? > I think "Extending" and "D

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

fdeazeve added inline comments. Comment at: lldb/include/lldb/Core/Module.h:126 Module( - const FileSpec &file_spec, const ArchSpec &arch, - const ConstString *object_name = nullptr, + const FileSpec &file_spec, const ArchSpec &arch, ConstString object_name,

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Good catch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158023/new/ https://reviews.llvm.org/D158023 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

fdeazeve added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start JDevlieghere wrote: > aprant

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

fdeazeve added a comment. I am slightly wary of making this a global set without any kind of thread safe mechanism, as I (naively, not really knowing how this class is used) would expect us to be able to instantiate multiple servers and have them be accessed concurrently. As such, it makes more

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

fdeazeve added a comment. > I decided to make it a global object to guarantee its lifetime independent of > any `PlatformRemoteGDBServer` instance. I don't mind wrapping it in a > concurrent structure to guarantee thread safety though. At that point we would pretty much be re-implementing the n

[Lldb-commits] [PATCH] D152870: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152870/new/ https://reviews.llvm.org/D152870 __

[Lldb-commits] [PATCH] D159150: [lldb][NFCI] Replace bespoke iterator check with std::next

fdeazeve accepted this revision. fdeazeve added a comment. Nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159150/new/ https://reviews.llvm.org/D159150 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

fdeazeve added inline comments. Comment at: lldb/include/lldb/Utility/StructuredData.h:436 auto array_sp = std::make_shared(); - collection::const_iterator iter; - for (iter = m_dict.begin(); iter != m_dict.end(); ++iter) { + for (auto iter = m_dict.begin();

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159011/new/ https://reviews.llvm.org/D159011 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159313/new/ https://reviews.llvm.org/D159313 __

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131901/new/ https://reviews.llvm.org/D131901 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

fdeazeve added a comment. This test is now failing even on the "basic" Clang (i.e. tip of trunk) test matrix entry: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/log/?consoleFull The log above is for the "Test DWARF4" portion of the job Repository:

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

fdeazeve added a comment. In D132004#3728394 , @fdeazeve wrote: > This test is now failing even on the "basic" Clang (i.e. tip of trunk) test > matrix entry: > > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/log/

[Lldb-commits] [PATCH] D132004: [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

fdeazeve added a comment. Greendragon is leaking environment configurations across runs. I'll address this in a separate PR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132004/new/ https://reviews.llvm.org/D132004 ___

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When running LLDB tests with a separately built copy of libcxx, it may be necessary to

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

fdeazeve updated this revision to Diff 454073. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. Fixed typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132257/new/ https://reviews.llvm.org/D132257 Files: lldb

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

fdeazeve added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + aprantl wrote: > JDevlieghere wrote: > > aprantl wrote: > > > JDevlieghere

[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Thanks for merging the two patches! This LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132263/new/ https://reviews.llvm.org/D132263

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

fdeazeve abandoned this revision. fdeazeve added a comment. Abandoning in favour of D132263 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132257/new/ https://reviews.llvm.org/D132257 _

[Lldb-commits] [PATCH] D132596: [lldb][nfc] Remove unused makefile test variables

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The variables LLDB_USING_LIBSTDCPP and LLDB_USING_LIBSTDCPP are no longer used anywhere. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When setting a breakpoint upon throwing exceptions, LLDB only searches for the libc++abi code inside dylibs named: 1. lib

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

fdeazeve added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } aprantl wrot

[Lldb-commits] [PATCH] D139361: [lldb-tests] Force system's libcxx on tests failing with debug symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fcc1840c31: [lldb-tests] Force system's libcxx on tests failing with debug symbols (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D143265: [lldb] Enable arm64 target for entry values test

fdeazeve created this revision. fdeazeve added a reviewer: Michael137. Herald added subscribers: omjavaid, kristof.beyls. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test is supposed to work in

[Lldb-commits] [PATCH] D143265: [lldb] Enable arm64 target for entry values test

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e70da2e431a: [lldb] Enable arm64 target for entry values test (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143265/new/ https://rev

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve created this revision. Herald added a subscriber: mikhail.ramalho. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For tests marked as "USE_SYSTEM_LIBCXX", the expectation is that the system's

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:434 +CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(SDKROOT)/usr/include/c++/v1 +LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++ +endif

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve updated this revision to Diff 507711. fdeazeve added a comment. Fix typos in commit message. Add hard error in case SDKROOT is not set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 Files: ll

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve updated this revision to Diff 507756. fdeazeve added a comment. Improve error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.ru

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve updated this revision to Diff 507757. fdeazeve added a comment. Fix typo in error msg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.ru

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

This revision was automatically updated to reflect the committed changes. Closed by commit rGc640a146c4ca: [lldb] Explicitly set libcxx paths when USE_SYSTEM_STDLIB is provided (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

fdeazeve added a comment. @labath I believe this broke the lldb bots, because the declaration of some virtual functions had the const qualifier removed, but not the definition: /Users/buildslave/jenkins/workspace/lldb-cmake@2/llvm-project/lldb/tools/lldb-server/lldb-gdbserver.cpp:79:36: erro

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

fdeazeve added a comment. Jonas fixed the build failures in c8522cadf7331bedd548ad5e2c6ef100c9166259 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146977/new/ https://reviews.ll

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

fdeazeve added a comment. > since ConstStrings live forever So long as this is true, I don't see any pitfalls either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://reviews.llvm.org/D148175 _

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The code inside Broadcaster makes usage of iterators using olden C++ coding style. Hidden in this old style is a couple of

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve updated this revision to Diff 520786. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ https://reviews.llvm.org/D150219 Files: lldb/source

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve added a comment. Heavily inspired by @bulbazord's D150168 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ https://reviews.llvm.org/D150219 ___ lldb-c

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:382 +auto iter = find_if(begin, end, listener_matches_and_shared_bits); +if (iter == m_event_map.end()) break; Oh, this should be `== end` Comment at

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:430 - while (true) { -auto events_predicate = -[&listener](const event_listener_key &input) -> bool { - return input.second.get() == listener; -}; -collection::iterator ite

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve updated this revision to Diff 520796. fdeazeve edited the summary of this revision. fdeazeve added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ https://reviews.llvm.org/D150219 Files: lldb

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:381 + for (auto begin = m_event_map.begin(), end = m_event_map.end();;) { +auto iter = find_if(begin, end, listener_matches_and_shared_bits); +if (iter == m_event_map.end())

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

fdeazeve added a comment. Nice cleanup! This gets rid of some implicit conversions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150222/new/ https://reviews.llvm.org/D150222 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

This revision was automatically updated to reflect the committed changes. Closed by commit rG25495c9b4c05: [lldb][NFCI] Remove n^2 loops and simplify iterator usage (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ ht

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! I like how the static_cast now is explicit about the fact that some truncation is going on from the ULEB reading. Do you have plans to do something similar for the attribute typedef? Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Most of the code changed here dates back to 2010, when LLDB was first introduced upstream, as such it benefits from a slig

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In an effort to unify the different dwarf parsers available in the codebase, this commit removes LLDB's custom parsing for

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32 - typedef std::map range_map; - typedef range_map::iterator range_map_iterator; - typedef range_map::const_iterator range_map_const_iterator; - range_map m_range_map; + s

[Lldb-commits] [PATCH] D150299: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150299/new/ https://reviews.llvm.org/D150299 _

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Thanks for doing this! In particular, all the early returns are very welcome :) I suspect you already have this in your radar, but `ExtractFormValueAtIndex` could probably return an `optio

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

This revision was automatically updated to reflect the committed changes. Closed by commit rG81be68062f49: [lldb][nfc] Simplify DebugRanges class (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150363/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

fdeazeve added a comment. In D150366#4336168 , @bulbazord wrote: > Ok, this looks like it's doing the same thing to me which is good. My > understanding of this change is that you're changing > `lldb::DWARFDebugRanges::Extract` to use `llvm::DWARFDebugR

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

This revision was automatically updated to reflect the committed changes. Closed by commit rG70aad4ec90f2: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges (authored by fdeazeve). Changed prior to commit: https://reviews.llvm.org/D150366?vs=521300&id=524731#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D151425: [lldb][nfc] Place comment in the right place

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This line has been misplaced since it was introduced in 2011 by c26e4454035a4160cffc3c865cf83be194ca38c4. Repository:

[Lldb-commits] [PATCH] D151451: [lldb][nfc] Refactor methods with out parameter

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, the method `GetAttributeAddressRanges` takes a DWARFRangeList as a parameter, just to immediately clear it. The

[Lldb-commits] [PATCH] D151425: [lldb][nfc] Place comment in the right place

fdeazeve added inline comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:47 + // Set the start value for the range, and keep the same size void SetRangeBase(BaseType b) { base = b; } JDevlieghere wrote: > I can update it for sure, but note that no

[Lldb-commits] [PATCH] D151425: [lldb][nfc] Place comment in the right place

This revision was automatically updated to reflect the committed changes. Closed by commit rG52b03b63972a: [lldb][nfc] Place comment in the right place (authored by fdeazeve). Changed prior to commit: https://reviews.llvm.org/D151425?vs=525544&id=525679#toc Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D151451: [lldb][nfc] Refactor methods with out parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG346afb857228: [lldb][nfc] Refactor methods with out parameter (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151451/new/ https://revi

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

fdeazeve added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:1001 -bool ObjCLanguage::GetFormatterPrefixSuffix(ValueObject &valobj, -ConstString type_hint, -

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

fdeazeve accepted this revision. fdeazeve added a comment. I'm not exactly familiar with DWOs, but the code motions LGTM! Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:882 + // we have a valid one to set it to. + assert(index_entry); + assert(!m_index_entry)

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

fdeazeve accepted this revision. fdeazeve added a comment. LGTM, thanks for picking this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152010/new/ https://reviews.llvm.org/D152010 ___ lldb-commits ma

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152210/new/ https://reviews.llvm.org/D152210 __

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152315/new/ https://reviews.llvm.org/D152315 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

fdeazeve accepted this revision. fdeazeve added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp:129-134 llvm::SmallString<64> name; { llvm::raw_svector_ostream os(name); os << GetPersistentVariablePrefix(is_err

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

fdeazeve added a comment. Thanks for looking into this! I think we should just remove the XFAIL instead, for the reasons you mentioned in the other patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152449/new/ https://reviews.llvm.org/D152449

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152449/new/ https://reviews.llvm.org/D152449 __

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. This is awesome! I believe you said there was no measurable perf diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152476/new/ https://rev

[Lldb-commits] [PATCH] D152872: Add support for __debug_line_str in Mach-O

fdeazeve accepted this revision. fdeazeve added a comment. Nice and subtle fix! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152872/new/ https://reviews.llvm.org/D152872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Nice catch! Also agree with the suggestion of using the STLExtras wrapper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152846/new/ https://

  1   2   3   >