fdeazeve accepted this revision.
fdeazeve added inline comments.
================
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp:129-134
llvm::SmallString<64> name;
{
llvm::raw_svector_ostream os(name);
os << GetPersistentVariablePrefix(is_error)
<< m_next_persistent_variable_id++;
}
----------------
JDevlieghere wrote:
> If we're going to return a `std::string`, we might as well use a
> `raw_string_ostream` and simplify this function.
+1, we can avoid the conversion of SmallString->std::string (and enable copy
elision) by declaring `name` as std::string
(we don't necessarily need to do it in this patch though, either way is fine
IMO)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152324/new/
https://reviews.llvm.org/D152324
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
