[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve added inline comments.


================
Comment at: lldb/include/lldb/Core/Module.h:126
   Module(
-      const FileSpec &file_spec, const ArchSpec &arch,
-      const ConstString *object_name = nullptr,
+      const FileSpec &file_spec, const ArchSpec &arch, ConstString object_name,
       lldb::offset_t object_offset = 0,
----------------
Out of curiosity, what was the rationale for removing the default parameter 
here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158043/new/

https://reviews.llvm.org/D158043

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits