[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added a comment. No problem. I doubt this is all of them but at least users can now workaround the gaps using the setting, and hack up one of these test cases to make reproducers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

This revision was automatically updated to reflect the committed changes. Closed by commit rGa723694321b9: [lldb] Add more ways to find split DWARF files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. In the interests of not being caught by the impeding shutdown at the end of the month, this is where we're at with this: I'm interested in the test suite results, but mostly for context of where this support is at, and not to block this. If it shows up bugs in any

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added a comment. From what I gather, split dwarf isn't a thing on Darwin so I've relanded with the tests skipped (https://github.com/llvm/llvm-project/commit/b1f14d647300b0ed003fa7c24af311b11605d009). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D151668: Wrong link target in the documentation #62990

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Sorry this got completely lost, built the HTML locally and the result is as expected. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D151668: Wrong link target in the documentation #62990

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ce82a10a322: Wrong link target in the documentation #62990 (authored by eddiep24, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D151668: Wrong link target in the documentation #62990

DavidSpickett added a comment. I've taken the liberty of landing it for you with the details from your last commit. Thanks again, we'll try not to take 3 months to review a simple fix next time :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1516

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f2ffb1cf31f: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data (authored by DavidSpickett). Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's SVE register state to TestArm64DynamicRegsets

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's SVE register state to TestArm64DynamicRegsets

DavidSpickett updated this revision to Diff 556541. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 Files: lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett added a comment. Did my best to update the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. Note: This requires later commits for ZA to func

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett created this revision. Herald added subscribers: sunshaoce, ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a register "svg" which mirrors SVE's "vg

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The size of ZA depends on the streamnig vector length regardl

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. An SME enabled program has the following extra state: - Stre

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett abandoned this revision. DavidSpickett added a comment. I've split them. I didn't split ZA definition and read/write because the former would be almost nothing, but otherwise it's into a few commits now ending with testing. I won't fold the ZA bugfix into this as I think it's weir

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added a comment. > Any chance we could simplify this situation and have dwo searches use exactly > the same/shared logic as source file searches? I'm not sure what exactly this means, can you clarify? I know that DWP and DWO have different search functions, that could certainly b

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett updated this revision to Diff 556555. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 Files: lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett updated this revision to Diff 556556. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ https://reviews.llvm.org/D159502 Files: lldb/include/lldb/Utility/RegisterValue.h lldb/source/P

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556557. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 556558. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556559. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556560. DavidSpickett added a comment. Herald added a subscriber: sunshaoce. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556561. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 556562. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 556563. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added a comment. Should all be updated now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett added a comment. > In this test can we figure out whether SVE was read from Streaming mode or > normal SVE mode?? and if yes may be add a check for that. Not sure what you mean. If you mean: - write non-streaming SVE with one set of values - write streaming SVE with another - ass

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett updated this revision to Diff 556564. DavidSpickett added a comment. Use the simpler way to get the register sets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 Files: lldb/test/API/com

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556565. DavidSpickett added a comment. Rebase after changes to previous patch to arm64 regsets test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: l

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. > I can make this change here, but I wonder if it should be a separate change. Sounds like bitness confusion, so yes it's worth making a patch for that. We don't test that scenario on the build bots but people do do this. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett added a comment. > I was actually curious if LLDB user can distinguish whether we are reading > SVE registers from streaming mode or normal SVE mode. But yes only config > registers like vg can tell that registers are read in non-SVE(FPSIMD), normal > SVE, or streaming modes. Rig

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:342 + // header itself. + m_za_ptrace_payload.resize(((m_za_header.vl) * (m_za_header.vl)) + + GetZAHeaderSize()); --

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add tests for SME's SVE register state to TestArm64DynamicRegsets

This revision was automatically updated to reflect the committed changes. Closed by commit rG11de4c724c8e: [lldb][AArch64] Add tests for SME's SVE register state to… (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/ne

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett added a comment. Made sense at the time with it being it's own regset in ptrace. Current state is: Scalable Matrix Array Storage Registers: za = {<...>} Scalable Matrix Extension Registers: svg = 0x0004 svcr = 0x0003 But I

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett updated this revision to Diff 556670. DavidSpickett added a comment. Put ZA in the SME register set instead. Once other patches are applied you end up with: Scalable Matrix Extension Registers: svcr = 0x svg = 0x0004 za = {0x

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556671. DavidSpickett added a comment. Adjust now that ZA is in the SME set. Putting SVG first for readability and ease of resizing ZA later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ http

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 556672. DavidSpickett added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegister

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556673. DavidSpickett added a comment. Update tests now that ZA is part of SME register set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556674. DavidSpickett added a comment. ZA is now part of the SME set so SVCR is stuck in before SVG. SVCR SVG ZA Updated the various indexes to reflect that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556675. DavidSpickett added a comment. Rebase, adjust to handling ZA as part of the SME register set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: l

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 556676. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 556677. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett added a comment. > Why do we have svg and za in different register sets? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 ___ lldb-commits m

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett added a comment. Scalable Matrix Extension Registers: svcr = 0x svg = 0x0004 za = {0x00 <...>} Is the layout now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ http

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556678. DavidSpickett added a comment. Reformat changes with black. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/re

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556679. DavidSpickett added a comment. Format with black. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Process/Linux/NativeRegis

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556680. DavidSpickett added a comment. Format with black. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterC

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:597 + // Here this means, does the system have ZA, not whether it is active. + if (GetRegisterInfo().IsZAEnabled()) { +error = ReadZAHeader(); --

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

DavidSpickett added a comment. ping! (in the interest of clearing Phabricator reviews soon) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159011/new/ https://reviews.llvm.org/D159011 ___ lldb-commits mai

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett updated this revision to Diff 556752. DavidSpickett added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ https://reviews.llvm.org/D159502 Files: lldb/include/lldb/Utility/RegisterValue

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett marked 3 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:597 + // Here this means, does the system have ZA, not whether it is active. + if (GetRegisterInfo().IsZAEnab

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556753. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 556754. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556755. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556756. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556757. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 556758. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 556759. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556844. DavidSpickett added a comment. - sme_regs -> sme_pseudo_regs, also changed the accesor method names. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Will apply the rename in core files as well later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 __

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett added a comment. Note that GetSMEOffset refers to the whole register set which does include ZA, so no change of name there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 _

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556851. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 556852. DavidSpickett added a comment. Combine reconfigure into one function. The tricky thing is we have to read svg and vg up front because we can't read registers while we're messing with register offsets. Otherwise, the result is a bit clearer and i

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:839 + +void GDBRemoteDynamicRegisterInfo::UpdateARM64SMERegistersInfos(uint64_t svg) { + for (auto ® : m_regs) {

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556853. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556854. DavidSpickett added a comment. Rebase, use new sme_pseudo_regs naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Proc

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556855. DavidSpickett added a comment. sme_regs -> sme_pseudo_regs and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Proc

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 556856. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added a comment. I'll hold off landing any of the prior patches until this is reviewed, in case I have to go back and move things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 __

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:201 +self.runCmd("register write za '{}'".format(za_value)) +self.expect("register read za", substrs=[za_value]) --

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett updated this revision to Diff 557007. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ https://reviews.llvm.org/D159502 Files: lldb/include/lldb/Utility/RegisterValue.h lldb/source/P

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 557008. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 557009. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 Files: lldb/incl

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/Makefile:3 + +CFLAGS_EXTRAS := -march=armv8-a+sve+sme -lpthread + DavidSpickett wrote:

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557010. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 557011. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 557012. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 557013. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 557014. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/main.c:12 +// (this is just how ptrace works). +// * Writing to an inactive ZA produces a SIGILL. + omjavaid wrote: > Is this a kern

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557021. DavidSpickett added a comment. Clarify comment about SIGILL from inactive ZA. Fix some leftover clang-format issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

This revision was automatically updated to reflect the committed changes. Closed by commit rGd99d9d8b74ff: [lldb][AArch64] Add SME's Array Storage (ZA) register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ h

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0768b8237ad: [lldb][AArch64] Add SME streaming vector length pseduo register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1595

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

This revision was automatically updated to reflect the committed changes. Closed by commit rG46b961f36bc5: [lldb][AArch64] Implement resizing of SME's ZA register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557034. DavidSpickett added a comment. Fix some python formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/reg

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe96adfd0dbcf: [lldb][AArch64] Add testing for SME's ZA and SVG registers (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/ne

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett abandoned this revision. DavidSpickett added a comment. Moved to https://github.com/llvm/llvm-project/pull/66767. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett abandoned this revision. DavidSpickett added a comment. Moved to https://github.com/llvm/llvm-project/pull/66768. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:262 + // NOTE: It's unsafe to iterate through LLDB_REGNUM_GENERICs + // But the a registers re sequential in the RISC-V register space + ++reg_index; S

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. FYI I will be away next week, and the week after that Phab is supposed to be made read-only. So look to @jasonmolenda to approve in that time frame, or we can take this to a PR after that. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} omjavaid wrote: > Shouldnt we build a relevant error message here incase ReadSMEControl fails > on ReadZAHeader I thi

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 557100. DavidSpickett added a comment. - Return error in SVCR read. - Note absence of write tests of SVCR because it's read only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} DavidSpickett wrote: > omjavaid wrote: > > Shouldnt we build a relevan

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 557101. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7fab666955e: [lldb][AArch64] Add SME's streaming vector control register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/n

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 557171. DavidSpickett added a comment. Remove redundant if. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/Registe

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43812c8c87b1: [lldb][AArch64] Linux corefile support for SME (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D115151: [lldb/qemu] Add emulator-args setting

DavidSpickett added a comment. LGTM. Not clear what qemu options will be most useful yet and a catch all is always useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115151/new/ https://reviews.llvm.org/D115151 ___

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:121 +auto host_it = host.find(KV.first()); +if (host_it == host.end() || host_it->second != KV.second) + set_env.push_back(Environment::compose(KV)); -

<    1   2   3   4   5   6   7   8   9   10   >