[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione updated this revision to Diff 172488. kastiglione added a comment. Added IOHandlerActivatedInteractively https://reviews.llvm.org/D48752 Files: include/lldb/Core/IOHandler.h packages/Python/lldbsuite/test/functionalities/command_regex/TestCommandRegex.py source/Commands/Comma

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. There are other commands that print instructions in the same way that `command regex` does, should they be updated in this change too? https://reviews.llvm.org/D48752 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D49776: Update framework-header-fix to force system sed

This revision was automatically updated to reflect the committed changes. Closed by commit rL346099: Update framework-header-fix to force system sed (authored by kastiglione, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49776?vs=157

[Lldb-commits] [PATCH] D49776: Update framework-header-fix to force system sed

kastiglione added a comment. @Keith I screwed up and committed without amending the commit message to attribute you as the author :( Repository: rL LLVM https://reviews.llvm.org/D49776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. @jingham If you're still willing to review this change to `command regex`, it is updated per our previous discussion, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 ___

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

kastiglione created this revision. kastiglione added a reviewer: xiaobai. Fix a "Manay" in SBSymbolContext.i https://reviews.llvm.org/D48620 Files: scripts/interface/SBSymbolContext.i Index: scripts/interface/SBSymbolContext.i

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL335709: Fix a single typo in SBSymbolContext (authored by kastiglione, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48620 Files: lldb/trunk/

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione created this revision. kastiglione added reviewers: clayborg, granata.enrico. This change fixes one issue with `lldb.command`, and also reduces the implementation. The fix: a command function's docstring was not shown when running `help `. This is because the docstring attached the

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione updated this revision to Diff 153114. kastiglione added a comment. Update a comment https://reviews.llvm.org/D48658 Files: scripts/Python/python-extensions.swig Index: scripts/Python/python-extensions.swig === --- s

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione added a subscriber: granata.enrico. kastiglione added a comment. Thanks @granata.enrico, sorry for the disruption, I noticed previous comments after I had submitted this. https://reviews.llvm.org/D48658 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione added a comment. @clayborg I'll dig into how `python-extensions.swig` gets tested, and add something accordingly. I have only briefly looked at `cmdtemplate.py`. I can look into adding similar registration behavior to it. For what it's worth, I prefer functions to classes for defin

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione created this revision. kastiglione added reviewers: clayborg, jingham. Within .lldbinit, regex commands can be structured as a list of substitutions over multiple lines. It's possible that this is uninentional, but it works and has benefits. For example: command regex s/pat1/re

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. Thanks @jingham. > if the `IOHandlerDelegate` could say whether it wants to be notified for > `IOHandlerActivated` when non-interactive (like have a > "`ShouldNotifyWhenNonInteractive`" method), and then the `IOHandler` could > dispatch it or not based on the respo

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione updated this revision to Diff 153654. kastiglione added a comment. Add tests and make command_name optional https://reviews.llvm.org/D48658 Files: packages/Python/lldbsuite/test/functionalities/command_script/TestCommandScript.py packages/Python/lldbsuite/test/functionalities/c

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

This revision was automatically updated to reflect the committed changes. Closed by commit rL336287: Fix and simplify lldb.command decorator (authored by kastiglione, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48658 Files: lldb/tr

[Lldb-commits] [PATCH] D49776: Update framework-header-fix to force system sed

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione updated this revision to Diff 187135. kastiglione added a comment. Herald added a subscriber: jdoerfert. Add interactive parameter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 Files: include/lldb/Core/IOHandler.h include/lldb/

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. @clayborg this has been updated the approach you suggested, adding an `interactive` parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

kastiglione added a comment. I'm getting build failures that appear to be caused by this patch. I'm compiling on macOS with Xcode 10.1. The failures are uses of `LLDB_RECORD_DUMMY()`, passing a callback function pointer as one of the args. This results in errors like: ../../tools/lldb/includ

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355793: Quiet command regex instructions during batch execution (authored by kastiglione, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: http

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. Thanks for reviewing @clayborg. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/include/lldb/Target/Target.h:496 + std::once_flag target_once_flag; // These two functions fill out the Broadcaster interface: did you mean to use this, or should it be deleted? Comment

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:133-135 + << "note: object description requested, but type doesn't implement " + "a custom object description. Consider using \"p\" instead of " + "\"po

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 539268. kastiglione added a comment. Refactor for better API layering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 Files: lldb/include/lldb/Target/LanguageRu

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione added a comment. @bulbazord @augusto2112 hopefully this is a quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 539359. kastiglione added a comment. Change `bool IsSwift()` to `LanguageType GetImplementationLanguage()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 Files:

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 542169. kastiglione added a comment. Redo ValueObjectDynamicValue::UpdateValue changes based on upstream testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 F

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe19339f5f8c1: [lldb] Identify Swift-implemented ObjC classes (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

kastiglione added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:41 llvm::StringRef value) { + std::lock_guard lock(m_mutex); Status error; this one doesn't need a lock Comment at: lldb

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

kastiglione added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:49 + std::lock_guard lock(m_mutex); if (GetType() == OptionValue::eTypeBoolean) return static_cast(this); do these GetAsX functions need to lock? Repository: rG LL

[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `std::basic_string` is not a regex, and treating it as such could unintentio

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

kastiglione added a comment. Thanks for doing this! Question to all: Should the summary string include the unit? lldb doesn't always show the type, so it could help comprehension if the unit is included. For example `60s` instead of `60`. Comment at: lldb/source/Plugins/Lang

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

kastiglione added inline comments. Comment at: lldb/source/Core/Section.cpp:153 + case eSectionTypeSwiftModules: +return "swift-modules"; } I wonder if this should be "swiftmodules". I have never seen it spelled with a hyphen. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

kastiglione added a comment. Merged in https://github.com/llvm/llvm-project/pull/66949 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158663/new/ https://reviews.llvm.org/D158663 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D115182: [lldb] Remove some trivial scoped timers

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While profiling lldb (from swift/llvm-project), these timers were noticed to be short lived

[Lldb-commits] [PATCH] D115182: [lldb] Remove some trivial scoped timers

This revision was automatically updated to reflect the committed changes. Closed by commit rG13278efd0c95: [lldb] Remove some trivial scoped timers (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115182/new/ https://reviews.

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `memory region` displays the top-level section name, which for MachO is the segment name. Th

[Lldb-commits] [PATCH] D116461: [lldb] Remove ProcessStructReader from NSStringSummaryProvider (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, augusto2112. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Simplify getting the length of `NSPathStore2` strings. `NSStringSummaryProvider

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos (NFC)

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl, augusto2112. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes incomplete command names in `apropos` results. The full command names given by

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione updated this revision to Diff 396955. kastiglione added a comment. Use std::move Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D116491 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h l

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

kastiglione added a comment. I see now this isn't valid as written. The address range and rwx permissions printed by `memory region` are for the segment not the section. I think it would be helpful to print the section too, but as this change is written now, it could appear that all the info is

[Lldb-commits] [PATCH] D116682: [lldb] Add StringList::AppendString(const Twine&) (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a convenience for appending constructed string values. Repository: rG LLVM Github Monorepo h

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto &subcommand_name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +commands_found.AppendString(std:

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto &subcommand_name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +commands_found.AppendString(std:

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione updated this revision to Diff 397681. kastiglione added a comment. explicit std::string type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D116491 Files: lldb/include/lldb/Interpreter/CommandInter

[Lldb-commits] [PATCH] D116708: [lldb] Break out long help for 'frame var'

kastiglione created this revision. kastiglione added reviewers: augusto2112, JDevlieghere, jingham, rastogishubham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current help for `frame variable` is somewhat long. Its leng

[Lldb-commits] [PATCH] D116708: [lldb] Break out long help for 'frame var'

This revision was automatically updated to reflect the committed changes. Closed by commit rGef6817f9329c: [lldb] Break out long help for 'frame var' (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116708/new/ https://review

[Lldb-commits] [PATCH] D116682: [lldb] Add StringList::AppendString(const Twine&) (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1a0d4957ec: [lldb] Add StringList::AppendString(const Twine&) (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116682/new/ h

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3bfd595a548: [lldb] Compute fully qualified command names in FindCommandsForApropos (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D116491?vs=397681&id=398034#toc Reposit

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, clayborg. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Ensure that errors in `frame variable` are reflected in result object. The statistics for `

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione updated this revision to Diff 398040. kastiglione added a comment. s/warning/error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116788/new/ https://reviews.llvm.org/D116788 Files: lldb/source/Commands/CommandObjectFrame.cpp Index:

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:560-563 } else if (num_matches == 0) { -result.GetErrorStream().Printf("error: no variables matched " - "the reg

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added a subscriber: jingham. kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:560-563 } else if (num_matches == 0) { -result.GetErrorStream().Printf("error: no variables matched " -

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c7d10c41278: [lldb] Set result error state in 'frame variable' (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116788/new/ https:/

[Lldb-commits] [PATCH] D116461: [lldb] Remove ProcessStructReader from NSStringSummaryProvider (NFC)

kastiglione added a comment. To add more context, `ProcessStructReader` is used in only a few places, and none seem like they should truly need it. This was a low hanging fruit. Something I don't understand about this code is why it the objc metadata is incomplete. The class is known, but not i

[Lldb-commits] [PATCH] D116461: [lldb] Remove ProcessStructReader from NSStringSummaryProvider (NFC)

kastiglione updated this revision to Diff 398341. kastiglione added a comment. give name to synthetic child Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116461/new/ https://reviews.llvm.org/D116461 Files: lldb/source/Plugins/Language/ObjC/NSStr

[Lldb-commits] [PATCH] D116863: [lldb] Remove anon struct from frame-var-anon-unions test

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, jingham, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test for anonymous unions seems off. It tests the following: union { //

[Lldb-commits] [PATCH] D116863: [lldb] Remove anon struct from frame-var-anon-unions test

kastiglione updated this revision to Diff 398348. kastiglione added a comment. clarify commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116863/new/ https://reviews.llvm.org/D116863 Files: lldb/test/API/lang/cpp/frame-var-anon-unions

[Lldb-commits] [PATCH] D116863: [lldb] Remove anon struct from frame-var-anon-unions test

kastiglione updated this revision to Diff 398349. kastiglione added a comment. once more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116863/new/ https://reviews.llvm.org/D116863 Files: lldb/test/API/lang/cpp/frame-var-anon-unions/TestFrameVar

[Lldb-commits] [PATCH] D116461: [lldb] Remove ProcessStructReader from NSStringSummaryProvider (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9f3e0ec773: [lldb] Remove ProcessStructReader from NSStringSummaryProvider (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D116901: [lldb] Guard libstdc++ specific 'frame var' test

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While working on D116788 (properly error out of `frame va

[Lldb-commits] [PATCH] D116912: [lldb] Check for arm64 in TestDisassembleRawData

kastiglione created this revision. kastiglione added reviewers: jasonmolenda, JDevlieghere. Herald added subscribers: omjavaid, kristof.beyls. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test checks for `aarch64` but th

[Lldb-commits] [PATCH] D116912: [lldb] Check for arm64 in TestDisassembleRawData

This revision was automatically updated to reflect the committed changes. Closed by commit rGaad27a890754: [lldb] Check for arm64 in TestDisassembleRawData (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116912/new/ https://

[Lldb-commits] [PATCH] D116901: [lldb] Guard libstdc++ specific 'frame var' test

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8549354c1b: [lldb] Guard libstdc++ specific 'frame var' test (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116901/new/ https://

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1695 + section_sp = section_sp->GetParent(); +section_name = section_sp->GetName(); + } aprantl wrote: > Why did `section_sp->GetName();`

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:76 + +self.runCmd("run", RUN_SUCCEEDED) + aprantl wrote: > Doesn't `lldbutil.run_break_set_by_symbol()` do the "file" and "run" already > and t

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added a comment. In D116788#3231612 , @clayborg wrote: > I would vote that if any argument or option is specified, and results in > something not being found, that an error be returned. Is this in response to my question about regexes? It se

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added a comment. > Let me know your thoughts as mine are just my initial thoughts after thinking > about things a bit more. For most of what you said, I was thinking the same. The only place where I wasn't as sure about (regex), I was on the fence. Your cases and arguments all seem

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added a comment. > if I run “frame var” from HandleCommand in a script, with this change I can’t > rely on the command status to tell whether the command output had anything > interesting in it. That seems awkward. This could be resolved by introducing a new enum value to indicate p

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Convert the `crashlog` command to be implemented as a class. The `Symbolicate` function is switched to a c

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione added a comment. Herald added a subscriber: JDevlieghere. The output of `help crashlog` is: (lldb) help crashlog For more information run 'help crashlog' Expects 'raw' input (see 'help raw-input'.) Syntax: crashlog Usage: crashlog [options] [FILE ...] Symbolicate o

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione updated this revision to Diff 399517. kastiglione added a comment. refer to the debugger parameter, not lldb.debugger Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.org/D117165 Files: lldb/examples/pyt

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:1236-1240 +def __lldb_init_module(debugger, internal_dict): +debugger.HandleCommand( +'command script add -c lldb.macosx.crashlog.Symbolicate crashlog') +debugger.HandleCommand(

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione updated this revision to Diff 399701. kastiglione added a comment. Add get_short_help, and add missing changes that should have been part of original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione added a comment. > Can you see if also adding a "get_short_help" gets rid of that dopey: Good call, it worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.org/D117165

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:1236-1240 +def __lldb_init_module(debugger, internal_dict): +debugger.HandleCommand( +'command script add -c lldb.macosx.crashlog.Symbolicate crashlog') +debugger.HandleCommand(

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione created this revision. kastiglione added reviewers: jingham, JDevlieghere, clayborg. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update examples and docs to demonstrate using `__lldb_init_module` instead of the i

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione updated this revision to Diff 399724. kastiglione added a comment. fix a few more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 Files: lldb/docs/use/python-reference.rst lldb/examples/da

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione added inline comments. Comment at: lldb/docs/use/python-reference.rst:586 the module is loaded allowing you to add whatever commands you want into the -current debugger. Note that this function will only be run when using the LLDB -command command script import, it w

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione updated this revision to Diff 399729. kastiglione added a comment. restore `if __name__ == '__main__'` example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 Files: lldb/docs/use/python-ref

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione updated this revision to Diff 399731. kastiglione added a comment. updates from reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 Files: lldb/docs/use/python-reference.rst lldb/exa

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione added inline comments. Comment at: lldb/docs/use/python-reference.rst:586 the module is loaded allowing you to add whatever commands you want into the -current debugger. Note that this function will only be run when using the LLDB -command command script import, it w

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb5ea132d2ee: [lldb] Add long help to `crashlog` (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases to command-regex

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a subscriber: jeroen.dobbelaere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow users to create aliases which invoke aliases to comman

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione updated this revision to Diff 399835. kastiglione added a comment. add @clayborg's improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 Files: lldb/docs/use/python-reference.rst ll

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione marked 2 inline comments as done. kastiglione added a comment. thanks @clayborg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 ___ lldb-commits mai

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1441ffe6a6da: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom (authored by kastiglione). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D117383: [lldb] From unordered_map synthetic provider, return std::pair children

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change the behavior of the libc++ `unordered_map` synthetic provider to present children as `std::pair` va

[Lldb-commits] [PATCH] D117383: [lldb] From unordered_map synthetic provider, return std::pair children

kastiglione updated this revision to Diff 400234. kastiglione added a comment. Herald added a subscriber: JDevlieghere. some tabs snuck in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 Files: lldb/sou

[Lldb-commits] [PATCH] D117383: [lldb] From unordered_map synthetic provider, return std::pair children

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:128 + // __cc is a field of __hash_value_type, which is a typedef. + if (name == "__cc") +m_element_type = key_value_type.GetTypedefedType();

[Lldb-commits] [PATCH] D116863: [lldb] Remove anon struct from frame-var-anon-unions test

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa7e7f541c081: [lldb] Remove anon struct from frame-var-anon-unions test (authored by kastiglione). Repository: rG LLVM

[Lldb-commits] [PATCH] D117837: [lldb] Fix timer logging inverted quiet condition

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, labath. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The logic of `g_quiet` was inverted in D26243 . This correct

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. nice CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117914/new/ https://reviews.llvm.org/D117914 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

kastiglione added a comment. I find "Unallocated" ambiguous. To the Allocator, maybe it's not, but to VM it is. What about Total/UsedUnused? Note that the docs for `BytesAllocated` say it can be used to calculated "wasted" space. /// How many bytes we've allocated. /// /// Used so that we

[Lldb-commits] [PATCH] D117837: [lldb] Fix timer logging inverted quiet condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ee14e29e98: [lldb] Fix timer logging inverted quiet condition (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117837/new/ https:/

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases to command-regex

kastiglione updated this revision to Diff 402132. kastiglione added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117259/new/ https://reviews.llvm.org/D117259 Files: lldb/source/Commands/CommandObjectCommands.cpp lldb/tes

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases of raw input commands

kastiglione updated this revision to Diff 402143. kastiglione edited the summary of this revision. kastiglione added a comment. use Jim's testing improvement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117259/new/ https://reviews.llvm.org/D117259

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases of raw input commands

This revision was automatically updated to reflect the committed changes. Closed by commit rGb95150418fb6: [lldb] Allow aliases to aliases of raw input commands (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117259/new/ htt

[Lldb-commits] [PATCH] D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries

kastiglione created this revision. kastiglione added reviewers: aprantl, augusto2112. kastiglione requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Change `Section::GetPermissions()` to indicate non-writability when the Mach

[Lldb-commits] [PATCH] D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries

kastiglione added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1436 result |= ePermissionsReadable; - if (seg_cmd.initprot & VM_PROT_WRITE) + if ((seg_cmd.initprot & VM_PROT_WRITE) && !(seg_cmd.flags & SG_READ_ONLY)) result |=

  1   2   3   4   5   6   7   8   >