[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

alexshap added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:238 +ifneq (,$(wildcard $(LLVM_DWP))) + MAKE_DWP=YES aprantl wrote: > Is the fact this this is *llvm-*dwp critical, or are llvm-dwp and GNU dwp > interchangeable? I

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

alexshap added a comment. @labath > I am not denying that there is value in running the dotest suite in all of > these modes. In fact, I think that (the fact that we can use the same tests > to exercise a lot of different scenarios) is one of the strengths ?>of our > test suite. However, I don

[Lldb-commits] [PATCH] D39825: [lldb] Fix cu_offset for dwo/dwp used by DWARFCompileUnit::Index

alexshap created this revision. Herald added subscribers: JDevlieghere, aprantl. At the moment for DIERefs coming from DWO/DWP LLDB expects cu_offset to be equal to the offset of the original compilation unit. This invariant is ensured during the "indexing" of DIEs of the original SymbolFileDWAR

[Lldb-commits] [PATCH] D39825: [lldb] Fix cu_offset for dwo/dwp used by DWARFCompileUnit::Index

alexshap added a comment. @tberghammer - for example, any call of SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE (with an object of the type SymbolFileDWARFDwo) will trigger indexing of the dwo file. @labath - yeah, i will add a test & update this patch Repository: rL LLVM https://r

[Lldb-commits] [PATCH] D39825: [lldb] Fix cu_offset for dwo/dwp used by DWARFCompileUnit::Index

alexshap added a comment. @tberghammer, SymbolFileDWARF (the base class of SymbolFileDWARFDwo) calls Index() "lazily" in may places, so indexing of dwo happens almost inevitably (at the moment) (FindCompleteObjCDefinitionTypeForDIE is just one example). > because this way you will index the c

[Lldb-commits] [PATCH] D39825: [lldb] Fix cu_offset for dwo/dwp used by DWARFCompileUnit::Index

alexshap added a comment. i'd like to think about this problem a little bit more (maybe i'm missing smth) + as i said above - will add a test Repository: rL LLVM https://reviews.llvm.org/D39825 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D39825: [lldb] Fix cu_offset for dwo/dwp used by DWARFCompileUnit::Index

alexshap added a comment. > The main point is that you should almost always interact with the > SymbolFileDWARF instance belonging to the main object file and it > (actually DWARFCompileUnit) will know when to access data from the Dwo >file > instead. > The original goal was to not leak pointe

[Lldb-commits] [PATCH] D39825: [lldb] Fix cu_offset for dwo/dwp used by DWARFCompileUnit::Index

alexshap updated this revision to Diff 122389. alexshap added a comment. Change the approach: add assert to ensure we don't double index .dwo files, rerun the tests. @tberghammer - many thanks for the suggestions. p.s. didn't add new tests (in this commit) - standalone repo is not trivial (objc

[Lldb-commits] [PATCH] D39884: [lldb] Remove unused method declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL317919: [lldb] Remove unused method declaration (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D39884?vs=122379&id=122493#toc Repository: rL LLVM https://reviews.llvm.org/

[Lldb-commits] [PATCH] D39825: [lldb] Ensure that dwo/dwp are not double-indexed

This revision was automatically updated to reflect the committed changes. Closed by commit rL318554: [lldb] Ensure that dwo/dwp are not double-indexed (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D39825?vs=122389&id=123403#toc Repository: rL LLVM https://reviews

[Lldb-commits] [PATCH] D40587: [lldb] Minor fixes for in TaskPool

alexshap created this revision. 1. Move everything into the namespace lldb_private 2. Add missing std::move in TaskPoolImpl::Worker 3. std::thread::hardware_concurrency may return 0, handle this case correctly Repository: rL LLVM https://reviews.llvm.org/D40587 Files: include/lldb/Host/Tas

[Lldb-commits] [PATCH] D40587: [lldb] Minor fixes for in TaskPool

alexshap updated this revision to Diff 124661. alexshap added a comment. fix the tests Repository: rL LLVM https://reviews.llvm.org/D40587 Files: include/lldb/Host/TaskPool.h source/Host/common/TaskPool.cpp unittests/Host/TaskPoolTest.cpp Index: unittests/Host/TaskPoolTest.cpp ==

[Lldb-commits] [PATCH] D40587: [lldb] Minor fixes in TaskPool

This revision was automatically updated to reflect the committed changes. Closed by commit rL319492: [lldb] A few minor fixes in TaskPool (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D40587?vs=124661&id=125036#toc Repository: rL LLVM https://reviews.llvm.org/D40

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap created this revision. alexshap added reviewers: tberghammer, labath, clayborg. Herald added subscribers: llvm-commits, JDevlieghere, aprantl. A small test where the issue is easy to reproduce: a.cpp: int f() { return 1; } b.cpp: extern int f(); void g() { int y = 14;

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap added a comment. @davide - the test case is in the description but i can try to add it to the test suite. Repository: rL LLVM https://reviews.llvm.org/D42563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap added a comment. @tberghammer > ELF specific as nothing really ties SymbolFileDWARF with the ELF format the only reason why it's currently guarded to ELF is the fact that for Mach-O uuid also encodes something and i didn't want to change that (see the comment in the old version of the

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:67-68 + lldb_private::ArchSpec arch; + if (dwarf->GetObjectFile()->GetArchitecture(arch) && + arch.GetTriple().isOSBinFormatELF()) { +// For SymbolFileDWARFDwo/SymbolFileDWARFDwoDwp

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap updated this revision to Diff 131920. alexshap added a comment. Update, rerun the tests. Repository: rL LLVM https://reviews.llvm.org/D42563 Files: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile packages/Python/lldbsuite/test/linux/mix-dwo-and-regular

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap updated this revision to Diff 131921. alexshap added a comment. fix typo Repository: rL LLVM https://reviews.llvm.org/D42563 Files: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMix

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap updated this revision to Diff 131922. alexshap added a comment. one more update Repository: rL LLVM https://reviews.llvm.org/D42563 Files: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap updated this revision to Diff 131924. alexshap added a comment. fix comment https://reviews.llvm.org/D42563 Files: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMixedDwarfBinary.py p

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap updated this revision to Diff 131938. alexshap added a comment. Update makefile Repository: rL LLVM https://reviews.llvm.org/D42563 Files: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap added inline comments. Comment at: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:10-12 +.PHONY: clean +clean:: + $(RM) -f a.dwo a.o b.o main tberghammer wrote: > Do you need this? I think Makefile.rules should generate

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

This revision was automatically updated to reflect the committed changes. Closed by commit rL323832: [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf (authored by alexshap, committed by ). Changed prior to commit: https://reviews.llvm.org/D42563?vs=131938&id=132067#toc R

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

alexshap created this revision. Herald added a subscriber: JDevlieghere. A *.dwo file itself can have DW_AT_GNU_dwo_name (but no DW_AT_comp_dir) (clang 4.0 generates such DWOs). In this case there is no need to try to get a new module, and, more over, if we try (below) the method ModuleList::Ge

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

alexshap added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1644-1656 +// A *.dwo file itself can have DW_AT_GNU_dwo_name (but no +// DW_AT_comp_dir) (clang 4.0 generates such DWOs). In this case +// there is

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

alexshap added a comment. @clayborg, many thanks for the review, i've added above a comment with more details about the issue (to the best my knowledge). Repository: rL LLVM https://reviews.llvm.org/D37295 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

alexshap added a comment. @clayborg - yeah, many thanks for the comments > Does this seem like it is a compiler bug yeah, i think it might be the case, although right now i can't say for sure and i need to consult with the DWO spec > If this is a long released compiler generating this, then we

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

alexshap added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D37295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

This revision was automatically updated to reflect the committed changes. Closed by commit rL313083: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D37295?vs=113249&id=114923#toc Repository:

[Lldb-commits] [PATCH] D38492: [lldb] Fix initialization of m_debug_cu_index_map

alexshap created this revision. Herald added subscribers: JDevlieghere, aprantl. SymbolFileDWARFDwp contains m_debug_cu_index_map which was previously initialized incorrectly: before m_debug_cu_index.parse is called m_debug_cu_index is empty, thus the map was not actually getting populated prope

[Lldb-commits] [PATCH] D38492: [lldb] Fix initialization of m_debug_cu_index_map

This revision was automatically updated to reflect the committed changes. Closed by commit rL314832: [lldb] Fix initialization of m_debug_cu_index_map (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D38492?vs=117470&id=117570#toc Repository: rL LLVM https://reviews

[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

alexshap created this revision. Herald added subscribers: JDevlieghere, aprantl. Previously LLDB required dwp to be located next to the executable file (see the code in SymbolFileDWARF::GetDwpSymbolFile). This diff uses the helper function Symbols::LocateExecutableSymbolFile to search for DWP file

[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

alexshap added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D38568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

alexshap updated this revision to Diff 118250. alexshap added a comment. Ignore the UUID comparison if the UUID field is not valid (in this case the interface seems to be a bit cleaner (module_spec is the single source of truth (without extra parameters)) Repository: rL LLVM https://reviews

[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

This revision was automatically updated to reflect the committed changes. Closed by commit rL315387: [lldb] Enable using out-of-tree dwps (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D38568?vs=118250&id=118504#toc Repository: rL LLVM https://reviews.llvm.org/D38

[Lldb-commits] [PATCH] D27115: [cleanup] Fix typos in file headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL287966: [lldb] Fix typos in file headers (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D27115?vs=79259&id=79329#toc Repository: rL LLVM https://reviews.llvm.org/D27115 F

[Lldb-commits] [PATCH] D27177: [lldb] Fix compilation of SymbolFileDWARF.cpp with ENABLE_DEBUG_PRINTF set

alexshap created this revision. alexshap added reviewers: labath, sas. alexshap added a subscriber: LLDB. alexshap set the repository for this revision to rL LLVM. This diff adds missing semicolon in SymbolFileDWARF.cpp . Repository: rL LLVM https://reviews.llvm.org/D27177 Files: source/Pl

[Lldb-commits] [PATCH] D27177: [lldb] Fix compilation of SymbolFileDWARF.cpp with ENABLE_DEBUG_PRINTF set

This revision was automatically updated to reflect the committed changes. Closed by commit rL288094: [lldb] Fix compilation of SymbolFileDWARF.cpp with ENABLE_DEBUG_PRINTF set (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D27177?vs=79465&id=79481#toc Repository: r

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

alexshap added inline comments. Comment at: include/lldb/Core/FastDemangle.h:22 +char * +FastDemangle(const char *mangled_name, size_t mangled_name_length, + std::function primitive_type_hook = nullptr); some thoughts: (also i assume i might be mista

[Lldb-commits] [PATCH] D27380: [lldb] Update the check for Linux or FreeBSD in SymbolFileDWARF::FindFunctions.

alexshap created this revision. alexshap added reviewers: clayborg, spyffe. alexshap added a subscriber: lldb-commits. alexshap set the repository for this revision to rL LLVM. This diff 1. Adds a comment to ObjectFileELF.cpp about the current approach to determining the OS. 2. Replaces the che

[Lldb-commits] [PATCH] D27380: [lldb] Update the check for Linux or FreeBSD in SymbolFileDWARF::FindFunctions.

alexshap updated this revision to Diff 80278. alexshap added a comment. Address comments Repository: rL LLVM https://reviews.llvm.org/D27380 Files: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Index: source/Plugins/SymbolFile/DWARF

[Lldb-commits] [PATCH] D27380: [lldb] Update the check for Linux or FreeBSD in SymbolFileDWARF::FindFunctions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288687: [lldb] Update the check for Linux or FreeBSD in SymbolFileDWARF::FindFunctions (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D27380?vs=80278&id=80295#toc Repository: