alexshap added inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:67-68
+ lldb_private::ArchSpec arch;
+ if (dwarf->GetObjectFile()->GetArchitecture(arch) &&
+ arch.GetTriple().isOSBinFormatELF()) {
+ // For SymbolFileDWARFDwo/SymbolFileDWARFDwoDwp
----------------
clayborg wrote:
> Why do this arch check? check? Why not just get rely on
> dwarf->GetBaseCompileUnit()? Seem like we are doing more work than needed.
the only reason why it's currently guarded to ELF is the fact that
for Mach-O uuid also encodes something (if i am not mistaken) and i didn't want
to change that (see the comment in the old version of the code)
(although i don't know if it's up to date).
If we don't need to check that we are dealing with ELF - I'm more than happy to
remove it.
Repository:
rL LLVM
https://reviews.llvm.org/D42563
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
