[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

xiaobai added inline comments. Comment at: lldb/source/Breakpoint/BreakpointInjectedSite.cpp:341 + "\n" + " typedef unsigned intuint32_t;\n" + " typedef unsigned long long uint64_t ;\n" labath wrote: > aprantl wrote

[Lldb-commits] [PATCH] D66811: [dotest] Remove results port

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66811/new/ https://reviews.llvm.org/D66811 ___ lldb-commi

[Lldb-commits] [PATCH] D66858: POSIX DYLD: add workaround for android L loader

xiaobai accepted this revision. xiaobai added a comment. Herald added a subscriber: JDevlieghere. LGTM, small typo tho Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:553 + // reported. Attempt to discover it based on the load address of the object + /

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai created this revision. xiaobai added reviewers: clayborg, JDevlieghere, jingham. Herald added a project: LLDB. DumpDataExtractor uses ClangASTContext in order to get the proper llvm fltSemantics for the type it needs so that it can dump floats in a more precise way. However, there's no rea

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai added a comment. Hmm, good question. If you call `GetAPInt` with a `byte_size` of 0, it should assert when trying to read 0 bytes with the `DataExtractor`. In the worst case, it gives you a broken APInt. I think guarded the call to `GetAPInt` to protect against this, but I think that it

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai updated this revision to Diff 219145. xiaobai added a comment. Refactored slightly to be a bit safer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67239/new/ https://reviews.llvm.org/D67239 Files: lldb/include/lldb/Symbol/ClangASTContext

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

This revision was automatically updated to reflect the committed changes. Closed by commit rL371258: [Core] Remove use of ClangASTContext in DumpDataExtractor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, compnerd, davide, clayborg. Herald added a project: LLDB. InferiorCallPOSIX directly grabs a ClangASTContext from the Target it has and does no error checking. I don't think these functions have a reason to know about clang spec

[Lldb-commits] [PATCH] D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX

This revision was automatically updated to reflect the committed changes. Closed by commit rL371654: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, compnerd, labath. Herald added a project: LLDB. InferiorCall is only ever used in Process, and it is not specific to POSIX. By moving it to Process, we can remove all dependencies on plugins from Process. Moving Inferi

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai updated this revision to Diff 220018. xiaobai added a comment. Rename InferiorCall to CallNoArgNoReturnFunc make CallNoArgReturnFunc public Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 Files: l

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai updated this revision to Diff 220023. xiaobai added a comment. Rename function in question to CallVoidArgVoidPtrReturn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 Files: lldb/include/lldb/Targ

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

This revision was automatically updated to reflect the committed changes. Closed by commit rL371796: [Target] Move InferiorCall to Process (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

xiaobai added inline comments. Herald added a subscriber: dexonsmith. Comment at: lldb/test/CMakeLists.txt:103 + ${system_debugserver_path} ${LLVM_RUNTIME_OUTPUT_INTDIR} + COMMENT "Copying the system debugserver to LLDB's binaries directory for testing.") message(

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. No objections from me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67991/new/ https://reviews.llvm.org/D67991 ___ lldb-commits maili

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

xiaobai added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3029 Log *log = LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO); - TypeSP type_sp = dwarf_ast->ParseTypeFromDWARF(sc, die, log, type_is_new_ptr); + + TypeSP type_sp; --

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

xiaobai added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) Doesn't this now include the `lldb-private` headers now? Is that intended? Repository: rL LLVM

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

xiaobai added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) hhb wrote: > xiaobai wrote: > > Doesn't this now include the `lldb-private` headers now? Is that in

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68039/new/ https://reviews.llvm.org/D68039 ___ lldb-commi

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

xiaobai added a comment. In D68048#1683238 , @clayborg wrote: > > There are some things still left. > > > > architecture: > > I don't know if we can simply reuse an existing variable and set it for > > all processes, or if we should really find the arch

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

xiaobai added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:240 + +bool parsePsHeader(const std::string &line, PsColumnsIndices &indices) { + std::stringstream line_stream(line); You could return the PsColu

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:110 do { - DeclVendor *modules_decl_vendor = - m_target->GetClangModulesDeclVendor(); + auto *modules_

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

xiaobai added inline comments. Comment at: source/API/CMakeLists.txt:99-100 lldbUtility +lldbPluginObjectContainerBSDArchive +lldbPluginObjectContainerMachOArchive ${LLDB_ALL_PLUGINS} These should get sucked into LLDB_ALL_PLUGINS right? Reposi

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

xiaobai added inline comments. Comment at: source/API/SystemInitializerFull.cpp:132-133 + ObjectContainerBSDArchive::Initialize(); + ObjectContainerUniversalMachO::Initialize(); + You need to include the headers for these classes Repository: rLLDB LLDB C

[Lldb-commits] [PATCH] D61362: lldb-server: remove link against lldbInterpreter

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Seems like the right thing to do. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61362/new/ https://reviews.llvm.org/D61362 _

[Lldb-commits] [PATCH] D61659: Fix bug in ArchSpec::MergeFrom

xiaobai added a comment. Ah, this was my bad. Thanks for taking care of this. Comment at: unittests/Utility/ArchSpecTest.cpp:188-193 +EXPECT_EQ(llvm::Triple::ArchType::arm, B.GetTriple().getArch()); +EXPECT_EQ(llvm::Triple::VendorType::UnknownVendor, + B.Ge

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, jingham, clayborg. Herald added a subscriber: mgorny. Breakpoint shouldn't need to depend on any specific details from a programming language. Currently the only language-specific detail it takes advantage of are the different q

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

xiaobai added a comment. Thanks for the feedback! I don't quite feel that "Method" is a great descriptor here either, but I think that it's probably fine for now until we can think of a better name. I'll update this when I get the chance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

xiaobai updated this revision to Diff 198911. xiaobai added a comment. Rework function GetVariantMethodNames -> GetMethodNameVariants CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61746/new/ https://reviews.llvm.org/D61746 Files: include/lldb/Target/Language.h source/Breakpoint/Bre

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai created this revision. xiaobai added reviewers: davide, JDevlieghere, jingham, kubamracek, clayborg. I don't think there's a good reason for this behavior to be considered ObjC-specific. We can generalize this. https://reviews.llvm.org/D61776 Files: source/Target/Thread.cpp Index: s

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai added a comment. In D61776#1498225 , @jingham wrote: > If you really are going to support many languages you need to figure out how > to tell folks what really happened with more specificity. I agree. > For instance, you can use C++ to throw an

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai updated this revision to Diff 199048. xiaobai added a comment. Add comments to give better context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61776/new/ https://reviews.llvm.org/D61776 Files: source/Target/Thread.cpp Index: source/Target/Thread.cpp ==

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

xiaobai updated this revision to Diff 199113. xiaobai added a comment. - Fix minor bug - Return vector by value instead of passing in one by parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61746/new/ https://reviews.llvm.org/D61746 Files: include/lldb/Target/Language.h sou

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rL360509: [Breakpoint] Make breakpoint language agnostic (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAS

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai added a comment. Unfortunately I can't land this patch as-is. With this patch applied, TestObjCExceptions fails. It looks like c++ exceptions are supported at the bare minimum as a part of the objc exception handling logic. It was failing 2 subtests: `test_objc_exceptions_at_throw` and

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai updated this revision to Diff 199364. xiaobai added a comment. - Fix minor bug in ItaniumABILanguageRuntime - Modify test to accomodate new behavior CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61776/new/ https://reviews.llvm.org/D61776 Files: packages/Python/lldbsuite/test/

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai created this revision. xiaobai added reviewers: jingham, JDevlieghere. When creating a ThreadPlan to step through a trampoline, we ask the ObjC language runtime and the CPP language runtime to come up with such a thread plan if the dynamic loader fails to give us one. I don't see why this

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai marked 2 inline comments as done. xiaobai added inline comments. Comment at: source/Target/ThreadPlanStepThrough.cpp:91 + if (!m_sub_plan_sp) { +for (unsigned lang = eLanguageTypeUnknown; + !m_sub_plan_sp && lang < eNumLanguageTypes; lang++) { ---

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai added a comment. In D61921#1502254 , @jingham wrote: > There is a TypeSystemEnumerateSupportedLanguages that we use so that we don't > have to enumerate over all the language in the languages enums. After all > the plugin manager knows which lan

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai added a comment. In D61921#1502338 , @jingham wrote: > Getting it from the Process's m_language_runtimes is probably fine. On > reflection, I can't think of a reason why you would want to iterate over all > the available LanguageRuntimes, includ

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360741: [Target] Generalize some behavior in Thread (authored by xiaobai, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai added a comment. In D61921#1503282 , @jingham wrote: > In D61921#1502502 , @labath wrote: > > > If this iteration is going to be used a lot, I'd recommend taking a bit of > > time to implement an iterator a

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

xiaobai added a comment. Seems like an overall improvement to the structure of this code. At the high level, the structure feels easier to understand. In D61994#1504336 , @labath wrote: > I think this is a bit more readable. I've included some suggestion

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

xiaobai added a comment. I noticed you have lots of comments that say "Release has different values for these variables". I think that you could instead guard the Release configuration behind a check. For example: if (CMAKE_BUILD_TYPE MATCHES Release) # Do the release configuration stuff

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

xiaobai added inline comments. Comment at: lldb/cmake/caches/Apple-lldb-macOS.cmake:18 +set(CMAKE_BUILD_TYPE RelWithDebInfo) +set(LLVM_ENABLE_MODULES ON CACHE BOOL "") xiaobai wrote: > labath wrote: > > sgraenitz wrote: > > > compnerd wrote: > > > > sgraenitz wro

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

xiaobai added a comment. In D61952#1506608 , @sgraenitz wrote: > @xiaobai Out of interest: have you faced overwrite issues when running > `install` and would this patch help? It's been a while since I've looked at in detail but I don't remember having

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

xiaobai added a comment. Landed -- r361079 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61833/new/ https://reviews.llvm.org/D61833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361079: Fix IPv6 support on lldb-server platform (authored by xiaobai, committed by ). Changed prior to commit: https://reviews.llvm.org/D61833?vs=199619&id=200108#toc Repository: rLLDB LLDB CHAN

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

xiaobai added a comment. This broke windows buildbots. I tried to fix with svn r361083 but there were other things that got broken. @aadsm: We should revisit this patch next week and see what we need to fix up before it goes in. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D62159: LLGS: support 32-bit on 64-bit hosts

xiaobai added a comment. Unsure about the MIPS one but the ARM/ARM64 one looks right to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62159/new/ https://reviews.llvm.org/D62159 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

xiaobai added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1257-1259 + +// We currently only support extracting values with Clang QualTypes. Do we +// care about others? I don't see any references to clang in

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

xiaobai added a comment. This is a much nicer solution. Thanks for doing this. Comment at: lldb/tools/debugserver/source/CMakeLists.txt:268 + if(LLDB_BUILD_FRAMEWORK) +lldb_add_to_framework(lldb-argdumper) + endif() This should be `debugserver`. Reposit

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

xiaobai added a comment. Thanks for doing this work! I'd love to see a faster LLDB. :) Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2697-2717 + std::string xfer_object; + if (packet.GetStringBeforeChar(xfer_object, ':') == 0) +r

[Lldb-commits] [PATCH] D62562: [Target] Introduce Process::GetLanguageRuntimes

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, davide, jingham. Currently there's not really a good way to iterate over the language runtimes a process has. This is sometimes desirable (as seen in my change to Thread). Additionally, there's not really a good reason to iterat

[Lldb-commits] [PATCH] D62562: [Target] Introduce Process::GetLanguageRuntimes

xiaobai updated this revision to Diff 201959. xiaobai added a comment. Address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62562/new/ https://reviews.llvm.org/D62562 Files: include/lldb/Target/Language.h include/lldb/Target/Process.h source/Target/Language.cpp

[Lldb-commits] [PATCH] D62562: [Target] Introduce Process::GetLanguageRuntimes

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361999: [Target] Introduce Process::GetLanguageRuntimes (authored by xiaobai, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D62562?vs=201959&id=20199

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai updated this revision to Diff 202013. xiaobai added a comment. Update to reflect the recently added method Process::GetLanguageRuntimes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61921/new/ https://reviews.llvm.org/D61921 Files: include/lldb/Target/CPPLanguageRuntime.h i

[Lldb-commits] [PATCH] D62626: Remove length modifier when using assignment suppression in TimerTest

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62626/new/ https://reviews.llvm.org/D62626 _

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai added a comment. @jingham @JDevlieghere Mind giving this a quick look? I modified it to use the new method I added earlier and wanted to make sure there were no outstanding issues here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61921/new/ https://reviews.llvm.org/D61921

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

This revision was automatically updated to reflect the committed changes. Closed by commit rL362164: [Target] Generalize language-specific behavior in ThreadPlanStepThrough (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

[Lldb-commits] [PATCH] D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled.

xiaobai added a comment. Seems good to me. Comment at: lldb/lit/Settings/TestFrameFormatColor.test:12 +# Check the ASCII escape code +# CHECK:  I don't see any escape code here, I assume phabricator is just not showing them? 😛 Repository: rLLDB LLDB CHA

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

xiaobai created this revision. xiaobai added reviewers: compnerd, davide, JDevlieghere, jingham, clayborg, labath, aprantl. I want to remove this method because I think that Process should be language agnostic, or at least, not have knowledge about specific language runtimes. There is "GetLanguag

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

xiaobai marked an inline comment as done. xiaobai added a comment. In D62755#1525790 , @jingham wrote: > This seems like carrying purity a little too far. I disagree that it is "carrying purity a little too far". My goal is to see LLDB's non-plugin libr

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

xiaobai added a comment. In D62755#1525890 , @aprantl wrote: > Those are good goals. Thank you for working on this! Thank you for taking the time to review this and discuss this with me! :) > I don't yet see the connection between those goals and this p

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

xiaobai added a comment. In D62755#1525890 , @aprantl wrote: > I don't yet see the connection between those goals and this patch, but I > might be missing something. Would CPPLanguageRuntime need to be anything but > a forward declaration in Process.h?

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

xiaobai added a comment. In D62755#1525937 , @jingham wrote: > Yeah, getting CPPLanguageRuntime out of the general forward declarations does > seem a worthy goal. But it would be great to do it in a way that doesn't add > so much line noise. I added th

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

xiaobai updated this revision to Diff 202523. xiaobai added a comment. Jim's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62755/new/ https://reviews.llvm.org/D62755 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/Process.h include/lldb/lldb-forward

[Lldb-commits] [PATCH] D62788: [lldb-server unittest] Add missing teardown logic

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62788/new/ https://reviews.llvm.org/D62788 __

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

xiaobai requested changes to this revision. xiaobai added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:32 +case llvm::Triple::ArchType::aarch64_32: + cpu = llvm::c

[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

xiaobai created this revision. xiaobai added reviewers: compnerd, labath, JDevlieghere, davide. LookupRuntimeSymbol seems like a general LanguageRuntime method. Although no other language runtime currently implements this, there's no reason another language runtime couldn't use this. Additionally

[Lldb-commits] [PATCH] D62796: [Target] Generalize some behavior in Target::SymbolsDidLoad

xiaobai created this revision. xiaobai added reviewers: compnerd, JDevlieghere, davide, labath. SymbolsDidLoad is currently only implemented for ObjCLanguageRuntime, but that doesn't mean that it couldn't be useful for other Langauges. Although this change seems like it's generalizing for the sake

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

xiaobai created this revision. xiaobai added reviewers: compnerd, davide, labath, JDevlieghere, aprantl, jingham. Herald added a subscriber: mgorny. PersistentStateExpressions (e.g. ClangPersistentVariables) have the ability to define types using expressions that persist throughout the debugging

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Commands/CommandObjectMemory.cpp:479 +if (persistent_vars->SetCompilerTypeFromPersistentDecl( +lookup_type_name, clang_ast_type)) + break;

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

xiaobai marked an inline comment as done. xiaobai added a comment. In D62755#1527004 , @labath wrote: > However, I just want to add that from an lldb-server POV, even the fact that > we pull in the `Process` class into it's dependency graph is a bug. Ag

[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

xiaobai added a comment. In D62795#1527035 , @labath wrote: > If this is supposed to be truly language-agnostic, shouldn't we be iterating > over all language plugins and asking all of them for the "runtime symbol" > (not that I know what a runtime symbo

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Expression/ExpressionVariable.h:235-236 + virtual bool SetCompilerTypeFromPersistentDecl(ConstString type_name, + CompilerType &com

[Lldb-commits] [PATCH] D62796: [Target] Generalize some behavior in Target::SymbolsDidLoad

xiaobai marked 2 inline comments as done. xiaobai added inline comments. Comment at: source/Target/Target.cpp:1670 if (m_process_sp) { - LanguageRuntime *runtime = - m_process_sp->GetLanguageRuntime(lldb::eLanguageTypeObjC); - if (runtime) { -ObjCL

[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

xiaobai updated this revision to Diff 202763. xiaobai added a comment. Make the behavior in IRExecutionUnit actually language agnostic. Also, reverse the order of the for loops. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62795/new/ https://reviews.llvm.org/D62795 Files: include/l

[Lldb-commits] [PATCH] D62796: [Target] Generalize some behavior in Target::SymbolsDidLoad

xiaobai updated this revision to Diff 202782. xiaobai added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62796/new/ https://reviews.llvm.org/D62796 Files: include/lldb/Target/LanguageRuntime.h include/lldb/Target/ObjCLanguageRuntime.h source/Target/Ta

[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:270-272 - virtual lldb::addr_t LookupRuntimeSymbol(ConstString name) { -return LLDB_INVALID_ADDRESS; - } clayborg wrote: > Which l

[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:270-272 - virtual lldb::addr_t LookupRuntimeSymbol(ConstString name) { -return LLDB_INVALID_ADDRESS; - } clayborg wrote: > xiaobai

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

xiaobai updated this revision to Diff 202805. xiaobai added a comment. Pavel's suggestion Renamed method from "SetCompilerTypeFromPersistentDecl" to "GetCompilerTypeFromPersistentDecl" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62797/new/ https://reviews.llvm.org/D62797 Files: in

[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

This revision was automatically updated to reflect the committed changes. Closed by commit rL362458: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository

[Lldb-commits] [PATCH] D62796: [Target] Generalize some behavior in Target::SymbolsDidLoad

This revision was automatically updated to reflect the committed changes. Closed by commit rL362461: [Target] Generalize some behavior in Target::SymbolsDidLoad (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHAN

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/CPPLanguageRuntime.h:47 + static CPPLanguageRuntime *GetCPPLanguageRuntime(Process &process) { +return static_cast( +process.GetLanguageRuntime(lldb::eLanguageTyp

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362543: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register (authored by xiaobai, committed by ). H

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

This revision was automatically updated to reflect the committed changes. Closed by commit rL362544: [Target] Remove Process::GetCPPLanguageRuntime (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAS

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

xiaobai accepted this revision. xiaobai added a comment. Seems fine to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62879/new/ https://reviews.llvm.org/D62879 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl

xiaobai added a comment. In D62797#1528483 , @jingham wrote: > I have no problem with the change in general. However, you've introduced the > possibility of name collision between convenience type definition in various > languages. So it would be good

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

xiaobai created this revision. xiaobai added reviewers: labath, JDevlieghere. Herald added a subscriber: arphaman. Using llvm-style rtti gives us stronger guarantees around casting LanguageRuntimes. As discussed in D62755 https://reviews.llvm.org/D62934 Files:

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

xiaobai updated this revision to Diff 203420. xiaobai added a comment. Implement labath's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62934/new/ https://reviews.llvm.org/D62934 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/LanguageRuntime.h incl

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl

xiaobai updated this revision to Diff 203483. xiaobai added a comment. Renamed `clang_ast_type` to `compiler_type` to be more general. Allow for disambiguating by language with the flag `-x` or `--language`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62797/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D62943: DWARF: Simplify SymbolFileDWARF::GetDWARFCompileUnit

xiaobai added a comment. Just a heads up: I reverted this change (rL362862 ) because it broke the test suite on macOS. Breakpoints were not being resolved correctly. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62943/new/ http

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

This revision was automatically updated to reflect the committed changes. Closed by commit rL362884: [LanguageRuntime] Introduce LLVM-style casts (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai created this revision. xiaobai added reviewers: compnerd, davide, JDevlieghere, jingham, aprantl, labath. Herald added a subscriber: arphaman. In an effort to make Process more language agnostic, I removed GetCPPLanguageRuntime from Process. I'm following up now with an equivalent change

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai updated this revision to Diff 203714. xiaobai added a comment. Small cleanups CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63052/new/ https://reviews.llvm.org/D63052 Files: include/lldb/Target/ObjCLanguageRuntime.h include/lldb/Target/Process.h include/lldb/lldb-forward.

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202 + static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) { +return llvm::cast_or_null( labath wrote: > compnerd

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai updated this revision to Diff 203872. xiaobai added a comment. Simplify a change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63052/new/ https://reviews.llvm.org/D63052 Files: include/lldb/Target/ObjCLanguageRuntime.h include/lldb/Target/Process.h include/lldb/lldb-forwa

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202 + static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) { +return llvm::cast_or_null( labath wrote: > xiaobai

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai updated this revision to Diff 203877. xiaobai added a comment. ObjCLanguageRuntime::GetObjCLanguageRuntime -> ObjCLanguageRuntime::Get CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63052/new/ https://reviews.llvm.org/D63052 Files: include/lldb/Target/ObjCLanguageRuntime.h i

<    7   8   9   10   11   12   13   14   >