xiaobai added inline comments.
================
Comment at:
lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:240
+
+bool parsePsHeader(const std::string &line, PsColumnsIndices &indices) {
+ std::stringstream line_stream(line);
----------------
You could return the PsColumsnIndices directly instead of returning the bool,
then have the caller check for validity.
================
Comment at:
lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:302
+ std::string output;
+ auto status = adb.Shell(command.c_str(), std::chrono::seconds(5), &output);
+ if (status.Fail()) {
----------------
Where does 5 seconds come from here?
================
Comment at:
lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:340
+ } else {
+ return PlatformRemoteGDBServer::FindProcesses(match_info, process_infos);
+ }
----------------
nit: remove the else
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68048/new/
https://reviews.llvm.org/D68048
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
