amccarth added a comment.
I'm re-running the tests now, but I agree this is probably not worth holding up
this patch.
http://reviews.llvm.org/D12651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
amccarth added a comment.
It seems to be general flakiness. In three runs without the patch, I got the
lower numbers every time. In three runs with the patch, I got higher numbers
twice and the lower numbers once.
I have no objection to this patch based on this.
http://reviews.llvm.org/D126
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
This includes a dump file captured using Visual Studio, of the enclosed sample
program, which was also build with Visual Studio.
The tests just verify that LLDB can access some very bas
amccarth marked 2 inline comments as done.
amccarth added a comment.
> Instead of test/functionalities/minidump, I would probably call this
> test/functionalities/core-file/windows.
Hmm...
There is talk of (eventually) debugging minidumps on other platforms. Also
some crash capture tools can
amccarth added a comment.
In http://reviews.llvm.org/D12888#247212, @zturner wrote:
> In http://reviews.llvm.org/D12888#247195, @amccarth wrote:
>
> > > Instead of test/functionalities/minidump, I would probably call this
> > > test/functionalities/core-file/windows.
> >
> >
> > Hmm...
> >
> > T
amccarth updated this revision to Diff 34906.
amccarth added a comment.
Addressed earlier comments and moved to functionalities\postmortem\minidump
http://reviews.llvm.org/D12888
Files:
test/functionalities/postmortem/minidump/TestMiniDump.py
test/functionalities/postmortem/minidump/fizzbuz
Author: amccarth
Date: Wed Sep 16 13:17:11 2015
New Revision: 247829
URL: http://llvm.org/viewvc/llvm-project?rev=247829&view=rev
Log:
Add first tests for mini-dump debugging.
Differential Revision: http://reviews.llvm.org/D12888
Added:
lldb/trunk/test/functionalities/postmortem/
lldb/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247829: Add first tests for mini-dump debugging. (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12888?vs=34906&id=34909#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12
Author: amccarth
Date: Thu Sep 17 15:52:29 2015
New Revision: 247939
URL: http://llvm.org/viewvc/llvm-project?rev=247939&view=rev
Log:
Get the process ID from a minidump.
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
lldb/trunk/source/Plugins/Process/
amccarth accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Windows/Live/DebuggerThread.cpp:309
@@ -308,1 +308,3 @@
{
+if (m_pid_to_detach != 0 &&
dbe.u.Exception.ExceptionRecord
I'll take a look this morning.
On Tue, Mar 24, 2020 at 7:00 AM Pavel Labath wrote:
> On 23/03/2020 17:17, Frédéric Riss via lldb-commits wrote:
> > The new testing for “inherit-env=false” is failing on Windows. I skipped
> the test for now.
> >
> > Could it be that it never worked there? (In whi
I took a stab at this, but I'm not seeing any new test failures. Can you
point me to the specific test and provide a log showing the failures?
I've been using `ninja check-lldb`, which runs (almost everything) and none
of the failures I'm seeing are related to inherit-env. I assume the
problem y
Oh, and in case I wasn't clear: I re-enabled the test TestSettings.py
locally.
On Tue, Mar 24, 2020 at 5:04 PM Adrian McCarthy wrote:
> I took a stab at this, but I'm not seeing any new test failures. Can you
> point me to the specific test and provide a log showing the failures?
>
> I've been
On Wed, Mar 25, 2020 at 9:10 AM Pavel Labath wrote:
> On 25/03/2020 01:04, Adrian McCarthy wrote:
> > I took a stab at this, but I'm not seeing any new test failures.
>
> That is odd.
>
> I was doing some stuff on windows today, so I figured I'd take a stab at
> this. I was kind of right that the
On Wed, Mar 25, 2020 at 9:49 AM Adrian McCarthy wrote:
>
>
> On Wed, Mar 25, 2020 at 9:10 AM Pavel Labath wrote:
>
>> On 25/03/2020 01:04, Adrian McCarthy wrote:
>> > I took a stab at this, but I'm not seeing any new test failures.
>>
>> That is odd.
>>
>> I was doing some stuff on windows today
Author: Adrian McCarthy
Date: 2020-08-11T13:44:14-07:00
New Revision: 479f5bfdb02b191f03b3de1a7c3d5a5098b3fcaf
URL:
https://github.com/llvm/llvm-project/commit/479f5bfdb02b191f03b3de1a7c3d5a5098b3fcaf
DIFF:
https://github.com/llvm/llvm-project/commit/479f5bfdb02b191f03b3de1a7c3d5a5098b3fcaf.dif
Author: Adrian McCarthy
Date: 2020-08-12T13:56:16-07:00
New Revision: 7ddfb956e1a5ee91d0d30f33ca0c84faeb471db4
URL:
https://github.com/llvm/llvm-project/commit/7ddfb956e1a5ee91d0d30f33ca0c84faeb471db4
DIFF:
https://github.com/llvm/llvm-project/commit/7ddfb956e1a5ee91d0d30f33ca0c84faeb471db4.dif
Author: Adrian McCarthy
Date: 2020-10-12T11:10:00-07:00
New Revision: f21fcccef7197f911a27b960aa2a180e0c7724aa
URL:
https://github.com/llvm/llvm-project/commit/f21fcccef7197f911a27b960aa2a180e0c7724aa
DIFF:
https://github.com/llvm/llvm-project/commit/f21fcccef7197f911a27b960aa2a180e0c7724aa.dif
Author: Adrian McCarthy
Date: 2019-10-25T15:57:52-07:00
New Revision: 5a3c657f3e8fe83ed5074edee94fb2303cd5fa2e
URL:
https://github.com/llvm/llvm-project/commit/5a3c657f3e8fe83ed5074edee94fb2303cd5fa2e
DIFF:
https://github.com/llvm/llvm-project/commit/5a3c657f3e8fe83ed5074edee94fb2303cd5fa2e.dif
It looks like this was the only call to getRerunArgs, so why not delete it?
On Mon, Oct 28, 2019 at 1:24 PM Jonas Devlieghere via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> Author: Jonas Devlieghere
> Date: 2019-10-28T13:24:07-07:00
> New Revision: f8a92af893eee7ac7ffda93c24b9e69df506
Author: amccarth
Date: Thu Aug 1 07:49:54 2019
New Revision: 367573
URL: http://llvm.org/viewvc/llvm-project?rev=367573&view=rev
Log:
Fix TestThreadSpecificBreakpoint on Windows
This test was frequently hanging on Windows, causing a timeout after
10 minutes. The short delay (100 microsecond) in
Does disabling tests really quality a patch for the [NFC] label?
Are these buggy tests or is there something that makes the actually not
relevant on Windows?
On Tue, Sep 3, 2019 at 9:20 AM Raphael Isemann via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: teemperor
> Date: Tue Sep
Author: amccarth
Date: Thu Sep 5 10:22:30 2019
New Revision: 371090
URL: http://llvm.org/viewvc/llvm-project?rev=371090&view=rev
Log:
Fix windows-x86-debug compilation with python enabled using multi-target
generator
[Patch by Leonid Mashinskiy]
Visual Studio CMake generator is multi-target an
Author: amccarth
Date: Fri Sep 13 11:50:39 2019
New Revision: 371882
URL: http://llvm.org/viewvc/llvm-project?rev=371882&view=rev
Log:
Fix error in ProcessLauncherWindows.cpp
Restored missing parens on a function call.
Modified:
lldb/trunk/source/Host/windows/ProcessLauncherWindows.cpp
Modi
Author: amccarth
Date: Fri Jun 7 14:13:30 2019
New Revision: 362844
URL: http://llvm.org/viewvc/llvm-project?rev=362844&view=rev
Log:
Fix lit tests on Windows related to CR+LF
Problem discovered in the breakpoint lit test, but probably exists in others.
lldb-test splits lines on LF. Input files
Author: amccarth
Date: Fri Jun 7 14:14:01 2019
New Revision: 362845
URL: http://llvm.org/viewvc/llvm-project?rev=362845&view=rev
Log:
NFC: Fix typo in a cmake message
Modified:
lldb/trunk/cmake/modules/LLDBConfig.cmake
Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake
URL:
http://llvm.o
Author: amccarth
Date: Tue Jun 25 16:13:16 2019
New Revision: 364361
URL: http://llvm.org/viewvc/llvm-project?rev=364361&view=rev
Log:
Fix a typo in help text.
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp
URL:
I thought the color code was smart enough to figure out whether it was
actually going to an actual terminal or being redirected. Is this hiding a
bug in that logic?
On Wed, Jul 17, 2019 at 10:56 AM Jonas Devlieghere via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jdevlieghere
>
Author: amccarth
Date: Wed Jul 17 15:36:26 2019
New Revision: 366383
URL: http://llvm.org/viewvc/llvm-project?rev=366383&view=rev
Log:
[NFC] Clarify a Cmake status message regarding Python on LLDBConfig
Modified:
lldb/trunk/cmake/modules/LLDBConfig.cmake
Modified: lldb/trunk/cmake/modules/LL
Author: amccarth
Date: Mon Jul 22 10:03:20 2019
New Revision: 366703
URL: http://llvm.org/viewvc/llvm-project?rev=366703&view=rev
Log:
[Windows] Fix race condition between state changes
Patch by Martin Andersson (martin.anders...@evoma.se)
If the process is resumed before the state is changed to
Author: Adrian McCarthy
Date: 2020-07-16T14:44:24-07:00
New Revision: 72958c9ab1cdf18c447778b836f13694a7e4e9e1
URL:
https://github.com/llvm/llvm-project/commit/72958c9ab1cdf18c447778b836f13694a7e4e9e1
DIFF:
https://github.com/llvm/llvm-project/commit/72958c9ab1cdf18c447778b836f13694a7e4e9e1.dif
Author: Adrian McCarthy
Date: 2019-11-21T08:37:35-08:00
New Revision: 3b69f0c5550a229dd6d39e361182cdd7cecc36a4
URL:
https://github.com/llvm/llvm-project/commit/3b69f0c5550a229dd6d39e361182cdd7cecc36a4
DIFF:
https://github.com/llvm/llvm-project/commit/3b69f0c5550a229dd6d39e361182cdd7cecc36a4.dif
Author: Adrian McCarthy
Date: 2020-02-03T14:22:05-08:00
New Revision: c25938d57b1cf9534887313405bc409e570a9b69
URL:
https://github.com/llvm/llvm-project/commit/c25938d57b1cf9534887313405bc409e570a9b69
DIFF:
https://github.com/llvm/llvm-project/commit/c25938d57b1cf9534887313405bc409e570a9b69.dif
Author: Adrian McCarthy
Date: 2020-02-03T14:22:05-08:00
New Revision: 0e362d82b97fe16b5671ceeb2f3e5b6f4ccf00dd
URL:
https://github.com/llvm/llvm-project/commit/0e362d82b97fe16b5671ceeb2f3e5b6f4ccf00dd
DIFF:
https://github.com/llvm/llvm-project/commit/0e362d82b97fe16b5671ceeb2f3e5b6f4ccf00dd.dif
not be loaded
> >
> > and the test doesn't expect that.
> >
> >
> > I'm looking into this, to see if I can get the more specific error
> message back in here again. I may xfail the test if I don't have a patch
> done tonight. I'd rather not
the error text,
>> >
>> > error: symbol file 'FILENAME' does not match any existing module
>> >
>> > but we're now getting,
>> >
>> > error: the object file could not be loaded
>> >
>> > and the test doesn't e
fix the tests?
>
> Jim
>
>
> > On Feb 4, 2020, at 11:18 AM, Adrian McCarthy via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >
> > I see why the behavior is different, but I'm not sure whether the new
> behavior is wrong.
> >
> >
.
> >
> > On Tue, Feb 4, 2020 at 12:07 PM Jim Ingham wrote:
> > Seems like your change is more informative. Could we just fix the tests?
> >
> > Jim
> >
> >
> > > On Feb 4, 2020, at 11:18 AM, Adrian McCarthy via lldb-commits <
> lldb-com
Author: Adrian McCarthy
Date: 2020-02-04T16:37:22-08:00
New Revision: fb0d2d455f56bca239041c8d7ad7b57da1087b35
URL:
https://github.com/llvm/llvm-project/commit/fb0d2d455f56bca239041c8d7ad7b57da1087b35
DIFF:
https://github.com/llvm/llvm-project/commit/fb0d2d455f56bca239041c8d7ad7b57da1087b35.dif
301 - 339 of 339 matches
Mail list logo
