I took a stab at this, but I'm not seeing any new test failures. Can you point me to the specific test and provide a log showing the failures?
I've been using `ninja check-lldb`, which runs (almost everything) and none of the failures I'm seeing are related to inherit-env. I assume the problem you're seeing is in TestSettings.py, but I've never figured out how to run individual Python-based lldb tests since all the dotest.py stuff was re-written. I've started up lldb interactively and tried to emulate the commands that test executes via SBAPI, but everything worked as expected. Adrian. On Tue, Mar 24, 2020 at 8:19 AM Adrian McCarthy <amcca...@google.com> wrote: > I'll take a look this morning. > > On Tue, Mar 24, 2020 at 7:00 AM Pavel Labath <pa...@labath.sk> wrote: > >> On 23/03/2020 17:17, Frédéric Riss via lldb-commits wrote: >> > The new testing for “inherit-env=false” is failing on Windows. I >> skipped the test for now. >> > >> > Could it be that it never worked there? (In which case XFail would be a >> better resolution) >> > Does anyone have easy access to a Windows build to try it out? >> > >> > Thanks, >> > Fred >> >> My guess is that this "defensive check" >> < >> https://github.com/llvm/llvm-project/blob/master/lldb/source/Host/windows/ProcessLauncherWindows.cpp#L26 >> > >> prevents us from passing a completely blank environment. I am tempted to >> just delete it and see what happens, but maybe Adrian is able to do a >> quick test of this? >> >> pl >> >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
