Does disabling tests really quality a patch for the [NFC] label? Are these buggy tests or is there something that makes the actually not relevant on Windows?
On Tue, Sep 3, 2019 at 9:20 AM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: teemperor > Date: Tue Sep 3 09:21:57 2019 > New Revision: 370776 > > URL: http://llvm.org/viewvc/llvm-project?rev=370776&view=rev > Log: > [lldb][NFC] Disable added frame select and all log option test on windows > > Modified: > > lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py > > lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py > > Modified: > lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py?rev=370776&r1=370775&r2=370776&view=diff > > ============================================================================== > --- > lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py > (original) > +++ > lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py > Tue Sep 3 09:21:57 2019 > @@ -11,6 +11,7 @@ class TestFrameSelect(TestBase): > mydir = TestBase.compute_mydir(__file__) > > @no_debug_info_test > + @skipIfWindows > def test_relative(self): > self.build() > > > Modified: > lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py?rev=370776&r1=370775&r2=370776&view=diff > > ============================================================================== > --- > lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py > (original) > +++ > lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py > Tue Sep 3 09:21:57 2019 > @@ -91,6 +91,7 @@ class LogTestCase(TestBase): > self.assertEquals(contents.find("bacon"), 0) > > # Enable all log options and check that nothing crashes. > + @skipIfWindows > def test_all_log_options(self): > if (os.path.exists(self.log_file)): > os.remove(self.log_file) > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
