[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace abandoned this revision. wallace added a comment. With https://reviews.llvm.org/D76470, targets created by lldb-vscode by default are inheriting the debugger's environment. I don't need this change anymore. We can work on providing a flag that disables that default behavior, but that can

[Lldb-commits] [PATCH] D76872: [intel-pt] fix python building

wallace created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. fix PT decoding Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76872 Files: lldb/tools/intel-features/CMakeLists.txt lldb/tools/intel-features/intel-pt/Decoder.cpp

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

wallace updated this revision to Diff 252936. wallace added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/new/ https://reviews.llvm.org/D76872 Files: lldb/tools/intel-features/CMakeLists.txt lldb/tools/in

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

wallace added a comment. His last activity was in Jun 2017. I hope he's still around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/new/ https://reviews.llvm.org/D76872 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D76891: [lldb-vscode] fix breakpoint result ordering

wallace created this revision. wallace added reviewers: clayborg, aadsm, kusmour, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The DAP specifies the following for the SetBreakpoints request: The breakpoints returned are in the same order as the elements of the

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253283. wallace added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testc

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace created this revision. wallace added reviewers: clayborg, kusmour, labath, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 253283. wallace added a comment. cleanup When using source maps for a breakpoint, in order to fin

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py:25-43 +source_basename = 'main.cpp' +source_path = os.path.join(os.getcwd(), source_basename) + +n

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253649. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvsc

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

wallace updated this revision to Diff 253684. wallace added a comment. merge the commits of this diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/new/ https://reviews.llvm.org/D76872 Files: lldb/tools/intel-features/CMakeLists.txt lldb

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253696. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253695. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvsc

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 253748. wallace added a comment. Added a stop command invocation in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ https://reviews.llvm.org/D77107 Files: lldb/test/API/tools/intel-features

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 253748. wallace added a comment. Added a stop command invocation in the test Depends on D76872

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:332 + + object.try_emplace("line", line); + clayborg wrote: > This should do what it was doing before: grab the source line only from the >

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253779. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvsc

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254039. wallace added a comment. Account for dynamically loaded libraries and update the logic for breakpoint events Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Fi

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace added a comment. Some included changes: - Removed the "source" element if the "breakpoint" object returned in breakpoint events - CreateBreakpoint now accepts an optional line number, which is used as fallback if no location is valid - Added a test that asserts breakpoints in dynamicall

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254041. wallace added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testc

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py:50-54 +"rand", # We expect to see a reference to the rand function +# within t

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Several lldb-vscode users have noticed that when a source map rule is invalid (because a folder doesn't exist anymore), the rest of the

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254068. wallace added a comment. Noise, for some reason I can't run clang-format as part of arc lint on this device. I'm running it manually anyway Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ htt

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254067. wallace added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ https://reviews.llvm.org/D77107 Files: lldb/test/API/tools/intel-features/intel-pt/test/Makefile lldb/

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254065. wallace added a comment. Addressed comments Also ran the test in parallel to a 'stress -c 100 -i 100' invocation, and it passed correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ https:

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/test/API/tools/intel-features/intel-pt/test/main.cpp:2-8 + + Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + See https://llvm.org/LICENSE.txt for

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/source/Interpreter/OptionValuePathMappings.cpp:73 changed = true; +idx++; } else { labath wrote: > does this actually change anything? In

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace updated this revision to Diff 254268. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77186/new/ https://reviews.llvm.org/D77186 Files: lldb/source/Interpreter/OptionValuePathMappings.cpp lldb/te

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254280. wallace marked 2 inline comments as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Pytho

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace added a comment. Thanks for the heads up. I think I got a false impression of how comments after accept vs requesting changes work in this repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77186/new/ https://reviews.llvm.org/D77186 __

[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

wallace updated this revision to Diff 254576. wallace added a comment. fix typos I think the quarantine is reducing my IQ overall... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77324/new/ https://reviews.llvm.org/D77324 Files: lldb/source/Int

[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgrang. Herald added a project: LLDB. wallace updated this revision to Diff 254576. wallace added a comment. fix typos I think the quarantine is reducing my IQ overall... In this di

[Lldb-commits] [PATCH] D77328: [intel-mpx] Delete an unnecessary license header

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @labath mentioned to me that test files shouldn't have a license header. I saw this one some days ago, so I'm doing some cleaning. Repository: rG LLV

[Lldb-commits] [PATCH] D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. I agree with the implementation. I also find no way notify the IDE that the user has switched to a different thread or frame in the console, and I actually think it's better this way.

[Lldb-commits] [PATCH] D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/console/TestVSCode_console.py:20 +def check_lldb_command(self, lldb_command, contains_string, assert_msg): +response = self.vscode.request_evaluate('`%s' % (lldb_command)) +output = res

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds support for commands created through the API to support autorepeat. This covers the case of single word and multiword commands. Comprehensive

[Lldb-commits] [PATCH] D77450: Fix LLDB debug builds

wallace created this revision. wallace added reviewers: clayborg, labath, jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A recent change in ThreadPlans introduced this little compilation error. Seems to be related to the work around https://reviews.llvm.org/D76814.

[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

wallace updated this revision to Diff 254981. wallace added a comment. address comments` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77324/new/ https://reviews.llvm.org/D77324 Files: lldb/source/Interpreter/OptionValuePathMappings.cpp lldb/t

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 254990. wallace edited the summary of this revision. wallace added a comment. improve description @labath raised

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 254990. wallace edited the summary of this revision. wallace added a comment. improve description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files: lldb/bindings

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace planned changes to this revision. wallace added a comment. Very good idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 255426. wallace added a comment. Herald added a subscriber: mgorny. - Moved the test to gtest. It's much better this way and I learned gtest - Changed the API. Some notes: Within the scope of a subcommand, the subcommand doesn't know the parent's command name

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 255429. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 Files: lldb/include/lldb/API/SBCommandInterpreter.h lldb/source/API/SBCommandI

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 255445. wallace edited the summary of this revision. wallace added a comment. See the new description of the diff for the updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace updated this revision to Diff 255454. wallace added a comment. wallace updated this revision to Diff 255455. . wallace added a comment.

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace updated this revision to Diff 255455. wallace added a comment. Improve some names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 Files: lldb/bindings/interface/SBCommandInterpreter.i lldb/inclu

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace updated this revision to Diff 255454. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 Files: lldb/bindings/interface/SBCommandInterpreter.i lldb/include/lldb/API/SBCom

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace abandoned this revision. wallace added a comment. Will revisit it whenever I need it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 ___ lldb-commits ma

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace added a comment. Ping ping. This will fix some existing issues reported by users :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 ___ lldb-commits mai

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 256022. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testca

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 256027. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 Files: lldb/include/lldb/API/SBCommandInterpreter.h lldb/source/AP

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

wallace added a comment. This looks really nice. The only thought I have is that you should accept multiple callbacks instead of only one, as the current implementation discards any existing callback if SetProgressCallback is called twice. I know that it'd be rare that two or more callbacks are

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

wallace added a comment. I'm quite happy with it besides the multiple callback thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97739/new/ https://reviews.llvm.org/D97739 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

wallace added a comment. I think that the mechanism used to show progress should be lock-free and mostly unblocked, as it's merely an observer without side effects within LLDB. So from the last thing you said it seems that SBEvent doesn't like a good solution. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace abandoned this revision. wallace marked 7 inline comments as done. wallace added a comment. I'll redo this diff in smaller diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/ https://reviews.llvm.org/D91679 _

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace reclaimed this revision. wallace added a comment. Changed my mind :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/ https://reviews.llvm.org/D91679 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace added a comment. I like that idea, but i'd rather do it in a different patch once we have a second stop event, so that I make sure the entire thing makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

wallace created this revision. wallace added reviewers: clayborg, aadsm. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff ass postRunCommands, which are the counterpart of the preRunCommands. TThey will be executed right a

[Lldb-commits] [PATCH] D100443: [lldb-vscode] Reduce chattiness of progress events

wallace created this revision. wallace added reviewers: clayborg, aadsm. Herald added a subscriber: mgorny. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Progress events internally have a completed count and a total count, which c

[Lldb-commits] [PATCH] D100443: [lldb-vscode] Reduce chattiness of progress events

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:38-78 +const char *ProgressEvent::GetEventName() const { + if (m_event_type == progressStart) +return "progressStart"; + else if (m_event_type == progressEnd) +return "progressEnd"; + e

[Lldb-commits] [PATCH] D100443: [lldb-vscode] Reduce chattiness of progress events

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc88d301a0bc: [lldb-vscode] Reduce chattiness of progress events (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D100740: json

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100740 Files: lldb/include/lldb/Target/Trace.h lldb/source/Commands/CommandObjectTh

[Lldb-commits] [PATCH] D100740: json

wallace updated this revision to Diff 338435. wallace added a comment. only json is left Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 Files: lldb/include/lldb/Target/Trace.h lldb/source/Commands/Co

[Lldb-commits] [PATCH] D100740: json

wallace updated this revision to Diff 339044. wallace retitled this revision from "[trace] Dedup different source lines when dumping instructions + refactor" to "json". wallace added a comment. ready for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79fbbeb41280: [lldb-vscode] Add postRunCommands (authored by wallace). Changed prior to commit: https://reviews.llvm.org/D100340?vs=336942&id=3393

[Lldb-commits] [PATCH] D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console

wallace updated this revision to Diff 339385. wallace added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99974/new/ https://reviews.llvm.org/D99974 Files:

[Lldb-commits] [PATCH] D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a0754b443b: [lldb-vscode] Distinguish shadowed variables in the scopes request (authored by wallace). Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934 +// We first find out which variable names are duplicated +std::unordered_map variable_name_counts; +for (auto i = start_idx; i < end_idx; ++i) { teemperor wrote: >

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When the number of shared libs is massive, there could be hundreds of thousands of short lived progress events sent to the IDE, which makes it irresponsi

[Lldb-commits] [PATCH] D70882: Add environment var LLDBVSCODE_SKIP_INIT_FILES to lldb-vscode

wallace abandoned this revision. wallace added a comment. not needed anymore because of D99974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70882/new/ https://reviews.llvm.org/D70882 _

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

wallace abandoned this revision. wallace added a comment. not needed anymore because of D99974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80659/new/ https://reviews.llvm.org/D80659 _

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace created this revision. wallace added reviewers: clayborg, teemperor. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As a follow up of https://reviews.llvm.org/D99989#inline-953343, I'm now storing std::string instead of cha

[Lldb-commits] [PATCH] D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console

wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:939 if log_file: adaptor_env['LLDBVSCODE_LOG'] = log_file self.process = subprocess.Popen([executable], JDevliegh

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace added a comment. TIL. I'll give it a try Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101131/new/ https://reviews.llvm.org/D101131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934 // We first find out which variable names are duplicated -llvm::DenseMap variable_name_counts; +std::map variable_name_counts; for (auto i = start_idx; i < end_idx; ++i) { ---

[Lldb-commits] [PATCH] D101198: [lldb-vscode] Read requests asynchronously

wallace created this revision. wallace added reviewers: clayborg, kusmour. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, lldb-vscode is reading and processing requests one at a time, which doesn't match exactly the inte

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace updated this revision to Diff 341017. wallace added a comment. now checking if the strings gotten from the API are null or not CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101131/new/ https://reviews.llvm.org/D101131 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/l

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:925 lldb::SBDeclaration declaration = v.GetDeclaration(); -std::string file_name(declaration.GetFileSpec().GetFilename()); const uint32_t line = declaration.GetLine(); i

[Lldb-commits] [PATCH] D101198: [lldb-vscode] Read requests asynchronously

wallace abandoned this revision. wallace added a comment. i'll rather focus on parallelizing symbol preloading Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101198/new/ https://reviews.llvm.org/D101198 _

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:89 + m_start_event_timestamp >= + std::chrono::seconds(3); +} clayborg wrote: > The patch description says 5 seconds, here

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342386. wallace marked 12 inline comments as done. wallace added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 Files: lldb/tools/l

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

wallace updated this revision to Diff 342448. wallace marked 10 inline comments as done. wallace added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 Files: lldb/include

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

wallace updated this revision to Diff 342453. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 Files: lldb/include/lldb/Target/Trace.h lldb/source/Plugins/Trace/intel-pt/Tr

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342650. wallace marked 12 inline comments as done. wallace added a comment. Address all comments - now the reporting timing conditions are in ProgressEvent, which simplifies the other classes - removed the progressInvalid enum by making sure only valid Progr

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342754. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 Files: lldb/tools/lldb-vscode/ProgressEvent.cpp lldb/tools/lldb-vscode/Progr

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

wallace marked 6 inline comments as done. wallace added inline comments. Comment at: lldb/source/Target/Trace.cpp:173 + // instruction's disassembler when possible. + auto calculate_disass = [&](const Address &address, const SymbolContext &sc) { +if (prev_insn.disassembler

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

wallace updated this revision to Diff 342770. wallace marked an inline comment as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/ProgressEvent.h:32 + ProgressEvent(uint64_t progress_id, llvm::StringRef message, +llvm::Optional percentage); clayborg wrote: > Why is there an optional percentage for a start e

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 346335. wallace added a comment. Simplified the constructors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 Files: lldb/tools/lldb-vscode/ProgressEvent.cpp lldb/

[Lldb-commits] [PATCH] D102866: [lldb][intel-pt] Remove old plugin

wallace added a comment. I'll contact them again. Last time I did they didn't reply. And btw, this feature was broken for years and last year i revived this plugin, so I imagine no one was using it. And in terms of features, the new implementation supports the same features Repository: rG L

[Lldb-commits] [PATCH] D102866: [lldb][intel-pt] Remove old plugin

wallace added a comment. Btw, lldb-server for a few months hasn't been supporting the functionalities required by the old plugin, and as no one has complained, I imagine it's been not actively used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. can you include a screenshot of how the view looked before (without the colors)? Also explain that this is done via a mime-type identification and a built-in support in the IDE for

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Very good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://reviews.llvm.org/D84555 ___

[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

wallace created this revision. wallace added reviewers: clayborg, labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace requested review of this revision. The initial implementation of the Intel PT support for LLDB came with some Python support. However, whe

[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

wallace added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:66-69 + std::string error_message; llvm::sys::DynamicLibrary dynlib = - llvm::sys::DynamicLibrary::getPermanentLibrary(spec.GetPath().c_str()); + llvm::sys::DynamicLibrary::getPermanentLibrary

[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

wallace updated this revision to Diff 281334. wallace added a comment. fix incorrect comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84791/new/ https://reviews.llvm.org/D84791 Files: lldb/source/API/SBDebugger.cpp lldb/test/API/tools/int

[Lldb-commits] [PATCH] D84810: [intel-pt] Simplify Python API configuration

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace requested review of this revision. Depends on D84791 . The existing way to configure Intel PT tracing t

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

wallace added a comment. It would be possible as well to have two media types with their corresponding syntax files, one for x86, and another for arm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://reviews.llvm.org/D84555 ___

[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. This is very good for a first implementation. You need to write a test for this as well. Once this works, you have to work on the launcher helper Greg and I mentioned to you that w

[Lldb-commits] [PATCH] D85068: [intel-pt] Refactor 1: rename the namespace

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. Depends on D84810 . The existing namespace

[Lldb-commits] [PATCH] D85070: [intel-pt] Refactor 2: create a new folder structure

wallace created this revision. wallace added a reviewer: clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. Depends on D85068 . The existing fo

<    2   3   4   5   6   7   8   9   10   >