wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
I agree with the implementation.
I also find no way notify the IDE that the user has switched to a different
thread or frame in the console, and I actually think it's better this way.
================
Comment at: lldb/test/API/tools/lldb-vscode/console/TestVSCode_console.py:20
+ def check_lldb_command(self, lldb_command, contains_string, assert_msg):
+ response = self.vscode.request_evaluate('`%s' % (lldb_command))
+ output = response['body']['result']
----------------
just use lldb_command instead of using a formatted string
================
Comment at: lldb/test/API/tools/lldb-vscode/console/TestVSCode_console.py:56
+ self.vscode.get_local_variables(frameIndex=0)
+ # Verify frame #1 is selected in the command interpreter by running
+ # the "frame seelct" command with no frame index which will print the
----------------
frame #0
================
Comment at: lldb/test/API/tools/lldb-vscode/console/TestVSCode_console.py:57
+ # Verify frame #1 is selected in the command interpreter by running
+ # the "frame seelct" command with no frame index which will print the
+ # currently selected frame.
----------------
select
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77347/new/
https://reviews.llvm.org/D77347
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
