wallace added inline comments.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934
// We first find out which variable names are duplicated
- llvm::DenseMap<const char *, int> variable_name_counts;
+ std::map<std::string, int> variable_name_counts;
for (auto i = start_idx; i < end_idx; ++i) {
----------------
JDevlieghere wrote:
> Have you considered an`llvm::StringMap`, it should be more performant.
I've been reading
https://llvm.org/devmtg/2014-04/PDFs/LightningTalks/data_structure_llvm.pdf and
it seems that it's not more performant speed-wise. I imagine it's more
performance space-wise, but here I mostly care about time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101131/new/
https://reviews.llvm.org/D101131
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
