[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. very good start! Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:5-6 +FORWARD_LIST = "FORWARD_LIST" +LIST = "LIST" + remove this ===

[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

wallace added a comment. is this going to be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110804/new/ https://reviews.llvm.org/D110804 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. could you share a screenshot of how this looks like? And thanks for doing this!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ ht

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Much better. Just some better patterns that you could follow. Read my comments. Besides that, now you can unify the tests across libcxx and libstdcpp Comment at:

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113362/new/ https://reviews.llvm.org/D113362 __

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. When you do your tests, don't care too much about std::string yet, as it has its own issues, but instead create a non-standard size type like struct Foo { int a; int b;

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. There are two things that could be added. One is already mentioned in the comments, which is logging error messages in a way that we can track bugs in an automated fashion, as righ

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. just some minor changes. Could you unify these tests with libcxx? Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:10 # before relying on these formatters to

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. discussed offline how to traverse each individual subarray. This might make it impossible to reuse it for queue and stack Comment at: lldb/examples/synthetic/gnu

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:22-27 +def get_object_kind(self, valobj): +type_name = valobj.GetTypeName() +for kind

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. good job! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760

[Lldb-commits] [PATCH] D114403: [formatters] Add a formatter for libstdc++ optional

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Besides adding the formatter and the summary, this makes the libcxx tests also work for this case. This is the polished version of https://reviews.llvm.

[Lldb-commits] [PATCH] D114403: [formatters] Add a formatter for libstdc++ optional

wallace updated this revision to Diff 389058. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114403/new/ https://reviews.llvm.org/D114403 Files: lldb/bindings/interface/SBValue.i lldb/examples/synthetic/gnu_libstdcp

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:14-16 +if valobj.GetNumChildren() >= list_capping_size: +return "(capped) size=" + str(valobj

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace created this revision. wallace added a reviewer: labath. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As suggested by @labath in https://reviews.llvm.org/D114403, we should make the formatter more resilient to corrupted d

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We need to add checks that ensure that some core variables are valid, so that we avoid printing out garbage data. The worst that could happen is that an

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace added a comment. > That said, I'm more worried about the strange interactions between libc++ and > libstdc++ formatters I reported. yes, I'm trying to install libc++ on my machine now Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:24 self.value = se

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. add generic tests for list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114433/new/ https://reviews.llvm.org/D114433 _

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace updated this revision to Diff 389260. wallace added a comment. fix the issue when both formatters run together and apply labath's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114450/new/ https://reviews.llvm.org/D114450 Files:

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/main.cpp:16 -int main() { +int main() { // Set break point at this line. std::unordered_map map; labath wrote: > It'd be better to

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace updated this revision to Diff 389267. wallace added a comment. labath's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114458/new/ https://reviews.llvm.org/D114458 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [PATCH] D114461: [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114461/new/ https://reviews.llvm.org/D114461 _

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

wallace updated this revision to Diff 391513. wallace added a comment. Fix the few issues in Danil's implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new/ https://reviews.llvm.org/D114008 Files: lldb/examples/synthetic/gnu_lib

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels (pre-4.1)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Lgtm, but please include the kernel version for the record Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133778/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels (pre-4.1)

wallace added a comment. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133778/new/ https://reviews.llvm.org/D133778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D135521: [lldb][trace] Add a basic function call dumpdump [1] - Add the command scaffolding

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The command is thread trace dump function-calls and as minimum will require p

[Lldb-commits] [PATCH] D135521: [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding

wallace updated this revision to Diff 466317. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135521/new/ https://reviews.llvm.org/D135521 Files: lldb/source/Commands/CommandObjectThread.cpp lldb/source/Commands/Opt

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff implements the reconstruction algorithm for the call tree and add t

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

wallace updated this revision to Diff 467605. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135917/new/ https://reviews.llvm.org/D135917 Files: lldb/include/lldb/Target/TraceDumper.h lldb/source/Commands/CommandObj

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

wallace marked 8 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceDumper.h:213-214 + /// The symbol information of the delimiting instructions. + SymbolInfo first_symbol_info; + SymbolInfo last_symbol_info; + //

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

wallace updated this revision to Diff 467911. wallace marked 7 inline comments as done. wallace added a comment. - address all comments - turn all the structs into classes with safe accessors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135917/new/

[Lldb-commits] [PATCH] D136034: [lldb][trace] Add a basic function call dump [3] - Add a JSON dumper

wallace created this revision. wallace added reviewers: persona0220, jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The JSON dumper is very minimalistic. It pretty much only shows the delimitin

[Lldb-commits] [PATCH] D136371: [trace][intel pt] Correctly treat kernel CPUs as individual threads

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice. I expected something as simple as that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136371/new/ https://reviews.llvm.org/D136371 _

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The low-level decoder might fall into an infinite decoding loop for various r

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace updated this revision to Diff 470047. wallace edited the summary of this revision. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136557/new/ https://reviews.llvm.org/D136557 Files: lldb/include/lldb/Core/Plugin

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty good! I just left cosmetic requests Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:285-312 + if (event.has_tsc) { +if (m_tsc

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:123 /// of a DenseMap because DenseMap can't understand enums. -std::unordered_map events_counts; -size_t total_count = 0; +std::unordered_map events_counts; +uint64

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace updated this revision to Diff 470343. wallace added a comment. address issues and comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136557/new/ https://reviews.llvm.org/D136557 Files: lldb/include/lldb/Core/PluginManager.h lldb/so

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks. Your explanation of why the verbose error is useful was good :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136610/new/ https://revi

[Lldb-commits] [PATCH] D136801: [intelpt] Update Python tests to account for new errrors

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136801/new/ https://reviews.llvm.org/D136801 __

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if the trace will be consumed using `SBTraceCursor`. "threads": [ --

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if the trace will be created not using the CLI or on a machine other than where the

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/API/SBTraceCursor.h:175 + /// if not available. + double GetWallClockTime() const; + /// \} mention here

[Lldb-commits] [PATCH] D137614: [trace] Add a new call graph reconstructor

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:296 std::vector m_item_data; + std::vector m_insn_extra_info; /// The TraceItemKind for each trace item encoded as uint8_t. We don't include jj10306 wrote: > do

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/API/SBTraceCursor.cpp:127-131 +double SBTraceCursor::GetWallClockTime() const { + LLDB_INSTRUMENT_VA(this); + + const auto &maybe_wall_clock_t

[Lldb-commits] [PATCH] D138345: [test][lldb-vscode] Un-realpath coreFile test.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. yep, there's no need for the realpath Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138345/new/ https://reviews.llvm.org/D138345

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

wallace added inline comments. Herald added a reviewer: teemperor. Comment at: lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py:38 +# Exit GUI. +self.child.send(escape_key) +self.expect_prompt() create a method s

[Lldb-commits] [PATCH] D103209: [lldb] Fix gnu_libstdcpp's update methods

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The variable.rst documentation says: If it returns a value, and that value is True, LLDB will be allowed to cache the children and the children count

[Lldb-commits] [PATCH] D103209: [lldb] Fix gnu_libstdcpp's update methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0283abee5c87: [lldb] Fix gnu_libstdcpp's update methods (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace created this revision. wallace added a reviewer: clayborg. Herald added a subscriber: dang. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a basic SB API for creating and stopping traces. Note: This doesn't add an

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace updated this revision to Diff 349376. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/ https://reviews.llvm.org/D103500 Files: lldb/bindings/interface/SBStructuredData.i lldb/bindings/interface/

[Lldb-commits] [PATCH] D103588: [trace] Create a global instruction class

wallace created this revision. wallace added a reviewer: clayborg. Herald added a subscriber: kristof.beyls. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We want to start doing some analisis at instruction level, including stack

[Lldb-commits] [PATCH] D103609: [lldb-vscode] Synchronize calls to SendTerminatedEvent

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103609/new/ https://reviews.llvm.org/D103609 ___

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 350419. wallace added a comment. Addressed the comments except for the "static function that we can call and remove the passing of the instance variable for the report callback all over to the event classes". That's a little bit hard to achieve because the c

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:31-32 +/// +/// This class assumes that errors will be extremely rare compared to the number +/// of correct instructions and storing them as \a ConstString should be fine. +class TraceInstruction {

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added a comment. https://reviews.llvm.org/P8265 is a sample DAP output with these messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 ___ lldb-comm

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace marked 18 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/API/SBStructuredData.h:103 friend class SBBreakpointName; + friend class SBTrace; clayborg wrote: > Is this needed? yes, to access the actual StructuredD

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace updated this revision to Diff 350493. wallace marked an inline comment as done. wallace added a comment. address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/ https://reviews.llvm.org/D103500 Files: lldb/bindings

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace updated this revision to Diff 350495. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103588/new/ https://reviews.llvm.org/D103588 Files: lldb/include/lldb/Target/Trace.h lldb/include/lldb/lldb-e

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:31-32 +/// +/// This class assumes that errors will be extremely rare compared to the number +/// of correct instructions and storing them as \a ConstString should be fine. +class TraceInstruction {

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:31-32 +/// +/// This class assumes that errors will be extremely rare compared to the number +/// of correct instructions and storing them as \a ConstString should be fine. +class TraceInstruction {

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace marked 9 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/Target.h:1137-1141 + llvm::Expected CreateTrace(); + + /// If a \a Trace object is present, this returns it, otherwise a new Trace is + /// created with \a Trace::Cre

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace updated this revision to Diff 350641. wallace marked an inline comment as done. wallace added a comment. address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/ https://reviews.llvm.org/D103500 Files: lldb/bindings

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace updated this revision to Diff 350647. wallace added a comment. improved the documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/ https://reviews.llvm.org/D103500 Files: lldb/bindings/interface/SBStructuredData.i lldb

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace updated this revision to Diff 350652. wallace added a comment. I tried to use a ConstString instead of a const char *, but that's not trivial because the compilers wants a safe destructor all the way down, and it seems that this is non-standard across compilers, except for C++17 and onwa

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace requested review of this revision. wallace added a comment. > At Apple, we use lldb to navigate instruction traces that contain billions of > instructions. Allocating 16 bytes per instruction simply will not scale for > our workflows. We require the in-memory overhead to be approximately

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace added a comment. > This approach - of prototyping trace analyses on a vector > representation and then rewriting them later when scaling issues arise - > doesn't sound good to me. Even for something simple, like finding a > backtrace, the window of instructions needed for analysis can e

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace updated this revision to Diff 350725. wallace marked 11 inline comments as done. wallace added a comment. Herald added a subscriber: mgorny. address all comments. I appreciate your feedback! - I ended up deleting all the deprecated methods, as I doubt anyone is using them. Intel wrote th

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace added a comment. I've been thinking about what you said and I'm having second thoughts on my implementation. I'll share more context: - I want to work in the short term on reverse debugging and reconstruction of stack traces, for that i'll need to know the instruction type of each inst

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace added a comment. Btw, thanks for the conversation. This is being really helpful. > I'm not convinced that retaining only 1 decoded instruction in memory at a > time (under a TraverseInstructions callback) will be sufficient for the use > cases you've outlined. Let's say the user sets a

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace updated this revision to Diff 351329. wallace added a comment. Herald added a subscriber: mgorny. Following @vsk 's feedback, I made the following changes: - Create a ThreadTrace class, that contains the trace for a specific thread and offers the TraverseInstructions method and other get

[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

wallace updated this revision to Diff 351344. wallace edited the summary of this revision. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103588/new/ https://reviews.llvm.org/D103588 Files: lldb/include/lldb/Target/T

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/ https://reviews.llvm.org/D103500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

wallace added a comment. I'll redo this in a different patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103588/new/ https://reviews.llvm.org/D103588 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace created this revision. wallace added reviewers: clayborg, vsk. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As a follow up of D103588 , I'm reinitiating the discussion with a new proposa

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace updated this revision to Diff 352605. wallace added a comment. - Simplified Trace.h by simply having lldb::TraceCursorUP GetCursor, as suggested. - Improved the documentation including a sample code. - Added methods to quickly move the trace to the beginning or the end. - Renamed TraceIns

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace updated this revision to Diff 352835. wallace marked 2 inline comments as done. wallace added a comment. address comments: - use llvm::ArrayRef where needed - improved documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

wallace added a comment. lgtm I wonder if it's lldb's style to rename m_mangled to m_mangled_do_not_use (or something like that) to prevent people from using it in the future. Comment at: lldb/source/Symbol/Symtab.cpp:625 + // with a prefix and end with a the symbol UserID,

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace marked 11 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:39-40 +/// +/// The Trace initially points to a dummy invalid instruction error signaling +/// the end of a trace, similar to a C++ collections' end iter

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace updated this revision to Diff 352872. wallace marked 2 inline comments as done. wallace added a comment. Herald added a subscriber: mgorny. address comments: - now simply pointing to the last instruction of the trace by default - removed the GetInstructionSize, as it's really not needed -

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:292 + /// \return + /// The stop ID of the live process being traced, or \b 0 if this is a + /// post-mortem trace session. clayborg w

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace updated this revision to Diff 353117. wallace marked an inline comment as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104422/new/ https://reviews.llvm.org/D104422 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace updated this revision to Diff 353135. wallace marked 3 inline comments as done. wallace added a comment. per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104422/new/ https://reviews.llvm.org/D104422 Files: lldb/include/lldb/Tar

[Lldb-commits] [PATCH] D104578: Clarify the "env" launch configuration setting.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104578/new/ https://reviews.llvm.org/D104578 ___

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:367 + /// We use 1 as a default stop id for post portem processes. + uint32_t m_stop_id = 1; clayborg wrote: > We really shouldn't have to set this manually. Probably best to start it

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

wallace added a comment. good to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Crossing fingers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105160/new/ https://reviews.llvm.org/D105160 _

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace created this revision. wallace added a reviewer: clayborg. Herald added subscribers: dang, mgorny. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D104422 added the interface for TraceCurso

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 356873. wallace added a comment. Herald added a subscriber: JDevlieghere. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105531/new/ https://reviews.llvm.org/D105531 Files: lldb/include/lldb/Target/Trace.

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 356875. wallace added a comment. improve documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105531/new/ https://reviews.llvm.org/D105531 Files: lldb/include/lldb/Target/Trace.h lldb/include/lldb/T

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

wallace requested changes to this revision. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:292 +Tests the evaluated expression expands successfully after "scopes" packets +and permanent +

[Lldb-commits] [PATCH] D105649: [LLDB] Move Trace-specific classes into separate library

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. this looks good to me. Let's wait for Greg's opinion as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:121 /// stopped at. See \a Trace::GetCursorPosition for more information. -class DecodedThread { +class DecodedThread : public std::enable_shared_from_this { public: c

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 357331. wallace added a comment. Addressed all issues - Created a TraceInstructionDumper class that keeps the index to print, which leaves the TraceCursor unaffected. It also keeps some other useful state. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace marked 9 inline comments as done. wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:2111 bool m_create_repeat_command_just_invoked; - size_t m_consecutive_repetitions = 0; + std::map> m_dumpers; }; clayborg wrot

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace added inline comments. Comment at: lldb/source/Target/TraceInstructionDumper.cpp:291 +s.Printf("\n"); +TryMoveOneInstruction(); + } clayborg wrote: > You should be watching the return value of this right? What if this returns > false? that's tak

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 357371. wallace added a comment. Address comments. - I ended up creating new method Next(int count) and Prev(int count) in the cursor for the skip operation. It might be useful for other things. I didn't add the count parameter to the existing Prev and Next

[Lldb-commits] [PATCH] D105832: [vscode] fix ubsan problem in the progress event reporter

wallace created this revision. wallace added a reviewer: clayborg. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The error UndefinedBehaviorSanitizer: undefined-behavior /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/l

<    1   2   3   4   5   6   7   8   9   10   >