[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Target/TraceInstructionDumper.cpp:291
+    s.Printf("\n");
+    TryMoveOneInstruction();
+  }
----------------
clayborg wrote:
> You should be watching the return value of this right? What if this returns 
> false?
that's taken care of by 
   if (m_no_more_data) {
      s.Printf("    no more data\n");
      break;
    }
in the beginning of the iteration


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105531/new/

https://reviews.llvm.org/D105531

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits