wallace marked 2 inline comments as done.
wallace added inline comments.
================
Comment at: lldb/include/lldb/Target/Trace.h:292
+ /// \return
+ /// The stop ID of the live process being traced, or \b 0 if this is a
+ /// post-mortem trace session.
----------------
clayborg wrote:
> zero is invalid. We should just have post mortem use a valid stop ID like 1
ahhhhh, good idea
================
Comment at: lldb/source/Target/Trace.cpp:478
+uint32_t Trace::GetStopID() {
+ RefreshLiveProcessState();
+ return m_stop_id;
----------------
clayborg wrote:
> We should make sure for core file that the m_stop_id is set correctly somehow
for a corefile the stop id is now set as 1 in Trace.h, which should be fine.
RefreshLiveProcessState does nothing for a corefile, btw
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104422/new/
https://reviews.llvm.org/D104422
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
