[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71151 This commit contains the initial scaffolding to convert the functionality currently implemented in LocateSymbolFile to a plugin architecture. The plugin approach allows us to easily add new ways to find plu

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Are you asking me to create a SymbolServer class for _this_ change, or do you > want me to get this diff polished & landed, then create the abstraction > before adding anything more? (Either is fine: I just can't quite tell what > you're looking for right now) I was sugg

[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/71128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add LLDB_ASSERT_OR_RETURN macro and make use of it (PR #71175)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I'm torn: on the one hand this is obviously making things better, on the other, it undermines what an assertion and has the potential to be used where error handling is necessary. The idea behind the latter is that if your assertion fails, you're already in an unrecoverable

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71151 >From 234258ff47b075a7094b5d57bfc0a420c49c7edb Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 2 Nov 2023 23:29:20 -0700 Subject: [PATCH 1/2] [lldb] Convert LocateSymbolFile into a plugin This c

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71151 >From 08eb0a2fef369c81c87c517811e634fd0cac7c6d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 2 Nov 2023 23:29:20 -0700 Subject: [PATCH] [lldb] Introduce a plugin to locate symbols This commit

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71151 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move FindSymbolFileInBundle to SymbolLocator plugin (PR #71247)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71247 This builds on top of the work started in c3a302d to convert LocateSymbolFile to a SymbolLocator plugin. This commit moves FindSymbolFileInBundle. >From a7ea01aca6b22a5eaf48f29ba162d6f4855a0352 Mon Sep 17 0

[Lldb-commits] [lldb] [lldb] Move FindSymbolFileInBundle to SymbolLocator plugin (PR #71247)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move LocateExecutableSymbolFile to SymbolLocator plugin (PR #71266)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71266 This builds on top of the work started in c3a302d to convert LocateSymbolFile to a SymbolLocator plugin. This commit moves LocateExecutableSymbolFile. >From e77c1245a5c3ca69c9f04d44c2be5304e08449e1 Mon Sep

[Lldb-commits] [lldb] [lldb] Move LocateExecutableSymbolFile to SymbolLocator plugin (PR #71266)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71267 This builds on top of the work started in c3a302d to convert LocateSymbolFile to a SymbolLocator plugin. This commit moves DownloadObjectAndSymbolFile. >From 8b237e9be1a17008b45d87596ee7384633d78f71 Mon Sep

[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The fourth installment in the SymbolLocator saga. https://github.com/llvm/llvm-project/pull/71267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71267 >From 8b237e9be1a17008b45d87596ee7384633d78f71 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 3 Nov 2023 14:21:24 -0700 Subject: [PATCH 1/2] [lldb] Move DownloadObjectAndSymbolFile to SymbolLoca

[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove LocateSymbolFile (PR #71301)

2023-11-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71301 This completes the conversion of LocateSymbolFile into a SymbolLocator plugin. The only remaining function is DownloadSymbolFileAsync which doesn't really fit into the plugin model, and therefore moves into

[Lldb-commits] [lldb] [lldb] Remove LocateSymbolFile (PR #71301)

2023-11-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The fifth and final installment in the SymbolLocator saga. https://github.com/llvm/llvm-project/pull/71301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove LocateSymbolFile (PR #71301)

2023-11-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [TraceIntelPT]Migrate to new function template for TraceIntelPT (PR #71258)

2023-11-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Nice, thank you for adopting the new APIs! https://github.com/llvm/llvm-project/pull/71258 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
@@ -32,6 +32,42 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter); ~ScriptedPythonInterface() override = default; + enum class AbstractMethodCheckerCases { +eNotImplemented, +eN

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Is there any way we could avoid ever having to instantiate a `Scripted{.*}Interface`? https://github.com/llvm/llvm-project/pull/71260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/71260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
@@ -32,27 +32,66 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter); ~ScriptedPythonInterface() override = default; + enum class AbstractMethodCheckerCases { +eNotImplemented, +e

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public ScriptedInterface { return {llvm::make_error()}; } + llvm::SmallVector GetAbstractMethods() const override { +return {}; + } JDevlieghere wrote: I think I asked something similar

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
@@ -99,25 +135,87 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { } llvm::Expected expected_return_object = - llvm::createStringError(llvm::inconvertibleErrorCode(), - "Resulting object is not initial

[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > These asserts are testing that the static representation of register contexts > is ok and building and testing with asserts enabled should flush out any > issues. `lldbassert()` is perfect for this since it is enabled for debug > builds while testing happens. The [contri

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: FWIW the "plugin-ification" has landed so this should be able to move forward as a plugin. https://github.com/llvm/llvm-project/pull/70996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71456 This commit adds an MD5 checksum (`Checksum`) class to LLDB. Its purpose is to store the MD5 hash added to the DWARF 5 line table. >From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001 Fro

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71457 Store a Checksum in FileSpec. Its purpose is to store the MD5 hash added to the DWARF 5 line table. >From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon,

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Depends on #71456. I considered an alternative where we don't store the `Checksum` in the `FileSpec` but create a new `SupportFile` class that wraps a `Checksum` and a `FileSpec`. The reason I didn't got with this approach is because of the `FileSpecList`. The latter has

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71458 Read the MD5 checksum from DWARF line tables and store it in the corresponding support files. >From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 6 Nov

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Depends on #71457. https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71459 Print a warning when the debugger detects a mismatch between the MD5 checksum in the DWARF 5 line table and the file on disk. >From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001 From: Jon

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Depends on #71458. This is probably incomplete and obviously needs a test, but I wanted to put up the PR to show what the dependent patches are building towards. https://github.com/llvm/llvm-project/pull/71459 ___ lldb-commits mai

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71456 >From 5693686d3570784fbcadb9921532faf354e5b74f Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 6 Nov 2023 14:39:26 -0800 Subject: [PATCH] [lldb] Add Checksum class to lldbUtility This commit add

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,46 @@ +//===-- Checksum.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
@@ -420,13 +428,17 @@ class FileSpec { /// The lifetime of the StringRefs is tied to the lifetime of the FileSpec. std::vector GetComponents() const; + /// Return the checksum for this FileSpec or all zeros if there is none. + const Checksum &GetChecksum() const { retu

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71457 >From 0a4b349d6299db6b2a0a6709c40d15b1a4a0f62a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 8 Nov 2023 16:51:53 -0800 Subject: [PATCH] [lldb] Add Checksum to FileSpec Store a Checksum in File

[Lldb-commits] [lldb] [lldb] Fix assert in ScriptedProcess destructor (PR #71744)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/71744 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71458 >From 5673248f1f19145cbbb0435177b6a5ed425fa1c0 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 24 Oct 2023 16:14:27 -0700 Subject: [PATCH] [lldb] Read Checksum from DWARF line tables Read the MD

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
@@ -184,6 +184,8 @@ class LLDB_API SBTarget { SBProcess LoadCore(const char *core_file); SBProcess LoadCore(const char *core_file, lldb::SBError &error); + SBProcess LoadCore(SBFile &file); JDevlieghere wrote: Did you add this for consistency? I don't th

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
@@ -24,7 +26,20 @@ class PostMortemProcess : public Process { using Process::Process; public: + PostMortemProcess(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, +lldb::FileSP file_sp) + : Process(target_sp, listener_sp), m_core_file(file_sp

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
@@ -354,12 +355,10 @@ class Process : public std::enable_shared_from_this, }; // This is all the event bits the public process broadcaster broadcasts. // The process shadow listener signs up for all these bits... - static constexpr int g_all_event_bits = eBroadcastBitSt

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
@@ -2104,9 +2113,10 @@ class CommandObjectTargetModulesDumpSymtab result.GetOutputStream().EOL(); result.GetOutputStream().EOL(); } - if (INTERRUPT_REQUESTED(GetDebugger(), -"Interrupted in dump sym

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. I left some comments inline. https://github.com/llvm/llvm-project/pull/71769 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-08 Thread Jonas Devlieghere via lldb-commits
@@ -443,6 +455,9 @@ class FileSpec { /// The unique'd filename path. ConstString m_filename; + /// The optional MD5 checksum of the file. + Checksum m_checksum; + JDevlieghere wrote: To close the loop on this for others, Greg measured the impact of the

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Hi @JDevlieghere, this change seems to be causing 59 test failures in the > cross-project-test suite. Can you take a look? > > https://lab.llvm.org/buildbot/#/builders/217/builds/30979 > https://lab.llvm.org/buildbot/#/builders/243/builds/15142 I'll revert the change, bu

[Lldb-commits] [lldb] Revert "[lldb] Read Checksum from DWARF line tables" (PR #71864)

2023-11-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71864 Reverts llvm/llvm-project#71458 as it might have caused cross-project-test failures. >From 5b740aafd3631fbe4bbe56cbe9e206da926a3c06 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 9 Nov 2023 1

[Lldb-commits] [lldb] Revert "[lldb] Read Checksum from DWARF line tables" (PR #71864)

2023-11-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71864 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Reverted in #71864. https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: It was also passing before with the change, so the issue isn't fully deterministic: https://lab.llvm.org/buildbot/#/builders/217/builds/30986 https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: That would've been helpful information to include in your original message and saved me the time of having to go through the logs. https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/71961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process) : LanguageRuntime(process) {} bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) { - return name == g_this; + return name == g_this || + // Artificial coroutine-related vari

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71984 This fixes a subtle and previously harmless off-by-one bug in ParseSupportFilesFromPrologue. The function accounts for the start index being one-based for DWARF v4 and earlier and zero-based for DWARF v5 an

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/71984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( JDevlieghere wrote: Without expressing an opinion, the [contributing guidelines](https://lldb.llvm.org/resources/contributing.html) say not to add new `lldbasserts`. This i

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( JDevlieghere wrote: This checks internal consistency so an `assert` is totally appropriate imho. https://github.com/llvm/llvm-project/pull/71828 ___

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 64f62de - [lldb] Read Checksum from DWARF line tables (#71458)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-11-10T14:43:47-08:00 New Revision: 64f62de96609dc3ea9a8a914a9e9445b7f4d625d URL: https://github.com/llvm/llvm-project/commit/64f62de96609dc3ea9a8a914a9e9445b7f4d625d DIFF: https://github.com/llvm/llvm-project/commit/64f62de96609dc3ea9a8a914a9e9445b7f4d625d.d

[Lldb-commits] [lldb] [lldb] Remove StructuredData::Array::GetItemAtIndexAsArray (PR #71994)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/71994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] DWARFv5: support DW_TAG_variable static data members declarations (PR #72236)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
@@ -2965,6 +2965,7 @@ void DWARFASTParserClang::ParseSingleMember( // data members is DW_AT_declaration, so we check it instead. // FIXME: Since DWARFv5, static data members are marked DW_AT_variable so we // can consistently detect them on both GCC and Clang without belo

[Lldb-commits] [lldb] [llvm] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. I would've preferred to return something like `LLDB_INVALID_HARDWARE_INDEX` but as we're deprecating this, it doesn't seem worth adding another define for. https://github.com/llvm/llvm-project/pull/72012 ___

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/68845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM with a few nits. I like "constituents". This is a pretty big patch which makes reviewing it challenging. I know it's a big change that touches a lot of things but I'm sure that this could've been broken up into smaller patches i

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,235 @@ +//===-- StopPointSiteList.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,235 @@ +//===-- StopPointSiteList.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,235 @@ +//===-- StopPointSiteList.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
@@ -1787,30 +1788,48 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo( // addresses should be provided as \a wp_addr. StringExtractor desc_extractor(description.c_str()); addr_t wp_addr = desc_extractor.GetU64(LLDB_INVALID_ADDRESS); - uint3

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,235 @@ +//===-- StopPointSiteList.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,235 @@ +//===-- StopPointSiteList.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

2023-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 👏 Thanks for doing this! https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Clarify comment around static member variable handling (PR #72495)

2023-11-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/72495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Send an explicit interrupt to cancel an attach waitfor. (PR #72565)

2023-11-16 Thread Jonas Devlieghere via lldb-commits
@@ -799,7 +799,33 @@ DNBProcessAttachWait(RNBContext *ctx, const char *waitfor_process_name, break; } - ::usleep(waitfor_interval); // Sleep for WAITFOR_INTERVAL, then poll again + // Now we're going to wait a while before polling again. But we also

[Lldb-commits] [lldb] Send an explicit interrupt to cancel an attach waitfor. (PR #72565)

2023-11-16 Thread Jonas Devlieghere via lldb-commits
@@ -3843,6 +3843,13 @@ thread_result_t Process::RunPrivateStateThread(bool is_secondary_thread) { ") woke up with an interrupt while attaching - " "forwarding interrupt.", __FUNCTION__, static_cast(this), GetID()); +

[Lldb-commits] [lldb] Add --copyExecutable and --ignoreNegativeCache to dsymForUUID invoke (PR #72579)

2023-11-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/72579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused Status::SetMachError (NFC) (PR #72668)

2023-11-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/72668 This function is never used, neither here nor downstream in the Swift fork. As far as I can tell, the same is true for the corresponding eErrorTypeMachKernel but as that's part of the SB API we cannot remov

[Lldb-commits] [lldb] [lldb] Pass important options to dsymForUUID (PR #72669)

2023-11-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/72669 On macOS, we usually use the DebugSymbols framework to find dSYMs, but we have a few places (including crashlog.py) that calls out directly to dsymForUUID. Currently, this invocation is missing two importan

[Lldb-commits] [lldb] [lldb] Pass important options to dsymForUUID (PR #72669)

2023-11-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/72669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused Status::SetMachError (NFC) (PR #72668)

2023-11-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/72668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-17 Thread Jonas Devlieghere via lldb-commits
@@ -260,6 +261,31 @@ SBProcess SBTarget::LoadCore(const char *core_file, lldb::SBError &error) { return sb_process; } +SBProcess SBTarget::LoadCore(const SBFile &file, lldb::SBError &error) { + LLDB_INSTRUMENT_VA(this, file, error); + + SBProcess sb_process; + TargetSP t

[Lldb-commits] [lldb] 48506fb - [lldb] Teach LLDB about Mach-O filesets

2022-08-25 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-08-25T15:24:51-07:00 New Revision: 48506fbbbf2732d9fc1fa75970a132450a1c1e20 URL: https://github.com/llvm/llvm-project/commit/48506fbbbf2732d9fc1fa75970a132450a1c1e20 DIFF: https://github.com/llvm/llvm-project/commit/48506fbbbf2732d9fc1fa75970a132450a1c1e20.d

[Lldb-commits] [lldb] e360281 - [lldb] Computer the slide when and apply it to each fileset's vm addr

2022-08-25 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-08-25T16:38:01-07:00 New Revision: e360281fa710a6e637667e6d70aa9e3919214b0f URL: https://github.com/llvm/llvm-project/commit/e360281fa710a6e637667e6d70aa9e3919214b0f DIFF: https://github.com/llvm/llvm-project/commit/e360281fa710a6e637667e6d70aa9e3919214b0f.d

[Lldb-commits] [lldb] 0044cb4 - [lldb] Fix two bugs in ObjectContainerMachOFileset

2022-08-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-08-30T14:07:20-07:00 New Revision: 0044cb4b2037827dd9a9318c7333eb40062c4ac3 URL: https://github.com/llvm/llvm-project/commit/0044cb4b2037827dd9a9318c7333eb40062c4ac3 DIFF: https://github.com/llvm/llvm-project/commit/0044cb4b2037827dd9a9318c7333eb40062c4ac3.d

[Lldb-commits] [lldb] f328922 - [lldb] Make the rumtimes target a test dependency

2022-08-31 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-08-31T14:25:07-07:00 New Revision: f328922f55fe62a587a3ec0cd7253861cadba85e URL: https://github.com/llvm/llvm-project/commit/f328922f55fe62a587a3ec0cd7253861cadba85e DIFF: https://github.com/llvm/llvm-project/commit/f328922f55fe62a587a3ec0cd7253861cadba85e.d

[Lldb-commits] [lldb] c7511b4 - [lldb] Correctly add runtime test dependencies

2022-08-31 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-08-31T16:37:35-07:00 New Revision: c7511b4ecf45c174c43d9177b843f15e2f3bd68b URL: https://github.com/llvm/llvm-project/commit/c7511b4ecf45c174c43d9177b843f15e2f3bd68b DIFF: https://github.com/llvm/llvm-project/commit/c7511b4ecf45c174c43d9177b843f15e2f3bd68b.d

[Lldb-commits] [lldb] 7240436 - [lldb] Fixed a number of typos

2022-09-13 Thread Jonas Devlieghere via lldb-commits
Author: Gabriel Ravier Date: 2022-09-13T10:38:38-07:00 New Revision: 7240436c94bd02762a723a2e3551528d16c8efdb URL: https://github.com/llvm/llvm-project/commit/7240436c94bd02762a723a2e3551528d16c8efdb DIFF: https://github.com/llvm/llvm-project/commit/7240436c94bd02762a723a2e3551528d16c8efdb.diff

[Lldb-commits] [lldb] d3a536f - [lldb] Appease the MSCV compiler

2022-09-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-09-19T17:37:27-07:00 New Revision: d3a536fa933bba5ffad48d7e5ab7de6f358550e7 URL: https://github.com/llvm/llvm-project/commit/d3a536fa933bba5ffad48d7e5ab7de6f358550e7 DIFF: https://github.com/llvm/llvm-project/commit/d3a536fa933bba5ffad48d7e5ab7de6f358550e7.d

[Lldb-commits] [lldb] 3b4db10 - [lldb] Actually support more than 32 logging categories

2022-09-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-09-19T22:31:20-07:00 New Revision: 3b4db10f3492dfbab705ca4b2dd19d32fee075b9 URL: https://github.com/llvm/llvm-project/commit/3b4db10f3492dfbab705ca4b2dd19d32fee075b9 DIFF: https://github.com/llvm/llvm-project/commit/3b4db10f3492dfbab705ca4b2dd19d32fee075b9.d

[Lldb-commits] [lldb] 01470b6 - [lldb] Fix hard-coded argument to set_target_properties

2022-10-06 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-10-06T11:43:52-07:00 New Revision: 01470b68f392af8bbf95b2ab48253b1662e2cdc7 URL: https://github.com/llvm/llvm-project/commit/01470b68f392af8bbf95b2ab48253b1662e2cdc7 DIFF: https://github.com/llvm/llvm-project/commit/01470b68f392af8bbf95b2ab48253b1662e2cdc7.d

[Lldb-commits] [lldb] 8c7a1f8 - Revert "[lldb] Fix member access in GetExpressionPath"

2022-10-20 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-10-20T15:21:59-07:00 New Revision: 8c7a1f87617067bc23c2e0733fe5e3202e1d6e81 URL: https://github.com/llvm/llvm-project/commit/8c7a1f87617067bc23c2e0733fe5e3202e1d6e81 DIFF: https://github.com/llvm/llvm-project/commit/8c7a1f87617067bc23c2e0733fe5e3202e1d6e81.d

[Lldb-commits] [lldb] 5b17eb1 - [lldb] Fix stale diagnostic event comments (NFC)

2022-10-24 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-10-24T11:14:52-07:00 New Revision: 5b17eb1c1e152a6d7dbcb94d7613bc2a7ea0b92b URL: https://github.com/llvm/llvm-project/commit/5b17eb1c1e152a6d7dbcb94d7613bc2a7ea0b92b DIFF: https://github.com/llvm/llvm-project/commit/5b17eb1c1e152a6d7dbcb94d7613bc2a7ea0b92b.d

[Lldb-commits] [lldb] 84ea6b6 - [lldb] Add diagnostics

2022-10-31 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-10-31T14:40:38-07:00 New Revision: 84ea6b6f78df789db6724ef8d774cf04d94d2313 URL: https://github.com/llvm/llvm-project/commit/84ea6b6f78df789db6724ef8d774cf04d94d2313 DIFF: https://github.com/llvm/llvm-project/commit/84ea6b6f78df789db6724ef8d774cf04d94d2313.d

[Lldb-commits] [lldb] 0d01300 - [lldb] Add a "diagnostics dump" command

2022-10-31 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-10-31T14:40:41-07:00 New Revision: 0d01300aacf6029b6d63f7dcede3ca8e15229d34 URL: https://github.com/llvm/llvm-project/commit/0d01300aacf6029b6d63f7dcede3ca8e15229d34 DIFF: https://github.com/llvm/llvm-project/commit/0d01300aacf6029b6d63f7dcede3ca8e15229d34.d

[Lldb-commits] [lldb] 8aed0ce - [lldb] Emit diagnostic events in the diagnostic dump

2022-10-31 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-10-31T14:40:41-07:00 New Revision: 8aed0ce20fc6be41a7e49ea1433095d4cf583e56 URL: https://github.com/llvm/llvm-project/commit/8aed0ce20fc6be41a7e49ea1433095d4cf583e56 DIFF: https://github.com/llvm/llvm-project/commit/8aed0ce20fc6be41a7e49ea1433095d4cf583e56.d

[Lldb-commits] [lldb] 4b21ecf - [lldb] Update TestDump.test for gnuwin32's 'file' command output

2022-11-02 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-11-02T09:33:25-07:00 New Revision: 4b21ecf10c8a0abb977bf11edf939cc708902cd3 URL: https://github.com/llvm/llvm-project/commit/4b21ecf10c8a0abb977bf11edf939cc708902cd3 DIFF: https://github.com/llvm/llvm-project/commit/4b21ecf10c8a0abb977bf11edf939cc708902cd3.d

<    16   17   18   19   20   21   22   23   24   25   >