https://github.com/JDevlieghere approved this pull request.

LGTM with a few nits. I like "constituents". 

This is a pretty big patch which makes reviewing it challenging. I know it's a 
big change that touches a lot of things but I'm sure that this could've been 
broken up into smaller patches if you keep that goal in mind from the 
beginning. Something to look out for in the future. 

https://github.com/llvm/llvm-project/pull/68845
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to