DavidSpickett wrote:
Ok so if had a very specific situation I wanted to run via lldb-rpc, I could
write an API test for it? That's cool, if I do find a bug I'd need to write a
test case anyway.
Please add that as a suggestion in the document where you describe / will
describe the testing proc
DavidSpickett wrote:
Please correct the REQUIRES if you have access to such machines to confirm it.
Maybe the test is so specific that it is fine to be on only one architecture/os
combination.
I recall a way in codegen tests to capture a line number in one pattern and
re-use that in a check p
DavidSpickett wrote:
I have got Arm's Foundation Model to boot with SME only, and the cpuinfo is:
```
Features: fp asimd evtstrm crc32 atomics fphp asimdhp cpuid asimdrdm
jscvt fcma lrcpc dcpop asimddp asimdfhm dit uscat ilrcpc flagm sb paca pacg gcs
dcpodp flagm2 frint i8mm bf16 dgh rn
DavidSpickett wrote:
> Therefore, this situation should only be an issue with older kernels, so
> perhaps it not something that regular user mode applications should need to
> worry about (unless specifically wanting to run with older kernels).
I will test this PR with an older kernel as well.
@@ -0,0 +1,76 @@
+//===-- RegisterInfoPOSIX_riscv32.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,76 @@
+//===-- RegisterInfoPOSIX_riscv32.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -319,3 +320,255 @@ TEST(MangledTest, NameIndexes_FindFunctionSymbols) {
EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeBase));
EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeMethod));
}
+
+TEST(MangledTest, DemangledNameInfo_SetMangledResets) {
+ Mangled mangl
DavidSpickett wrote:
You could adapt commands from
https://github.com/llvm/llvm-project/tree/main/lldb/scripts/lldb-test-qemu, if
you have an existing Ubuntu system of some other architecture.
https://lldb.llvm.org/resources/qemu-testing.html
https://github.com/llvm/llvm-project/pull/115408
_
https://github.com/DavidSpickett approved this pull request.
Also noticed this trying to reproduce a failure on Windows with lldb-dotest.py,
LGTM.
https://github.com/llvm/llvm-project/pull/137262
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
DavidSpickett wrote:
> The instruction emulation plugins are used to implement software
> single-stepping on architectures without (reliably present) hardware support.
> AFAIK aarch64 is not one of those.
I think it's also used in unwinding for some basic prologue/epilogue
instructions, but I
@@ -239,15 +239,15 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid,
Status ProcessWindows::DoResume(RunDirection direction) {
Log *log = GetLog(WindowsLog::Process);
llvm::sys::ScopedLock lock(m_mutex);
- Status error;
if (direction == RunDirection::eRunRev
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/137351
The new test added in https://github.com/llvm/llvm-project/pull/132783 was
failing on Windows because it created a new error to say it did not support the
feature, but then returned the existing, default
DavidSpickett wrote:
@rocallahan FYI.
https://github.com/llvm/llvm-project/pull/137351
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -979,8 +967,8 @@ lldb::SBError DAP::WaitForProcessToStop(uint32_t seconds) {
}
std::this_thread::sleep_for(std::chrono::microseconds(250));
}
- error.SetErrorStringWithFormat("process failed to stop within %u seconds",
- seconds);
+
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/137351
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
:+1:
https://github.com/llvm/llvm-project/pull/137371
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
We (Linaro) are seeing the same error message with a different test on our
AArch64 Linux bot:
```
ERROR: test_indexedVariables_with_raw_child_for_synthetics
(TestDAP_variables.TestDAP_variables)
--
Tracebac
DavidSpickett wrote:
A few failures in [Linux
CI](https://buildkite.com/llvm-project/github-pull-requests/builds/171994#01966898-2a91-49c2-9cbe-911629208365).
All are like:
```
CheckArrayPointer.test.script: line 3: fg: no job control
```
https://github.com/llvm/llvm-project/pull/136748
_
DavidSpickett wrote:
I have zero context for the problem this aims to solve, but the way you
describe it, it seems like this shouldn't be a setting, it should just be how
we do it.
> this could make it easier when debugging crashes and stack traces to
> understand which function the unnamed s
@@ -0,0 +1,13 @@
+// Skipping temporarily due to rdar://14958
DavidSpickett wrote:
Not a great sign that all the client tests are disabled on the system that
they're originally intended for.
What exactly is the issue here?
https://github.com/llvm/llvm-proj
DavidSpickett wrote:
> FWIW, it would be super convenient if QEMU could be set up to emulate this
> precise configuration. You don't happen to have connections to someone who
> could be prodded into implementing it? :-)
A least for Linaro, there are no plans to implement this. QEMU doesn't try
DavidSpickett wrote:
> We can't change the signature of CalculateSymbolContextFunction as it's an
> abstract function (and some of its implementations can return nullptr)
By which you mean, because there are still use cases for
`CalculateSymbolContextFunction` to return `nullptr`, so it must r
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/137611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,57 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+
+import argparse
+import os
+import re
+import subprocess
DavidSpickett wrote:
Audit these imports, I think at least subprocess is unused.
https://github.com/llvm/llvm-p
@@ -0,0 +1,61 @@
+#!/usr/bin/env python3
+# Usage: framework-header-version-fix.py
MAJOR MINOR PATCH
DavidSpickett wrote:
And the file read/write modes, use the most minimal you can.
https://github.com/llvm/llvm-project/pull/136748
___
@@ -0,0 +1,19 @@
+if(LLDB_CODESIGN_IDENTITY)
+ # Use explicit LLDB identity
+ set(LLVM_CODESIGNING_IDENTITY ${LLDB_CODESIGN_IDENTITY})
+else()
+ # Use explicit LLVM identity or default to ad-hoc signing if empty
+ if(NOT LLVM_CODESIGNING_IDENTITY)
+set(LLVM_CODESIGNING_IDE
@@ -0,0 +1,61 @@
+#!/usr/bin/env python3
+# Usage: framework-header-version-fix.py
MAJOR MINOR PATCH
+
+import argparse
+import os
+import re
+import subprocess
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("input")
+parser.add_argument("
@@ -0,0 +1,39 @@
+#!/usr/bin/env python3
+# Usage: framework-header-include-fix.py
+
+import argparse
+import os
+import re
+import subprocess
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("input")
+parser.add_argument("output")
+args
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,39 @@
+#!/usr/bin/env python3
+# Usage: framework-header-include-fix.py
+
+import argparse
+import os
+import re
+import subprocess
DavidSpickett wrote:
Check you're using all these imports, subprocess appears unused.
https://github.com/llvm/llvm-p
@@ -0,0 +1,61 @@
+#!/usr/bin/env python3
+# Usage: framework-header-version-fix.py
MAJOR MINOR PATCH
DavidSpickett wrote:
As other files, short description here, audit your imports.
https://github.com/llvm/llvm-project/pull/136748
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/136748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,57 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+
+import argparse
+import os
+import re
+import subprocess
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("input")
+parser.add_argument("output")
+
@@ -0,0 +1,57 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+
+import argparse
+import os
+import re
+import subprocess
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("input")
+parser.add_argument("output")
+
https://github.com/DavidSpickett commented:
This is a lot to deal with. So I have a bunch of nits on the first few files
but my lack of overall understanding of the process meant I can't assess 1000s
of lines of C++ implementing it.
I know you explained the mechanics of this in the RFC, but, I
@@ -0,0 +1,57 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+
+import argparse
+import os
+import re
+import subprocess
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("input")
+parser.add_argument("output")
+
@@ -0,0 +1,57 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+
+import argparse
+import os
+import re
+import subprocess
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("input")
+parser.add_argument("output")
+
@@ -0,0 +1,39 @@
+#!/usr/bin/env python3
+# Usage: framework-header-include-fix.py
DavidSpickett wrote:
Add a short description of what this script does. Mainly, what is it fixing
specifically?
https://github.com/llvm/llvm-project/pull/136748
___
@@ -0,0 +1,39 @@
+#!/usr/bin/env python3
+# Usage: framework-header-include-fix.py
+
+import argparse
+import os
+import re
+import subprocess
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("input")
+parser.add_argument("output")
+args
Author: David Spickett
Date: 2025-04-29T14:01:01Z
New Revision: 65b0d21eb490aaa0c742739ce95b1acc654be22b
URL:
https://github.com/llvm/llvm-project/commit/65b0d21eb490aaa0c742739ce95b1acc654be22b
DIFF:
https://github.com/llvm/llvm-project/commit/65b0d21eb490aaa0c742739ce95b1acc654be22b.diff
LOG
@@ -239,15 +239,15 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid,
Status ProcessWindows::DoResume(RunDirection direction) {
Log *log = GetLog(WindowsLog::Process);
llvm::sys::ScopedLock lock(m_mutex);
- Status error;
if (direction == RunDirection::eRunRev
@@ -142,6 +142,7 @@ add_lldb_library(liblldb SHARED ${option_framework}
lldbValueObject
lldbVersion
${LLDB_ALL_PLUGINS}
+swiftCore
DavidSpickett wrote:
I don't see a library named this in `llvm/llvm-project`, did you mean to submit
this to App
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
+
DavidSpickett wrote:
I once again attempt to parse your PR description, armed with this
understanding.
> Currently we're creating inheritable (~FD_CLOEXEC) file descriptors in the
> (few) cases where we need to pass an FD to a subprocess. The problem with
> these is that, in a multithreaded a
DavidSpickett wrote:
It was an
[ABI](https://github.com/llvm/llvm-project/commit/7d01b85c2a0aa8bc91f731cfeb2a7b6885b8d04a)
difference between X86 and AArch64.
If you can think of a way to force a memory write without relying on the return
address, it would be nice to get this test running on
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
+
@@ -0,0 +1,102 @@
+# REQUIRES: x86, lld
+
+# RUN: split-file %s %t
+# RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux %t/file.s -o %t/file.o
+# RUN: ld.lld %t/file.o -o %t/file.out -T %t/file.lds
+# RUN: %lldb %t/file.out -o "disassemble --name func1" -o exit | FileCheck %s
+
+
@@ -283,39 +283,42 @@ uint32_t Block::GetRangeIndexContainingAddress(const
Address &addr) {
return m_ranges.FindEntryIndexThatContains(file_addr - func_file_addr);
}
+static AddressRange ToAddressRange(const Address &func_addr,
+ const Bloc
Author: David Spickett
Date: 2025-05-02T09:14:16Z
New Revision: daa4061d61216456baa83ab404e096200e327fb4
URL:
https://github.com/llvm/llvm-project/commit/daa4061d61216456baa83ab404e096200e327fb4
DIFF:
https://github.com/llvm/llvm-project/commit/daa4061d61216456baa83ab404e096200e327fb4.diff
LOG
DavidSpickett wrote:
I've
[reverted](https://github.com/llvm/llvm-project/commit/daa4061d61216456baa83ab404e096200e327fb4)
this because it's failing on Windows on Arm.
It looks like all the IDs are there but not in the right place, so if we're
lucky it's just some extra line that only appears
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: David Spickett
Date: 2025-05-07T10:07:02Z
New Revision: 62385b848757f2dc35070eadb2ccd921508497dc
URL:
https://github.com/llvm/llvm-project/commit/62385b848757f2dc35070eadb2ccd921508497dc
DIFF:
https://github.com/llvm/llvm-project/commit/62385b848757f2dc35070eadb2ccd921508497dc.diff
LOG
Author: David Spickett
Date: 2025-05-08T08:47:12Z
New Revision: 2668167e2cf935528f7d93cb3b12a651a29e52f6
URL:
https://github.com/llvm/llvm-project/commit/2668167e2cf935528f7d93cb3b12a651a29e52f6
DIFF:
https://github.com/llvm/llvm-project/commit/2668167e2cf935528f7d93cb3b12a651a29e52f6.diff
LOG
DavidSpickett wrote:
We have a few failures on Windows on Arm too:
https://github.com/llvm/llvm-project/commit/2668167e2cf935528f7d93cb3b12a651a29e52f6
I've skipped those tests for now.
https://github.com/llvm/llvm-project/pull/138791
___
lldb-commit
@@ -36,34 +39,49 @@ int main() {
}
// CHECK-LABEL: process status -d
-// CHECK: m_stop_id: 2
-// CHECK: m_memory_id: 0
+// CHECK: m_stop_id: [[#STOP_ID:]]
+// CHECK: m_memory_id: [[#MEMORY_ID:]]
// CHECK-LABEL: expr x.i != 42
// IDs are not changed when executing simple ex
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/138941
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
Looks fine just one question.
https://github.com/llvm/llvm-project/pull/138941
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
A few tests still failing on Windows -
https://lab.llvm.org/buildbot/#/builders/141/builds/8523
```
Unresolved Tests (1):
lldb-api :: tools/lldb-dap/send-event/TestDAP_sendEvent.py
Failed Tests (2):
lldb-a
DavidSpickett wrote:
Random example - `llvm/test/Analysis/BasicAA/separate_storage.ll`:
```
define i8 @simple_no(ptr %p1, ptr %p2) {
; CHECK-LABEL: @simple_no(
; CHECK-NEXT: entry:
; CHECK-NEXT:store i8 0, ptr [[P1:%.*]], align 1
; CHECK-NEXT:store i8 1, ptr [[P2:%.*]], align 1
; CHECK-N
DavidSpickett wrote:
As far as I can know, https://github.com/llvm/llvm-project/pull/138219 went
onto main, so you can revert my revert to get that back.
Then there was
https://github.com/llvm/llvm-project/commit/69a0af35a5860156836e9e295ecef9de3474db11,
which was later reverted in
https://g
DavidSpickett wrote:
I've reverted this. Please take a look at the logs of
https://lab.llvm.org/buildbot/#/builders/141/builds/8500 and see if any of it
makes sense to you.
We didn't have failures on Linux (though a lot of tests are disabled, they
would be disabled everywhere) so my first ins
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -36,34 +39,49 @@ int main() {
}
// CHECK-LABEL: process status -d
-// CHECK: m_stop_id: 2
-// CHECK: m_memory_id: 0
+// CHECK: m_stop_id: [[#STOP_ID:]]
+// CHECK: m_memory_id: [[#MEMORY_ID:]]
// CHECK-LABEL: expr x.i != 42
// IDs are not changed when executing simple ex
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/138941
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -148,6 +148,7 @@ def __init__(self, lit_config, config):
features.add("long_tests")
if target_triple:
+print(target_triple)
DavidSpickett wrote:
Remove this
https://github.com/llvm/llvm-project/pull/124475
_
https://github.com/DavidSpickett commented:
I'm somewhat professionally restricted from getting too involved in RISC-V ,as
much as I would like to see it actually work normally, just to save others
hassle.
But I can see this pretty obviously fixes the bug, so I don't have a problem
letting th
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/124475
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -652,6 +652,153 @@ def haltReason(self):
)
self.match("register read s31", ["s31 = 128"])
+@skipIfXmlSupportMissing
+@skipIfRemote
+@skipIfLLVMTargetMissing("RISCV")
+def test_riscv64_regs(self):
+"""Test grabbing various riscv64 regi
@@ -0,0 +1,37 @@
+# REQUIRES: native && target-riscv64
+# RUN: %clangxx_host %p/Inputs/riscv64-gp-read.cpp -o %t
+# RUN: %lldb -b -s %s %t | FileCheck %s
+process launch
+
+register read --all
+# CHECK-DAG: x0 = 0x0
+# CHECK-DAG: x1 = 0x1
+# CHECK-DAG: x2 = 0x2
+# CHECK-DAG: x3 =
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/124475
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett requested changes to this pull request.
Please add a test like `lldb/test/Shell/Register/aarch64-gp-read.test` which
tests the normal and alias names using a live process.
Note that the main "trick" of that test is to manually insert a breakpoint
instruction:
`
DavidSpickett wrote:
Everything in the PR at the moment is fine, just need the extra test case.
https://github.com/llvm/llvm-project/pull/124059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/124475
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/129038
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP
&listener_sp) {
m_forward_listener_sp.reset();
}
+bool Debugger::StatuslineSupported() {
+ if (GetShowStatusline()) {
+if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) {
+ Fi
@@ -0,0 +1,171 @@
+//===-- Statusline.cpp ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
DavidSpickett wrote:
I had to try some Unicode of course. I think you have a TODO in there about
this already but just because it was fun...
```
>>> "東".encode()
b'\xe6\x9d\xb1'
>>> "a".encode()
b'a'
```
I can get way more 'a' before I get the '...' than '東'. Same for an emoji,
which is a more
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP
&listener_sp) {
m_forward_listener_sp.reset();
}
+bool Debugger::StatuslineSupported() {
+ if (GetShowStatusline()) {
+if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) {
+ Fi
DavidSpickett wrote:
> displayed the bottom of the screen
displayed **at** the bottom of the screen
> The statusline supersedes the current progress reporting implementation.
I will find this out looking at the code shortly, but - does this mean that if
you disable the statusline, you get the
@@ -0,0 +1,171 @@
+//===-- Statusline.cpp ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,171 @@
+//===-- Statusline.cpp ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -1912,7 +1919,30 @@ bool FormatEntity::Format(const Entry &entry, Stream &s,
return true;
}
return false;
+
+ case Entry::Type::ProgressCount:
+if (Target *target = Target::GetTargetFromContexts(exe_ctx, sc)) {
+ Debugger &debugger = target->GetDebugg
@@ -0,0 +1,171 @@
+//===-- Statusline.cpp ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP
&listener_sp) {
m_forward_listener_sp.reset();
}
+bool Debugger::StatuslineSupported() {
+ if (GetShowStatusline()) {
+if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) {
+ Fi
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP
&listener_sp) {
m_forward_listener_sp.reset();
}
+bool Debugger::StatuslineSupported() {
+ if (GetShowStatusline()) {
+if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) {
+ Fi
@@ -0,0 +1,171 @@
+//===-- Statusline.cpp ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,171 @@
+//===-- Statusline.cpp ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/121860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in {
Global,
DefaultStringValue<"${ansi.normal}">,
Desc<"When displaying progress in a color-enabled terminal, use the ANSI
terminal code specified in this format immediately after the progress
message.">;
+ def Sh
@@ -765,6 +765,8 @@ def setUpCommands(cls):
# Disable fix-its by default so that incorrect expressions in
tests don't
# pass just because Clang thinks it has a fix-it.
"settings set target.auto-apply-fixits false",
+# Disable the
@@ -243,6 +243,19 @@ Status Debugger::SetPropertyValue(const ExecutionContext
*exe_ctx,
// Prompt colors changed. Ping the prompt so it can reset the ansi
// terminal codes.
SetPrompt(GetPrompt());
+} else if (property_path ==
+ g_debugger_p
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/130277
When https://github.com/llvm/llvm-project/pull/130034 enabled RISC-V here I
noticed that these should run for ARM as well.
ARM only has 4 argument registers, which matches Arm's ABI for it:
https://githu
DavidSpickett wrote:
Some of this will be expected, but reporting it in case it's not.
```
$ ./bin/lldb /tmp/test.o
(lldb) target create "/tmp/test.o"
Current executable set to '/tmp/test.o' (aarch64).
(lldb)
<< should this be here?
test.o << is the status line
```
Is that empty line meant
https://github.com/DavidSpickett commented:
I was going to bikeshed (or indeed bike shed) "statusline" vs. "status line"
but I see that NeoVim spells it this way. That's popular already, so one word
is fine with me.
Going to try this locally now.
https://github.com/llvm/llvm-project/pull/1218
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/130034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/130034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -292,6 +292,13 @@ def create_parser():
metavar="platform-working-dir",
help="The directory to use on the remote platform.",
)
+group.add_argument(
+"--platform-available-ports",
+dest="lldb_platform_available_ports",
+type=lamb
@@ -195,8 +195,17 @@ def
test_qRegisterInfo_contains_required_generics_debugserver(self):
# Ensure we have a stack pointer register.
self.assertIn("sp", generic_regs)
-# Ensure we have a flags register.
-self.assertIn("flags", generic_regs)
+
2601 - 2700 of 2869 matches
Mail list logo