[Lldb-commits] [lldb] 6cdc223 - [lldb][AArch64] Simplify MTE memory region test

2021-04-14 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-04-14T11:50:45+01:00 New Revision: 6cdc2239dbabeb6fb8a9f933693f744a60d50a8c URL: https://github.com/llvm/llvm-project/commit/6cdc2239dbabeb6fb8a9f933693f744a60d50a8c DIFF: https://github.com/llvm/llvm-project/commit/6cdc2239dbabeb6fb8a9f933693f744a60d50a8c.diff

[Lldb-commits] [lldb] d0c521d - [lldb] Correct format enum comment (NFC)

2021-04-28 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-04-28T12:17:03+01:00 New Revision: d0c521da3f0cfd1bd01696773349f1b723d8b057 URL: https://github.com/llvm/llvm-project/commit/d0c521da3f0cfd1bd01696773349f1b723d8b057 DIFF: https://github.com/llvm/llvm-project/commit/d0c521da3f0cfd1bd01696773349f1b723d8b057.diff

[Lldb-commits] [lldb] f31e390 - [lldb][AArch64] Don't check for VmFlags in smaps files

2021-04-29 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-04-29T09:30:14+01:00 New Revision: f31e390453d255bc6a486bbd5cb990e684b29510 URL: https://github.com/llvm/llvm-project/commit/f31e390453d255bc6a486bbd5cb990e684b29510 DIFF: https://github.com/llvm/llvm-project/commit/f31e390453d255bc6a486bbd5cb990e684b29510.diff

[Lldb-commits] [lldb] 8fdfc1d - [lldb] Add tests for DumpDataExtractor formats

2021-04-30 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-04-30T10:29:05+01:00 New Revision: 8fdfc1d64c51d949b84b2ee824f2ba9b9a3a6bd6 URL: https://github.com/llvm/llvm-project/commit/8fdfc1d64c51d949b84b2ee824f2ba9b9a3a6bd6 DIFF: https://github.com/llvm/llvm-project/commit/8fdfc1d64c51d949b84b2ee824f2ba9b9a3a6bd6.diff

[Lldb-commits] [lldb] a86cbd4 - [lldb] More tests for DumpDataExtractor

2021-04-30 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-04-30T16:16:38+01:00 New Revision: a86cbd475576b0c08537bea44c54cfc332f215f2 URL: https://github.com/llvm/llvm-project/commit/a86cbd475576b0c08537bea44c54cfc332f215f2 DIFF: https://github.com/llvm/llvm-project/commit/a86cbd475576b0c08537bea44c54cfc332f215f2.diff

[Lldb-commits] [lldb] 8da5d11 - [lldb] DumpDataExtractor tests for item byte size errors

2021-04-30 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-04-30T16:49:04+01:00 New Revision: 8da5d111a5d2f795d5c32ef194f2e93c8ac0ec3f URL: https://github.com/llvm/llvm-project/commit/8da5d111a5d2f795d5c32ef194f2e93c8ac0ec3f DIFF: https://github.com/llvm/llvm-project/commit/8da5d111a5d2f795d5c32ef194f2e93c8ac0ec3f.diff

[Lldb-commits] [lldb] 44d0ad5 - [lldb] Change DumpDataExtractorTest function names to lldb style (NFC)

2021-04-30 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-04-30T16:55:34+01:00 New Revision: 44d0ad53afbe06d1141b84321eaca234c60a1305 URL: https://github.com/llvm/llvm-project/commit/44d0ad53afbe06d1141b84321eaca234c60a1305 DIFF: https://github.com/llvm/llvm-project/commit/44d0ad53afbe06d1141b84321eaca234c60a1305.diff

[Lldb-commits] [lldb] 5af3a66 - Remove Windows editline from LLDB

2021-05-12 Thread David Spickett via lldb-commits
Author: Neal (nealsid) Date: 2021-05-12T10:05:44+01:00 New Revision: 5af3a6645f38e5638b4ba03613ee18140f36962d URL: https://github.com/llvm/llvm-project/commit/5af3a6645f38e5638b4ba03613ee18140f36962d DIFF: https://github.com/llvm/llvm-project/commit/5af3a6645f38e5638b4ba03613ee18140f36962d.diff

[Lldb-commits] [lldb] e82866d - [lldb][AArch64] Correct compile options for Neon corefile

2020-08-06 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-08-06T13:39:09+01:00 New Revision: e82866d5d9eef913252833789acda04ef8389e52 URL: https://github.com/llvm/llvm-project/commit/e82866d5d9eef913252833789acda04ef8389e52 DIFF: https://github.com/llvm/llvm-project/commit/e82866d5d9eef913252833789acda04ef8389e52.diff

[Lldb-commits] [lldb] 9ad5d37 - [lldb] Correct wording of EXP_MSG

2020-08-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-08-26T11:52:30+01:00 New Revision: 9ad5d37fd917a5b8b3ffe5c12145c85021ee2578 URL: https://github.com/llvm/llvm-project/commit/9ad5d37fd917a5b8b3ffe5c12145c85021ee2578 DIFF: https://github.com/llvm/llvm-project/commit/9ad5d37fd917a5b8b3ffe5c12145c85021ee2578.diff

[Lldb-commits] [lldb] c1e6f1a - [lldb] Fix gcc 5.4.0 compile error

2020-08-27 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-08-27T10:23:05+01:00 New Revision: c1e6f1a7b1a8cb2bb11a76b904c6f8150bfcc3a6 URL: https://github.com/llvm/llvm-project/commit/c1e6f1a7b1a8cb2bb11a76b904c6f8150bfcc3a6 DIFF: https://github.com/llvm/llvm-project/commit/c1e6f1a7b1a8cb2bb11a76b904c6f8150bfcc3a6.diff

[Lldb-commits] [lldb] 9f18f3c - [lldb] Improve test failure reporting for expect()

2020-09-03 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-09-03T13:35:05+01:00 New Revision: 9f18f3c858d5ff8154701a50c2be6f7b19667a1d URL: https://github.com/llvm/llvm-project/commit/9f18f3c858d5ff8154701a50c2be6f7b19667a1d DIFF: https://github.com/llvm/llvm-project/commit/9f18f3c858d5ff8154701a50c2be6f7b19667a1d.diff

[Lldb-commits] [lldb] c687af0 - [lldb] Don't send invalid region addresses to lldb server

2020-09-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-09-17T10:26:16+01:00 New Revision: c687af0c30b4dbdc9f614d5e061c888238e0f9c5 URL: https://github.com/llvm/llvm-project/commit/c687af0c30b4dbdc9f614d5e061c888238e0f9c5 DIFF: https://github.com/llvm/llvm-project/commit/c687af0c30b4dbdc9f614d5e061c888238e0f9c5.diff

[Lldb-commits] [lldb] c65627a - Revert "[lldb] Don't send invalid region addresses to lldb server"

2020-09-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-09-17T13:07:44+01:00 New Revision: c65627a1fe3be7521fc232d633bb6df577f55269 URL: https://github.com/llvm/llvm-project/commit/c65627a1fe3be7521fc232d633bb6df577f55269 DIFF: https://github.com/llvm/llvm-project/commit/c65627a1fe3be7521fc232d633bb6df577f55269.diff

[Lldb-commits] [lldb] 71cf97e - Reland "[lldb] Don't send invalid region addresses to lldb server"

2020-10-05 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-10-05T11:50:29+01:00 New Revision: 71cf97e95b8c888367284d1d12925f79b38034eb URL: https://github.com/llvm/llvm-project/commit/71cf97e95b8c888367284d1d12925f79b38034eb DIFF: https://github.com/llvm/llvm-project/commit/71cf97e95b8c888367284d1d12925f79b38034eb.diff

[Lldb-commits] [lldb] 2d1ee7c - [lldb] Note difference in vFile:pread/pwrite format for lldb

2020-10-12 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-10-12T15:09:49+01:00 New Revision: 2d1ee7cae9b2299186fa25d8d1fbdb8af482046c URL: https://github.com/llvm/llvm-project/commit/2d1ee7cae9b2299186fa25d8d1fbdb8af482046c DIFF: https://github.com/llvm/llvm-project/commit/2d1ee7cae9b2299186fa25d8d1fbdb8af482046c.diff

[Lldb-commits] [lldb] f8a3b9b - [lldb] Correct vFile:pread/pwrite packet docs

2020-10-27 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-10-27T11:47:35Z New Revision: f8a3b9b06c4a46fe2a83ec52f8e396d335b44fdd URL: https://github.com/llvm/llvm-project/commit/f8a3b9b06c4a46fe2a83ec52f8e396d335b44fdd DIFF: https://github.com/llvm/llvm-project/commit/f8a3b9b06c4a46fe2a83ec52f8e396d335b44fdd.diff LOG

[Lldb-commits] [lldb] 749f13e - [lldb] Correct --help output for qemu rootfs script

2020-10-29 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-10-29T09:57:32Z New Revision: 749f13e7635aebcda978ee2e42f5569ab7f0fafc URL: https://github.com/llvm/llvm-project/commit/749f13e7635aebcda978ee2e42f5569ab7f0fafc DIFF: https://github.com/llvm/llvm-project/commit/749f13e7635aebcda978ee2e42f5569ab7f0fafc.diff LOG

[Lldb-commits] [lldb] 50f12ad - [lldb] Fix a couple of remote llgs tests

2020-11-18 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-11-18T11:36:45Z New Revision: 50f12ade2de1b30e989c13f410461cb27c126f13 URL: https://github.com/llvm/llvm-project/commit/50f12ade2de1b30e989c13f410461cb27c126f13 DIFF: https://github.com/llvm/llvm-project/commit/50f12ade2de1b30e989c13f410461cb27c126f13.diff LOG

[Lldb-commits] [lldb] 3254168 - [lldb][AArch64/Linux] Show memory tagged memory regions

2020-11-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-11-20T11:21:59Z New Revision: 32541685b2a980290c320adb289b56395a88d4c3 URL: https://github.com/llvm/llvm-project/commit/32541685b2a980290c320adb289b56395a88d4c3 DIFF: https://github.com/llvm/llvm-project/commit/32541685b2a980290c320adb289b56395a88d4c3.diff LOG

[Lldb-commits] [lldb] 98e87f7 - [lldb] Error when there are no ports to launch a gdbserver on

2020-11-30 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-11-30T10:19:14Z New Revision: 98e87f76d0f486122d76b334232102e0d7a9254d URL: https://github.com/llvm/llvm-project/commit/98e87f76d0f486122d76b334232102e0d7a9254d DIFF: https://github.com/llvm/llvm-project/commit/98e87f76d0f486122d76b334232102e0d7a9254d.diff LOG

[Lldb-commits] [lldb] a7f8d96 - [lldb] Use llvm::Optional for port in LaunchGDBServer

2020-11-30 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2020-11-30T11:20:39Z New Revision: a7f8d96b16a394a87230d592c727906f67a4ba07 URL: https://github.com/llvm/llvm-project/commit/a7f8d96b16a394a87230d592c727906f67a4ba07 DIFF: https://github.com/llvm/llvm-project/commit/a7f8d96b16a394a87230d592c727906f67a4ba07.diff LOG

[Lldb-commits] [lldb] 801c786 - [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA

2021-01-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-01-07T10:51:47Z New Revision: 801c7866e6d4fba81c97d27ca56c9e05ba7b157a URL: https://github.com/llvm/llvm-project/commit/801c7866e6d4fba81c97d27ca56c9e05ba7b157a DIFF: https://github.com/llvm/llvm-project/commit/801c7866e6d4fba81c97d27ca56c9e05ba7b157a.diff LOG

[Lldb-commits] [lldb] 9a7672a - [lldb] Fix crash in "help memory read"

2021-01-19 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-01-19T09:54:17Z New Revision: 9a7672ac4980bca8829814e1e49e1c201a5bf9b6 URL: https://github.com/llvm/llvm-project/commit/9a7672ac4980bca8829814e1e49e1c201a5bf9b6 DIFF: https://github.com/llvm/llvm-project/commit/9a7672ac4980bca8829814e1e49e1c201a5bf9b6.diff LOG

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/110822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I don't want a fix for AArch64 TLS to break TLS support elsewhere, so this needs testing and we may need to add new tests for the existing support. Could you: * Find out what TLS testing we have right now. (a really ugly way to do it is to delete the

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -790,9 +793,12 @@ DynamicLoaderPOSIXDYLD::GetThreadLocalData(const lldb::ModuleSP module_sp, LLDB_LOGF(log, "GetThreadLocalData error: fail to read modid"); return LLDB_INVALID_ADDRESS; } - + const llvm::Triple &triple_ref = + m_process->GetTarget().GetArchi

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -3557,6 +3560,12 @@ VariableSP SymbolFileDWARF::ParseVariableDIE(const SymbolContext &sc, } } + // If It's a declaration then symbol not present in this symbolfile + // return early to try other linked objects. + if (is_declaration) { +return nullptr; + } ---

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() { m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr); } } - + if (m_error.Fail() && variable->IsThreadLocal()) { +ExecutionContext exe_ctx(GetExecutionContextRef()); +Thread *thread

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -73,19 +73,20 @@ #undef DECLARE_REGISTER_INFOS_ARM64_STRUCT static lldb_private::RegisterInfo g_register_infos_pauth[] = { -DEFINE_EXTENSION_REG(data_mask), DEFINE_EXTENSION_REG(code_mask)}; +DEFINE_EXTENSION_REG(data_mask, KIND_ALL_INVALID), +DEFINE_EXTENSION_R

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() { m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr); } } - + if (m_error.Fail() && variable->IsThreadLocal()) { +ExecutionContext exe_ctx(GetExecutionContextRef()); Da

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() { m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr); } } - + if (m_error.Fail() && variable->IsThreadLocal()) { +ExecutionContext exe_ctx(GetExecutionContextRef()); +Thread *thread

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: I don't see any tests yet, I think `lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py` will be the place for those. There is a template program file you can use in that folder. If you need more functionality to get to the point you can add tests, please

[Lldb-commits] [lldb] [lldb] Make the system log a NOOP on Windows (PR #112052)

2024-10-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: I wonder if this is going to fix https://lab.llvm.org/buildbot/#/builders/141/builds/3100, so I am testing it right now. ``` c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\filecheck.exe C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell

[Lldb-commits] [lldb] [lldb] Replace Code Owners with Maintainers (PR #111686)

2024-10-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: I suggest @medismailben (or an Apple colleague he nominates), runs this test locally and does their best to narrow down the problem. @rocallahan does `rr` work on Mac? Because one cross check here would be to connect lldb to actual `rr` and see if that works. If it does th

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: See what @labath says since they commented there too. https://github.com/llvm/llvm-project/pull/112342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Log errors to the system log if they would otherwise get dropped (PR #111911)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: >the Swift fork starts by logging the used lldb version to the system log. Oh so this is why the tests on Windows suddenly printed version numbers then :) > I'm starting to wonder if we should just make the system log a NOOP on Linux > too like we did on Windows. The pit

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/112296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks for working on this feature, I will find the time to review it properly today. I don't remember whether the Arm ABI specifies a way to represent TLS variables, or whether it's the compilers that aren't producing it. If it's the former, we (Arm that is) do take prop

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Seems ok to me. I checked our bot and `make` is in a path without spaces, that's why we didn't see this problem there. https://github.com/llvm/llvm-project/pull/112342 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb][test] Enable TestDAP_runInTerminal on non-x86 architectures (PR #111543)

2024-10-08 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111543 I don't see an obvious reason it has to be x86 specific and local testing on Arm and AArch64 is fine. Originally disabled in 50337fb933e0f666d34d747a43d46840b3982bf7 in response to failures apparently ca

[Lldb-commits] [lldb] [lldb][test] Enable TestDAP_runInTerminal on non-x86 architectures (PR #111543)

2024-10-08 Thread David Spickett via lldb-commits
DavidSpickett wrote: Noticed this looking at a failure from https://github.com/llvm/llvm-project/pull/106919, which I think was unrelated. If this lands and our bot blows up I'll just revert this. https://github.com/llvm/llvm-project/pull/111543 ___

[Lldb-commits] [lldb] 7c10876 - [lldb][test] Fix unexpected pass of TestBSDArchives on Windows

2024-10-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-08T08:56:21Z New Revision: 7c1087613bb9f4ceebb991e5a4b2ef4d5adb4dfa URL: https://github.com/llvm/llvm-project/commit/7c1087613bb9f4ceebb991e5a4b2ef4d5adb4dfa DIFF: https://github.com/llvm/llvm-project/commit/7c1087613bb9f4ceebb991e5a4b2ef4d5adb4dfa.diff LOG

[Lldb-commits] [lldb] ec00999 - [lldb][test] Remove xfails from static lib tests on Windows

2024-10-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-08T08:58:43Z New Revision: ec009994a06338995dfb6431c943b299f9327fd2 URL: https://github.com/llvm/llvm-project/commit/ec009994a06338995dfb6431c943b299f9327fd2 DIFF: https://github.com/llvm/llvm-project/commit/ec009994a06338995dfb6431c943b299f9327fd2.diff LOG

[Lldb-commits] [lldb] 98c9c1a - [lldb][test] Disable new lldb-dap test on non-x86

2024-10-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-08T14:29:08Z New Revision: 98c9c1a4d2d4fc41b34f73e4630de435c9c0c396 URL: https://github.com/llvm/llvm-project/commit/98c9c1a4d2d4fc41b34f73e4630de435c9c0c396 DIFF: https://github.com/llvm/llvm-project/commit/98c9c1a4d2d4fc41b34f73e4630de435c9c0c396.diff LOG

[Lldb-commits] [lldb] Make env and source map dictionaries #95137 (PR #106919)

2024-10-08 Thread David Spickett via lldb-commits
DavidSpickett wrote: I suspect a missing unsupported annotation: ``` UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment (TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following par

[Lldb-commits] [lldb] [lldb][test] Enable TestDAP_runInTerminal on non-x86 architectures (PR #111543)

2024-10-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 146d3f0 - [lldb][test] Disable TestSharedLibStrippedSymbols on Arm

2024-10-09 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-09T08:51:38Z New Revision: 146d3f04ff92e396ea40ab581304e65e8511d8ac URL: https://github.com/llvm/llvm-project/commit/146d3f04ff92e396ea40ab581304e65e8511d8ac DIFF: https://github.com/llvm/llvm-project/commit/146d3f04ff92e396ea40ab581304e65e8511d8ac.diff LOG

[Lldb-commits] [lldb] Revert "[lldb][test] Enable TestDAP_runInTerminal on non-x86 architectures" (PR #111648)

2024-10-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111648 Reverts llvm/llvm-project#111543 https://lab.llvm.org/buildbot/#/builders/18/builds/5140 failed here again. Clearly there is something different on Arm but I don't know what it is yet. >From 358ad5760066

[Lldb-commits] [lldb] Revert "[lldb][test] Enable TestDAP_runInTerminal on non-x86 architectures" (PR #111648)

2024-10-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace Code Owners with Maintainers (PR #111686)

2024-10-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111686 To align with the new policy: https://llvm.org/docs/DeveloperPolicy.html#maintainers I've assumed that Jonas will be the "Lead Maintainer" as he was the default Code Owner. I know the past Code Owners w

[Lldb-commits] [lldb] [lldb] Replace Code Owners with Maintainers (PR #111686)

2024-10-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: Folks may want to read the new wording for themselves, but at least by my interpretation there's not much change from what I myself have been doing and what I've seen the folks listed in this file doing. So I don't think you're opting into a whole lot more work. https://g

[Lldb-commits] [lldb] [lldb] Replace Code Owners with Maintainers (PR #111686)

2024-10-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: Added a bunch of you on review not because this is some complex change, but just as a heads up in case you did want to reconsider being listed here or suggest alternatives. https://github.com/llvm/llvm-project/pull/111686 ___ lld

[Lldb-commits] [lldb] [lldb] Replace Code Owners with Maintainers (PR #111686)

2024-10-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/111686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: Failed on Arm and AArch64: ``` FAIL: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_reverse_continue_skip_breakpoint (TestReverseContinueBreakpoints.TestReverseContinueBreakpoints) lldb-server exiting... error: stopped due to an error

[Lldb-commits] [lldb] 993de55 - [lldb][docs] Add link to RISC-V tracking issue in Platform Support

2024-10-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-10T10:21:41+01:00 New Revision: 993de5512d81f4582373aa8bd7507e5aa44311ab URL: https://github.com/llvm/llvm-project/commit/993de5512d81f4582373aa8bd7507e5aa44311ab DIFF: https://github.com/llvm/llvm-project/commit/993de5512d81f4582373aa8bd7507e5aa44311ab.diff

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-10 Thread David Spickett via lldb-commits
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-10 Thread David Spickett via lldb-commits
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-10 Thread David Spickett via lldb-commits
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-10 Thread David Spickett via lldb-commits
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-10 Thread David Spickett via lldb-commits
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: So is this X86 and ARM64 or just one? Also this needs a release note, which is a good place to note the limitations as well. https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb][test] elf-memory.test requires LLDB build with Python support (PR #111810)

2024-10-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111810 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] elf-memory.test requires LLDB build with Python support (PR #111810)

2024-10-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111810 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is something to do with evaluating `false_condition`. With a normal session we see these libraries: ``` (lldb) image list [ 0] 371298DF 0xa000 /home/david.spickett/build-llvm-aarch64/lldb-test-build.noindex/functionalities/reverse-execution/TestReverseCont

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: So on x86, either `false_condition` doesn't require JIT, or it does and the mmap found is fine. I tried changing it to `0` or `false`, and while this will fall back to an interpreter, the lldb-server appears to have already died by the time that finishes. https://github.c

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,418 @@ +import os +import os.path +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbproxy import * +import lldbgdbserverutils +import re + + +class ThreadSnapshot: +def __init__(self, thread_

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: The problem is not to do with the debug symbols, or it being a "properly remote" connection due to the proxy and that messing up search paths. It's because evaluating an expression using JIT requires us to send a `vCont` and something goes wrong there, it appears to be mis

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also X86 may support the memory allocation packets and not need to call mmap to get JIT memory. So if making it a function call doesn't reproduce it, try hacking out support for `_M`. https://github.com/llvm/llvm-project/pull/99736 _

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-10-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: ping! https://github.com/llvm/llvm-project/pull/110104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-10-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: > TEST 'lldb-api :: > lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py' FAILED > This test is flaky on Arm 32, I'll figure it out. https://github.com/llvm/llvm-project/pull/104238

[Lldb-commits] [lldb] [lldb][debugserver] Check if Rosetta debugserver exists (PR #110943)

2024-10-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: > TEST 'lldb-api :: > lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py' FAILED There's something flaky about this test, I've seen it failing on unrelated patches a few times. We'll look into it. https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-16 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/112360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/112296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-10-21 Thread David Spickett via lldb-commits
DavidSpickett wrote: ping! @omjavaid https://github.com/llvm/llvm-project/pull/110104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c47df3e - [lldb][test] Make vector operator[] return T& to workaround Arm codegen issue

2024-10-21 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-21T11:54:54Z New Revision: c47df3e8c8f47bab8a8302757c50710e0e1c43fb URL: https://github.com/llvm/llvm-project/commit/c47df3e8c8f47bab8a8302757c50710e0e1c43fb DIFF: https://github.com/llvm/llvm-project/commit/c47df3e8c8f47bab8a8302757c50710e0e1c43fb.diff LOG

[Lldb-commits] [lldb] [lldb][docs] Fix "Developing LLDB" table of contents (PR #113166)

2024-10-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. I guess it sees each `# ...` as the start of a new document? Strange. https://github.com/llvm/llvm-project/pull/113166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: What you describe makes some sense, but could you give an example of where this is used? Can this be triggered with `lldb program file --`? If so it would be good to 1. put that in the commit message in case anyone hits the same problem and searches the log, and 2. add a

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: > @DavidSpickett General debugging commands can be used on LoongArch with some > known issues to be addressed. Here is a summary > https://github.com/llvm/llvm-project/issues/109394. For RISC-V I have been using https://github.com/llvm/llvm-project/issues/55383 as the tra

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: You may be able to reduce the file by changing the `/proc/pid/coredump_filter` value: https://man7.org/linux/man-pages/man5/core.5.html I can't say I understand them all but usually what I do is cut things until the test fails. I've been

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-17 Thread David Spickett via lldb-commits
@@ -833,6 +845,107 @@ def test_riscv64_regs_gpr_only(self): substrs=["registers were unavailable"], ) +@skipIfLLVMTargetMissing("LoongArch") +def test_loongarch64_regs(self): +# check registers using 64 bit LoongArch64 core file containing

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-17 Thread David Spickett via lldb-commits
@@ -833,6 +845,107 @@ def test_riscv64_regs_gpr_only(self): substrs=["registers were unavailable"], ) +@skipIfLLVMTargetMissing("LoongArch") DavidSpickett wrote: Is LoongArch one LLVM target or do you need to specifically have LoongArc

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-17 Thread David Spickett via lldb-commits
@@ -833,6 +845,107 @@ def test_riscv64_regs_gpr_only(self): substrs=["registers were unavailable"], ) +@skipIfLLVMTargetMissing("LoongArch") +def test_loongarch64_regs(self): +# check registers using 64 bit LoongArch64 core file containing

[Lldb-commits] [lldb] 2882bb1 - [lldb][docs] Add link to LoongArch tracking issue

2024-10-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-17T12:48:03+01:00 New Revision: 2882bb192b07674bc11fd5ddd5a4fa6cea194628 URL: https://github.com/llvm/llvm-project/commit/2882bb192b07674bc11fd5ddd5a4fa6cea194628 DIFF: https://github.com/llvm/llvm-project/commit/2882bb192b07674bc11fd5ddd5a4fa6cea194628.diff

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Not sure what's going on with the register formatting. It might be that because we do a substring comparison, `foo = 0x00` is found in `foo = 0x`. So I would recommend loading the core file manually and just copying whatever `register read` shows. If the formatting

[Lldb-commits] [lldb] [lldb] Replace Code Owners with Maintainers (PR #111686)

2024-10-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'll land this on Monday unless anyone objects. After that anyone can make their own changes as usual. https://github.com/llvm/llvm-project/pull/111686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] 39cdfdf - [lldb][test] Fix typo in TestSharedLibStrippedSymbols

2024-10-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-08T09:36:56Z New Revision: 39cdfdfad961e146131966757d563bfd667246d6 URL: https://github.com/llvm/llvm-project/commit/39cdfdfad961e146131966757d563bfd667246d6 DIFF: https://github.com/llvm/llvm-project/commit/39cdfdfad961e146131966757d563bfd667246d6.diff LOG

[Lldb-commits] [lldb] [lldb] Fix finding make tool for tests (PR #111980)

2024-10-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix finding make tool for tests (PR #111980)

2024-10-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: I don't think so, it's used to generate dotest.py on all platforms I think. Perhaps my cmake is being strict / less strict? The funny thing is, I can see `LLDB_TEST_MAKE` set in the cache even when the build breaks. https://github.com/llvm/llvm-project/pull/111980

[Lldb-commits] [lldb] d941254 - [lldb][test] Fix var name typo in TestProcessSaveCoreMinidump

2024-10-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-10-11T11:00:07Z New Revision: d941254da94c8a5897689a74012a57de279c2c9e URL: https://github.com/llvm/llvm-project/commit/d941254da94c8a5897689a74012a57de279c2c9e DIFF: https://github.com/llvm/llvm-project/commit/d941254da94c8a5897689a74012a57de279c2c9e.diff LOG

[Lldb-commits] [lldb] [lldb] Fix finding make tool for tests (PR #111980)

2024-10-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111980 Fixes 0e913237871e8c9290e82be30be8b3484952eee0 / https://github.com/llvm/llvm-project/pull/111531 For reasons I can't explain, a clean build works fine for me, and all the bots are working fine. But if I

[Lldb-commits] [lldb] [lldb] Fix finding make tool for tests (PR #111980)

2024-10-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: Putting this in review because I've zero idea why this fixes it. Without it I get this on a rebuild: ``` Traceback (most recent call last): File "/home/david.spickett/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py", line 67

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: The only info I can get out of the call to `__mmap` is that it's frame 0 is at `0x` aka "the process died for some reason". I'm thinking that something is preventing us finding the debug info files because this is a "remote" not a local server, haven't found what y

[Lldb-commits] [lldb] [lldb] Log errors to the system log if they would otherwise get dropped (PR #111911)

2024-10-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Log errors to the system log if they would otherwise get dropped Dropped because of what exactly, because the user did not enable a channel that would include them? How does one enable collection of these with the current lldb? > @DavidSpickett, do you have any thoughts

[Lldb-commits] [lldb] [lldb] Make the system log a NOOP on Windows (PR #112052)

2024-10-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: Merging to fix our Windows bot. https://github.com/llvm/llvm-project/pull/112052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make the system log a NOOP on Windows (PR #112052)

2024-10-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/112052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make the system log a NOOP on Windows (PR #112052)

2024-10-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/112052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-25 Thread David Spickett via lldb-commits
@@ -0,0 +1,486 @@ +""" +Specification, compiler, disassembler, and interpreter +for LLDB dataformatter bytecode. + +See formatter-bytecode.md for more details. +""" +from __future__ import annotations + +# Types +type_String = 1 +type_Int = 2 +type_UInt = 3 +type_Object = 4 +type_

<    14   15   16   17   18   19   20   21   22   23   >