Author: David Spickett Date: 2020-10-12T15:09:49+01:00 New Revision: 2d1ee7cae9b2299186fa25d8d1fbdb8af482046c
URL: https://github.com/llvm/llvm-project/commit/2d1ee7cae9b2299186fa25d8d1fbdb8af482046c DIFF: https://github.com/llvm/llvm-project/commit/2d1ee7cae9b2299186fa25d8d1fbdb8af482046c.diff LOG: [lldb] Note difference in vFile:pread/pwrite format for lldb https://sourceware.org/gdb/current/onlinedocs/gdb/Host-I_002fO-Packets.html States that all numbers should be hexidecimal but lldb uses decimals in vFile:pread and vFile:pwrite. lldb-server can accept either since it ends up using strtoull which will detect the base being used. Reviewed By: labath Differential Revision: https://reviews.llvm.org/D89227 Added: Modified: lldb/docs/lldb-platform-packets.txt Removed: ################################################################################ diff --git a/lldb/docs/lldb-platform-packets.txt b/lldb/docs/lldb-platform-packets.txt index 8d3fed7ab341..e688fc92bb7e 100644 --- a/lldb/docs/lldb-platform-packets.txt +++ b/lldb/docs/lldb-platform-packets.txt @@ -411,6 +411,12 @@ incompatible with the flags that gdb specifies. // // Response is F, followed by the number of bytes read (base 10), a // semicolon, followed by the data in the binary-escaped-data encoding. +// +// COMPATIBILITY +// The gdb-remote serial protocol documentation says that numbers +// in "vFile:" packets should be hexidecimal. Instead lldb uses +// decimal for the number of bytes and offset. +// lldb-server can process either format. //---------------------------------------------------------------------- @@ -430,7 +436,11 @@ incompatible with the flags that gdb specifies. // 3. binary-escaped-data to be written // // Response is F, followed by the number of bytes written (base 10) - +// +// COMPATIBILITY +// The gdb-remote serial protocol documentation says that numbers +// in "vFile:" packets should be hexidecimal. Instead lldb uses +// decimal for the offset. lldb-server can process either format. _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
