[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a few targeted tests to make sure that when refactoring this function later I don't break these proper

[Lldb-commits] [PATCH] D123501: [lldb][NFC] Simplify part of Options::GenerateOptionUsage

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use llvm::enumerate, remove an unused arg name stream and replace repeated uses of indexing to get the option de

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of building a set twice for optional and required, build a set for each while walking the options once.

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

DavidSpickett added a reviewer: jingham. DavidSpickett added a subscriber: jingham. DavidSpickett added a comment. @jingham You suggested I take a look at this function after I did a small fix a while back so adding you on review for this and the following changes. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This means we don't have to remember to update this code as much. Thi

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

DavidSpickett added a reviewer: labath. DavidSpickett added a subscriber: labath. DavidSpickett added a comment. @labath This addresses (most of) what you asked about in https://reviews.llvm.org/D121999. The architecture revision is still manual but given how lax llvm is about allowing any exten

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett updated this revision to Diff 422164. DavidSpickett added a comment. !empty instead of size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123502/new/ https://reviews.llvm.org/D123502 Files: lldb/source/Interpreter/Options.cpp Inde

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Interpreter/Options.cpp:457 - if (!options.empty()) { -// We have some required options with no arguments + if (required_options.size()) { str

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

DavidSpickett updated this revision to Diff 422191. DavidSpickett added a comment. Use llvm::join. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123582/new/ https://reviews.llvm.org/D123582 Files: lldb/source/Plugins/Disassembler/LLVMC/Disassemb

[Lldb-commits] [PATCH] D123582: [lldb][AArch64] Automatically add all extensions to disassembler

This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rG0231a90bc438: [lldb][AArch64] Automatically add all extensions to disassembler (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Given that you'd never find empty string, just error. Also add a test that an invalid expr generates an error.

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

DavidSpickett added a comment. Previously this would crash. Unless we'd rather treat it as `\x0` but that could be confusing. You can always search for literal 0 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123793/new/ https://reviews.l

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

This revision was automatically updated to reflect the committed changes. Closed by commit rG68e73eaee632: [lldb] Handle empty search string in "memory find" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123793/new/ http

[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. FixAnyAddress is to be used when we don't know or don't care whether w

[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

DavidSpickett added reviewers: omjavaid, JDevlieghere. DavidSpickett added a subscriber: JDevlieghere. DavidSpickett added a comment. This comes from https://reviews.llvm.org/D118794 on the subject of whether it's ok to just pick one of fixcode/fixdata and assume it'll work. Of all the uses of F

[Lldb-commits] [PATCH] D121876: [BOLT][DWARF] Implement monolithic DWARF5.

DavidSpickett added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s:17 -# RUN: %clang_host -o %t %s \ +# RUN: %clang_host -gdwarf-4 -o %t %s \ # RUN: %S/Inputs/DW_TAG_variable-DW_AT_decl_fil

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123502/new/ https://reviews.llvm.org/D123502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

DavidSpickett added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123500/new/ https://reviews.llvm.org/D123500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

DavidSpickett added a comment. Bunch of random nits. Looks like a great addition. I know debug load time is a common annoyance. Comment at: lldb/docs/use/ondemand.rst:1 +On Demand Symbols += If you can find a logical place for it, maybe define

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added a comment. The current assumption is that once you've got a valid (currently anything non-zero) mask then that's it, it's not going to change. I think a future extension could change the meaning of the existing non-address bits at runtime, but that wouldn't be a problem unle

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added a comment. There's some argument that the thing asking for the mask shouldn't ask so early but I think the logic here is still an improvement regardless. If we don't have a thread yet we can't have a mask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added a comment. > If we don't have a thread yet we can't have a mask. Though this isn't a watertight argument since I think Mach corefiles can have a note that tells you the number of addressable bits. In our case there's nothing like that. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

DavidSpickett updated this revision to Diff 424900. DavidSpickett added a comment. I realised that in theory the tests could still pass if your ordering just happend to land in the right way. For the short option `[-ABCabc]` there's not a lot I can do about that, so I added another check for a di

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:288 + if (lldb::ABISP abi_sp = GetABI()) +addr = abi_sp->FixDataAddress(addr); + omjavaid wrote: > Is this a candidate for FixAnyAddress ? Absolutely. I

[Lldb-commits] [PATCH] D124601: [lldb] Use shutil.which instead of distutils find_executable

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. distutils is deprecated and shutil.which is the suggested replacement for this function. https://peps.python.or

[Lldb-commits] [PATCH] D124601: [lldb] Use shutil.which instead of distutils find_executable

DavidSpickett added a reviewer: JDevlieghere. DavidSpickett added a comment. https://reviews.llvm.org/D124429 unblocked doing this. The github issue is https://github.com/llvm/llvm-project/issues/54337. Once I know this is ok with the bots I'll see what I can do about our various `which` re-imp

[Lldb-commits] [PATCH] D124604: [lldb] Use shutil.which in Shell tests find_executable

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In build.py we have our own find_executable that looks a lot like the distutils one that I switched to shutil.wh

[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rGb809c4cdb70a: [lldb] Add FixAnyAddress to ABI plugins (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124000/new/ https://reviews

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett updated this revision to Diff 425778. DavidSpickett added a comment. Use FixAnyAddress instead of FixDataAddress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 Files: lldb/source/Target/

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett updated this revision to Diff 425779. DavidSpickett added a comment. Use FixAnyAddress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122411/new/ https://reviews.llvm.org/D122411 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

DavidSpickett accepted this revision. DavidSpickett added a comment. All my comments were addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 ___ lldb-co

[Lldb-commits] [PATCH] D124601: [lldb] Use shutil.which instead of distutils find_executable

This revision was automatically updated to reflect the committed changes. Closed by commit rG14869bd2dfab: [lldb] Use shutil.which instead of distutils find_executable (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124601/

[Lldb-commits] [PATCH] D124604: [lldb] Use shutil.which in Shell tests find_executable

This revision was automatically updated to reflect the committed changes. Closed by commit rG713752610edd: [lldb] Use shutil.which in Shell tests find_executable (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124604/new/

[Lldb-commits] [PATCH] D124670:

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TODO: This would require packaging (https://github.com/pypa/packaging) to be added as a third party module, i

[Lldb-commits] [PATCH] D124670:

DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/54337. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124670/new/ https://reviews.llvm.org/D124670 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

DavidSpickett added a comment. I reverted this due to an assert: https://lab.llvm.org/buildbot/#/builders/96/builds/22715/steps/6/logs/stdio (set cmake `LLVM_ENABLE_ASSERTIONS` to `ON`) I think you could just add PowerPC to the `if (!reg_interface` there but first time looking at the code I'm

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

This revision was automatically updated to reflect the committed changes. Closed by commit rGca0b41665978: [lldb][NFC] Add more tests for GenerateOptionsUsage (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123500/new/ htt

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett added a comment. > Were there any tests for the help output? If not, maybe we should add one. For these bits no, in fact I broke them without realising at first. Hence the tests in the other review as you saw, they'll be landed before this. Thanks for the reviews! Repository:

[Lldb-commits] [PATCH] D123501: [lldb][NFC] Simplify part of Options::GenerateOptionUsage

This revision was automatically updated to reflect the committed changes. Closed by commit rG61f2d3074699: [lldb][NFC] Simplify part of Options::GenerateOptionUsage (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123501/new

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf05de7168b0: [lldb][NFC] Refactor printing of short options in help (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123502/new/

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

DavidSpickett added a comment. Looks good to me but final decision for @mgorny . Comment at: lldb/test/API/python_api/sbvalue_const_addrof/main.cpp:2 +#include +#include Stray change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D125089: [lldb] Change implementation of memory read --show-tags option

DavidSpickett created this revision. Herald added a subscriber: mgorny. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This does 2 things: - Moves it after the short options. Which makes sense gi

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is off by default. If you get a result and that memory has memory tags, when --show-tags is given you'll se

[Lldb-commits] [PATCH] D125089: [lldb] Change implementation of memory read --show-tags option

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. I did try to add the option via Options.td but adding a multi character short option there doesn't seem to work. I could enable that but it seems like just as much work to make an option group for it. Repository: rG LLV

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

DavidSpickett updated this revision to Diff 427609. DavidSpickett added a comment. Test that show-tags without finding anything doesn't do anything strange. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125090/new/ https://reviews.llvm.org/D125090

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

DavidSpickett added a comment. The logic for handling misalignment is all done in DumpDataExtractor so that is covered by the "memory read --show-tags" tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125090/new/ https://reviews.llvm.org/D1250

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

DavidSpickett updated this revision to Diff 427612. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125090/new/ https://reviews.

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

DavidSpickett added a comment. Can you add a test for the help output to `lldb/test/API/commands/help/TestHelp.py` ? Just the one line that includes the argument list is fine. Also I see that we don't test this part of the command at all. Not an issue for this change (I assume it is working fo

[Lldb-commits] [PATCH] D125218: [lldb][NFC] Make cmd a reference in GenerateOptionUsage

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Nowhere in lldb do we call this with a null pointer. If we did, the first line of the function would fault anywa

[Lldb-commits] [PATCH] D125219: [lldb][NFC] Simplify GenerateOptionUsage

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Once we get into the if block we know the value of only_print_args. Move some variables closer to point of use.

[Lldb-commits] [PATCH] D125218: [lldb][NFC] Make cmd a reference in GenerateOptionUsage

This revision was automatically updated to reflect the committed changes. Closed by commit rGe473e79cd194: [lldb][NFC] Make cmd a reference in GenerateOptionUsage (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125218/new/

[Lldb-commits] [PATCH] D125219: [lldb][NFC] Simplify GenerateOptionUsage

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a94e3801dd7: [lldb][NFC] Simplify GenerateOptionUsage (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125219/new/ https://review

[Lldb-commits] [PATCH] D125786: [lldb] const a couple of getters on MemoryRegionInfo

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. GetDirtyPageList was being assigned to const & in most places anyway. If you wanted to change the list you'd mak

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430042. DavidSpickett added a comment. Herald added a project: All. Correct help text. Make a parameter const (uses the previous stacked change). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111791/new/

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430055. DavidSpickett added a comment. Figured that the usage was now a bit confusing. Though I'm not sure how to write "either" in symbols, I see {A|B} used in some other tools, I've just stuck with the word "or" for now. Doesn't matter too much, the

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430088. DavidSpickett added a comment. Move variables closer to usage in DumpRegion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111791/new/ https://reviews.llvm.org/D111791 Files: lldb/source/Comman

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430092. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add a release note before I inevitably forget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett updated this revision to Diff 430276. DavidSpickett added a comment. Correct "addr" -> "fixed_addr" in a couple of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 Files: lldb/sou

[Lldb-commits] [PATCH] D125786: [lldb] const a couple of getters on MemoryRegionInfo

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7d8ec4dc4461: [lldb] const a couple of getters on MemoryRegionInfo (authored by DavidSpickett). Repository: rG LLVM Git

[Lldb-commits] [PATCH] D125786: [lldb] const a couple of getters on MemoryRegionInfo

DavidSpickett added a comment. Landed as obvious as I'll shortly land the follow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125786/new/ https://reviews.llvm.org/D125786 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430293. DavidSpickett added a comment. Fixup the tagged memory region test (it doesn't care about the content of the usage just that the command eventually fails) and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430312. DavidSpickett added a comment. Fixup the loop on systems that have more non-address bits than just top byte ignore. With only top byte ignore: - We ask the remote for the last region - It says ok it's unmapped and it ends at 0xFF - Then we

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e648f195c3d: [lldb] Add --all option to "memory region" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9398a91e2a6: [lldb] Remove non-address bits from read/write addresses in lldb (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

This revision was automatically updated to reflect the committed changes. Closed by commit rG00a12585933e: [lldb][AArch64] Fix corefile memory reads when there are non-address bits (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D125089: [lldb] Change implementation of memory read --show-tags option

This revision was automatically updated to reflect the committed changes. Closed by commit rG29e556fc2ba9: [lldb] Change implementation of memory read --show-tags option (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12508

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett added a comment. Relanded in https://reviews.llvm.org/rG13e1cf806567bc4987817e14a774198c3e3f2709. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111791/new/ https://reviews.llvm.org/D111791

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG068f14f1e4ec: [lldb] Add --show-tags option to "memory find" (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D12509

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address = region.GetRegionEnd() Davi

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Much clearer now, thanks. LGTM with the one nit fixed. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:42

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. I know very little about the interpreter so someone else can comment there. Certainly seems like a useful change. Added some generic comments. Comment at: lldb/test/API/lang/c/fpeval/TestFPEval.py:1

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

DavidSpickett added a comment. (I also keep an eye on the bots Omair was referring to) You can just reland this change as is (revert your revert) and if something else goes wrong you'll either get a failure email or we'll let you know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

DavidSpickett added a comment. > This changes the PE/COFF and PDB plugins to set the module triple according > to the default target triple used to build LLDB. I'm missing some context here but using triple used when *building* lldb seems to conflict with the idea that the same lldb (client at

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

DavidSpickett added a comment. There is an arch setting to `target create` but I doubt passing the whole triple there will make a difference (truncated to arch only at best). Platforms do have settings so you could try adding something to `remote-windows` or presumably `host` when run on Window

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Can you include some links to documentation of the debuglink feature in the commit message? I assume https://sourceware.org/gdb/onlinedocs/gdb/Separate-Debug-Files.html is what you'd want. Comment at: l

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. I won't have time to comment much more but Omair might be able to help. Also you might want to look at how the apple platforms select their ABI if you haven't already. If the answer is "with a flag in the object file" then

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:883 + std::string gnu_debuglink_file = data.GetCStr(&gnu_debuglink_offset); + gnu_debuglink_offset = llvm::alignTo(gnu_debuglink_offset, 4); + data.GetU32(&g

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This LGTM. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:929 + if (GetDebugLinkContents

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

DavidSpickett added a comment. Is it easy to test this? Ideally this behaviour works with a path to a file as well as `PATH` itself e.g. `C:\foo` becomes `C:\foo.exe` and you could write a test that only runs on Windows quite easily. If not I guess you could do a shell test that compiles a pro

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13 +EnumValues<"OptionEnumValues(g_abi_enums)">, +Desc<"A mapping of ABI override to use for specific modul

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Any reason to `#if 0` this instead of just removing it and maybe adding a one line comment like "nested exceptions are not supported"? So that someone can git blame that and find this commit with the removal. If this

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13 +EnumValues<"OptionEnumValues(g_abi_enums)">, +Desc<"A mapping of ABI override to use for specific modules. The module name is matched by its file nam

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128201/new/ https://reviews.llvm.org/D128201 _

[Lldb-commits] [PATCH] D128226: [lldb] Remove an outdated comment. NFC.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128226/new/ https://reviews.llvm.org/D128226 _

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Are there public docs for these numbers? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128221/new/ https://reviews.llvm.org/D128221 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

DavidSpickett added a comment. > However, after this commit, if the object file is advertised with the > different environment (either when built in a mingw environment, or if that > setting is set), the fat binary validation won't accept the file any longer. Is "this commit" referring to http

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

DavidSpickett added a comment. > Now since the addition of the new setting in > 25c8a061c5739677d2fc0af29a8cc9520207b923 > , > ObjectFile::GetModuleSpecifications can return i386-pc-windows-gnu and > i686-pc-windows-gnu, whil

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm.org/D127234 _

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436 _

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. I like the ifs the way I suggested but up to you, either way it's not the easiest logic to parse. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

DavidSpickett added a comment. I've reverted this due to failures on our bots: https://lab.llvm.org/buildbot/#/builders/96/builds/25032/steps/6/logs/stdio /usr/bin/ld: /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/test/Shell/Commands/Output/dwarf5-low-pc-ranges-inlining.test

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

DavidSpickett added a comment. Looks mechanically fine. These classes are all a bit of a copy paste job right now, so if you were going to take inspiration riscv is your best bet. On the subject of coding style, https://lldb.llvm.org/resources/contributing.html. Coding Style: LLDB’s code sty

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

DavidSpickett added a comment. Looked at the lldb changes, some comments for you. If you want to get a "looks good" for those please submit a separate review with only the lldb parts and I'll review that instead. As others said, appreciate the effort but the review process doesn't scale well t

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

DavidSpickett accepted this revision. DavidSpickett added a comment. This LGTM. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h:58 + uint32_t reg_num) override; + lldb::addr_t ReadPC(bool *succe

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

DavidSpickett added a comment. If you don't have LTO, does this mean that only that one test won't run, or will the whole suite not run? Perhaps I misunderstand the purpose of add_lldb_test_dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. Before I look closely, I see you added namespace llvm. This is fine, neatens things up but can we get that in its own change? Also, llvm is moving to std::optional, can you do that and make it its own patch too? Of course add me to review both, should be pretty me

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. Further work: RV32DC and RV64DC instructions support. Also I don't think we need this in the commit message. Unless someone might assume it was included. In which case I'd be explicit "this does not include ". Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett added a comment. Is the further work in the commit message work you intended to include in this patch? I appreciate the status update might be useful for some but commit messages are for describing what's in a commit (among other things). If you think people might wrongly assume t

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This is all very repetitive, but that's to be expected. Whatever you can do to reduce boilerplate in future patches would be great. For example, can 32 and 64 bit variants of som

<    1   2   3   4   5   6   7   8   9   10   >