[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D157214: [lldb] Fix typo in comments and in test

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa2784876a24: [lldb] Fix typo in comments and in test (authored by Eymay, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157214/n

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This has always worked but had no coverage. Adding testing now so that

[Lldb-commits] [PATCH] D157589: [lldb] Fix building with latest libc++

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157589/new/ https://reviews.llvm.org/D157589

[Lldb-commits] [PATCH] D157609: WIP: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. DavidSpickett planned changes to this revision. Herald added

[Lldb-commits] [PATCH] D157609: WIP: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/28667 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

DavidSpickett updated this revision to Diff 549834. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157000/new/ https://reviews.llvm.org/D157000 Files: lldb/test/API/commands/register/register/aarch64_sve_sim

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett updated this revision to Diff 549835. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157488/new/ https://reviews.llvm.org/D157488 Files: lldb/test/API/commands/register/register/aarch64_mte_ctrl

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 549836. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156687/new/ https://reviews.llvm.org/D156687 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D157845: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This always succeeds. While I'm here, document why we check the size o

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's SVE register state to TestArm64DynamicRegsets

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Since we need to switch modes, this is its own test. I will b

[Lldb-commits] [PATCH] D157609: WIP: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett updated this revision to Diff 549872. DavidSpickett added a comment. Cleanup, add testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 Files: lldb/source/Plugins/SymbolFile/DWARF/Symbo

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett added reviewers: aprantl, clayborg, lenary. DavidSpickett added a subscriber: lenary. DavidSpickett added a comment. https://github.com/llvm/llvm-project/issues/28667 is the github issue. @lenary This fixes your reproducer, if you have any more ways to confuse lldb please try them

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. The "Matrix" part of the Scalable Matrix Extensi

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 549951. DavidSpickett added a comment. Rebase and reimplement this on top of ZA/SVG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett added a comment. I realise this is a giant patch, so if you see a way to split it, great. However, SVG is read from the ZA header and we need SVG to implement the resizing of ZA. So at least those are tied to each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1737 + if (!dwo_file.IsRelative()) { +found = FileSystem::Instance().Exists(dwo_file); + } else { clayborg wrote: > Maybe we can also check the debug i

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett added a comment. > We are also looking for a way to locate .dwo files at Meta. One idea we came > up with is to add a setting that can be set: > (lldb) settings set symbols.locate-dwo-script /path/to/locate-dwo.py Probably best bring this up on Discourse for a wider audience as I'm

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 550250. DavidSpickett added a comment. In TestZAThreadedDynamic.py, replace the while < 3 threads check in Python with atomic variables in the program file. This fixes a situation where the first "process continue" hits the breakpoint in thread 2, and w

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we would "process continue" then wait for the number of thr

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett added a comment. One recent example of a timeout on the Graviton bot: https://lab.llvm.org/buildbot/#/builders/96/builds/43649 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157967/new/ https://reviews.llvm.org/D157967 __

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. I was not able to reproduce the bot's timeout situation with this or the previous implementation, but I did run this on a loop with `stress` in the background and didn't get any failures. I think doing it with atomics is at

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 550289. DavidSpickett added a comment. Replace missing process variable in TestZAThreadedDynamic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157883/new/ https://reviews.llvm.org/D157883 Files: lldb/

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 550290. DavidSpickett added a comment. Remove redundant get process calls in TestSVEThreadedDynamic.py. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157883/new/ https://reviews.llvm.org/D157883 Files:

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To address https://github.com/llvm/llvm-project/issues/64616, this cha

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett added reviewers: JDevlieghere, bulbazord. DavidSpickett added a comment. I've confirmed the instructions work for x86 -> AArch64. The original issue was x86 -> Arm 32 bit, so I hope to get the issue reporter to confirm whether the instructions make sense with this change. Reposit

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 550769. DavidSpickett added a comment. Correct regiter -> register in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Proc

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

DavidSpickett added a comment. I was in this exact situation yesterday but luckily I had already used a virtualenv to fix some other Python problems so I knew how to fix it. Had it not been for that, seeing the exact Python path would have been very useful here, thanks for adding this message.

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett added a comment. I think `CMAKE_TOOLCHAIN_FILE` is the "proper" way to be passing `CMAKE_SYSTEM_NAME` etc. so let me look into that. It may be something we get away with with current CMake, but breaks later, much like `CMAKE_CROSS_COMPILING` seemed to be less effective as time wen

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

DavidSpickett added a comment. I fixed a typo in this to get the Windows build going again: https://github.com/llvm/llvm-project/commit/f8d1209f966ccd1dd0a19f3acef0871bf8fc3c94 I assume it's a typo, not an attempt to use what seems to have been a NetBSD type at one point. Repository: rG LLV

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett updated this revision to Diff 551122. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D158182: [lldb] Try to find relative DWO files by file name only, as a last resort

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. Relative DWO files are normally found at some/path/to/file.

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1737 + if (!dwo_file.IsRelative()) { +found = FileSystem::Instance().Exists(dwo_file); + } else { David

[Lldb-commits] [PATCH] D158182: [lldb] Try to find relative DWO files by file name only, as a last resort

DavidSpickett added a comment. @clayborg This is I think what you meant. I'm not 100% sure it's safe because I keep wondering if we could find the wrong files this way, but with 1 DWO file per program it seems unlikely. I've reduced the nesting in the new tests compared to the previous patch. A

[Lldb-commits] [PATCH] D158209: [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158209/new/ https://reviews.llvm.org/D158209

[Lldb-commits] [PATCH] D158251: [lldb] Propagate destination type's byte order to memory writer

DavidSpickett added a comment. Seems like a noble goal but I don't have the experience to review. I will just ask, how do you plan to test this? I guess this change is in response to an issue you hit, that's a good place to start from. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett updated this revision to Diff 551469. DavidSpickett added a comment. Address feedback from Github issue: - Include the whole command not just the additions. - Note how to find the possible values of CMAKE_SYSTEM_*. - Add a note about testing and setting the test compiler. Reposito

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett added a comment. > It could be useful to also document some other interesting cross-compilation > options like CMAKE_TOOLCHAIN_FILE So this is the way CMake prefers you to do it, but I don't really understand the best practice so I'll leave it out for now. We have plenty of caches

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett updated this revision to Diff 551483. DavidSpickett added a comment. Use `` so people have to think about what that should be for their build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158085/new/ https://reviews.llvm.org/D158085

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett added a comment. Will land Monday unless there are other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158085/new/ https://reviews.llvm.org/D158085 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Which was done in https://reviews.llvm.org/D157058. This follows the fix for lldb-server in https://reviews.llvm

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG7549cde6bd52: [lldb][debugserver] Fix build after libcxx removed generic char_traits… (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

DavidSpickett added a comment. I was going to wait for some Mac specific reviewer too but it's simple and the Green Dragon bots should verify it well enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158391/new/ https://reviews.llvm.org/D15839

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds the ability to read streaming SVE registers, ZA, SV

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett added a comment. I did have some code to verify the arguments were passed correctly to the program but it made each core file 200k so I don't think it's worth it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://revi

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett created this revision. Herald added subscribers: ctetreau, arphaman, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This adds a release note for all

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett added reviewers: omjavaid, jasonmolenda. DavidSpickett added a subscriber: jasonmolenda. DavidSpickett added a comment. @jasonmolenda you asked some good questions about all this before, any of those not answered by this doc? No need to look deeply into anything, just stuff that co

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett added a comment. And if one of those is why does lldb use `vg` with these strange units, I think "vg" the term Arm's Fast Models used and GDB adopted it. It's possible we could improve that later but for now it is what it is. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes a bug where writing vg during streaming mode could

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett added a comment. And if you're wondering, ZA being disabled after a vector length change is expected. lldb is just reporting what the kernel does here. lldb-server will still give you back a block of 0s though and that's what was not shown in this situation. Repository: rG LLV

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett updated this revision to Diff 552360. DavidSpickett added a comment. Link to CMake's cross compilation docs up front, as a fallback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158085/new/ https://reviews.llvm.org/D158085 Files:

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett added a comment. > IMO it's usually the safest/most sustainable way to maintain > cross-compilation jobs. Part of my unfamiliarity is that I don't cross compile more than one configuration at a time, so a another config file just to do what I already do always seems like work I d

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

This revision was automatically updated to reflect the committed changes. Closed by commit rG1083ae234718: [LLDB][Docs] Update cross compilation docs and examples (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158085/new/

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 552623. DavidSpickett added a comment. - Correct speeling. - Drop repeated word. - Clarify vg/vq/vl explanation and end with a listing of each value for the example shown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett added a comment. > LGTM, fwiw. Thanks! I wanted to have someone who wasn't knee deep in this to look it over. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 ___

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

DavidSpickett added a comment. I'm not familiar with this mechanism but just out of curiosity: `ld.so loads the main executable and any dependent shared libraries and wants to update the "_r_debug" structure, but it now finds "_r_debug" in the a.out program and updates the state in this other c

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:260-266 +// the dynamic loader. The problem happens as soon as the executable or +// shared library that exports another "_r_debug" is loaded by the dynamic +

[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

DavidSpickett added a comment. And this is being done for what reason? I seem to remember something about static and anonymous namespace in the developer guide, please cite that if so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158971/new/ htt

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159011/new/ https://reviews.llvm.org/D159011

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. > I have a feeling that expressions are becoming an expensive operation with > amount of data we need to move back and forth between various buffers. Is > there a way we can optimise this may be write register directly from source > buffer. I don't know about exp

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. > Is there a way we can optimise this may be write register directly from > source buffer. Though now I wonder if when you say source here you mean the member buffers in the register context, or literally the `src` pointer we use in the code. Repository: rG LL

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. From what little I know about the ABI this looks ok. Consider adding a riscv expert to check those bits for you. Testing wise riscv is in a strange place without a working lldb-server or a buildbot that could run such

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. Also could you provide a list of things you have tested with qemu. So I can get an idea of how sure we can be any of this works / be a test plan, albeit manual for anyone updating this code in future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. I understand now. If we take `WriteTLS` for example, that ends with `m_tls_is_valid = false;`. So you're suggesting instead we have a `WriteTLS` whose source is not the usual TLS buffer, but the set of saved register data instead. I'll look into it. Repository:

[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > Are you referring to > https://llvm.org/docs/CodingStandards.html#anonymous-namespaces? That's the one, please include that in the commit message. Other than that this LGTM.

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

DavidSpickett added a comment. The added context helps document what was already there so that's a nice improvement. Something I'm not clear on mechanically. The original r_debug has eAdd set. Then the second r_debug is loaded, which also has eAdd set. What is the state of r_map at that point?

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:145 + return false; +} + ted wrote: > DavidSpickett wrote: > > Looking at the comments in lldb/include/lldb/Target/ABI.h I'm not sure > > which of these should be i

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. > I've done the following: Great. Could you include that in the commit message? Seems like we get a lot of questions about how mature risc-v support is, so we can point to this as a milestone for that. There is https://lldb.llvm.org/#platform-support but there's

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

DavidSpickett updated this revision to Diff 554648. DavidSpickett added a comment. Single function to set the simd values, that takes a base value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157000/new/ https://reviews.llvm.org/D157000 Files:

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_sve_simd_registers/main.c:43 +void write_simd_regs_expr() { +#define WRITE_SIMD(NUM)

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett updated this revision to Diff 554652. DavidSpickett added a comment. Remove unused includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157488/new/ https://reviews.llvm.org/D157488 Files: lldb/test/API/commands/register/register

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett added a comment. > This looks fine but instead of adding a new test cant we add MTE control > register tests to already available MTE tests? We have these existing tests: mte_core_file - clearly it can't go here, core files are read only. mte_memory_region - memory regions have not

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett updated this revision to Diff 554657. DavidSpickett added a comment. Remove HWCAP check from program file. The runner will check cppuinfo and even if that was fooled, the prctl would fail at runtime if you didn't have MTE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 554744. DavidSpickett added a comment. clang-format some missing bits. Replace a missing memcpy in the FPR case. This only works because the buffer happens to still contain the previous state. If there is some route to restore arbitray states, this wo

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. First thing to note is that WriteRegister also behaves this way, but there it is more appropriate because it updates only part of the buffer before writing it out in its entirety. Useful to know where the pattern came from though. You would need roughly the follow

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I understand the mechanism now, so for lack of any other strong opinions, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15858

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett updated this revision to Diff 554938. DavidSpickett added a comment. Actually these don't need to be atomic. They aren't writing to the same locations we just have one writer and one reader, and if the reader is delayed a bit it's not a problem. The volatile isn't needed at -O0 but

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0407f681a7ef: [lldb][AArch64] Use atomics to sync threads in SVE threading test (authored by DavidSpickett). Repository:

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett added a comment. The only way to know this truly works is to observe it on the bot for a while and I'm already piling too many reviews on Omair as it is. So I've gone ahead and landed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. > The only area of concern could be a LLDB running on a resource constrained > container but we can ignore that for now. Ironically we're the ones who are most likely to see that issue :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rG6697afe99fb6: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test (authored by DavidSpickett).

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

This revision was automatically updated to reflect the committed changes. Closed by commit rG22044f0bde01: [lldb][AArch64] Add testing of save/restore for Linux MTE control register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 554993. DavidSpickett added a comment. Herald added a subscriber: sunshaoce. As for the SVE test, the sync variables don't need to be atomic. Each one has one writer and one reader only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett updated this revision to Diff 555330. DavidSpickett added a comment. In the interests of my own sanity I've squashed the subsequent review into this one and applied the suggestions from both. Also I changed the tests to look for a global so we don't have to update the line number a

[Lldb-commits] [PATCH] D158182: [lldb] Try to find relative DWO files by file name only, as a last resort

DavidSpickett abandoned this revision. DavidSpickett added a comment. Squashed into previous review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158182/new/ https://reviews.llvm.org/D158182 ___ lldb-co

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755 + dwo_file.AppendPathComponent(dwo_name); + found = FileSystem::Instance().Exists(dwo_file); +} else {

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 555333. DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Use *.dwo in commands since I'm not sure the DWO name will be the same everywhere. The specific name isn't important, we know there's only going to be one. Repositor

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:573 - ::memcpy(dst, GetGPRBuffer(), GetGPRBufferSize()); - dst += GetGPRBufferSize(); + dst = AddSavedRegisters(dst, SavedRegistersKind::GPR, GetGPRBuffer

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 555343. DavidSpickett added a comment. Correct SVE reconfigure on non-SVE machines. It used to return if there was no vg, which is correct, not sure why I changed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 555347. DavidSpickett added a comment. So this is almost the opposite of what you asked for, but I made WriteAllRegisterValues similar to ReadAll by giving it it's own convenient wrapper function. Which ensures you don't forget to set a valid bool, or

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. So hopefully it is more readable in both in the sense that Readall/writeall is almost declarative. The details are all in the helpers so you can't forget one of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 555353. DavidSpickett added a comment. Rebase after changes to WriteAllRegisterValues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157883/new/ https://reviews.llvm.org/D157883 Files: lldb/include/lld

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 555762. DavidSpickett added a comment. Kind -> Type Pull out the caching and size calculation into its own function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156687/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 555822. DavidSpickett added a comment. Rename as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 Files: lldb/source/Plugins/SymbolFile/DWARF/Symbol

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 555827. DavidSpickett added a comment. In the fallback, only check binary dir + dwo name if the dwo name is relative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1808-1810 +FileSpec dwo_name_next_to_binary(next_to_binary); +dwo_name_next_to_binary.AppendPathComponent(dwo_name); +dwo_paths.Append(dwo_name_next_to_binary); -

[Lldb-commits] [PATCH] D157845: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6b6234d14d2: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 556016. DavidSpickett added a comment. Log when comp dir not found and carry on to fallback search. Add a test for the search path being a symlink. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1747-1754 if (!comp_dir) { unit.SetDwoError(Status::createWithFormat( "unable to locate relative .dwo d

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1779 +FileSystem::Instance().Resolve(dirspec); +if (!FileSystem::Instance().IsDirectory(dirspec)) + c

<    1   2   3   4   5   6   7   8   9   10   >