DavidSpickett marked 2 inline comments as done.
DavidSpickett added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755
+ dwo_file.AppendPathComponent(dwo_name);
+ found = FileSystem::Instance().Exists(dwo_file);
+ } else {
----------------
clayborg wrote:
> If "found == false" here, do we want to fall through to the "else" clause
> below? This would mean we have a full path to a DW_AT_comp_dir, but we didn't
> find the .dwo file and "dwo_name" is relative, so maybe we should try to use
> the relative "dwo_name" below without the comp dir if not found?
I've done this in this latest revision.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1795
- if (!FileSystem::Instance().Exists(dwo_file)) {
+ if (!found) {
unit.SetDwoError(Status::createWithFormat(
----------------
clayborg wrote:
> Here is where we might think about doing the debug info search path +
> basename searches since it doesn't matter if the .dwo file original path was
> relative or not.
This is now done above, either relative or not will end up trying paths +
dwoname and paths + filename.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157609/new/
https://reviews.llvm.org/D157609
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
