DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1779 + FileSystem::Instance().Resolve(dirspec); + if (!FileSystem::Instance().IsDirectory(dirspec)) + continue; ---------------- DavidSpickett wrote: > clayborg wrote: > > Will this return false for a symlink to a directory? > In this case no because comp_dir was always being added to it, unless the > result of that was also pointing to a symlink. > > I have added a test case to check you can set the search path to a symlink, > I'm not sure of an easy way to do that for comp_dir. The underlying filesystem does have different types for a directory and a symlink, so the general answer is yes it appears that IsDirectory would return false for a symlink. Which you'd think would affect the later searches using the search path only, but it doesn't. So maybe resolving helps there, not sure. End result is good anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
