[Lldb-commits] [lldb] [lldb][test] Synchronize `__compressed_pair_padding` with libc++ (PR #142516)

2025-07-02 Thread A. Jiang via lldb-commits
https://github.com/frederick-vs-ja closed https://github.com/llvm/llvm-project/pull/142516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][mcp] Skip MCPUnixSocketCommandTestCase if remote (PR #146807)

2025-07-02 Thread Alexandre Perez via lldb-commits
https://github.com/aperez created https://github.com/llvm/llvm-project/pull/146807 It looks like #146603 broke the [lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197) build bot because `MCPUnixSocketCommandTestCase` is trying to start a protocol-server via unix domain socket

[Lldb-commits] [lldb] [lldb][mcp] Skip MCPUnixSocketCommandTestCase if remote (PR #146807)

2025-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alexandre Perez (aperez) Changes It looks like #146603 broke the [lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197) build bot because `MCPUnixSocketCommandTestCase` is trying to start a protocol-server via unix domain s

[Lldb-commits] [lldb] [lldb][mcp] Skip MCPUnixSocketCommandTestCase if remote (PR #146807)

2025-07-02 Thread via lldb-commits
https://github.com/kusmour approved this pull request. https://github.com/llvm/llvm-project/pull/146807 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr (PR #146686)

2025-07-02 Thread Hemang Gadhavi via lldb-commits
@@ -420,8 +420,7 @@ void DWARFFormValue::Dump(Stream &s) const { DumpAddress(s.AsRawOstream(), uvalue, sizeof(uint64_t) * 2); else DumpAddress(s.AsRawOstream(), uvalue, HemangGadhavi wrote: No need to check for the <= 2 DWARF version now, Becau

[Lldb-commits] [lldb] [lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr (PR #146686)

2025-07-02 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > @HemangGadhavi (can't add you to reviewers for whatever reason) May be I do not have maintainer access yet ..?? Not sure. https://github.com/llvm/llvm-project/pull/146686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] dfcef35 - [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (#146480)

2025-07-02 Thread via lldb-commits
Author: Jason Molenda Date: 2025-07-02T10:21:38-07:00 New Revision: dfcef35ff1d30d112362645ec2cd0d5e99952b0f URL: https://github.com/llvm/llvm-project/commit/dfcef35ff1d30d112362645ec2cd0d5e99952b0f DIFF: https://github.com/llvm/llvm-project/commit/dfcef35ff1d30d112362645ec2cd0d5e99952b0f.diff

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 656beb2df5f39604454af0e3f4a9f4b1b7e9c5f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH 1/5] [lldb] Add SB API to make a breakpoint a hardware b

[Lldb-commits] [lldb] d457621 - [lldb] Fixing warnings / win32 builds in MainLoop. (#146632)

2025-07-02 Thread via lldb-commits
Author: John Harrison Date: 2025-07-02T12:49:19-07:00 New Revision: d457621872528d27c8081cf147d41a6f46276d1d URL: https://github.com/llvm/llvm-project/commit/d457621872528d27c8081cf147d41a6f46276d1d DIFF: https://github.com/llvm/llvm-project/commit/d457621872528d27c8081cf147d41a6f46276d1d.diff

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-02 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/146632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread via lldb-commits
jimingham wrote: Object Description is always code-running. It works in languages that have a convention for printing a user-facing string representation of an object. I guess you could have a language with a static way to do this but I haven't seen one. https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread via lldb-commits
jimingham wrote: dynamic value and object description are orthogonal. Dynamic value is the system that allows you to discover, for instance, the "most specific class of an object" when you are passed a pointer typed as one of the base classes of that most specific class. , I don't think

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread via lldb-commits
jimingham wrote: The way Xcode deals with this is that the Locals view's Right-Click menu offers a "Print Description" action. That way users can very easily dial up the object description, but doing so remains under the user's explicit control. https://github.com/llvm/llvm-project/pull/14675

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread via lldb-commits
jimingham wrote: IIRC, C# has a similar object description mechanism, and they had to add some annotations to the object to specify "don't run this one automatically" because they kept getting into trouble with object descriptions that did too much work, or forced lazily evaluated entities to

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread via lldb-commits
jimingham wrote: Also note that for ObjC in particular for many classes the "Object Description" is NOT a summary of the object. Print the Object Description of an NSDictionary 1000 objects and you'll get pages and pages of output with all the elements (and their Descriptions inline IIRC). T

[Lldb-commits] [lldb] 119705e - [lldb][test] Synchronize `__compressed_pair_padding` with libc++ (#142516)

2025-07-02 Thread via lldb-commits
Author: A. Jiang Date: 2025-07-03T13:57:20+08:00 New Revision: 119705e5ad2b7e4bfc55f7df9a8fbaa7504aedbd URL: https://github.com/llvm/llvm-project/commit/119705e5ad2b7e4bfc55f7df9a8fbaa7504aedbd DIFF: https://github.com/llvm/llvm-project/commit/119705e5ad2b7e4bfc55f7df9a8fbaa7504aedbd.diff LOG:

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-02 Thread Peter Smith via lldb-commits
smithp35 wrote: > Just requesting changes so we don't forget about the ABI change. > > Might need to coordinate with other toolchains, we can deal with that after > ABI discussions. I did a quick check of the support for R_AARCH64_TLS_DTPREL64 in GNU by making up a fake .debug_info section wi

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: > I'm still seeing the no job control error in the pre-commit CI. As far as I > know this error is not supposed to be happening, RPC should be getting built > which should mean that the lldb-rpc-gen tool is available for use in the > shell test. I can't repro locally, I'm

[Lldb-commits] [lldb] [lldb][test] Consolidate generic and libcxx std::deque formatter tests (PR #146697)

2025-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/dequ

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also it's a bit misleading, this is printed but I don't know if it is the cause of the include problem: ``` fixed-compilation-database: Error while opening fixed database: No such file or directory json-compilation-database: Error while opening JSON database: No such file o

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread via lldb-commits
@@ -69,7 +69,7 @@ class BreakpointLocation // The next section deals with various breakpoint options. /// If \a enabled is \b true, enable the breakpoint, if \b false disable it. - void SetEnabled(bool enabled); + bool SetEnabled(bool enabled); jimingham

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread via lldb-commits
@@ -148,6 +148,8 @@ class LLDB_API SBBreakpoint { bool IsHardware() const; + bool SetIsHardware(bool is_hardware); jimingham wrote: Document the return value's meaning somewhere. https://github.com/llvm/llvm-project/pull/146602 __

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 656beb2df5f39604454af0e3f4a9f4b1b7e9c5f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH 1/3] [lldb] Add SB API to make a breakpoint a hardware b

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread via lldb-commits
jimingham wrote: There's one more tricky bit we need to handle here. What happens if I have a breakpoint that has more locations than we have hardware resources, and you do `SBBreakpoint.SetIsHardware(True)`? Do we set the first `n` breakpoints and stop there? Do we back out and restore the

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 656beb2df5f39604454af0e3f4a9f4b1b7e9c5f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH 1/4] [lldb] Add SB API to make a breakpoint a hardware b

[Lldb-commits] [lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 👋 https://github.com/llvm/llvm-project/pull/146480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @labath let me know what you think of this approach. I'd like to take this on the Swift 6.2 release branch as it addresses several issues folks have reported. https://github.com/llvm/llvm-project/pull/146578 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: More test coverage sounds great! https://github.com/llvm/llvm-project/pull/146740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 40275a4 - [lldb][test] Add tests for formatting pointers to std::unordered_map

2025-07-02 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-07-02T11:21:02+01:00 New Revision: 40275a4ee31203b9ed014b0b830f456a1c267063 URL: https://github.com/llvm/llvm-project/commit/40275a4ee31203b9ed014b0b830f456a1c267063 DIFF: https://github.com/llvm/llvm-project/commit/40275a4ee31203b9ed014b0b830f456a1c267063.diff

[Lldb-commits] [lldb] [LLDB] Simplify libstdc++ string summaries (PR #146562)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/146562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4c7a706 - [LLDB] Simplify libstdc++ string summaries (#146562)

2025-07-02 Thread via lldb-commits
Author: nerix Date: 2025-07-02T11:21:31+01:00 New Revision: 4c7a706589ca97101972c88d90449d27275b3ab5 URL: https://github.com/llvm/llvm-project/commit/4c7a706589ca97101972c88d90449d27275b3ab5 DIFF: https://github.com/llvm/llvm-project/commit/4c7a706589ca97101972c88d90449d27275b3ab5.diff LOG: [L

[Lldb-commits] [lldb] [lldb][test] Consolidate generic and libcxx std::deque formatter tests (PR #146697)

2025-07-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/146697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e324392 - [lldb][test] Consolidate generic and libcxx std::deque formatter tests (#146697)

2025-07-02 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-02T16:05:09+01:00 New Revision: e32439249d8af2b1d0654e01472506d7e0c92f7b URL: https://github.com/llvm/llvm-project/commit/e32439249d8af2b1d0654e01472506d7e0c92f7b DIFF: https://github.com/llvm/llvm-project/commit/e32439249d8af2b1d0654e01472506d7e0c92f7b.diff

[Lldb-commits] [lldb] [lldb][test] Consolidate generic and libcxx std::deque formatter tests (PR #146697)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/146697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/146740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/146740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][mcp] Fix unix domain socket protocol server addresses (PR #146603)

2025-07-02 Thread Alexandre Perez via lldb-commits
https://github.com/aperez updated https://github.com/llvm/llvm-project/pull/146603 >From 8ffabe86dd320880736c691e45e71611988ceb38 Mon Sep 17 00:00:00 2001 From: Alexandre Perez Date: Tue, 1 Jul 2025 14:19:45 -0700 Subject: [PATCH 1/2] [lldb][mcp] Fix unix domain socket protocol server addresse

[Lldb-commits] [lldb] [lldb][mcp] Fix unix domain socket protocol server addresses (PR #146603)

2025-07-02 Thread Alexandre Perez via lldb-commits
aperez wrote: @kusmour @JDevlieghere I added a test for this. Since my change is in command parsing I created a test in `lldb/test/API/commands/protocol/` rather than extend `lldb/unittests/Protocol/ProtocolMCPServerTest.cpp`. LMK what you think. https://github.com/llvm/llvm-project/pull/1466

[Lldb-commits] [lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

2025-07-02 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/146480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr (PR #146686)

2025-07-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: @HemangGadhavi (can't add you to reviewers for whatever reason) https://github.com/llvm/llvm-project/pull/146686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Consolidate generic and libcxx std::deque formatter tests (PR #146697)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/146697 The plan is to move all STL formatter API tests into a single directory. The `std::deque` test is currently the only test that is duplicated between the `libcxx` and `generic` directories. This patch moves t

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/146740 This patch moves all the data-formatter tests that were only run for libc++ to the generic directory. There's nothing libc++ specific about these tests. For aynthing tied to libcxx we can have a dedicated su

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146740 >From 8e2f7ff404eaf048179ad43b65d53ef1617cefb9 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Jul 2025 15:01:27 +0100 Subject: [PATCH] [lldb][test] Turn (most) libcxx data-formatters tests into gen

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146740 >From 66a4fdb156d493bf994fd5c0050cfd2d7352732d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Jul 2025 15:01:27 +0100 Subject: [PATCH] [lldb][test] Turn (most) libcxx data-formatters tests into gen

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/test/API/functionalities/data-formatter/data-for

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/rang

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146740 >From 66a4fdb156d493bf994fd5c0050cfd2d7352732d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Jul 2025 15:01:27 +0100 Subject: [PATCH 1/3] [lldb][test] Turn (most) libcxx data-formatters tests into

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch moves all the data-formatter tests that were only run for libc++ to the generic directory. There's nothing libc++ specific about these tests. For aynthing tied to libcxx we can have a dedicated

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-07-02 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,15 @@ +# Disabling until the lldb-rpc-gen tool lands. +UNSUPPORTED: system-windows, system-linux, system-darwin chelcassanova wrote: The unsupported can probably be removed actually, these tests still need to test after the tool lands however. https:

[Lldb-commits] [lldb] fc00256 - [lldb][test][NFC] Rename libcxx unordered_map tests to unordered_map-iterator

2025-07-02 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-07-02T14:36:41+01:00 New Revision: fc00256b2b4d7a5328b775b51240258e0d28701c URL: https://github.com/llvm/llvm-project/commit/fc00256b2b4d7a5328b775b51240258e0d28701c DIFF: https://github.com/llvm/llvm-project/commit/fc00256b2b4d7a5328b775b51240258e0d28701c.diff

[Lldb-commits] [lldb] [lldb][test] Consolidate generic and libcxx std::deque formatter tests (PR #146697)

2025-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The plan is to move all STL formatter API tests into a single directory. The `std::deque` test is currently the only test that is duplicated between the `libcxx` and `generic` directories. This patch moves

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-02 Thread Michael Buch via lldb-commits
@@ -0,0 +1,120 @@ +# coding=utf8 +""" +Test std::*string summaries with MSVC's STL. +""" Michael137 wrote: https://github.com/llvm/llvm-project/pull/146740 https://github.com/llvm/llvm-project/pull/143177 ___ lldb-comm

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-02 Thread John Harrison via lldb-commits
ashgti wrote: I'll update my PR to add `#include ` https://github.com/llvm/llvm-project/pull/145621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-02 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/146632 >From 3e0129934a74f9300a7d386797b63304a02b855f Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 1 Jul 2025 20:55:32 -0700 Subject: [PATCH 1/3] [lldb] Fixing warnings / win32 builds in MainLoop. Commit 1a7

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-07-02 Thread Abdullah Mohammad Amin via lldb-commits
https://github.com/UltimateForce21 updated https://github.com/llvm/llvm-project/pull/144238 >From 8ed8c540e7600d720a63bc2882a81a2c65c11d41 Mon Sep 17 00:00:00 2001 From: ultimateforce21 Date: Wed, 11 Jun 2025 00:11:09 -0400 Subject: [PATCH 01/10] [lldb] Add DWARFExpressionEntry and GetExpressi

[Lldb-commits] [lldb] [lldb][mcp] Fix unix domain socket protocol server addresses (PR #146603)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/146603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr (PR #146686)

2025-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Not that we ever do that, because this is unused code, but if someone was debugging lldb I guess they'd call this. Was missed in https://github.com/llvm/llvm-project/pull/145645 Relates to https://gi

[Lldb-commits] [lldb] [lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr (PR #146686)

2025-07-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/146686 Not that we ever do that, because this is unused code, but if someone was debugging lldb I guess they'd call this. Was missed in https://github.com/llvm/llvm-project/pull/145645 Relates to https://github

[Lldb-commits] [lldb] [lldb][test] Consolidate generic and libcxx std::deque formatter tests (PR #146697)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146697 >From 168f2c960757ad0203391724836d021b8bf89b5b Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Jul 2025 14:51:04 +0100 Subject: [PATCH 1/2] [lldb][test] Consolidate generic and libcxx std::deque for

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-02 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/146632 >From 3e0129934a74f9300a7d386797b63304a02b855f Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 1 Jul 2025 20:55:32 -0700 Subject: [PATCH 1/2] [lldb] Fixing warnings / win32 builds in MainLoop. Commit 1a7

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread via lldb-commits
jimingham wrote: It would be good to test the response to enabling a HW breakpoint or trying to set it to HW when you've exhausted the number of HW breakpoint resources. For some reason we have SBProcess::GetNumSupportedHardwareWatchpoints but not SBProcess::GetNumSupportedHardwareBreakpoints

[Lldb-commits] [lldb] [lldb][Commands][NFC] image lookup: remove unused local variable (PR #146554)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/146554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-02 Thread Shivam Gupta via lldb-commits
xgupta wrote: Thanks, we can wait for the ABI change. https://github.com/llvm/llvm-project/pull/146572 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-02 Thread David Spickett via lldb-commits
@@ -0,0 +1,37 @@ +; RUN: llc -O0 -mtriple=aarch64-linux-gnu -filetype=obj < %s \ +; RUN: | llvm-objdump -r - | FileCheck %s DavidSpickett wrote: indent the second line a bit so it's clear it's a continuation: ``` ; RUN: | llvm... ``` https://github.com/llvm/llv

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-02 Thread David Spickett via lldb-commits
@@ -1,8 +1,14 @@ -; RUN: llc -filetype=obj -mtriple=aarch64--linux-gnu -o - %s | llvm-dwarfdump -v - | FileCheck %s -; +; RUN: llc -O0 -mtriple=aarch64-non-linux-gnu -filetype=obj < %s \ +; RUN: | llvm-dwarfdump - | FileCheck %s DavidSpickett wrote: indent the

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-02 Thread David Spickett via lldb-commits
@@ -30,7 +30,7 @@ void AArch64_ELFTargetObjectFile::Initialize(MCContext &Ctx, // AARCH64 ELF ABI does not define static relocation type for TLS offset // within a module. Do not generate AT_location for TLS variables. DavidSpickett wrote: This comment s

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-02 Thread David Spickett via lldb-commits
@@ -0,0 +1,37 @@ +; RUN: llc -O0 -mtriple=aarch64-linux-gnu -filetype=obj < %s \ +; RUN: | llvm-objdump -r - | FileCheck %s + +; CHECK: R_AARCH64_TLS_DTPREL64 DavidSpickett wrote: What does the full output look like? Because this check looks a bit non-specific.

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett requested changes to this pull request. Just requesting changes so we don't forget about the ABI change. Might need to coordinate with other toolchains, we can deal with that after ABI discussions. https://github.com/llvm/llvm-project/pull/146572 __

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-02 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: This broke compilation on mingw (for 64 bit targets, a 32 bit test build is still pending): ``` ../../lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:455:29: error: cast from pointer to smaller type 'lldb::socket_t' (aka 'unsigned int') loses information 455 | se

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: They put up https://github.com/llvm/llvm-project/pull/146632 to fix it, if one of you wants to check it works. https://github.com/llvm/llvm-project/pull/145621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb] Use llvm::erase_if (NFC) (PR #146624)

2025-07-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::erase_if (NFC) (PR #146624)

2025-07-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/146624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7ead20d - [lldb] Use llvm::erase_if (NFC) (#146624)

2025-07-02 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-07-02T11:00:58+01:00 New Revision: 7ead20db28425b81ae56f27928af909f518d7c60 URL: https://github.com/llvm/llvm-project/commit/7ead20db28425b81ae56f27928af909f518d7c60 DIFF: https://github.com/llvm/llvm-project/commit/7ead20db28425b81ae56f27928af909f518d7c60.diff L

[Lldb-commits] [lldb] 5fe63ae - [lldb-dap] Fix flaky test TestDAP_server (#145231)

2025-07-02 Thread via lldb-commits
Author: DrSergei Date: 2025-07-02T12:16:48+01:00 New Revision: 5fe63ae9a3fb7502ce7ed076ea14def97d79e85e URL: https://github.com/llvm/llvm-project/commit/5fe63ae9a3fb7502ce7ed076ea14def97d79e85e DIFF: https://github.com/llvm/llvm-project/commit/5fe63ae9a3fb7502ce7ed076ea14def97d79e85e.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-07-02 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/145231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-07-02 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/143644 >From 24e8bbe12758773ef9ca55c3c4022a610db434e9 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 11 Jun 2025 02:14:12 +0100 Subject: [PATCH 1/2] [lldb-dap] Prevent using an implicit `step-in`. When there i

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-02 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: > They put up #146632 to fix it, if one of you wants to check it works. Thanks - it looks like that does fix some issues, but it only lets the build proceed slightly further to hit other errors caused by this patch: ``` ../../lldb/source/Host/windows/MainLoopWindows.cpp:120:3: e

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/146754 This corrects a mistake I made when I previously tried to add support for obj-c/swift variables in lldb-dap. This should call into `GetObjectDescription` if there is no summary of the type available and the desc

[Lldb-commits] [lldb] ab0fa6c - [lldb] Fix else-after-return in Breakpoint (NFC)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-02T12:07:20-07:00 New Revision: ab0fa6c5dc725ef6f839ac8cea9b3a41aa3a5b75 URL: https://github.com/llvm/llvm-project/commit/ab0fa6c5dc725ef6f839ac8cea9b3a41aa3a5b75 DIFF: https://github.com/llvm/llvm-project/commit/ab0fa6c5dc725ef6f839ac8cea9b3a41aa3a5b75.d

[Lldb-commits] [lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

2025-07-02 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb,llvm` at step 7 "build-default". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/11272 Here is the relevant piece of

[Lldb-commits] [lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

2025-07-02 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `publish-sphinx-docs` running on `as-worker-4` while building `lldb,llvm` at step 5 "build-docs-llvm-html-docs-clang-html-docs-clang...". Full details are available at: https://lab.llvm.org/buildbot/#/builders/45/builds/13922

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-02 Thread Christopher Di Bella via lldb-commits
@@ -78,23 +80,232 @@ public: __split_buffer, void>; - pointer __first_; - pointer __begin_; - pointer __end_; - _LIBCPP_COMPRESSED_PAIR(pointer, __cap_, allocator_type, __alloc_); + struct __data { cjdb wrote:

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-02 Thread Christopher Di Bella via lldb-commits
@@ -431,52 +599,61 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp, _Allocator>::shrink_to_fi template template _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp, _Allocator>::emplace_front(_Args&&... __args) { - if (__begin_ == __first_) { -if (__end_ < _

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-02 Thread Christopher Di Bella via lldb-commits
cjdb wrote: I still think that `_LIBCPP_SIZE_BASED_VECTOR` is the most appropriate name, since this work was entirely motivated by size-based vector, and this PR is a precursor to enabling size-based vector in libc++. The changes to `std::deque` are only happ

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-02 Thread Christopher Di Bella via lldb-commits
@@ -253,30 +436,35 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp, _Allocator>::__construct_ template _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp, _Allocator>::__construct_at_end(size_type __n, const_reference __x) { - _ConstructTransaction __tx(std::add

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-07-02 Thread Abdullah Mohammad Amin via lldb-commits
https://github.com/UltimateForce21 updated https://github.com/llvm/llvm-project/pull/144238 >From 8ed8c540e7600d720a63bc2882a81a2c65c11d41 Mon Sep 17 00:00:00 2001 From: ultimateforce21 Date: Wed, 11 Jun 2025 00:11:09 -0400 Subject: [PATCH 01/11] [lldb] Add DWARFExpressionEntry and GetExpressi

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-07-02 Thread Abdullah Mohammad Amin via lldb-commits
@@ -53,6 +54,30 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t func_load_addr, return GetExpressionAtAddress(func_load_addr, addr) != nullptr; } +std::optional +DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr, +

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From e87953011acc6052c0ced1911e578347b66a2dc0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [LLDB] Simplify libstdc++ string summaries (PR #146562)

2025-07-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/146562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-07-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 >From 5b5ba0f552715cd68e82aa03adadb5323e5c6eff Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:24:03 -0700 Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters Thi

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread John Harrison via lldb-commits
ashgti wrote: > If you can ensure that the expression you are running can safely be executed > by running only the current thread, it's only a performance problem to run > expressions behind the user's back. But otherwise, we really should only run > expressions when the user explicitly asks u

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-02 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > I expect not because the compilation database only deals with sources, .cpp, > .cc etc. not headers. So it should be trying to load something like `compile_commands.json`? Which is in the root of the build dir so when the tool needs to load it's going to try and do some

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread via lldb-commits
jimingham wrote: Remember, running code is NOT a risk free operation. If I am stopped on a thread in code that has acquired a non-recursive lock A, and I run an expression by hand that ends up first successfully acquiring a lock B and then trying to acquire A, that expression will deadlock. T

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread via lldb-commits
jimingham wrote: There are exceptions to this, for instance we run functions automatically to gather the various Sanitizer report results. But those functions have been written with this use in mind, so they don't take locks or do anything that might be unsafe. https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb-dap] Improving 'variables' hover requests. (PR #146773)

2025-07-02 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/146773 This partially fixes https://github.com/llvm/llvm-project/issues/146559. When hovering over variables while debugging with lldb-dap we are receiving hover requests that include symbols. For example, if you have

[Lldb-commits] [lldb] [lldb-dap] Improving 'variables' hover requests. (PR #146773)

2025-07-02 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/146773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving 'variables' hover requests. (PR #146773)

2025-07-02 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/146773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving 'variables' hover requests. (PR #146773)

2025-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This partially fixes https://github.com/llvm/llvm-project/issues/146559. When hovering over variables while debugging with lldb-dap we are receiving hover requests that include symbols. For example, if you h

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread John Harrison via lldb-commits
ashgti wrote: We can add a button to the variables UI or a context menu entry for running the description. I can switch to that instead. https://github.com/llvm/llvm-project/pull/146754 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] [lldb-dap] Adjust variable display values. (PR #146754)

2025-07-02 Thread John Harrison via lldb-commits
https://github.com/ashgti converted_to_draft https://github.com/llvm/llvm-project/pull/146754 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >