mstorsjo wrote:
> They put up #146632 to fix it, if one of you wants to check it works.
Thanks - it looks like that does fix some issues, but it only lets the build
proceed slightly further to hit other errors caused by this patch:
```
../../lldb/source/Host/windows/MainLoopWindows.cpp:120:3: error: no type named
'thread' in namespace 'std'; did you mean 'Thread'?
120 | std::thread m_monitor_thread;
| ^~~~~~~~~~~
| Thread
../../lldb/include/lldb/lldb-forward.h:241:7: note: 'Thread' declared here
241 | class Thread;
| ^
../../lldb/source/Host/windows/MainLoopWindows.cpp:67:31: error: no member named
'thread' in namespace 'std'
67 | m_monitor_thread = std::thread(&PipeEvent::Monitor, this);
| ^~~~~~
../../lldb/source/Host/windows/MainLoopWindows.cpp:213:33: error: no viable
overloaded '='
213 | m_read_fds[waitable_handle] = {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
214 | std::make_unique<PipeEvent>((HANDLE)waitable_handle), callback};
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../lldb/include/lldb/Host/windows/MainLoopWindows.h:56:10: note: candidate
function (the implicit copy assignment operator) not viable: cannot convert
initializer list argument to 'const FdInfo'
56 | struct FdInfo {
| ^~~~~~
../../lldb/include/lldb/Host/windows/MainLoopWindows.h:56:10: note: candidate
function (the implicit move assignment operator) not viable: cannot convert
initializer list argument to 'FdInfo'
56 | struct FdInfo {
| ^~~~~~
```
That seems to be easy to fix with a plain `#include <thread>` in
`MainLoopWindows.cpp` though.
https://github.com/llvm/llvm-project/pull/145621
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
