@@ -190,8 +190,83 @@ void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
bool ObjectFileXCOFF::IsStripped() { return false; }
-void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {}
-
+void ObjectFileXCOFF::CreateSections(SectionList &unified_section
cmtice wrote:
> A very predictable question. Why is the implementation of this more
> complicated than `base->GetChildMemberWithName(name)`. I think it shouldn't
> be.
>
> To avoid repeating the same points over and over, I suggest going through the
> discussion on the dereference/addressof p
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/138805
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/138805
>From 4fc9acd03a58a3617b113352c48e5dd2fdb58eda Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 6 May 2025 22:37:17 -0700
Subject: [PATCH 1/4] [lldb] Provide lr value in faulting frame on arm64
When
jasonmolenda wrote:
I'm thinking I'll write an API test that instruction steps through the whole
thing and backtraces at each point, making sure it can get every function
between the current one & main at all points, just for fun extra stress testing.
https://github.com/llvm/llvm-project/pull/
Author: Jacob Lalonde
Date: 2025-05-07T12:53:37-07:00
New Revision: 40941f15962191d0236ecdc29cd6937abce974fb
URL:
https://github.com/llvm/llvm-project/commit/40941f15962191d0236ecdc29cd6937abce974fb
DIFF:
https://github.com/llvm/llvm-project/commit/40941f15962191d0236ecdc29cd6937abce974fb.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/138943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
>From 998d59c6462326874d3fcd13f4cf92290c7bf5f9 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 30 Apr 2025 02:00:44 +0200
Subject: [PATCH 1/5] Expose QueueThreadPlanForStepSingleInstruction function
to SBT
felipepiovezan wrote:
Btw I think this is causing an asan failure:
https://green.lab.llvm.org/job/lldb-cmake-sanitized/1671/
```
2025-05-07T19:03:57.557Z] ==73219==ERROR: AddressSanitizer:
stack-buffer-overflow on address 0x0001070cf5b8 at pc 0x0001056051c0 bp
0x00016b0a3730 sp 0x00016b0a2ee0
https://github.com/JDevlieghere approved this pull request.
LGTM but please give @da-viper a chance to review this before merging.
https://github.com/llvm/llvm-project/pull/138977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/jeremyd2019 edited
https://github.com/llvm/llvm-project/pull/138587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/138981
>From 8c7a01465891c83f7cc99ee95b0852c56e0f150f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 6 May 2025 15:58:44 -0700
Subject: [PATCH 1/2] [lldb-dap] Change the launch sequence (#138219)
Thi
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/138977
>From 756174c282fc7101bfadb29556f39ce046ad0116 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 7 May 2025 14:54:29 -0700
Subject: [PATCH 1/2] [lldb-dap] Adding a modules explorer to lldb-dap ext.
This cr
@@ -763,6 +764,16 @@
}
]
}
-]
+],
+"views": {
+ "debug": [
+{
+ "id": "lldb-dap.modulesExplorer",
+ "name": "LLDB Modules Explorer",
ashgti wrote:
Updated to just be 'Modules'.
https://github.
Author: Jonas Devlieghere
Date: 2025-05-07T16:20:47-07:00
New Revision: aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd
URL:
https://github.com/llvm/llvm-project/commit/aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd
DIFF:
https://github.com/llvm/llvm-project/commit/aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd.d
JDevlieghere wrote:
aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd
https://github.com/llvm/llvm-project/pull/138981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/138981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/138987
This adds types for the 'continue' request and updates the existing handler to
the new base class.
Rate limit · GitHub
body {
background-color: #f6f8fa;
co
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds types for the 'continue' request and updates the existing handler to
the new base class.
---
Full diff: https://github.com/llvm/llvm-project/pull/138987.diff
4 Files Affected:
- (modified) lldb/t
https://github.com/JDevlieghere approved this pull request.
Very straightforward. LGTM.
https://github.com/llvm/llvm-project/pull/138987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileB
@@ -763,6 +764,16 @@
}
]
}
-]
+],
+"views": {
+ "debug": [
+{
+ "id": "lldb-dap.modulesExplorer",
+ "name": "LLDB Modules Explorer",
JDevlieghere wrote:
Is "explorer" common terminology in VS C
https://github.com/JDevlieghere commented:
This is really awesome and I'm surprised/impressed with how little TypeScript
it takes to implement something like this.
https://github.com/llvm/llvm-project/pull/138977
___
lldb-commits mailing list
lldb-com
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/138977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
>From 998d59c6462326874d3fcd13f4cf92290c7bf5f9 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 30 Apr 2025 02:00:44 +0200
Subject: [PATCH 1/5] Expose QueueThreadPlanForStepSingleInstruction function
to SBT
Author: Jason Molenda
Date: 2025-05-07T15:53:30-07:00
New Revision: 0d0ef58c8facb0f2e5c2f4615b0d25f19e5abe01
URL:
https://github.com/llvm/llvm-project/commit/0d0ef58c8facb0f2e5c2f4615b0d25f19e5abe01
DIFF:
https://github.com/llvm/llvm-project/commit/0d0ef58c8facb0f2e5c2f4615b0d25f19e5abe01.diff
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/138977
This creates a very basic module explorer for tracking and displaying loaded
modules, reported by lldb-dap for the active debug session.
This includes a basic session tracker that we can use to observe the debug
https://github.com/preames approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/138940
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This creates a very basic module explorer for tracking and displaying loaded
modules, reported by lldb-dap for the active debug session.
This includes a basic session tracker that we can use to observe the de
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/138977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
Oh, that script should already be defined in the package.json, that was the
script I used for formatting.
https://github.com/llvm/llvm-project/pull/138925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/138981
This PR changes how we treat the launch sequence in lldb-dap.
- Send the initialized event after we finish handling the initialize
request, rather than after we finish attaching or launching.
- Delay h
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This PR changes how we treat the launch sequence in lldb-dap.
- Send the initialized event after we finish handling the initialize
request, rather than after we finish attaching or launching.
-
@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces
references to LLDB
+# with those for RPC. This happens for:
+# - namespace definitions
+# - namespace usage
+
https://github.com/DavidSpickett approved this pull request.
Sure, let's give this a go now.
(rather than end of week for a potential weekend of red)
https://github.com/llvm/llvm-project/pull/138791
___
lldb-commits mailing list
lldb-commits@lists.llv
https://github.com/DavidSpickett requested changes to this pull request.
Actually the launch sequence changes are breaking Windows tests. I need to see
that all green first.
https://github.com/llvm/llvm-project/pull/138791
___
lldb-commits mailing lis
DavidSpickett wrote:
We have failing tests on Windows after this. Latest result at this time is:
```
Unresolved Tests (2):
lldb-api :: tools/lldb-dap/completions/TestDAP_completions.py
lldb-api :: tools/lldb-dap/startDebugging/TestDAP_startDebugging.py
***
@@ -133,7 +142,45 @@ static bool GetProcessAndStatInfo(::pid_t pid,
uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
ProcessInstanceInfoList &process_infos) {
- return 0;
+ static const char procdir[] = "/proc/";
+
https://github.com/labath commented:
Could you also make unit tests for these two functions:
- call GetProgramFileSpec and make sure the result is reasonable (exists?)
- create a Process and make sure FindProcesses finds it (you can use
[this](https://github.com/llvm/llvm-project/blob/52f568dbbb
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/138687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -133,7 +142,45 @@ static bool GetProcessAndStatInfo(::pid_t pid,
uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
ProcessInstanceInfoList &process_infos) {
- return 0;
+ static const char procdir[] = "/proc/";
+
jasonmolenda wrote:
to be clear, when I mention a big chunk of `SavedLocationForRegister` which I
don't think is actually doing anything -- I refuse to look at the history, but
it looks suspiciously like something I wrote a decade ago :)
https://github.com/llvm/llvm-project/pull/138805
__
101 - 142 of 142 matches
Mail list logo
