[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-14 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/133624 >From 3240fe49515e5f59c5b9ff9c02423b77504d8a43 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 28 Mar 2025 14:02:53 -0700 Subject: [PATCH 1/6] [lldb-dap] Refactoring lldb-dap 'launch' request to use type

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-14 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/14470 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-14 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 4 "build". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/7879 Here is the relevant piece of

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-14 Thread Pavel Labath via lldb-commits
@@ -18,6 +18,22 @@ namespace lldb_private::dil { +static lldb::ValueObjectSP +ArrayToPointerConversion(lldb::ValueObjectSP valobj, + std::shared_ptr ctx) { + assert(valobj->IsArrayType() && + "an argument to array-to-pointer conversion must be

[Lldb-commits] [lldb] [lldb] Make sure the process is stopped when computing the symbol context (PR #135458)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/135458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
@@ -230,6 +232,10 @@ class SymbolCompleter : public Completer { // Now add the functions & symbols to the list - only add if unique: for (const SymbolContext &sc : sc_list) { +if (m_match_set.size() >= m_request.GetMaxNumberOfResultsToAdd()) { + br

[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/135455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-14 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/134354 >From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Fri, 4 Apr 2025 00:59:17 -0500 Subject: [PATCH 1/4] [lldb][AIX] get host info for AIX --- lldb/source/Hos

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-14 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-14 Thread Hemang Gadhavi via lldb-commits
@@ -141,6 +141,7 @@ else() add_host_subdirectory(aix aix/Host.cpp aix/HostInfoAIX.cpp + linux/Support.cpp HemangGadhavi wrote: Hey @labath Made the changes as per the discussion, I have added the common `posix/Support.cpp` for unix-like

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-14 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > > > We have a tests for this function in `unittests/Host/linux/HostTest.cpp` > > > and it looks like at least some of it should apply to other systems as > > > well. We could move it to the "posix" folder so that it applies to your > > > code as well. Depending on the si

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-14 Thread Hemang Gadhavi via lldb-commits
@@ -7,21 +7,24 @@ //===--===// #include "lldb/Host/linux/Support.h" +#include "lldb/Host/posix/Support.h" #include "llvm/Support/Threading.h" #include "gtest/gtest.h" using namespace lldb_private; TES

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/135637 >From 0383630d48f60cf25d241deda909737869b65998 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 14 Apr 2025 08:56:55 -0700 Subject: [PATCH] [lldb] Override Should{Select,Show} in StopR

[Lldb-commits] [lldb] [lldb-dap] Fix win32 build. (PR #135638)

2025-04-14 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev approved this pull request. https://github.com/llvm/llvm-project/pull/135638 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix win32 build. (PR #135638)

2025-04-14 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/135638 This enum was not fully specified. >From 1fe129959d425d8f298e111d73cfa88e429e3cfc Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 14 Apr 2025 09:07:48 -0700 Subject: [PATCH] [lldb-dap] Fix win32 build.

[Lldb-commits] [lldb] [lldb-dap] Fix win32 build. (PR #135638)

2025-04-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This enum was not fully specified. --- Full diff: https://github.com/llvm/llvm-project/pull/135638.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/Transport.cpp (+1-1) ``diff diff --git a

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-14 Thread John Harrison via lldb-commits
ashgti wrote: PR #135638 should fix the build failure. https://github.com/llvm/llvm-project/pull/130169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-14 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/133624 >From 3240fe49515e5f59c5b9ff9c02423b77504d8a43 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 28 Mar 2025 14:02:53 -0700 Subject: [PATCH 1/8] [lldb-dap] Refactoring lldb-dap 'launch' request to use type

[Lldb-commits] [lldb] 6b863e8 - [lldb-dap] Fix win32 build. (#135638)

2025-04-14 Thread via lldb-commits
Author: John Harrison Date: 2025-04-14T09:56:58-07:00 New Revision: 6b863e810d6decb689bff8f6620e8ea07b356d86 URL: https://github.com/llvm/llvm-project/commit/6b863e810d6decb689bff8f6620e8ea07b356d86 DIFF: https://github.com/llvm/llvm-project/commit/6b863e810d6decb689bff8f6620e8ea07b356d86.diff

[Lldb-commits] [lldb] 2d30a60 - [lldb-dap] Adding support for cancelling a request. (#130169)

2025-04-14 Thread via lldb-commits
Author: John Harrison Date: 2025-04-14T08:29:02-07:00 New Revision: 2d30a60e9ff8b22f7e07ca5360fe1582f96be1ac URL: https://github.com/llvm/llvm-project/commit/2d30a60e9ff8b22f7e07ca5360fe1582f96be1ac DIFF: https://github.com/llvm/llvm-project/commit/2d30a60e9ff8b22f7e07ca5360fe1582f96be1ac.diff

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-14 Thread Ebuka Ezike via lldb-commits
da-viper wrote: /cherrypick dda53bef35c5ab49967e8755e69ce893ecb525c4 5b384c3015100ad815f4d994d7ef35cc947db711 https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-14 Thread Ilia Kuklin via lldb-commits
@@ -18,6 +18,22 @@ namespace lldb_private::dil { +static lldb::ValueObjectSP +ArrayToPointerConversion(lldb::ValueObjectSP valobj, + std::shared_ptr ctx) { + assert(valobj->IsArrayType() && + "an argument to array-to-pointer conversion must be

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-14 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: One thing that looks fishy, but that is even a different node, is this early return on `VisitSubstNonTypeTemplateParmPackExpr` in `ASTReaderStmt`. ```C++ if (ArgPack.getKind() != TemplateArgument::Pack) return; ``` This looks impossible to hit, because `getArgumentPack` c

[Lldb-commits] [lldb] [lldb-dap] Fix win32 build. (PR #135638)

2025-04-14 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/135638 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix win32 build. (PR #135638)

2025-04-14 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @ashgti Did you test #130169 on Windows? This patch will fix the building, but I'm not sure that it will work on Windows considering this: ``` // TODO: On Windows this should be a HANDLE, and wait should use // WaitForMultipleObjects typedef int WaitableHandle; IOObject::Waitab

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-14 Thread via lldb-commits
eaeltsin wrote: Comparing bcanalyzer --dump outputs for non-deterministic pcms, I see a lot of op values that differ by 1. I wonder if this might be something like the mismatch of Read Write UnsignedOrNone vs unsigned ... https://github.com/llvm/llvm-project/pull/132401 _

[Lldb-commits] [lldb] [lldb] Fix use-color settings not persistent (PR #135626)

2025-04-14 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/135626 Fixes https://github.com/llvm/llvm-project/issues/22981 Do you think it is necessary for the`SetUseColor` to return a bool for the interface >From 0487d125beb27f87acc2c137b1554e08a52d195d Mon Sep 17 00:00:00

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-04-14 Thread Marcel Laverdet via lldb-commits
https://github.com/laverdet closed https://github.com/llvm/llvm-project/pull/135563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-14 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 8 "build-default". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/3983 Here is the relevant piece of the bui

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This is necessary so that LLDB does not select (or show the stop reason for) a thread which stopped at an internal breakpoint. Other than manual testing/inspection, which I've done, this

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-14 Thread via lldb-commits
eaeltsin wrote: Using library with assertions, I'm seeing out-of-bounds source location read called from `ASTStmtReader::VisitSubstNonTypeTemplateParmExpr` - [trace](https://gist.github.com/eaeltsin/845fb9cc6f65f47ed03a64aca5aff923) https://github.com/llvm/llvm-project/pull/132401

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Target/StopInfo.cpp `` View

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-14 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/130169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-14 Thread John Harrison via lldb-commits
@@ -9,127 +9,66 @@ #include "DAP.h" #include "EventHelper.h" #include "JSONUtils.h" +#include "Protocol/ProtocolRequests.h" #include "RequestHandler.h" #include "llvm/Support/FileSystem.h" namespace lldb_dap { -// "LaunchRequest": { -// "allOf": [ { "$ref": "#/definiti

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-14 Thread John Harrison via lldb-commits
@@ -33,15 +35,12 @@ MakeArgv(const llvm::ArrayRef &strs) { return argv; } -static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj, - llvm::StringRef key, lldb::LaunchFlags mask) { - if (const auto opt_value = GetBoolean(obj,

[Lldb-commits] [lldb] [lldb-dap] Fix win32 build. (PR #135638)

2025-04-14 Thread John Harrison via lldb-commits
ashgti wrote: This should fix https://lab.llvm.org/buildbot/#/builders/197/builds/3983 https://github.com/llvm/llvm-project/pull/135638 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-14 Thread via lldb-commits
eaeltsin wrote: Didn't fire so far. Though this is non-deterministic, I might be (un)lucky. https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] Draft: test (PR #135630)

2025-04-14 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/135630 >From a1320e77fc49c78a5915335e07c7eb7e8823cd0a Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 14 Apr 2025 11:56:01 -0300 Subject: [PATCH] Draft: test With change: 1) 4m46s - https://buildkite.com/l

[Lldb-commits] [lldb] [llvm] Draft: test (PR #135630)

2025-04-14 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/135630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Aiden Grossman via lldb-commits
@@ -52,6 +52,8 @@ "clang": {"clang-tools-extra", "compiler-rt", "cross-project-tests"}, "clang-tools-extra": {"libc"}, "mlir": {"flang"}, +# Test everyything if ci scripts are changed. +".ci": {"llvm", "clang", "lld", "lldb"}, boomanaiden154

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Aiden Grossman via lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT projects="${1}" targets="${2}" +runtimes="${3}" lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests" echo "--- cmake" export PIP_BREAK_SYSTEM_PACKAGES=1 + pip ins

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Matheus Izvekov via lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT projects="${1}" targets="${2}" +runtimes="${3}" lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests" echo "--- cmake" export PIP_BREAK_SYSTEM_PACKAGES=1 + pip ins

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-14 Thread Michael Buch via lldb-commits
Michael137 wrote: Latest set of commits should be reviewable. I updated the PR description with an overview of the commits. One remaining issue I haven't dealt with yet is `TestCxxFrameFormatRecursive.test` where we set the `plugin.cplusplus.language.function-name-format` variable to `${func

[Lldb-commits] [lldb] cbbf562 - [lldb][Format][NFC] Remove unused FormatEntity::FormatCString

2025-04-14 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-04-14T13:42:35+01:00 New Revision: cbbf562d1c2a076de83d50fedfee78acfb4d8003 URL: https://github.com/llvm/llvm-project/commit/cbbf562d1c2a076de83d50fedfee78acfb4d8003 DIFF: https://github.com/llvm/llvm-project/commit/cbbf562d1c2a076de83d50fedfee78acfb4d8003.diff

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
@@ -157,6 +162,23 @@ class CompletionRequest { size_t GetCursorIndex() const { return m_cursor_index; } + size_t GetMaxReturnElements() const { return m_max_return_elements; } + + /// Returns true if the maximum number of completions has been reached + /// already. + bo

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-14 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-14 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: Ping https://github.com/llvm/llvm-project/pull/135033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: This definitely needs a test. https://github.com/llvm/llvm-project/pull/135565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 73b554d - [lldb] Make sure the process is stopped when computing the symbol context (#135458)

2025-04-14 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-14T10:09:43+02:00 New Revision: 73b554d7a0a666e252f3c837510a55ee1acb1df5 URL: https://github.com/llvm/llvm-project/commit/73b554d7a0a666e252f3c837510a55ee1acb1df5 DIFF: https://github.com/llvm/llvm-project/commit/73b554d7a0a666e252f3c837510a55ee1acb1df5.d

[Lldb-commits] [lldb] [lldb-dap] fix inconsistent debugAdapterHostname argument name (PR #135544)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: CC @matthewbastien https://github.com/llvm/llvm-project/pull/135544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-14 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix inconsistent debugAdapterHostname argument name (PR #135544)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/135544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-14 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-14 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-14 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/135499 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-14 Thread Michael Buch via lldb-commits
@@ -208,6 +209,152 @@ static bool PrettyPrintFunctionNameWithArgs(Stream &out_stream, return true; } +static std::optional GetDemangledBasename(Function &function) { + auto demangled_name = function.GetName().GetStringRef(); + if (demangled_name.empty()) +return std:

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-14 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Aiden Grossman via lldb-commits
@@ -52,6 +52,8 @@ "clang": {"clang-tools-extra", "compiler-rt", "cross-project-tests"}, "clang-tools-extra": {"libc"}, "mlir": {"flang"}, +# Test everyything if ci scripts are changed. +".ci": {"llvm", "clang", "lld", "lldb"}, boomanaiden154

[Lldb-commits] [lldb] [lldb/cmake] Normalize use of HAVE_LIBCOMPRESSION (PR #135528)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/135528 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix use-color settings not persistent (PR #135626)

2025-04-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Fixes https://github.com/llvm/llvm-project/issues/22981 Do you think it is necessary for the`SetUseColor` to return a bool for the interface --- Full diff: https://github.com/llvm/llvm-project/pull/135626.d

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-14 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/135033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/135455 >From b1416c5e13207eaa56985c84e9c2ac74db6a4d2b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 11 Apr 2025 22:48:44 + Subject: [PATCH 1/3] [lldb] Remove ProcessRunLock::TrySetRunning I trac

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Matheus Izvekov via lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT projects="${1}" targets="${2}" +runtimes="${3}" lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests" echo "--- cmake" export PIP_BREAK_SYSTEM_PACKAGES=1 + pip ins

[Lldb-commits] [lldb] d792094 - [lldb] Remove ProcessRunLock::TrySetRunning (#135455)

2025-04-14 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-14T10:09:19+02:00 New Revision: d792094c26dc6b40136f1e6c2e393c041062e371 URL: https://github.com/llvm/llvm-project/commit/d792094c26dc6b40136f1e6c2e393c041062e371 DIFF: https://github.com/llvm/llvm-project/commit/d792094c26dc6b40136f1e6c2e393c041062e371.d

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Aiden Grossman via lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT projects="${1}" targets="${2}" +runtimes="${3}" lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests" echo "--- cmake" export PIP_BREAK_SYSTEM_PACKAGES=1 + pip ins

[Lldb-commits] [lldb] e4a672b - [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (#135033)

2025-04-14 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2025-04-14T14:30:09+04:00 New Revision: e4a672bc17a2a7dc39e51c9f5e656d705312a12b URL: https://github.com/llvm/llvm-project/commit/e4a672bc17a2a7dc39e51c9f5e656d705312a12b DIFF: https://github.com/llvm/llvm-project/commit/e4a672bc17a2a7dc39e51c9f5e656d705312a12b.dif

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
@@ -231,6 +253,8 @@ class CompletionRequest { size_t m_cursor_index; /// The cursor position in the argument indexed by m_cursor_index. size_t m_cursor_char_position; + /// The maximum number of completions that should be returned. + size_t m_max_return_elements = SIZE_

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-14 Thread Michael Buch via lldb-commits
@@ -0,0 +1,60 @@ +# Test the ${function.arguments} frame-format variable. Michael137 wrote: done https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov deleted https://github.com/llvm/llvm-project/pull/135499 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Matheus Izvekov via lldb-commits
@@ -52,6 +52,8 @@ "clang": {"clang-tools-extra", "compiler-rt", "cross-project-tests"}, "clang-tools-extra": {"libc"}, "mlir": {"flang"}, +# Test everyything if ci scripts are changed. +".ci": {"llvm", "clang", "lld", "lldb"}, mizvekov wrote

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Please also update the [website/docs](https://lldb.llvm.org/use/formatting.html#variables) with the new format variables. https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread via lldb-commits
jimingham wrote: I'm also not sure how you would test this. Pretty much all the predictable internal breakpoints that we set get converted to different StopInfo's before the public stop. At some point it would be nice to add a "testing only" library - like the SB API set but only available wh

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-14 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM, thanks for working on this! https://github.com/llvm/llvm-project/pull/129092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Matheus Izvekov via lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT projects="${1}" targets="${2}" +runtimes="${3}" lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests" echo "--- cmake" export PIP_BREAK_SYSTEM_PACKAGES=1 + pip ins

[Lldb-commits] [lldb] [lldb] Slide eh_frame unwind plan if it doesn't begin at function boundary (PR #135333)

2025-04-14 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. OK looks reasonable. https://github.com/llvm/llvm-project/pull/135333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-14 Thread via lldb-commits
jimingham wrote: We may use the word `expr` in documentation, but that doesn't mean that a user could decide they wanted to use `expr` for something completely different. And even if we added an explicit alias for `expr` someone who was using it for another purpose will just get a little anno

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-14 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: Could it be you are hitting an overflow/wrap around perhaps? Some of these nodes store the unsignedOrNone representation in a bitfield, but that's still 15 bits. https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailin

[Lldb-commits] [lldb] 7491ff7 - [lldb] Override Should{Select, Show} in StopReasonBreakpoint (#135637)

2025-04-14 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-14T16:21:24-07:00 New Revision: 7491ff74d2b99c0e5e879ec7fd370fe9654528c4 URL: https://github.com/llvm/llvm-project/commit/7491ff74d2b99c0e5e879ec7fd370fe9654528c4 DIFF: https://github.com/llvm/llvm-project/commit/7491ff74d2b99c0e5e879ec7fd370fe96

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/135565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. All tests pas on macOS. Thanks! https://github.com/llvm/llvm-project/pull/135033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-14 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/134339 >From 4f0ac25e9e7f93d64940e8af2949569bf9898c4e Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 3 Apr 2025 22:29:13 -0700 Subject: [PATCH 1/3] [lldb] Make SBProcess thread related actions listen to StopLocker

[Lldb-commits] [lldb] Draft: test (PR #135630)

2025-04-14 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/135630 >From 1571fc17e789839bd2f177cca80c0b9f69233cf6 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 14 Apr 2025 11:56:01 -0300 Subject: [PATCH] Draft: test With change: 1) 4m46s - https://buildkite.com/l

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/135637 This is necessary so that LLDB does not select (or show the stop reason for) a thread which stopped at an internal breakpoint. Other than manual testing/inspection, which I've done, this does not seem to

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-14 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: In one of these changes we did bump one of these bit fields down to 15 bits, starting from 16. https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-04-14 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: As the patch notes, Apple's M4 has the SME register & instructions, plus Streaming SVE Mode and the SVE register set, but most of the SVE instructions are not supported. And the SVE registers (z0-31, p0-15) are only available when the core is in Streaming SVE Mode I believe

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-04-14 Thread Marcel Laverdet via lldb-commits
https://github.com/laverdet reopened https://github.com/llvm/llvm-project/pull/135563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Imporve error reporting if a command's arguments fail to parse correctly. (PR #135684)

2025-04-14 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/135684 >From cab7671780bde4d4e2e137f10ced6b5fe504 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 14 Apr 2025 13:22:31 -0700 Subject: [PATCH 1/2] [lldb-dap] Imporve error reporting if a command's arguments

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/135637 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/135637 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits