[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

[Matheus Izvekov via lldb-commits]

mizvekov wrote:

One thing that looks fishy, but that is even a different node, is this early 
return on `VisitSubstNonTypeTemplateParmPackExpr` in `ASTReaderStmt`.

```C++
  if (ArgPack.getKind() != TemplateArgument::Pack)
    return;
```

This looks impossible to hit, because `getArgumentPack` calls a constructor 
which can only return Packs.

Can you turn that into an assert and try again?

```C++
assert (ArgPack.getKind() == TemplateArgument::Pack);
```

https://github.com/llvm/llvm-project/pull/132401
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits